[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271429#comment-13271429 ] Hudson commented on HDFS-3363: -- Integrated in Hadoop-Mapreduce-trunk #1074 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1074/]) Remove the empty file FSInodeInfo.java for HDFS-3363. (Revision 1335788) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335788 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSInodeInfo.java > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271387#comment-13271387 ] Hudson commented on HDFS-3363: -- Integrated in Hadoop-Hdfs-trunk #1039 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1039/]) Remove the empty file FSInodeInfo.java for HDFS-3363. (Revision 1335788) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335788 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSInodeInfo.java > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271067#comment-13271067 ] Eli Collins commented on HDFS-3363: --- Looks like this may have broken a test on branch-2, see HDFS-3391. > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270902#comment-13270902 ] Hudson commented on HDFS-3363: -- Integrated in Hadoop-Mapreduce-trunk-Commit #2227 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2227/]) Remove the empty file FSInodeInfo.java for HDFS-3363. (Revision 1335788) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335788 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSInodeInfo.java > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270882#comment-13270882 ] Hudson commented on HDFS-3363: -- Integrated in Hadoop-Common-trunk-Commit #2210 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2210/]) Remove the empty file FSInodeInfo.java for HDFS-3363. (Revision 1335788) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335788 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSInodeInfo.java > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270880#comment-13270880 ] Hudson commented on HDFS-3363: -- Integrated in Hadoop-Hdfs-trunk-Commit #2285 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2285/]) Remove the empty file FSInodeInfo.java for HDFS-3363. (Revision 1335788) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335788 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSInodeInfo.java > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270469#comment-13270469 ] Hudson commented on HDFS-3363: -- Integrated in Hadoop-Mapreduce-trunk #1073 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1073/]) HDFS-3363. Define BlockCollection and MutableBlockCollection interfaces so that INodeFile and INodeFileUnderConstruction do not have to be used in block management. Contributed by John George (Revision 1335304) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335304 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockCollection.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicy.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/MutableBlockCollection.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSInodeInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestDNFencing.java > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270435#comment-13270435 ] Hudson commented on HDFS-3363: -- Integrated in Hadoop-Hdfs-trunk #1038 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1038/]) HDFS-3363. Define BlockCollection and MutableBlockCollection interfaces so that INodeFile and INodeFileUnderConstruction do not have to be used in block management. Contributed by John George (Revision 1335304) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335304 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockCollection.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicy.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/MutableBlockCollection.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSInodeInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestDNFencing.java > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270121#comment-13270121 ] Tsz Wo (Nicholas), SZE commented on HDFS-3363: -- This broke RAID as expected. I filed MAPREDUCE-4231 and posted a patch. > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270113#comment-13270113 ] Hudson commented on HDFS-3363: -- Integrated in Hadoop-Mapreduce-trunk-Commit #2219 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2219/]) HDFS-3363. Define BlockCollection and MutableBlockCollection interfaces so that INodeFile and INodeFileUnderConstruction do not have to be used in block management. Contributed by John George (Revision 1335304) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335304 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockCollection.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicy.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/MutableBlockCollection.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSInodeInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestDNFencing.java > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270103#comment-13270103 ] Hudson commented on HDFS-3363: -- Integrated in Hadoop-Hdfs-trunk-Commit #2277 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2277/]) HDFS-3363. Define BlockCollection and MutableBlockCollection interfaces so that INodeFile and INodeFileUnderConstruction do not have to be used in block management. Contributed by John George (Revision 1335304) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335304 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockCollection.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicy.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/MutableBlockCollection.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSInodeInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestDNFencing.java > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270104#comment-13270104 ] Hudson commented on HDFS-3363: -- Integrated in Hadoop-Common-trunk-Commit #2202 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2202/]) HDFS-3363. Define BlockCollection and MutableBlockCollection interfaces so that INodeFile and INodeFileUnderConstruction do not have to be used in block management. Contributed by John George (Revision 1335304) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335304 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockCollection.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicy.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/MutableBlockCollection.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSInodeInfo.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFileUnderConstruction.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestDNFencing.java > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270083#comment-13270083 ] Hadoop QA commented on HDFS-3363: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525926/HDFS-3363.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2386//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2386//console This message is automatically generated. > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java, > HDFS-3363.patch > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269934#comment-13269934 ] Hadoop QA commented on HDFS-3363: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525890/HDFS-3363.java against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2385//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2385//console This message is automatically generated. > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269874#comment-13269874 ] Daryn Sharp commented on HDFS-3363: --- +1 I'm fine if Nicholas is fine. > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Attachments: HDFS-3363.java, HDFS-3363.java, HDFS-3363.java > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[
https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268708#comment-13268708
]
Tsz Wo (Nicholas), SZE commented on HDFS-3363:
--
- Move BlockCollection.setBlock(..) to MutableBlockCollection and change the
parameter in BlockManger.forceCompleteBlock(..) and completeBlock(..) to
MutableBlockCollection. We should also move setBlock(..) from INodeFile to
INodeFileUnderConstruction (this can be done separately.)
- need to update the following
{code}
//FSNamesystem.listCorruptFileBlocks(..)
String src = FSDirectory.getFullPathName(inode);
{code}
- revert the following: we don't need to cast it for null checking
{code}
//FSNamesystem
private boolean isValidBlock(Block b) {
-return (blockManager.getINode(b) != null);
+return ((INodeFile) blockManager.getINode(b) != null);
}
{code}
- Need to rewrite the javadoc in BlockCollection and MutableBlockCollection
-* do not use "file"
-* do not mention INodeFile and INodeFileUnderConstruction
- revert the changes in TestBlockManager and FSEditLogLoader.
> blockmanagement should stop using INodeFile & INodeFileUC
> --
>
> Key: HDFS-3363
> URL: https://issues.apache.org/jira/browse/HDFS-3363
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
>Affects Versions: 2.0.0, 3.0.0
>Reporter: John George
>Assignee: John George
>Priority: Minor
> Attachments: HDFS-3363.java, HDFS-3363.java
>
>
> Blockmanagement should stop using INodeFile and INodeFileUnderConstruction.
> One way would be to create an interface, like BlockColletion, that is passed
> along to the blockmanagement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268393#comment-13268393 ] Hadoop QA commented on HDFS-3363: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525624/HDFS-3363.java against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2375//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2375//console This message is automatically generated. > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Attachments: HDFS-3363.java, HDFS-3363.java > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267845#comment-13267845 ] Tsz Wo (Nicholas), SZE commented on HDFS-3363: -- After the patch, we could easily change INodeFile and INodeFileUnderConstruction to package private. We only have to update a few unit tests. Nice work! > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Attachments: HDFS-3363.java > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267806#comment-13267806 ] Tsz Wo (Nicholas), SZE commented on HDFS-3363: -- - BlockCollection and MutableBlockCollection should be in the blockmanagement package. Then, services other than namenode can use them. Also, the javadoc should not use the term "file". - Remove BlockCollection.isDirectory() and the assert statement in BlockManager.getReplication(Block block). - Remove BlockCollection.isUnderConstruction() and replace the use of it in blockmanagement by checking instanceof MutableBlockCollection. - Rename getFullPathName() to getName(). It is the name of the collection but not necessarily a path name. - I agree with Daryn that we should rename BlocksMap.getINode(..) and, in addition, the local variable names such as fileInode. We could do the rename separately. > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Attachments: HDFS-3363.java > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267800#comment-13267800 ] Hadoop QA commented on HDFS-3363: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525494/HDFS-3363.java against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2368//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2368//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2368//console This message is automatically generated. > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > Attachments: HDFS-3363.java > > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[
https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267761#comment-13267761
]
Daryn Sharp commented on HDFS-3363:
---
This is probably just a step in the right direction, but it seems odd that
{{BlocksMap#getINode}} isn't renamed to {{getBlockCollection}} since it now
returns a {{BlockCollection}}.
My only concern is why pathname handling is moved into {{INode}}? Inodes
should be "dumb" model objects, with a controller that handles path
manipulation -- ie. {{FSDirectory}}.
> blockmanagement should stop using INodeFile & INodeFileUC
> --
>
> Key: HDFS-3363
> URL: https://issues.apache.org/jira/browse/HDFS-3363
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
>Affects Versions: 2.0.0, 3.0.0
>Reporter: John George
>Assignee: John George
>Priority: Minor
> Attachments: HDFS-3363.java
>
>
> Blockmanagement should stop using INodeFile and INodeFileUnderConstruction.
> One way would be to create an interface, like BlockColletion, that is passed
> along to the blockmanagement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267632#comment-13267632 ] Tsz Wo (Nicholas), SZE commented on HDFS-3363: -- Block management should only care about blocks but not the namespace. It should not know anything about the namespace. It makes sense to define a BlockCollection interface for INodeFile and INodeFileUnderConstruction. We probably need two interfaces, one for mutable collections and another one for immutable collections. > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George >Priority: Minor > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267557#comment-13267557 ] John George commented on HDFS-3363: --- It is not absolutely important, but its needed to complete the move of block management over. I will move the priority to 'Minor' to indicate the same. > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3363) blockmanagement should stop using INodeFile & INodeFileUC
[ https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267544#comment-13267544 ] Suresh Srinivas commented on HDFS-3363: --- bq. Blockmanagement should stop using INodeFile and INodeFileUnderConstruction Can you add details on why this is important? > blockmanagement should stop using INodeFile & INodeFileUC > -- > > Key: HDFS-3363 > URL: https://issues.apache.org/jira/browse/HDFS-3363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node >Affects Versions: 2.0.0, 3.0.0 >Reporter: John George >Assignee: John George > > Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. > One way would be to create an interface, like BlockColletion, that is passed > along to the blockmanagement. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
