[jira] [Commented] (HDFS-3896) Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466051#comment-13466051 ] Aaron T. Myers commented on HDFS-3896: -- +1, the latest patch looks good to me. I'm going to commit this momentarily. Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml - Key: HDFS-3896 URL: https://issues.apache.org/jira/browse/HDFS-3896 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.0.0-alpha Reporter: Jeff Lord Assignee: Jeff Lord Priority: Minor Attachments: hdfs-default-1.patch, hdfs-default-2.patch, hdfs-default-3.patch, hdfs-default.patch Currently there are mentions of these properties in the docs but not much else. Would make sense to have empty place holders in hdfs-default.xml to clarify where they go and what they are. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3896) Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451354#comment-13451354 ] Hadoop QA commented on HDFS-3896: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544354/hdfs-default-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer org.apache.hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps org.apache.hadoop.hdfs.TestListFilesInFileContext org.apache.hadoop.security.TestRefreshUserMappings org.apache.hadoop.hdfs.server.namenode.ha.TestHAWebUI org.apache.hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality org.apache.hadoop.hdfs.TestDFSClientFailover org.apache.hadoop.hdfs.server.namenode.ha.TestDFSZKFailoverController org.apache.hadoop.hdfs.TestParallelLocalRead org.apache.hadoop.hdfs.server.datanode.TestBlockReport org.apache.hadoop.hdfs.TestParallelRead org.apache.hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling org.apache.hadoop.hdfs.TestLeaseRecovery2 org.apache.hadoop.hdfs.TestBlockMissingException org.apache.hadoop.hdfs.server.journalservice.TestJournalService org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage org.apache.hadoop.hdfs.TestWriteConfigurationToDFS org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.fs.TestGlobPaths org.apache.hadoop.hdfs.TestCrcCorruption org.apache.hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation org.apache.hadoop.hdfs.TestFileAppend org.apache.hadoop.hdfs.TestPread org.apache.hadoop.hdfs.server.namenode.TestEditLogRace org.apache.hadoop.hdfs.TestReplication org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery org.apache.hadoop.fs.viewfs.TestViewFileSystemHdfs org.apache.hadoop.hdfs.TestMissingBlocksAlert org.apache.hadoop.hdfs.TestDFSUpgradeFromImage org.apache.hadoop.hdfs.server.datanode.TestMultipleNNDataBlockScanner org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure org.apache.hadoop.hdfs.TestDFSAddressConfig org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner org.apache.hadoop.hdfs.TestSmallBlock org.apache.hadoop.hdfs.web.TestWebHDFS org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite org.apache.hadoop.hdfs.server.namenode.TestBackupNode org.apache.hadoop.hdfs.server.namenode.TestStartupOptionUpgrade org.apache.hadoop.hdfs.server.datanode.TestRefreshNamenodes org.apache.hadoop.hdfs.server.namenode.TestFsck org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark org.apache.hadoop.fs.viewfs.TestViewFsHdfs org.apache.hadoop.hdfs.server.namenode.TestStartup org.apache.hadoop.hdfs.server.namenode.TestNameNodeMXBean org.apache.hadoop.hdfs.server.namenode.ha.TestStateTransitionFailure org.apache.hadoop.hdfs.server.datanode.TestDatanodeJsp org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery org.apache.hadoop.hdfs.TestFileStatus org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement org.apache.hadoop.hdfs.server.namenode.TestEditLogFileOutputStream
[jira] [Commented] (HDFS-3896) Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451450#comment-13451450 ] Hadoop QA commented on HDFS-3896: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544374/hdfs-default-3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3164//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3164//console This message is automatically generated. Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml - Key: HDFS-3896 URL: https://issues.apache.org/jira/browse/HDFS-3896 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.0.0-alpha Reporter: Jeff Lord Assignee: Jeff Lord Priority: Minor Attachments: hdfs-default-1.patch, hdfs-default-2.patch, hdfs-default-3.patch, hdfs-default.patch Currently there are mentions of these properties in the docs but not much else. Would make sense to have empty place holders in hdfs-default.xml to clarify where they go and what they are. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3896) Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451120#comment-13451120 ] Aaron T. Myers commented on HDFS-3896: -- Hey Jeff, latest patch looks better. Thanks for addressing my comments. I didn't intend to suggest that you should remove the if the port is 0... from everywhere in the file, but rather just from the NN http-address description. Thinking about it more, however, I think this is probably a good change as well. Does anyone have any thoughts on that? Two more little comments on the patch: # I should've noticed this before, but this patch actually introduces a second instance of dfs.namenode.http-address in hdfs-default.xml, even though it's already present. We should only have one instance. # The patch doesn't cleanly apply to trunk. Please upload a patch against trunk, and hit the Submit patch button so that Jenkins runs once you've done so. Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml - Key: HDFS-3896 URL: https://issues.apache.org/jira/browse/HDFS-3896 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.0.0-alpha Reporter: Jeff Lord Assignee: Jeff Lord Priority: Minor Attachments: hdfs-default-1.patch, hdfs-default.patch Currently there are mentions of these properties in the docs but not much else. Would make sense to have empty place holders in hdfs-default.xml to clarify where they go and what they are. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3896) Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450118#comment-13450118 ] Aaron T. Myers commented on HDFS-3896: -- Patch looks pretty good to me, Jeff. A few little comments: # I'd recommend removing the line about if the port is 0... from the namenode http-address config. Even if that's technically true, users really shouldn't be doing that, since they then won't be able to find the NN web UI, and the 2NN won't be able to checkpoint since it needs to know the HTTP address of the NN. # In general I think I'd replace the word server with address in your patch, e.g. RPC address for HDFS... instead of RPC server for HDFS # This sentence doesn't really parse: In the case of HA/Federation where multiple namenodes exist. The suffix of the namenode service id is added to the name e.g. dfs.namenode.rpc-address.ns1 dfs.namenode.rpc-address.NameServiceID # You might want to mention in the description for servicerpc-address that the value of the rpc-address will be used as the default if the servicerpc-address is unset. Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml - Key: HDFS-3896 URL: https://issues.apache.org/jira/browse/HDFS-3896 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 0.23.0 Reporter: Jeff Lord Attachments: hdfs-default.patch Currently there are mentions of these properties in the docs but not much else. Would make sense to have empty place holders in hdfs-default.xml to clarify where they go and what they are. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3896) Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml
[ https://issues.apache.org/jira/browse/HDFS-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450277#comment-13450277 ] Jeff Lord commented on HDFS-3896: - ATM, Thank you for the recommendations. Second pass is attached. Add place holder for dfs.namenode.rpc-address and dfs.namenode.servicerpc-address to hdfs-default.xml - Key: HDFS-3896 URL: https://issues.apache.org/jira/browse/HDFS-3896 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.0.0-alpha Reporter: Jeff Lord Assignee: Jeff Lord Priority: Minor Attachments: hdfs-default-1.patch, hdfs-default.patch Currently there are mentions of these properties in the docs but not much else. Would make sense to have empty place holders in hdfs-default.xml to clarify where they go and what they are. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
