[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153077#comment-14153077
]
Hudson commented on HDFS-4165:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #696 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/696/])
Move HDFS-4165 from trunk to 2.6.0 in CHANGES.txt. (wang: rev
371ef4cefc65996e41f7072c4f396fe14d2375b1)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 2.6.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153191#comment-14153191
]
Hudson commented on HDFS-4165:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1887 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1887/])
Move HDFS-4165 from trunk to 2.6.0 in CHANGES.txt. (wang: rev
371ef4cefc65996e41f7072c4f396fe14d2375b1)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 2.6.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153248#comment-14153248
]
Hudson commented on HDFS-4165:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1912 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1912/])
Move HDFS-4165 from trunk to 2.6.0 in CHANGES.txt. (wang: rev
371ef4cefc65996e41f7072c4f396fe14d2375b1)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 2.6.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151982#comment-14151982
]
Hudson commented on HDFS-4165:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6140 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6140/])
Move HDFS-4165 from trunk to 2.6.0 in CHANGES.txt. (wang: rev
371ef4cefc65996e41f7072c4f396fe14d2375b1)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 2.6.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148641#comment-14148641
]
Andrew Wang commented on HDFS-4165:
---
Hey guys, any reason this was not merged to branch-2? I was doing a diff on
FSDirectory for unrelated reasons, and realized this wasn't pushed down.
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148805#comment-14148805
]
Binglin Chang commented on HDFS-4165:
-
I think the change is simple and it is OK to merge to branch-2.
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13493895#comment-13493895
]
Hudson commented on HDFS-4165:
--
Integrated in Hadoop-Yarn-trunk #31 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/31/])
HDFS-4165. Faulty sanity check in FsDirectory.unprotectedSetQuota.
Contributed by Binglin Chang. (Revision 1407245)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1407245
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13493977#comment-13493977
]
Hudson commented on HDFS-4165:
--
Integrated in Hadoop-Hdfs-trunk #1221 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1221/])
HDFS-4165. Faulty sanity check in FsDirectory.unprotectedSetQuota.
Contributed by Binglin Chang. (Revision 1407245)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1407245
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13494002#comment-13494002
]
Hudson commented on HDFS-4165:
--
Integrated in Hadoop-Mapreduce-trunk #1251 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1251/])
HDFS-4165. Faulty sanity check in FsDirectory.unprotectedSetQuota.
Contributed by Binglin Chang. (Revision 1407245)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1407245
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13493445#comment-13493445
]
Brandon Li commented on HDFS-4165:
--
+1, the patch looks good. Thanks for fixing it.
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13493460#comment-13493460
]
Hudson commented on HDFS-4165:
--
Integrated in Hadoop-trunk-Commit #2984 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/2984/])
HDFS-4165. Faulty sanity check in FsDirectory.unprotectedSetQuota.
Contributed by Binglin Chang. (Revision 1407245)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1407245
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13493482#comment-13493482
]
Eli Collins commented on HDFS-4165:
---
How about updating TestQuota? See HDFS-46 for a similar example.
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13493644#comment-13493644
]
Binglin Chang commented on HDFS-4165:
-
Thanks Suresh and Brandon for review.
@Eli
Given the current constant value, the current sanity check can't fail
{code}
public static final long QUOTA_DONT_SET = Long.MAX_VALUE;
public static final long QUOTA_RESET = -1L;
{code}
HDFS-46 also reminds me that Long.MAX_VALUE is used both for QUOTA_DONT_SET and
the default namespace quota of root directory, so you can't set quota to
Long.MAX_VALUE for root directory using RPC, a better value for QUOTA_DONT_SET
should be -2 instead.
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 3.0.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota
[
https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13492962#comment-13492962
]
Hadoop QA commented on HDFS-4165:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12552588/HDFS-4165.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3464//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3464//console
This message is automatically generated.
Faulty sanity check in FsDirectory.unprotectedSetQuota
--
Key: HDFS-4165
URL: https://issues.apache.org/jira/browse/HDFS-4165
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HDFS-4165.patch
According to the documentation:
The quota can have three types of values : (1) 0 or more will set
the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies
the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET}
implies the quota will be reset. Any other value is a runtime error.
sanity check in FsDirectory.unprotectedSetQuota should use
{code}
nsQuota != HdfsConstants.QUOTA_RESET
{code}
rather than
{code}
nsQuota HdfsConstants.QUOTA_RESET
{code}
Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem
for this code, but it is better to do it right.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
