[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551927#comment-13551927 ] Hudson commented on HDFS-4274: -- Integrated in Hadoop-Mapreduce-trunk #1311 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1311/]) Update CHANGES.txt to reflect HDFS-4274 merge. (Revision 1432316) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432316 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 2.0.0-alpha, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth >Priority: Minor > Fix For: 2.0.3-alpha, trunk-win > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551919#comment-13551919 ] Hudson commented on HDFS-4274: -- Integrated in Hadoop-Hdfs-trunk #1283 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1283/]) Update CHANGES.txt to reflect HDFS-4274 merge. (Revision 1432316) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432316 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 2.0.0-alpha, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth >Priority: Minor > Fix For: 2.0.3-alpha, trunk-win > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551886#comment-13551886 ] Hudson commented on HDFS-4274: -- Integrated in Hadoop-Yarn-trunk #94 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/94/]) Update CHANGES.txt to reflect HDFS-4274 merge. (Revision 1432316) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432316 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 2.0.0-alpha, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth >Priority: Minor > Fix For: 2.0.3-alpha, trunk-win > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551590#comment-13551590 ] Hudson commented on HDFS-4274: -- Integrated in Hadoop-trunk-Commit #3221 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3221/]) Update CHANGES.txt to reflect HDFS-4274 merge. (Revision 1432316) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432316 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 2.0.0-alpha, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth >Priority: Minor > Fix For: 2.0.3-alpha, trunk-win > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551493#comment-13551493 ] Suresh Srinivas commented on HDFS-4274: --- Please merge it. > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Fix For: 3.0.0 > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551462#comment-13551462 ] Eli Collins commented on HDFS-4274: --- This like a nice fix to merge to branch-2, anyone objections? > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Fix For: 3.0.0 > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549876#comment-13549876 ] Chris Nauroth commented on HDFS-4274: - Aaron, thanks for the note here so that I would notice the new jira. I'm going to enter some preliminary analysis on HDFS-4328. > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Fix For: 3.0.0 > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549394#comment-13549394 ] Aaron T. Myers commented on HDFS-4274: -- Hey ya'll, it looks like this commit has broken TestLargeBlock. I can't tell for sure since the results from this JIRA's test-patch run have been deleted by Jenkins, but I suspect that this wasn't noticed since test-patch doesn't report on tests that time out rather than explicitly fail. This test failure is tracked by HDFS-4328. Chris - would you mind taking a look at that JIRA to see if you can tell what the trouble is? > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Fix For: 3.0.0 > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533395#comment-13533395 ] Hudson commented on HDFS-4274: -- Integrated in Hadoop-Mapreduce-trunk #1287 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1287/]) HDFS-4274. BlockPoolSliceScanner does not close verification log during shutdown. Contributed by Chris Nauroth. (Revision 1422276) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1422276 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceScanner.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Fix For: 3.0.0 > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533385#comment-13533385 ] Hudson commented on HDFS-4274: -- Integrated in Hadoop-Hdfs-trunk #1256 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1256/]) HDFS-4274. BlockPoolSliceScanner does not close verification log during shutdown. Contributed by Chris Nauroth. (Revision 1422276) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1422276 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceScanner.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Fix For: 3.0.0 > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533347#comment-13533347 ] Hudson commented on HDFS-4274: -- Integrated in Hadoop-Yarn-trunk #67 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/67/]) HDFS-4274. BlockPoolSliceScanner does not close verification log during shutdown. Contributed by Chris Nauroth. (Revision 1422276) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1422276 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceScanner.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Fix For: 3.0.0 > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533063#comment-13533063 ] Hudson commented on HDFS-4274: -- Integrated in Hadoop-trunk-Commit #3124 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3124/]) HDFS-4274. BlockPoolSliceScanner does not close verification log during shutdown. Contributed by Chris Nauroth. (Revision 1422276) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1422276 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceScanner.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Fix For: 3.0.0 > > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533057#comment-13533057 ] Suresh Srinivas commented on HDFS-4274: --- +1 for the patch. > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530376#comment-13530376 ] Ivan Mitic commented on HDFS-4274: -- Thanks Chris, change looks good to me, +1 > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530374#comment-13530374 ] Xuan Gong commented on HDFS-4274: - +1 Looks good > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529620#comment-13529620 ] Chris Nauroth commented on HDFS-4274: - There are no new tests, but this patch is required to unblock more than 100 test suites when running on Windows. > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529598#comment-13529598 ] Hadoop QA commented on HDFS-4274: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12560484/HDFS-4274.2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3645//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3645//console This message is automatically generated. > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4274.1.patch, HDFS-4274.2.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528590#comment-13528590 ] Ivan Mitic commented on HDFS-4274: -- Thanks Chris for reporting the problem and for the patch! I also saw that something around DataBlockScanner causes many tests to fail. Quick question, would it make sense to shutdown BlockPoolSliceScanners on DataBlockScanner#shutdown? In the current patch you are assuming that it is fine to close the verificationlogs when DataBlockScanner#run exits what might not be always true (don't know for sure, asking based on the class relationship). Just a thought, otherwise patch looks good. > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4274.1.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528363#comment-13528363 ] Xuan Gong commented on HDFS-4274: - +1 Looks good > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4274.1.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526959#comment-13526959 ] Hadoop QA commented on HDFS-4274: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12559982/HDFS-4274.1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3623//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3623//console This message is automatically generated. > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4274.1.patch > > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4274) BlockPoolSliceScanner does not close verification log during shutdown
[ https://issues.apache.org/jira/browse/HDFS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510657#comment-13510657 ] Chris Nauroth commented on HDFS-4274: - This is particularly problematic for tests on Windows. The tests stop and start {{MiniDFSCluster}} many times within the same process. Windows holds a lock on the unclosed verification log, preventing {{MiniDFSCluster}} from fully deleting the testing data directory. This problem currently causes 152 test suites to fail early during initialization on Windows. I have a patch in progress for {{DataBlockScanner}} to call a shutdown method on {{BlockPoolSliceScanner}} so that it can close the verification log. > BlockPoolSliceScanner does not close verification log during shutdown > - > > Key: HDFS-4274 > URL: https://issues.apache.org/jira/browse/HDFS-4274 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Affects Versions: trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > > {{BlockPoolSliceScanner}} holds open a handle to a verification log. This > file is not getting closed during process shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira