[jira] [Commented] (HDFS-4567) Webhdfs does not need a token for token operations
[
https://issues.apache.org/jira/browse/HDFS-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596571#comment-13596571
]
Hadoop QA commented on HDFS-4567:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12572621/HDFS-4567.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:red}-1 one of tests included doesn't have a timeout.{color}
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4052//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4052//console
This message is automatically generated.
> Webhdfs does not need a token for token operations
> --
>
> Key: HDFS-4567
> URL: https://issues.apache.org/jira/browse/HDFS-4567
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: webhdfs
>Affects Versions: 2.0.0-alpha, 3.0.0, 0.23.7
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: HDFS-4567.branch-23.patch, HDFS-4567.patch
>
>
> Webhdfs will implicitly acquire a token to get/renew/cancel other tokens even
> though it neither needs nor uses the token. The implicit token triggers a
> renewer thread for the fs which is undesirable for daemons such as oozie and
> yarn's RM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4567) Webhdfs does not need a token for token operations
[
https://issues.apache.org/jira/browse/HDFS-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597240#comment-13597240
]
Hadoop QA commented on HDFS-4567:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12572769/HDFS-4567.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 tests included appear to have a timeout.{color}
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4059//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4059//console
This message is automatically generated.
> Webhdfs does not need a token for token operations
> --
>
> Key: HDFS-4567
> URL: https://issues.apache.org/jira/browse/HDFS-4567
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: webhdfs
>Affects Versions: 2.0.0-alpha, 3.0.0, 0.23.7
>Reporter: Daryn Sharp
>Assignee: Daryn Sharp
> Attachments: HDFS-4567.branch-23.patch, HDFS-4567.branch-23.patch,
> HDFS-4567.patch, HDFS-4567.patch
>
>
> Webhdfs will implicitly acquire a token to get/renew/cancel other tokens even
> though it neither needs nor uses the token. The implicit token triggers a
> renewer thread for the fs which is undesirable for daemons such as oozie and
> yarn's RM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4567) Webhdfs does not need a token for token operations
[ https://issues.apache.org/jira/browse/HDFS-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597279#comment-13597279 ] Kihwal Lee commented on HDFS-4567: -- The patch looks good. The change prevents unconditional pre-acquisition of tokens, but do acquire a token for non-token related operations. There is slight change in behavior. If the file system instance is created, but no operation is done for long enough to expire tgt in the ticket cache, it won't be usable any more. Previously, pre-acquired token could outlast tgt and allow the file system to be used. But this change of behavior will only matter if ticket cache is used, not keytab and a WebHdfsFileSystem instance is created, but unused for a long time. Since services typically use keytab, this will mostly be confined to user interactive sessions and scripts where users need to make sure a valid tgt is present and the file system is used right away. Overall, there should be no visible negative effect. +1 > Webhdfs does not need a token for token operations > -- > > Key: HDFS-4567 > URL: https://issues.apache.org/jira/browse/HDFS-4567 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: webhdfs >Affects Versions: 2.0.0-alpha, 3.0.0, 0.23.7 >Reporter: Daryn Sharp >Assignee: Daryn Sharp > Attachments: HDFS-4567.branch-23.patch, HDFS-4567.branch-23.patch, > HDFS-4567.patch, HDFS-4567.patch > > > Webhdfs will implicitly acquire a token to get/renew/cancel other tokens even > though it neither needs nor uses the token. The implicit token triggers a > renewer thread for the fs which is undesirable for daemons such as oozie and > yarn's RM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4567) Webhdfs does not need a token for token operations
[ https://issues.apache.org/jira/browse/HDFS-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597289#comment-13597289 ] Hudson commented on HDFS-4567: -- Integrated in Hadoop-trunk-Commit #3441 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3441/]) HDFS-4567. Webhdfs does not need a token for token operations. Contributed by Daryn Sharp. (Revision 1454460) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454460 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTokens.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsUrl.java > Webhdfs does not need a token for token operations > -- > > Key: HDFS-4567 > URL: https://issues.apache.org/jira/browse/HDFS-4567 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: webhdfs >Affects Versions: 2.0.0-alpha, 3.0.0, 0.23.7 >Reporter: Daryn Sharp >Assignee: Daryn Sharp > Attachments: HDFS-4567.branch-23.patch, HDFS-4567.branch-23.patch, > HDFS-4567.patch, HDFS-4567.patch > > > Webhdfs will implicitly acquire a token to get/renew/cancel other tokens even > though it neither needs nor uses the token. The implicit token triggers a > renewer thread for the fs which is undesirable for daemons such as oozie and > yarn's RM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4567) Webhdfs does not need a token for token operations
[ https://issues.apache.org/jira/browse/HDFS-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597896#comment-13597896 ] Hudson commented on HDFS-4567: -- Integrated in Hadoop-Yarn-trunk #150 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/150/]) HDFS-4567. Webhdfs does not need a token for token operations. Contributed by Daryn Sharp. (Revision 1454460) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454460 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTokens.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsUrl.java > Webhdfs does not need a token for token operations > -- > > Key: HDFS-4567 > URL: https://issues.apache.org/jira/browse/HDFS-4567 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: webhdfs >Affects Versions: 2.0.0-alpha, 3.0.0, 0.23.7 >Reporter: Daryn Sharp >Assignee: Daryn Sharp > Fix For: 3.0.0, 0.23.7, 2.0.4-alpha > > Attachments: HDFS-4567.branch-23.patch, HDFS-4567.branch-23.patch, > HDFS-4567.patch, HDFS-4567.patch > > > Webhdfs will implicitly acquire a token to get/renew/cancel other tokens even > though it neither needs nor uses the token. The implicit token triggers a > renewer thread for the fs which is undesirable for daemons such as oozie and > yarn's RM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4567) Webhdfs does not need a token for token operations
[ https://issues.apache.org/jira/browse/HDFS-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597915#comment-13597915 ] Hudson commented on HDFS-4567: -- Integrated in Hadoop-Hdfs-0.23-Build #548 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/548/]) Undo double application of patch to TestWebHdfsTokens.java for HDFS-4567. (Revision 1454474) HDFS-4567. Webhdfs does not need a token for token operations. Contributed by Daryn Sharp. (Revision 1454469) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454474 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTokens.java kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454469 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTokens.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsUrl.java > Webhdfs does not need a token for token operations > -- > > Key: HDFS-4567 > URL: https://issues.apache.org/jira/browse/HDFS-4567 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: webhdfs >Affects Versions: 2.0.0-alpha, 3.0.0, 0.23.7 >Reporter: Daryn Sharp >Assignee: Daryn Sharp > Fix For: 3.0.0, 0.23.7, 2.0.4-alpha > > Attachments: HDFS-4567.branch-23.patch, HDFS-4567.branch-23.patch, > HDFS-4567.patch, HDFS-4567.patch > > > Webhdfs will implicitly acquire a token to get/renew/cancel other tokens even > though it neither needs nor uses the token. The implicit token triggers a > renewer thread for the fs which is undesirable for daemons such as oozie and > yarn's RM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4567) Webhdfs does not need a token for token operations
[ https://issues.apache.org/jira/browse/HDFS-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597924#comment-13597924 ] Hudson commented on HDFS-4567: -- Integrated in Hadoop-Hdfs-trunk #1339 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1339/]) HDFS-4567. Webhdfs does not need a token for token operations. Contributed by Daryn Sharp. (Revision 1454460) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454460 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTokens.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsUrl.java > Webhdfs does not need a token for token operations > -- > > Key: HDFS-4567 > URL: https://issues.apache.org/jira/browse/HDFS-4567 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: webhdfs >Affects Versions: 2.0.0-alpha, 3.0.0, 0.23.7 >Reporter: Daryn Sharp >Assignee: Daryn Sharp > Fix For: 3.0.0, 0.23.7, 2.0.4-alpha > > Attachments: HDFS-4567.branch-23.patch, HDFS-4567.branch-23.patch, > HDFS-4567.patch, HDFS-4567.patch > > > Webhdfs will implicitly acquire a token to get/renew/cancel other tokens even > though it neither needs nor uses the token. The implicit token triggers a > renewer thread for the fs which is undesirable for daemons such as oozie and > yarn's RM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4567) Webhdfs does not need a token for token operations
[ https://issues.apache.org/jira/browse/HDFS-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597946#comment-13597946 ] Hudson commented on HDFS-4567: -- Integrated in Hadoop-Mapreduce-trunk #1367 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1367/]) HDFS-4567. Webhdfs does not need a token for token operations. Contributed by Daryn Sharp. (Revision 1454460) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454460 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTokens.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsUrl.java > Webhdfs does not need a token for token operations > -- > > Key: HDFS-4567 > URL: https://issues.apache.org/jira/browse/HDFS-4567 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: webhdfs >Affects Versions: 2.0.0-alpha, 3.0.0, 0.23.7 >Reporter: Daryn Sharp >Assignee: Daryn Sharp > Fix For: 3.0.0, 0.23.7, 2.0.4-alpha > > Attachments: HDFS-4567.branch-23.patch, HDFS-4567.branch-23.patch, > HDFS-4567.patch, HDFS-4567.patch > > > Webhdfs will implicitly acquire a token to get/renew/cancel other tokens even > though it neither needs nor uses the token. The implicit token triggers a > renewer thread for the fs which is undesirable for daemons such as oozie and > yarn's RM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
