[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1360#comment-1360 ] Hudson commented on HDFS-4572: -- Integrated in Hadoop-Hdfs-trunk #1342 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1342/]) HDFS-4572. Fix TestJournal failures on Windows. Contributed by Arpit Agarwal. (Revision 1455360) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455360 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournal.java > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600053#comment-13600053 ] Hudson commented on HDFS-4572: -- Integrated in Hadoop-Mapreduce-trunk #1370 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1370/]) HDFS-4572. Fix TestJournal failures on Windows. Contributed by Arpit Agarwal. (Revision 1455360) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455360 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournal.java > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599906#comment-13599906 ] Hudson commented on HDFS-4572: -- Integrated in Hadoop-Yarn-trunk #153 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/153/]) HDFS-4572. Fix TestJournal failures on Windows. Contributed by Arpit Agarwal. (Revision 1455360) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455360 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournal.java > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599472#comment-13599472 ] Hudson commented on HDFS-4572: -- Integrated in Hadoop-trunk-Commit #3449 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3449/]) HDFS-4572. Fix TestJournal failures on Windows. Contributed by Arpit Agarwal. (Revision 1455360) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455360 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournal.java > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599453#comment-13599453 ] Suresh Srinivas commented on HDFS-4572: --- +1 for the patch. I will commit it soon. > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599441#comment-13599441 ] Ivan Mitic commented on HDFS-4572: -- Hi Arpit, we already filed HDFS-4586 on TestDataDirs failing. Will resolve yours as a duplicate. > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599436#comment-13599436 ] Arpit Agarwal commented on HDFS-4572: - The TestDataDirs failure is unrelated to my patch and repros on clean trunk. I filed HDFS-4589. > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[
https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599424#comment-13599424
]
Hadoop QA commented on HDFS-4572:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12573176/HDFS-4572.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 tests included appear to have a timeout.{color}
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.datanode.TestDataDirs
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4078//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4078//console
This message is automatically generated.
> Fix TestJournal failures on Windows
> ---
>
> Key: HDFS-4572
> URL: https://issues.apache.org/jira/browse/HDFS-4572
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode, test
>Affects Versions: 3.0.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Fix For: 3.0.0
>
> Attachments: HDFS-4572.patch, HDFS-4572.patch, HDFS-4572.patch
>
>
> Multiple test failures in TestJournal. Windows is stricter about restricting
> access to in-use files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[
https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599227#comment-13599227
]
Suresh Srinivas commented on HDFS-4572:
---
Also, while handling the above comment, you could also make the code terse by:
{code}
// Cannot read from the locked file on Windows
String lockingJvmName = Path.WINDOWS ? "" : file.readLine();
{code}
> Fix TestJournal failures on Windows
> ---
>
> Key: HDFS-4572
> URL: https://issues.apache.org/jira/browse/HDFS-4572
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode, test
>Affects Versions: 3.0.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Fix For: 3.0.0
>
> Attachments: HDFS-4572.patch, HDFS-4572.patch
>
>
> Multiple test failures in TestJournal. Windows is stricter about restricting
> access to in-use files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599217#comment-13599217 ] Suresh Srinivas commented on HDFS-4572: --- Arpit, instead of printing "It appears that another namenode unknown has already locked the storage directory", would it not make sense to print "It appears that another namenode has already locked the storage directory". That is instead of setting lockingJvmName to unknown, set it to empty? > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597847#comment-13597847 ] Arpit Agarwal commented on HDFS-4572: - Thanks for reviewing! Ivan, adding timeout annotations for each new or changed test case is a requirement in trunk now. > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597813#comment-13597813 ] Ivan Mitic commented on HDFS-4572: -- Patch looks good, +1 One question though, I see that you're adding a timeout to every test case in the test. Is this a new guideline? I found it hard to debug tests like these and always ended up removing the timeout what seemed a bit odd. Would it make more sense to have a test wide 15 minute timeout or something? Ideally, the timeout would be configured from the outside and not hit when debugging from eclipse. > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[
https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597446#comment-13597446
]
Hadoop QA commented on HDFS-4572:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12572789/HDFS-4572.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 tests included appear to have a timeout.{color}
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4061//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4061//console
This message is automatically generated.
> Fix TestJournal failures on Windows
> ---
>
> Key: HDFS-4572
> URL: https://issues.apache.org/jira/browse/HDFS-4572
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode, test
>Affects Versions: 3.0.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Fix For: 3.0.0
>
> Attachments: HDFS-4572.patch, HDFS-4572.patch
>
>
> Multiple test failures in TestJournal. Windows is stricter about restricting
> access to in-use files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597350#comment-13597350 ] Chris Nauroth commented on HDFS-4572: - +1 for the current patch. Thanks for addressing the findbugs warning, and the explanation makes sense. > Fix TestJournal failures on Windows > --- > > Key: HDFS-4572 > URL: https://issues.apache.org/jira/browse/HDFS-4572 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, test >Affects Versions: 3.0.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0 > > Attachments: HDFS-4572.patch, HDFS-4572.patch > > > Multiple test failures in TestJournal. Windows is stricter about restricting > access to in-use files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[
https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596654#comment-13596654
]
Hadoop QA commented on HDFS-4572:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12572639/HDFS-4572.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 tests included appear to have a timeout.{color}
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4053//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/4053//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4053//console
This message is automatically generated.
> Fix TestJournal failures on Windows
> ---
>
> Key: HDFS-4572
> URL: https://issues.apache.org/jira/browse/HDFS-4572
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode, test
>Affects Versions: 3.0.0
>Reporter: Arpit Agarwal
> Fix For: 3.0.0
>
> Attachments: HDFS-4572.patch
>
>
> Multiple test failures in TestJournal. Windows is stricter about restricting
> access to in-use files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4572) Fix TestJournal failures on Windows
[
https://issues.apache.org/jira/browse/HDFS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596641#comment-13596641
]
Chris Nauroth commented on HDFS-4572:
-
Great catches!
Is it possible/worthwhile to use one of the file sharing APIs on the lock file
instead of saying that the lock owner is unknown? (i.e.
{{NativeIO#getShareDeleteFileInputStream}} or perhaps add a new
{{NativeIO#getShareReadFileInputStream}} for additional safety.)
{code}
+ lockingJvmName = new String("'unknown'");
{code}
Since this is a string literal, we wouldn't need to call new, and instead could
just say:
{code}
+ lockingJvmName = "'unknown'";
{code}
> Fix TestJournal failures on Windows
> ---
>
> Key: HDFS-4572
> URL: https://issues.apache.org/jira/browse/HDFS-4572
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode, test
>Affects Versions: 3.0.0
>Reporter: Arpit Agarwal
> Fix For: 3.0.0
>
> Attachments: HDFS-4572.patch
>
>
> Multiple test failures in TestJournal. Windows is stricter about restricting
> access to in-use files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
