[jira] [Commented] (HDFS-5981) PBImageXmlWriter generates malformed XML
[
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908390#comment-13908390
]
Hudson commented on HDFS-5981:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1705 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1705/])
HDFS-5981. loadGenerator exit code is not reliable. Contributed by Haohui Mai.
(cnauroth:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570468)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
> PBImageXmlWriter generates malformed XML
>
>
> Key: HDFS-5981
> URL: https://issues.apache.org/jira/browse/HDFS-5981
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
>Affects Versions: 3.0.0, 2.4.0
>Reporter: Haohui Mai
>Assignee: Haohui Mai
>Priority: Minor
> Fix For: 3.0.0, 2.4.0
>
> Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch,
> HDFS-5981.002.patch, HDFS-5981.003.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}}
> incorrectly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5981) PBImageXmlWriter generates malformed XML
[
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908312#comment-13908312
]
Hudson commented on HDFS-5981:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1680 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1680/])
HDFS-5981. loadGenerator exit code is not reliable. Contributed by Haohui Mai.
(cnauroth:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570468)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
> PBImageXmlWriter generates malformed XML
>
>
> Key: HDFS-5981
> URL: https://issues.apache.org/jira/browse/HDFS-5981
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
>Affects Versions: 3.0.0, 2.4.0
>Reporter: Haohui Mai
>Assignee: Haohui Mai
>Priority: Minor
> Fix For: 3.0.0, 2.4.0
>
> Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch,
> HDFS-5981.002.patch, HDFS-5981.003.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}}
> incorrectly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5981) PBImageXmlWriter generates malformed XML
[
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908173#comment-13908173
]
Hudson commented on HDFS-5981:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #488 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/488/])
HDFS-5981. loadGenerator exit code is not reliable. Contributed by Haohui Mai.
(cnauroth:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570468)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
> PBImageXmlWriter generates malformed XML
>
>
> Key: HDFS-5981
> URL: https://issues.apache.org/jira/browse/HDFS-5981
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
>Affects Versions: 3.0.0, 2.4.0
>Reporter: Haohui Mai
>Assignee: Haohui Mai
>Priority: Minor
> Fix For: 3.0.0, 2.4.0
>
> Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch,
> HDFS-5981.002.patch, HDFS-5981.003.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}}
> incorrectly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5981) PBImageXmlWriter generates malformed XML
[
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908039#comment-13908039
]
Hudson commented on HDFS-5981:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #5202 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/5202/])
HDFS-5981. loadGenerator exit code is not reliable. Contributed by Haohui Mai.
(cnauroth:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570468)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
> PBImageXmlWriter generates malformed XML
>
>
> Key: HDFS-5981
> URL: https://issues.apache.org/jira/browse/HDFS-5981
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
>Affects Versions: 3.0.0, 2.4.0
>Reporter: Haohui Mai
>Assignee: Haohui Mai
>Priority: Minor
> Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch,
> HDFS-5981.002.patch, HDFS-5981.003.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}}
> incorrectly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5981) PBImageXmlWriter generates malformed XML
[
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907766#comment-13907766
]
Haohui Mai commented on HDFS-5981:
--
HDFS-5991 is tracking the failure of {{TestLoadGenerator}}. The failure of
{{TestCacheDirectives}} is unrelated.
> PBImageXmlWriter generates malformed XML
>
>
> Key: HDFS-5981
> URL: https://issues.apache.org/jira/browse/HDFS-5981
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
>Affects Versions: 3.0.0, 2.4.0
>Reporter: Haohui Mai
>Assignee: Haohui Mai
>Priority: Minor
> Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch,
> HDFS-5981.002.patch, HDFS-5981.003.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}}
> incorrectly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5981) PBImageXmlWriter generates malformed XML
[
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907763#comment-13907763
]
Hadoop QA commented on HDFS-5981:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12630158/HDFS-5981.003.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.fs.loadGenerator.TestLoadGenerator
org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6196//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6196//console
This message is automatically generated.
> PBImageXmlWriter generates malformed XML
>
>
> Key: HDFS-5981
> URL: https://issues.apache.org/jira/browse/HDFS-5981
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
>Affects Versions: 3.0.0, 2.4.0
>Reporter: Haohui Mai
>Assignee: Haohui Mai
>Priority: Minor
> Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch,
> HDFS-5981.002.patch, HDFS-5981.003.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}}
> incorrectly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5981) PBImageXmlWriter generates malformed XML
[
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907752#comment-13907752
]
Hadoop QA commented on HDFS-5981:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12630155/HDFS-5981.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.fs.loadGenerator.TestLoadGenerator
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6195//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6195//console
This message is automatically generated.
> PBImageXmlWriter generates malformed XML
>
>
> Key: HDFS-5981
> URL: https://issues.apache.org/jira/browse/HDFS-5981
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
>Affects Versions: 3.0.0, 2.4.0
>Reporter: Haohui Mai
>Assignee: Haohui Mai
>Priority: Minor
> Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch,
> HDFS-5981.002.patch, HDFS-5981.003.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}}
> incorrectly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5981) PBImageXmlWriter generates malformed XML
[
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907525#comment-13907525
]
Hadoop QA commented on HDFS-5981:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12630112/HDFS-5981.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6193//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6193//console
This message is automatically generated.
> PBImageXmlWriter generates malformed XML
>
>
> Key: HDFS-5981
> URL: https://issues.apache.org/jira/browse/HDFS-5981
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Haohui Mai
>Priority: Minor
> Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch,
> HDFS-5981.002.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}}
> incorrectly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5981) PBImageXmlWriter generates malformed XML
[
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907446#comment-13907446
]
Chris Nauroth commented on HDFS-5981:
-
Thanks, Haohui. The patch looks good. Would it be possible to add a test that
runs the XML processor on an fsimage containing snapshots, and then asserts
that the output is well-formed XML?
> PBImageXmlWriter generates malformed XML
>
>
> Key: HDFS-5981
> URL: https://issues.apache.org/jira/browse/HDFS-5981
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Haohui Mai
>Priority: Minor
> Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}}
> incorrectly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5981) PBImageXmlWriter generates malformed XML
[
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907320#comment-13907320
]
Akira AJISAKA commented on HDFS-5981:
-
Thank you for updating the patch! LGTM, +1.
> PBImageXmlWriter generates malformed XML
>
>
> Key: HDFS-5981
> URL: https://issues.apache.org/jira/browse/HDFS-5981
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Haohui Mai
>Assignee: Haohui Mai
>Priority: Minor
> Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}}
> incorrectly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
