[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941806#comment-13941806
 ] 

Hudson commented on HDFS-6100:
--

SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1732 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1732/])
HDFS-6100. DataNodeWebHdfsMethods does not failover in HA mode. Contributed by 
Haohui Mai. (jing9: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579301)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/InetSocketAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/NamenodeAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/NamenodeRpcAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFSForHA.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java


> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Fix For: 2.4.0
>
> Attachments: HDFS-6100.000.patch, HDFS-6100.001.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. This implementation has two problems:
> # The {{DFSClient}} only knows about the current active NN, thus it does not 
> support failover.
> # The delegation token is based on the active NN, therefore the {{DFSClient}} 
> will fail to authenticate of the standby NN in secure HA setup.
> Currently the parameter {{namenoderpcaddress}} in the URL stores the host-ip 
> pair that corresponds to the active NN. To fix this bug, this jira proposes 
> to store the name service id in the parameter in HA setup (yet the parameter 
> stays the same in non-HA setup).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941734#comment-13941734
 ] 

Hudson commented on HDFS-6100:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk #1707 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1707/])
HDFS-6100. DataNodeWebHdfsMethods does not failover in HA mode. Contributed by 
Haohui Mai. (jing9: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579301)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/InetSocketAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/NamenodeAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/NamenodeRpcAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFSForHA.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java


> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Fix For: 2.4.0
>
> Attachments: HDFS-6100.000.patch, HDFS-6100.001.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. This implementation has two problems:
> # The {{DFSClient}} only knows about the current active NN, thus it does not 
> support failover.
> # The delegation token is based on the active NN, therefore the {{DFSClient}} 
> will fail to authenticate of the standby NN in secure HA setup.
> Currently the parameter {{namenoderpcaddress}} in the URL stores the host-ip 
> pair that corresponds to the active NN. To fix this bug, this jira proposes 
> to store the name service id in the parameter in HA setup (yet the parameter 
> stays the same in non-HA setup).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-20 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941631#comment-13941631
 ] 

Hudson commented on HDFS-6100:
--

FAILURE: Integrated in Hadoop-Yarn-trunk #515 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/515/])
HDFS-6100. DataNodeWebHdfsMethods does not failover in HA mode. Contributed by 
Haohui Mai. (jing9: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579301)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/InetSocketAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/NamenodeAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/NamenodeRpcAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFSForHA.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java


> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Fix For: 2.4.0
>
> Attachments: HDFS-6100.000.patch, HDFS-6100.001.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. This implementation has two problems:
> # The {{DFSClient}} only knows about the current active NN, thus it does not 
> support failover.
> # The delegation token is based on the active NN, therefore the {{DFSClient}} 
> will fail to authenticate of the standby NN in secure HA setup.
> Currently the parameter {{namenoderpcaddress}} in the URL stores the host-ip 
> pair that corresponds to the active NN. To fix this bug, this jira proposes 
> to store the name service id in the parameter in HA setup (yet the parameter 
> stays the same in non-HA setup).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-19 Thread Jing Zhao (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940716#comment-13940716
 ] 

Jing Zhao commented on HDFS-6100:
-

+1 for the latest patch.

> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Attachments: HDFS-6100.000.patch, HDFS-6100.001.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. This implementation has two problems:
> # The {{DFSClient}} only knows about the current active NN, thus it does not 
> support failover.
> # The delegation token is based on the active NN, therefore the {{DFSClient}} 
> will fail to authenticate of the standby NN in secure HA setup.
> Currently the parameter {{namenoderpcaddress}} in the URL stores the host-ip 
> pair that corresponds to the active NN. To fix this bug, this jira proposes 
> to store the name service id in the parameter in HA setup (yet the parameter 
> stays the same in non-HA setup).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-19 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940727#comment-13940727
 ] 

Hudson commented on HDFS-6100:
--

SUCCESS: Integrated in Hadoop-trunk-Commit #5358 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/5358/])
HDFS-6100. DataNodeWebHdfsMethods does not failover in HA mode. Contributed by 
Haohui Mai. (jing9: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579301)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/InetSocketAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/NamenodeAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/NamenodeRpcAddressParam.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFSForHA.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java


> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Fix For: 2.4.0
>
> Attachments: HDFS-6100.000.patch, HDFS-6100.001.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. This implementation has two problems:
> # The {{DFSClient}} only knows about the current active NN, thus it does not 
> support failover.
> # The delegation token is based on the active NN, therefore the {{DFSClient}} 
> will fail to authenticate of the standby NN in secure HA setup.
> Currently the parameter {{namenoderpcaddress}} in the URL stores the host-ip 
> pair that corresponds to the active NN. To fix this bug, this jira proposes 
> to store the name service id in the parameter in HA setup (yet the parameter 
> stays the same in non-HA setup).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-19 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940351#comment-13940351
 ] 

Hadoop QA commented on HDFS-6100:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12635471/HDFS-6100.001.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/6439//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6439//console

This message is automatically generated.

> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Attachments: HDFS-6100.000.patch, HDFS-6100.001.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. This implementation has two problems:
> # The {{DFSClient}} only knows about the current active NN, thus it does not 
> support failover.
> # The delegation token is based on the active NN, therefore the {{DFSClient}} 
> will fail to authenticate of the standby NN in secure HA setup.
> Currently the parameter {{namenoderpcaddress}} in the URL stores the host-ip 
> pair that corresponds to the active NN. To fix this bug, this jira proposes 
> to store the name service id in the parameter in HA setup (yet the parameter 
> stays the same in non-HA setup).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-18 Thread Haohui Mai (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940245#comment-13940245
 ] 

Haohui Mai commented on HDFS-6100:
--

The v1 patch addresses Jing's comments.

I've tested the patch in all four combinations of secure and HA setups. I've 
verified this patch by using WebHDFS to retrieve the content of a file.

> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Attachments: HDFS-6100.000.patch, HDFS-6100.001.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. This implementation has two problems:
> # The {{DFSClient}} only knows about the current active NN, thus it does not 
> support failover.
> # The delegation token is based on the active NN, therefore the {{DFSClient}} 
> will fail to authenticate of the standby NN in secure HA setup.
> Currently the parameter {{namenoderpcaddress}} in the URL stores the host-ip 
> pair that corresponds to the active NN. To fix this bug, this jira proposes 
> to store the name service id in the parameter in HA setup (yet the parameter 
> stays the same in non-HA setup).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-18 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940234#comment-13940234
 ] 

Hadoop QA commented on HDFS-6100:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12635471/HDFS-6100.001.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The following test timeouts occurred in 
hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/6435//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6435//console

This message is automatically generated.

> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Attachments: HDFS-6100.000.patch, HDFS-6100.001.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. Currently the parameter is set by the NN and it is a host-ip pair, 
> which does not support HA.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-14 Thread Jing Zhao (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935411#comment-13935411
 ] 

Jing Zhao commented on HDFS-6100:
-

The patch looks pretty good to me. Some minor comments:
# In DatanodeWebHdfsMethods, the current patch has some inconsistent field name 
for the NamenodeAddressParam parameter (nnId, namenodeId, and 
namenodeRpcAddress). How about just calling them "namenode" since it can be 
either NameService ID or NameNode RPC address?
# Nit: the following code needs some reformat:
{code}
tokenServiceName = HAUtil.isHAEnabled(conf,
nsId) ? nsId : NetUtils.getHostPortString
(rpcServer.getRpcAddress());
{code}
# In the new unit test, we can add some extra check about the content of the 
new created file. Also, maybe we can try to transition the second NN to active 
first so that the first create call can also hit a failover.
# Looks like the patch also fixes the token service name in HA setup for 
webhdfs. Please update the description of the jira.
# Could you also post your system test results (HA, non-HA, secured, insecure 
setup etc.)?

> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Attachments: HDFS-6100.000.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. Currently the parameter is set by the NN and it is a host-ip pair, 
> which does not support HA.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934541#comment-13934541
 ] 

Hadoop QA commented on HDFS-6100:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12634593/HDFS-6100.000.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/6402//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6402//console

This message is automatically generated.

> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Attachments: HDFS-6100.000.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. Currently the parameter is set by the NN and it is a host-ip pair, 
> which does not support HA.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6100) DataNodeWebHdfsMethods does not failover in HA mode

2014-03-13 Thread Haohui Mai (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934360#comment-13934360
 ] 

Haohui Mai commented on HDFS-6100:
--

The v0 patch overloads the meaning of the URL parameter {{namenoderpcaddress}}. 
It is the host-port pair of the NN in non-HA mode, but it becomes the 
nameservice id in HA mode.

> DataNodeWebHdfsMethods does not failover in HA mode
> ---
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Haohui Mai
> Attachments: HDFS-6100.000.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to 
> the NN, so that it can access the files in the cluster. 
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate 
> the NN. Currently the parameter is set by the NN and it is a host-ip pair, 
> which does not support HA.



--
This message was sent by Atlassian JIRA
(v6.2#6252)