[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182703#comment-14182703
 ] 

Hudson commented on HDFS-7243:
--

SUCCESS: Integrated in Hadoop-Yarn-trunk #722 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/722/])
HDFS-7243. HDFS concat operation should not be allowed in Encryption Zone. 
(clamb via yliu) (yliu: rev 57dec288070f903931771485d6424317b20551aa)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java


 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Fix For: 2.6.0

 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch, HDFS-7243.004.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-24 Thread Charles Lamb (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182768#comment-14182768
 ] 

Charles Lamb commented on HDFS-7243:


Thanks [~hitliuyi] for the review and commit.


 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Fix For: 2.6.0

 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch, HDFS-7243.004.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182817#comment-14182817
 ] 

Hudson commented on HDFS-7243:
--

SUCCESS: Integrated in Hadoop-Hdfs-trunk #1911 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1911/])
HDFS-7243. HDFS concat operation should not be allowed in Encryption Zone. 
(clamb via yliu) (yliu: rev 57dec288070f903931771485d6424317b20551aa)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Fix For: 2.6.0

 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch, HDFS-7243.004.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182905#comment-14182905
 ] 

Hudson commented on HDFS-7243:
--

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1936 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1936/])
HDFS-7243. HDFS concat operation should not be allowed in Encryption Zone. 
(clamb via yliu) (yliu: rev 57dec288070f903931771485d6424317b20551aa)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java


 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Fix For: 2.6.0

 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch, HDFS-7243.004.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-23 Thread Charles Lamb (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14181632#comment-14181632
 ] 

Charles Lamb commented on HDFS-7243:


bq. Will commit later today.

Hi [~hitliuyi],

If you get a minute and can commit this, then we can close it out.

Thanks.
Charles


 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch, HDFS-7243.004.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-23 Thread Yi Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182265#comment-14182265
 ] 

Yi Liu commented on HDFS-7243:
--

Yes, there is some issue for git commit in my local env, I'm fixing that :)

 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch, HDFS-7243.004.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182380#comment-14182380
 ] 

Hudson commented on HDFS-7243:
--

FAILURE: Integrated in Hadoop-trunk-Commit #6329 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/6329/])
HDFS-7243. HDFS concat operation should not be allowed in Encryption Zone. 
(clamb via yliu) (yliu: rev 57dec288070f903931771485d6424317b20551aa)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java


 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch, HDFS-7243.004.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-21 Thread Yi Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178342#comment-14178342
 ] 

Yi Liu commented on HDFS-7243:
--

Thanks Charles for updating.  
+1,  pending jenkins. 

 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch, HDFS-7243.004.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178526#comment-14178526
 ] 

Hadoop QA commented on HDFS-7243:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12676081/HDFS-7243.004.patch
  against trunk revision 171f237.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

  
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
  org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/8468//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8468//console

This message is automatically generated.

 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch, HDFS-7243.004.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-21 Thread Yi Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179434#comment-14179434
 ] 

Yi Liu commented on HDFS-7243:
--

Will commit later today.

 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch, HDFS-7243.004.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-20 Thread Yi Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177941#comment-14177941
 ] 

Yi Liu commented on HDFS-7243:
--

Hi Charles, I was going to commit this patch just now, but found another issue, 
sorry for missing that in previous comments.
{code}
dir.getINodesInPath4Write(target, true);
{code}
we should call
{code}
dir.getINodesInPath4Write(target);
{code}
Since the later will hold the FsDir read lock.

Besides, another small nits in the test, 
{code}
fs.concat(new Path(ez, target), new Path[] { src1, src2 });
{code}
We could use {{target}} instead of {{new Path(ez, target)}} 

 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-16 Thread Yi Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173690#comment-14173690
 ] 

Yi Liu commented on HDFS-7243:
--

Thanks Charles for updating the patch, it looks good to me.

 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-16 Thread Charles Lamb (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173695#comment-14173695
 ] 

Charles Lamb commented on HDFS-7243:


Thanks for reviewing Yi.



 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-16 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173862#comment-14173862
 ] 

Hadoop QA commented on HDFS-7243:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12675272/HDFS-7243.003.patch
  against trunk revision 2894433.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

  
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
  org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/8440//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8440//console

This message is automatically generated.

 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
 HDFS-7243.003.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172506#comment-14172506
 ] 

Hadoop QA commented on HDFS-7243:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12674986/HDFS-7243.002.patch
  against trunk revision 128ace1.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

  
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
  org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/8430//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8430//console

This message is automatically generated.

 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-15 Thread Yi Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173405#comment-14173405
 ] 

Yi Liu commented on HDFS-7243:
--

Charles, the latest patch looks good and only one comment:
{code}
final INodesInPath trgIip = dir.getINodesInPath(target, true);
{code}
here, we should use {{getINodesInPath4Write}} instead of {{getINodesInPath}}.

 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-14 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171858#comment-14171858
 ] 

Hadoop QA commented on HDFS-7243:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12674865/HDFS-7243.001.patch
  against trunk revision cdce883.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

  org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
  org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat
  
org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
  
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
  org.apache.hadoop.hdfs.TestDFSInotifyEventInputStream
  org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache
  org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/8425//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8425//console

This message is automatically generated.

 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-7243) HDFS concat operation should not be allowed in Encryption Zone

2014-10-14 Thread Yi Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171934#comment-14171934
 ] 

Yi Liu commented on HDFS-7243:
--

Thanks Clarles for post the patch.
*1.*
{quote}
target.substring(0, target.lastIndexOf(Path.SEPARATOR_CHAR))
{quote}
could be empty string (if the parent if root), then will cause {{getEZForPath}} 
failed.
*2.*
Don't invoke FSN#getEZForPath directly, it's a bit heavy, more importantly it 
has own permission check which will cause some issues: For example, concat just 
needs write permission for target, and read, parent write permission for 
srcs.  If we invoke {{getEZForPath}} on target or parent directly, it requires 
read permission of the path. 
Why not do a lite check of whether target is in an encryption zone in 
{{concatInternal}}.


 HDFS concat operation should not be allowed in Encryption Zone
 --

 Key: HDFS-7243
 URL: https://issues.apache.org/jira/browse/HDFS-7243
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: encryption, namenode
Affects Versions: 2.6.0
Reporter: Yi Liu
Assignee: Charles Lamb
 Attachments: HDFS-7243.001.patch


 For HDFS encryption at rest, files in an encryption zone are using different 
 data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)