[jira] [Commented] (HDFS-7340) make rollingUpgrade start/finalize idempotent
[
https://issues.apache.org/jira/browse/HDFS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195828#comment-14195828
]
Hadoop QA commented on HDFS-7340:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12679139/HDFS-7340.000.patch
against trunk revision c5a46d4.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.util.TestByteArrayManager
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8636//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8636//console
This message is automatically generated.
> make rollingUpgrade start/finalize idempotent
> -
>
> Key: HDFS-7340
> URL: https://issues.apache.org/jira/browse/HDFS-7340
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Jing Zhao
> Attachments: HDFS-7340.000.patch
>
>
> I was running this on a HA cluster with
> dfs.client.test.drop.namenode.response.number set to 1. So the first request
> goes through but the response is dropped. Which then causes another request
> which fails and says a request is already in progress. We should add retry
> cache support for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7340) make rollingUpgrade start/finalize idempotent
[ https://issues.apache.org/jira/browse/HDFS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196334#comment-14196334 ] Suresh Srinivas commented on HDFS-7340: --- +1 for the patch. Couple of comments: bq. upgrade has been finalized Can you please change this to "upgrade already has been finalized"? Also please add Idempotent annotation to the method. > make rollingUpgrade start/finalize idempotent > - > > Key: HDFS-7340 > URL: https://issues.apache.org/jira/browse/HDFS-7340 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha >Affects Versions: 2.4.0 >Reporter: Arpit Gupta >Assignee: Jing Zhao > Attachments: HDFS-7340.000.patch > > > I was running this on a HA cluster with > dfs.client.test.drop.namenode.response.number set to 1. So the first request > goes through but the response is dropped. Which then causes another request > which fails and says a request is already in progress. We should add retry > cache support for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7340) make rollingUpgrade start/finalize idempotent
[ https://issues.apache.org/jira/browse/HDFS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196355#comment-14196355 ] Tsz Wo Nicholas Sze commented on HDFS-7340: --- +1 patch looks good. No additional comments. > make rollingUpgrade start/finalize idempotent > - > > Key: HDFS-7340 > URL: https://issues.apache.org/jira/browse/HDFS-7340 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha >Affects Versions: 2.4.0 >Reporter: Arpit Gupta >Assignee: Jing Zhao > Attachments: HDFS-7340.000.patch > > > I was running this on a HA cluster with > dfs.client.test.drop.namenode.response.number set to 1. So the first request > goes through but the response is dropped. Which then causes another request > which fails and says a request is already in progress. We should add retry > cache support for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7340) make rollingUpgrade start/finalize idempotent
[
https://issues.apache.org/jira/browse/HDFS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196511#comment-14196511
]
Hadoop QA commented on HDFS-7340:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12679263/HDFS-7340.001.patch
against trunk revision 3dfd6e6.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8639//console
This message is automatically generated.
> make rollingUpgrade start/finalize idempotent
> -
>
> Key: HDFS-7340
> URL: https://issues.apache.org/jira/browse/HDFS-7340
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
>Affects Versions: 2.4.0
>Reporter: Arpit Gupta
>Assignee: Jing Zhao
> Attachments: HDFS-7340.000.patch, HDFS-7340.001.patch
>
>
> I was running this on a HA cluster with
> dfs.client.test.drop.namenode.response.number set to 1. So the first request
> goes through but the response is dropped. Which then causes another request
> which fails and says a request is already in progress. We should add retry
> cache support for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7340) make rollingUpgrade start/finalize idempotent
[ https://issues.apache.org/jira/browse/HDFS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196514#comment-14196514 ] Hudson commented on HDFS-7340: -- FAILURE: Integrated in Hadoop-trunk-Commit #6434 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6434/]) HDFS-7340. Make rollingUpgrade start/finalize idempotent. Contributed by Jing Zhao. (jing9: rev 3dfd6e68fe5028fe3766ae5056dc175c38cc97e1) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > make rollingUpgrade start/finalize idempotent > - > > Key: HDFS-7340 > URL: https://issues.apache.org/jira/browse/HDFS-7340 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha >Affects Versions: 2.4.0 >Reporter: Arpit Gupta >Assignee: Jing Zhao > Attachments: HDFS-7340.000.patch, HDFS-7340.001.patch > > > I was running this on a HA cluster with > dfs.client.test.drop.namenode.response.number set to 1. So the first request > goes through but the response is dropped. Which then causes another request > which fails and says a request is already in progress. We should add retry > cache support for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7340) make rollingUpgrade start/finalize idempotent
[ https://issues.apache.org/jira/browse/HDFS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198308#comment-14198308 ] Hudson commented on HDFS-7340: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #734 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/734/]) HDFS-7340. Make rollingUpgrade start/finalize idempotent. Contributed by Jing Zhao. (jing9: rev 3dfd6e68fe5028fe3766ae5056dc175c38cc97e1) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java > make rollingUpgrade start/finalize idempotent > - > > Key: HDFS-7340 > URL: https://issues.apache.org/jira/browse/HDFS-7340 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha >Affects Versions: 2.4.0 >Reporter: Arpit Gupta >Assignee: Jing Zhao > Fix For: 2.6.0 > > Attachments: HDFS-7340.000.patch, HDFS-7340.001.patch > > > I was running this on a HA cluster with > dfs.client.test.drop.namenode.response.number set to 1. So the first request > goes through but the response is dropped. Which then causes another request > which fails and says a request is already in progress. We should add retry > cache support for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7340) make rollingUpgrade start/finalize idempotent
[ https://issues.apache.org/jira/browse/HDFS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198406#comment-14198406 ] Hudson commented on HDFS-7340: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1923 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1923/]) HDFS-7340. Make rollingUpgrade start/finalize idempotent. Contributed by Jing Zhao. (jing9: rev 3dfd6e68fe5028fe3766ae5056dc175c38cc97e1) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > make rollingUpgrade start/finalize idempotent > - > > Key: HDFS-7340 > URL: https://issues.apache.org/jira/browse/HDFS-7340 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha >Affects Versions: 2.4.0 >Reporter: Arpit Gupta >Assignee: Jing Zhao > Fix For: 2.6.0 > > Attachments: HDFS-7340.000.patch, HDFS-7340.001.patch > > > I was running this on a HA cluster with > dfs.client.test.drop.namenode.response.number set to 1. So the first request > goes through but the response is dropped. Which then causes another request > which fails and says a request is already in progress. We should add retry > cache support for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7340) make rollingUpgrade start/finalize idempotent
[ https://issues.apache.org/jira/browse/HDFS-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198497#comment-14198497 ] Hudson commented on HDFS-7340: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1948 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1948/]) HDFS-7340. Make rollingUpgrade start/finalize idempotent. Contributed by Jing Zhao. (jing9: rev 3dfd6e68fe5028fe3766ae5056dc175c38cc97e1) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java > make rollingUpgrade start/finalize idempotent > - > > Key: HDFS-7340 > URL: https://issues.apache.org/jira/browse/HDFS-7340 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha >Affects Versions: 2.4.0 >Reporter: Arpit Gupta >Assignee: Jing Zhao > Fix For: 2.6.0 > > Attachments: HDFS-7340.000.patch, HDFS-7340.001.patch > > > I was running this on a HA cluster with > dfs.client.test.drop.namenode.response.number set to 1. So the first request > goes through but the response is dropped. Which then causes another request > which fails and says a request is already in progress. We should add retry > cache support for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
