[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226069#comment-14226069
]
Hudson commented on HDFS-7440:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #17 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/17/])
HDFS-7440. Consolidate snapshot related operations in a single class.
Contributed by Haohui Mai. (wheat9: rev
4a3161182905afaf450a60d02528161ed1f97471)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Fix For: 2.7.0
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch,
HDFS-7440.002.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226089#comment-14226089
]
Hudson commented on HDFS-7440:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #755 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/755/])
HDFS-7440. Consolidate snapshot related operations in a single class.
Contributed by Haohui Mai. (wheat9: rev
4a3161182905afaf450a60d02528161ed1f97471)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Fix For: 2.7.0
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch,
HDFS-7440.002.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226240#comment-14226240
]
Hudson commented on HDFS-7440:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1945 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1945/])
HDFS-7440. Consolidate snapshot related operations in a single class.
Contributed by Haohui Mai. (wheat9: rev
4a3161182905afaf450a60d02528161ed1f97471)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Fix For: 2.7.0
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch,
HDFS-7440.002.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226250#comment-14226250
]
Hudson commented on HDFS-7440:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #17 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/17/])
HDFS-7440. Consolidate snapshot related operations in a single class.
Contributed by Haohui Mai. (wheat9: rev
4a3161182905afaf450a60d02528161ed1f97471)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Fix For: 2.7.0
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch,
HDFS-7440.002.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226304#comment-14226304
]
Hudson commented on HDFS-7440:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1969 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1969/])
HDFS-7440. Consolidate snapshot related operations in a single class.
Contributed by Haohui Mai. (wheat9: rev
4a3161182905afaf450a60d02528161ed1f97471)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Fix For: 2.7.0
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch,
HDFS-7440.002.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226321#comment-14226321
]
Hudson commented on HDFS-7440:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #17 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/17/])
HDFS-7440. Consolidate snapshot related operations in a single class.
Contributed by Haohui Mai. (wheat9: rev
4a3161182905afaf450a60d02528161ed1f97471)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Fix For: 2.7.0
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch,
HDFS-7440.002.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225094#comment-14225094
]
Jing Zhao commented on HDFS-7440:
-
The patch looks good to me. One small suggestion is that I think the changes
related to audit log can be separated into another jira since it changes the
current auditlog semantic. +1 after addressing the comments.
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7440.000.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225346#comment-14225346
]
Hadoop QA commented on HDFS-7440:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683635/HDFS-7440.001.patch
against trunk revision 61a2510.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8833//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8833//console
This message is automatically generated.
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225363#comment-14225363
]
Jing Zhao commented on HDFS-7440:
-
With the change now FSNamesystem#removeBlocks is moved into the fsn write lock
(in {{deleteSnapshot}}). I think we'd better still keep it out of the write
lock.
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225608#comment-14225608
]
Jing Zhao commented on HDFS-7440:
-
The latest patch looks good to me. +1 pending Jenkins.
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch,
HDFS-7440.002.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225620#comment-14225620
]
Hadoop QA commented on HDFS-7440:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683691/HDFS-7440.002.patch
against trunk revision 56f3eec.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8837//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8837//console
This message is automatically generated.
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch,
HDFS-7440.002.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225757#comment-14225757
]
Hudson commented on HDFS-7440:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6608 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6608/])
HDFS-7440. Consolidate snapshot related operations in a single class.
Contributed by Haohui Mai. (wheat9: rev
4a3161182905afaf450a60d02528161ed1f97471)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Fix For: 2.7.0
Attachments: HDFS-7440.000.patch, HDFS-7440.001.patch,
HDFS-7440.002.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7440) Consolidate snapshot related operations in a single class
[
https://issues.apache.org/jira/browse/HDFS-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224054#comment-14224054
]
Hadoop QA commented on HDFS-7440:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683456/HDFS-7440.000.patch
against trunk revision 45fa7f0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestLeaseRecovery2
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8829//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8829//console
This message is automatically generated.
Consolidate snapshot related operations in a single class
-
Key: HDFS-7440
URL: https://issues.apache.org/jira/browse/HDFS-7440
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7440.000.patch
Currently the snapshot-related code scatters across both {{FSNameSystem}} and
{{FSDirectory}}. This jira proposes to consolidate the logic in a single
class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
