[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-09-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937975#comment-14937975
 ] 

Hudson commented on HDFS-8466:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #439 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/439/])
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
62c5a879ef2129b6d11752ccea099d461d29b4b7)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
05c696882ee0844052247cab5451e4bf7bb12a0f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt


> Refactor BlockInfoContiguous and fix NPE in 
> TestBlockInfo#testCopyConstructor()
> ---
>
> Key: HDFS-8466
> URL: https://issues.apache.org/jira/browse/HDFS-8466
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Affects Versions: HDFS-7285
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Fix For: HDFS-7285
>
> Attachments: HDFS-8466-HDFS-7285-01.patch
>
>
> HDFS-7716 refactored BlockInfoContiguous.java
> Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
> Along with fixing test failure, some of the code can be refactored to re-use 
> code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-09-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937755#comment-14937755
 ] 

Hudson commented on HDFS-8466:
--

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #473 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/473/])
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
62c5a879ef2129b6d11752ccea099d461d29b4b7)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
05c696882ee0844052247cab5451e4bf7bb12a0f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt


> Refactor BlockInfoContiguous and fix NPE in 
> TestBlockInfo#testCopyConstructor()
> ---
>
> Key: HDFS-8466
> URL: https://issues.apache.org/jira/browse/HDFS-8466
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Affects Versions: HDFS-7285
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Fix For: HDFS-7285
>
> Attachments: HDFS-8466-HDFS-7285-01.patch
>
>
> HDFS-7716 refactored BlockInfoContiguous.java
> Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
> Along with fixing test failure, some of the code can be refactored to re-use 
> code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-09-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938350#comment-14938350
 ] 

Hudson commented on HDFS-8466:
--

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2408 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2408/])
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
62c5a879ef2129b6d11752ccea099d461d29b4b7)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
05c696882ee0844052247cab5451e4bf7bb12a0f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt


> Refactor BlockInfoContiguous and fix NPE in 
> TestBlockInfo#testCopyConstructor()
> ---
>
> Key: HDFS-8466
> URL: https://issues.apache.org/jira/browse/HDFS-8466
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Affects Versions: HDFS-7285
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Fix For: HDFS-7285
>
> Attachments: HDFS-8466-HDFS-7285-01.patch
>
>
> HDFS-7716 refactored BlockInfoContiguous.java
> Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
> Along with fixing test failure, some of the code can be refactored to re-use 
> code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-09-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938545#comment-14938545
 ] 

Hudson commented on HDFS-8466:
--

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #465 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/465/])
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
62c5a879ef2129b6d11752ccea099d461d29b4b7)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
05c696882ee0844052247cab5451e4bf7bb12a0f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt


> Refactor BlockInfoContiguous and fix NPE in 
> TestBlockInfo#testCopyConstructor()
> ---
>
> Key: HDFS-8466
> URL: https://issues.apache.org/jira/browse/HDFS-8466
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Affects Versions: HDFS-7285
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Fix For: HDFS-7285
>
> Attachments: HDFS-8466-HDFS-7285-01.patch
>
>
> HDFS-7716 refactored BlockInfoContiguous.java
> Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
> Along with fixing test failure, some of the code can be refactored to re-use 
> code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-09-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937499#comment-14937499
 ] 

Hudson commented on HDFS-8466:
--

FAILURE: Integrated in Hadoop-Yarn-trunk #1203 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/1203/])
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
62c5a879ef2129b6d11752ccea099d461d29b4b7)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
05c696882ee0844052247cab5451e4bf7bb12a0f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt


> Refactor BlockInfoContiguous and fix NPE in 
> TestBlockInfo#testCopyConstructor()
> ---
>
> Key: HDFS-8466
> URL: https://issues.apache.org/jira/browse/HDFS-8466
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Affects Versions: HDFS-7285
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Fix For: HDFS-7285
>
> Attachments: HDFS-8466-HDFS-7285-01.patch
>
>
> HDFS-7716 refactored BlockInfoContiguous.java
> Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
> Along with fixing test failure, some of the code can be refactored to re-use 
> code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-09-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937249#comment-14937249
 ] 

Hudson commented on HDFS-8466:
--

FAILURE: Integrated in Hadoop-trunk-Commit #8548 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/8548/])
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
62c5a879ef2129b6d11752ccea099d461d29b4b7)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
05c696882ee0844052247cab5451e4bf7bb12a0f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt


> Refactor BlockInfoContiguous and fix NPE in 
> TestBlockInfo#testCopyConstructor()
> ---
>
> Key: HDFS-8466
> URL: https://issues.apache.org/jira/browse/HDFS-8466
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Affects Versions: HDFS-7285
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Fix For: HDFS-7285
>
> Attachments: HDFS-8466-HDFS-7285-01.patch
>
>
> HDFS-7716 refactored BlockInfoContiguous.java
> Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
> Along with fixing test failure, some of the code can be refactored to re-use 
> code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-09-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937053#comment-14937053
 ] 

Hudson commented on HDFS-8466:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk #2379 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2379/])
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
62c5a879ef2129b6d11752ccea099d461d29b4b7)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java
HDFS-8466. Refactor BlockInfoContiguous and fix NPE in (vinayakumarb: rev 
05c696882ee0844052247cab5451e4bf7bb12a0f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt


> Refactor BlockInfoContiguous and fix NPE in 
> TestBlockInfo#testCopyConstructor()
> ---
>
> Key: HDFS-8466
> URL: https://issues.apache.org/jira/browse/HDFS-8466
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>Affects Versions: HDFS-7285
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Fix For: HDFS-7285
>
> Attachments: HDFS-8466-HDFS-7285-01.patch
>
>
> HDFS-7716 refactored BlockInfoContiguous.java
> Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
> Along with fixing test failure, some of the code can be refactored to re-use 
> code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-07-01 Thread Zhe Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611151#comment-14611151
 ] 

Zhe Zhang commented on HDFS-8466:
-

Thanks Vinay for the fix. With the HDFS-8499 refactor, does {{BlockInfo}} in 
trunk need this change?

 Refactor BlockInfoContiguous and fix NPE in 
 TestBlockInfo#testCopyConstructor()
 ---

 Key: HDFS-8466
 URL: https://issues.apache.org/jira/browse/HDFS-8466
 Project: Hadoop HDFS
  Issue Type: Sub-task
Affects Versions: HDFS-7285
Reporter: Vinayakumar B
Assignee: Vinayakumar B
 Fix For: HDFS-7285

 Attachments: HDFS-8466-HDFS-7285-01.patch


 HDFS-7716 refactored BlockInfoContiguous.java
 Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
 Along with fixing test failure, some of the code can be refactored to re-use 
 code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Auto-Re: [jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-07-01 Thread wsb
您的邮件已收到!谢谢!

[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-06-16 Thread Uma Maheswara Rao G (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588389#comment-14588389
 ] 

Uma Maheswara Rao G commented on HDFS-8466:
---

+1

 Refactor BlockInfoContiguous and fix NPE in 
 TestBlockInfo#testCopyConstructor()
 ---

 Key: HDFS-8466
 URL: https://issues.apache.org/jira/browse/HDFS-8466
 Project: Hadoop HDFS
  Issue Type: Sub-task
Affects Versions: HDFS-7285
Reporter: Vinayakumar B
Assignee: Vinayakumar B
 Attachments: HDFS-8466-HDFS-7285-01.patch


 HDFS-7716 refactored BlockInfoContiguous.java
 Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
 Along with fixing test failure, some of the code can be refactored to re-use 
 code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-06-09 Thread Vinayakumar B (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14578607#comment-14578607
 ] 

Vinayakumar B commented on HDFS-8466:
-

As mentioned in description, {{TestBlockInfo}} is not failing now with Patch.
Other failures are unrelated

 Refactor BlockInfoContiguous and fix NPE in 
 TestBlockInfo#testCopyConstructor()
 ---

 Key: HDFS-8466
 URL: https://issues.apache.org/jira/browse/HDFS-8466
 Project: Hadoop HDFS
  Issue Type: Sub-task
Affects Versions: HDFS-7285
Reporter: Vinayakumar B
Assignee: Vinayakumar B
 Attachments: HDFS-8466-HDFS-7285-01.patch


 HDFS-7716 refactored BlockInfoContiguous.java
 Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
 Along with fixing test failure, some of the code can be refactored to re-use 
 code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-06-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572307#comment-14572307
 ] 

Hadoop QA commented on HDFS-8466:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  15m  9s | Findbugs (version ) appears to 
be broken on HDFS-7285. |
| {color:green}+1{color} | @author |   0m  1s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   7m 35s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 46s | There were no new javadoc 
warning messages. |
| {color:red}-1{color} | release audit |   0m 15s | The applied patch generated 
1 release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 37s | There were no new checkstyle 
issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 1  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:red}-1{color} | findbugs |   3m 28s | The patch appears to introduce 1 
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 16s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 176m 57s | Tests failed in hadoop-hdfs. |
| | | 219m 18s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| Failed unit tests | hadoop.hdfs.TestEncryptedTransfer |
|   | hadoop.hdfs.server.mover.TestMover |
|   | hadoop.hdfs.TestRecoverStripedFile |
|   | hadoop.hdfs.server.namenode.TestAuditLogs |
|   | hadoop.hdfs.server.namenode.TestFileTruncate |
|   | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS |
|   | hadoop.hdfs.util.TestStripedBlockUtil |
| Timed out tests | org.apache.hadoop.hdfs.TestBlockStoragePolicy |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12734779/HDFS-8466-HDFS-7285-01.patch
 |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HDFS-7285 / 673280d |
| Release Audit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11225/artifact/patchprocess/patchReleaseAuditProblems.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11225/artifact/patchprocess/whitespace.txt
 |
| Findbugs warnings | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11225/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
 |
| hadoop-hdfs test log | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11225/artifact/patchprocess/testrun_hadoop-hdfs.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11225/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/11225/console |


This message was automatically generated.

 Refactor BlockInfoContiguous and fix NPE in 
 TestBlockInfo#testCopyConstructor()
 ---

 Key: HDFS-8466
 URL: https://issues.apache.org/jira/browse/HDFS-8466
 Project: Hadoop HDFS
  Issue Type: Sub-task
Affects Versions: HDFS-7285
Reporter: Vinayakumar B
Assignee: Vinayakumar B
 Attachments: HDFS-8466-HDFS-7285-01.patch


 HDFS-7716 refactored BlockInfoContiguous.java
 Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
 Along with fixing test failure, some of the code can be refactored to re-use 
 code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-05-24 Thread Vinayakumar B (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557992#comment-14557992
 ] 

Vinayakumar B commented on HDFS-8466:
-

bq. why we still have this in branch
As mentioned in description, HDFS-7716 again added it.

 Refactor BlockInfoContiguous and fix NPE in 
 TestBlockInfo#testCopyConstructor()
 ---

 Key: HDFS-8466
 URL: https://issues.apache.org/jira/browse/HDFS-8466
 Project: Hadoop HDFS
  Issue Type: Sub-task
Affects Versions: HDFS-7285
Reporter: Vinayakumar B
Assignee: Vinayakumar B
 Attachments: HDFS-8466-HDFS-7285-01.patch


 HDFS-7716 refactored BlockInfoContiguous.java
 Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
 Along with fixing test failure, some of the code can be refactored to re-use 
 code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-05-23 Thread Walter Su (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557198#comment-14557198
 ] 

Walter Su commented on HDFS-8466:
-

HDFS-8113 removed 
{code}
-this(from, from.bc.getBlockReplication());
{code}
why we still have this in branch
{code}
this(from, from.getBlockCollection().getPreferredBlockReplication());
{code}
Can we just merged HDFS-8113 into branch to remove this line as well? I don't 
know well about rebase, just asking.

 Refactor BlockInfoContiguous and fix NPE in 
 TestBlockInfo#testCopyConstructor()
 ---

 Key: HDFS-8466
 URL: https://issues.apache.org/jira/browse/HDFS-8466
 Project: Hadoop HDFS
  Issue Type: Sub-task
Affects Versions: HDFS-7285
Reporter: Vinayakumar B
Assignee: Vinayakumar B
 Attachments: HDFS-8466-HDFS-7285-01.patch


 HDFS-7716 refactored BlockInfoContiguous.java
 Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
 Along with fixing test failure, some of the code can be refactored to re-use 
 code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HDFS-8466) Refactor BlockInfoContiguous and fix NPE in TestBlockInfo#testCopyConstructor()

2015-05-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556016#comment-14556016
 ] 

Hadoop QA commented on HDFS-8466:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 55s | Pre-patch HDFS-7285 compilation 
is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |   7m 38s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 46s | There were no new javadoc 
warning messages. |
| {color:red}-1{color} | release audit |   0m 15s | The applied patch generated 
1 release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 38s | There were no new checkstyle 
issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 1  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 35s | The patch built with 
eclipse:eclipse. |
| {color:red}-1{color} | findbugs |   3m 25s | The patch appears to introduce 1 
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 21s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests |  60m 50s | Tests failed in hadoop-hdfs. |
| | | 103m  5s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
|  |  Inconsistent synchronization of 
org.apache.hadoop.hdfs.DFSOutputStream.streamer; locked 88% of time  
Unsynchronized access at DFSOutputStream.java:88% of time  Unsynchronized 
access at DFSOutputStream.java:[line 146] |
| Failed unit tests | hadoop.hdfs.server.namenode.snapshot.TestSnapshotManager |
|   | hadoop.hdfs.TestFileAppend4 |
|   | hadoop.hdfs.TestRead |
|   | hadoop.hdfs.server.namenode.TestFSPermissionChecker |
|   | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
|   | hadoop.hdfs.server.namenode.snapshot.TestSnapshot |
|   | hadoop.hdfs.server.namenode.TestSecondaryWebUi |
|   | hadoop.hdfs.server.namenode.TestSaveNamespace |
|   | hadoop.hdfs.server.namenode.TestNNStorageRetentionFunctional |
|   | hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd |
|   | hadoop.hdfs.server.namenode.ha.TestHAStateTransitions |
|   | hadoop.hdfs.server.datanode.TestRefreshNamenodes |
|   | hadoop.hdfs.TestHdfsAdmin |
|   | hadoop.hdfs.server.datanode.TestDataNodeUUID |
|   | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
|   | hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN |
|   | hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength |
|   | hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler |
|   | hadoop.hdfs.TestClientReportBadBlock |
|   | hadoop.hdfs.server.namenode.TestNamenodeCapacityReport |
|   | hadoop.hdfs.server.namenode.TestNamenodeRetryCache |
|   | hadoop.hdfs.server.namenode.TestFSEditLogLoader |
|   | hadoop.hdfs.server.namenode.TestAuditLogger |
|   | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
|   | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy |
|   | hadoop.hdfs.server.blockmanagement.TestDatanodeManager |
|   | hadoop.hdfs.server.datanode.TestDataNodeMetrics |
|   | hadoop.hdfs.TestAppendSnapshotTruncate |
|   | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles |
|   | hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup |
|   | 
hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement |
|   | hadoop.hdfs.server.namenode.TestNameNodeRpcServer |
|   | hadoop.hdfs.TestFileAppendRestart |
|   | hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade |
|   | hadoop.cli.TestErasureCodingCLI |
|   | hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot |
|   | hadoop.hdfs.server.namenode.ha.TestHAFsck |
|   | hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots |
|   | hadoop.hdfs.protocol.TestBlockListAsLongs |
|   | hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot |
|   | hadoop.hdfs.server.namenode.TestHDFSConcat |
|   | hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics |
|   | hadoop.TestRefreshCallQueue |
|   | hadoop.hdfs.TestListFilesInDFS |
|   | hadoop.hdfs.server.namenode.TestAddBlock |
|   | hadoop.hdfs.server.namenode.TestMalformedURLs |
|   | hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold |
|   | hadoop.hdfs.TestEncryptedTransfer |
|   | hadoop.hdfs.server.namenode.TestNameEditsConfigs |
|   | hadoop.hdfs.TestMiniDFSCluster |
|   | hadoop.hdfs.server.mover.TestMover |
|   |