[jira] [Commented] (HDFS-9141) Thread leak in Datanode#refreshVolumes
[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934783#comment-14934783
]
Yi Liu commented on HDFS-9141:
--
+1 pending Jenkins, Thanks Uma.
> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9141) Thread leak in Datanode#refreshVolumes
[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934922#comment-14934922
]
Hadoop QA commented on HDFS-9141:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 20m 30s | Pre-patch trunk has 1 extant
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 8m 48s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 11m 29s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 25s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 33s | The applied patch generated 1
new checkstyle issues (total was 145, now 143). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 37s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 55s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 40s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 127m 41s | Tests failed in hadoop-hdfs. |
| | | 179m 19s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.TestFileTruncate |
| | hadoop.hdfs.server.datanode.TestDirectoryScanner |
| | hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot |
| | hadoop.hdfs.server.namenode.ha.TestEditLogTailer |
| Timed out tests | org.apache.hadoop.hdfs.server.namenode.TestEditLog |
| | org.apache.hadoop.hdfs.security.token.block.TestBlockToken |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12764189/HDFS-9141.00.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 151fca5 |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/12736/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/12736/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/12736/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/12736/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/12736/console |
This message was automatically generated.
> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9141) Thread leak in Datanode#refreshVolumes
[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935327#comment-14935327
]
Hudson commented on HDFS-9141:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #1197 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/1197/])
HDFS-9141. Thread leak in Datanode#refreshVolumes. (Uma Maheswara Rao G via
yliu) (yliu: rev 715dbddf77866bb47a4b95421091f64a3785444f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 2.8.0
>
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9141) Thread leak in Datanode#refreshVolumes
[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935228#comment-14935228
]
Yi Liu commented on HDFS-9141:
--
The test failures are unrelated, and checkstyle is about the file contains too
much lines, and we don't need to fix it.
Will commit the patch shortly.
> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9141) Thread leak in Datanode#refreshVolumes
[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935239#comment-14935239
]
Hudson commented on HDFS-9141:
--
FAILURE: Integrated in Hadoop-trunk-Commit #8539 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/8539/])
HDFS-9141. Thread leak in Datanode#refreshVolumes. (Uma Maheswara Rao G via
yliu) (yliu: rev 715dbddf77866bb47a4b95421091f64a3785444f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 2.8.0
>
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9141) Thread leak in Datanode#refreshVolumes
[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935275#comment-14935275
]
Hudson commented on HDFS-9141:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #466 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/466/])
HDFS-9141. Thread leak in Datanode#refreshVolumes. (Uma Maheswara Rao G via
yliu) (yliu: rev 715dbddf77866bb47a4b95421091f64a3785444f)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 2.8.0
>
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9141) Thread leak in Datanode#refreshVolumes
[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935346#comment-14935346
]
Hudson commented on HDFS-9141:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #459 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/459/])
HDFS-9141. Thread leak in Datanode#refreshVolumes. (Uma Maheswara Rao G via
yliu) (yliu: rev 715dbddf77866bb47a4b95421091f64a3785444f)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 2.8.0
>
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9141) Thread leak in Datanode#refreshVolumes
[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935566#comment-14935566
]
Hudson commented on HDFS-9141:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #434 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/434/])
HDFS-9141. Thread leak in Datanode#refreshVolumes. (Uma Maheswara Rao G via
yliu) (yliu: rev 715dbddf77866bb47a4b95421091f64a3785444f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 2.8.0
>
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9141) Thread leak in Datanode#refreshVolumes
[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935463#comment-14935463
]
Hudson commented on HDFS-9141:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2402 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2402/])
HDFS-9141. Thread leak in Datanode#refreshVolumes. (Uma Maheswara Rao G via
yliu) (yliu: rev 715dbddf77866bb47a4b95421091f64a3785444f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 2.8.0
>
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9141) Thread leak in Datanode#refreshVolumes
[
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935519#comment-14935519
]
Hudson commented on HDFS-9141:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2374 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2374/])
HDFS-9141. Thread leak in Datanode#refreshVolumes. (Uma Maheswara Rao G via
yliu) (yliu: rev 715dbddf77866bb47a4b95421091f64a3785444f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 2.8.0
>
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
