[jira] [Commented] (HDFS-9340) libhdfspp fails to compile after HDFS-9207
[
https://issues.apache.org/jira/browse/HDFS-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980873#comment-14980873
]
Hadoop QA commented on HDFS-9340:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s
{color} | {color:blue} docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 5m 49s
{color} | {color:red} root in HDFS-8707 failed. {color} |
| {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red} 0m 21s
{color} | {color:red} hadoop-hdfs-client in HDFS-8707 failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 6s
{color} | {color:red} hadoop-hdfs-client in HDFS-8707 failed with JDK
v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 8s
{color} | {color:red} hadoop-hdfs-client in HDFS-8707 failed with JDK
v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 7s
{color} | {color:red} hadoop-hdfs-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red} 0m 8s
{color} | {color:red} hadoop-hdfs-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 7s
{color} | {color:red} hadoop-hdfs-client in the patch failed with JDK
v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 7s
{color} | {color:red} hadoop-hdfs-client in the patch failed with JDK
v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s
{color} | {color:green} hadoop-hdfs-client in the patch passed with JDK
v1.8.0_66. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 24s
{color} | {color:green} hadoop-hdfs-client in the patch passed with JDK
v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 19s
{color} | {color:red} Patch generated 425 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 10m 34s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.7.0 Server=1.7.0
Image:test-patch-base-hadoop-date2015-10-29 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12769571/HDFS-9340.HDFS-8707.000.patch
|
| JIRA Issue | HDFS-9340 |
| Optional Tests | asflicense javac javadoc mvninstall unit xml |
| uname | Linux d767612bb0e9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-c3a2069/precommit/personality/hadoop.sh
|
| git revision | HDFS-8707 / 07c904d |
| Default Java | 1.7.0_79 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_66
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HDFS-Build/13279/artifact/patchprocess/branch-mvninstall-root.txt
|
| mvneclipse |
https://builds.apache.org/job/PreCommit-HDFS-Build/13279/artifact/patchprocess/branch-mvneclipse-hadoop-hdfs-project_hadoop-hdfs-client.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDFS-Build/13279/artifact/patchprocess/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDFS-Build/13279/artifact/patchprocess/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.7.0_79.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDFS-Build/13279/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
|
| mvneclipse |
https://builds.apache.org/job/PreCommit-HDFS-Build/13279/artifact/patchprocess/patch-mvneclipse-hadoop-hdfs-project_hadoop-hdfs-client.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HDFS-Build/13279/artifact/patchprocess/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdk1.8.0_66.txt
|
| javadoc |
[jira] [Commented] (HDFS-9340) libhdfspp fails to compile after HDFS-9207
[
https://issues.apache.org/jira/browse/HDFS-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981103#comment-14981103
]
Hadoop QA commented on HDFS-9340:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
38s {color} | {color:green} HDFS-8707 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s {color} | {color:green} HDFS-8707 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} HDFS-8707 passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} HDFS-8707 passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
34s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 57s
{color} | {color:green} hadoop-hdfs-client in the patch passed with JDK
v1.8.0_60. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 57s
{color} | {color:green} hadoop-hdfs-client in the patch passed with JDK
v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 24s
{color} | {color:red} Patch generated 425 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 34s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.7.1 Server=1.7.1
Image:test-patch-base-hadoop-date2015-10-29 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12769571/HDFS-9340.HDFS-8707.000.patch
|
| JIRA Issue | HDFS-9340 |
| Optional Tests | asflicense javac javadoc mvninstall unit xml |
| uname | Linux 54caa9d90fe5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/patchprocess/apache-yetus-c3a2069/precommit/personality/hadoop.sh
|
| git revision | HDFS-8707 / 85232c6 |
| Default Java | 1.7.0_79 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_60
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 |
| JDK v1.7.0_79 Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/13283/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-HDFS-Build/13283/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client U:
hadoop-hdfs-project/hadoop-hdfs-client |
| Max memory used | 230MB |
| Powered by | Apache Yetus http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/13283/console |
This message was automatically generated.
> libhdfspp fails to compile after HDFS-9207
> --
>
> Key: HDFS-9340
> URL: https://issues.apache.org/jira/browse/HDFS-9340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-9340.HDFS-8707.000.patch
>
>
> After the refactor of HDFS-9207 the {{hadoop-hdfs-client}} module fails to
> compile as it invokes {{cmake}} against a directory that does not exist. It
> should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9340) libhdfspp fails to compile after HDFS-9207
[
https://issues.apache.org/jira/browse/HDFS-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981341#comment-14981341
]
Bob Hansen commented on HDFS-9340:
--
[~wheat9]: this removes the old and broken pom file; is there an analog that
_does_ compile and test the libhdfspp project? Should this have been moved
rather than deleted?
> libhdfspp fails to compile after HDFS-9207
> --
>
> Key: HDFS-9340
> URL: https://issues.apache.org/jira/browse/HDFS-9340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-9340.HDFS-8707.000.patch
>
>
> After the refactor of HDFS-9207 the {{hadoop-hdfs-client}} module fails to
> compile as it invokes {{cmake}} against a directory that does not exist. It
> should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9340) libhdfspp fails to compile after HDFS-9207
[
https://issues.apache.org/jira/browse/HDFS-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981295#comment-14981295
]
Haohui Mai commented on HDFS-9340:
--
I propose fixing the issues of ASF licensing header in a separate jira.
[~bobhansen] and [~James Clampffer], can you please review? Thanks.
> libhdfspp fails to compile after HDFS-9207
> --
>
> Key: HDFS-9340
> URL: https://issues.apache.org/jira/browse/HDFS-9340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-9340.HDFS-8707.000.patch
>
>
> After the refactor of HDFS-9207 the {{hadoop-hdfs-client}} module fails to
> compile as it invokes {{cmake}} against a directory that does not exist. It
> should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9340) libhdfspp fails to compile after HDFS-9207
[
https://issues.apache.org/jira/browse/HDFS-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981342#comment-14981342
]
Bob Hansen commented on HDFS-9340:
--
The ASF licensing headers can be taken care of as part of HDFS-9233.
> libhdfspp fails to compile after HDFS-9207
> --
>
> Key: HDFS-9340
> URL: https://issues.apache.org/jira/browse/HDFS-9340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-9340.HDFS-8707.000.patch
>
>
> After the refactor of HDFS-9207 the {{hadoop-hdfs-client}} module fails to
> compile as it invokes {{cmake}} against a directory that does not exist. It
> should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9340) libhdfspp fails to compile after HDFS-9207
[
https://issues.apache.org/jira/browse/HDFS-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981461#comment-14981461
]
James Clampffer commented on HDFS-9340:
---
Fantastic. It looks like it's building all the binaries. What was the old
directory it was trying to compile? libhdfspp/src/main/native in the old
location?
Haohui, is there a flag I can use with maven to run tests on just the native
code? I'd like to verify all our gmock tests are running before I +1 but it's
taking a while because I'm running all tests (in a VM) at the moment.
Also Is there a good reference on the build and test systems, ideally including
the implementation? The set of flags for maven you gave me worked but I
haven't found much documentation other than the very basic stuff in "How To
Contribute" and the pages that links to. If there aren't any docs and I have
to learn from scratch is there anywhere in the tree that you think would be
best to start looking? Thanks
> libhdfspp fails to compile after HDFS-9207
> --
>
> Key: HDFS-9340
> URL: https://issues.apache.org/jira/browse/HDFS-9340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-9340.HDFS-8707.000.patch
>
>
> After the refactor of HDFS-9207 the {{hadoop-hdfs-client}} module fails to
> compile as it invokes {{cmake}} against a directory that does not exist. It
> should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9340) libhdfspp fails to compile after HDFS-9207
[
https://issues.apache.org/jira/browse/HDFS-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981513#comment-14981513
]
Haohui Mai commented on HDFS-9340:
--
bq. Fantastic. It looks like it's building all the binaries. What was the old
directory it was trying to compile? libhdfspp/src/main/native in the old
location?
Yes. Looks like there is a merge error happened during HDFS-9170 / HDFS-9207.
bq. Haohui, is there a flag I can use with maven to run tests on just the
native code? I'd like to verify all our gmock tests are running before I +1 but
it's taking a while because I'm running all tests (in a VM) at the moment.
Not yet -- the current pom.xml does not run {{make test}}. Will need to file
another jira to fix it.
bq. Also Is there a good reference on the build and test systems, ideally
including the implementation? The set of flags for maven you gave me worked but
I haven't found much documentation other than the very basic stuff in "How To
Contribute" and the pages that links to. If there aren't any docs and I have to
learn from scratch is there anywhere in the tree that you think would be best
to start looking? Thanks
Can you be more concrete on what kinds of documentation can help here? It will
be great to capture your experience in the wiki for other contributors.
> libhdfspp fails to compile after HDFS-9207
> --
>
> Key: HDFS-9340
> URL: https://issues.apache.org/jira/browse/HDFS-9340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-9340.HDFS-8707.000.patch
>
>
> After the refactor of HDFS-9207 the {{hadoop-hdfs-client}} module fails to
> compile as it invokes {{cmake}} against a directory that does not exist. It
> should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9340) libhdfspp fails to compile after HDFS-9207
[
https://issues.apache.org/jira/browse/HDFS-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981559#comment-14981559
]
Bob Hansen commented on HDFS-9340:
--
bq. the current pom.xml does not run make test. Will need to file another jira
to fix it.
Does the current pom.xml run "make"? I don't see anything in the pom that is
compiling libhdfspp.
> libhdfspp fails to compile after HDFS-9207
> --
>
> Key: HDFS-9340
> URL: https://issues.apache.org/jira/browse/HDFS-9340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-9340.HDFS-8707.000.patch
>
>
> After the refactor of HDFS-9207 the {{hadoop-hdfs-client}} module fails to
> compile as it invokes {{cmake}} against a directory that does not exist. It
> should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9340) libhdfspp fails to compile after HDFS-9207
[
https://issues.apache.org/jira/browse/HDFS-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981637#comment-14981637
]
James Clampffer commented on HDFS-9340:
---
+1 on the patch, but I think a jira that wires up make test to maven is high
priority. If you could implement or help with that step I think I could go the
rest of the way with the integration tests with minimal support.
"Does the current pom.xml run "make"? I don't see anything in the pom that is
compiling libhdfspp."
To answer your question Bob it is running make, but how that gets invoked I
have no idea. I just looked for the static libraries after the build and they
all showed up.
"Can you be more concrete on what kinds of documentation can help here? It will
be great to capture your experience in the wiki for other contributors."
Bob's question about make is pretty much the same thing I'm running into. I
know that the build primarily uses maven but things start getting hard to
follow when that calls ant which calls cmake; at least that's my current
understanding of the chain of events to build libhdfs++. In my experience as a
new contributor it's fairly difficult to follow how mvn install
eventually invokes cmake, and even what the working directories for this
process are.
I guess what I'd like is a page that says something like:
1a) here's the pom.xml at the root of the project, and a brief summary what the
most important bits of it do
1b) here are the options you can give at that level to control the build and
change what sorts of tests get run with different flags etc
2a) when you're using a language like C++ that isn't natural for maven these
are the steps that are taken to invoke something like cmake
2b) here are some references to the plugins that do most of the work
2c) here's a snippet of code that you could drop in a pom.xml to build some C++
project, or here's a a project that should be considered a prototypical example
As someone with a C and C++ and hardware background I don't have the high level
of familiarity with maven, ant, and the rest of the java ecosystem that I think
many Hadoop contributors take for granted. I think the steps above would go a
long way towards enabling people with with experience similar to mine to become
productive quickly. If there isn't much of anything in this area I'd be happy
to contribute to a wiki that addresses this, I just have to learn it all first.
> libhdfspp fails to compile after HDFS-9207
> --
>
> Key: HDFS-9340
> URL: https://issues.apache.org/jira/browse/HDFS-9340
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-9340.HDFS-8707.000.patch
>
>
> After the refactor of HDFS-9207 the {{hadoop-hdfs-client}} module fails to
> compile as it invokes {{cmake}} against a directory that does not exist. It
> should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
