[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Mingliang Liu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992619#comment-14992619
 ] 

Mingliang Liu commented on HDFS-9377:
-

Thanks to [~yzhangal] for review and commit. Thanks to [~cnauroth] and 
[~xiaochen] for review.

> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992801#comment-14992801
 ] 

Hudson commented on HDFS-9377:
--

FAILURE: Integrated in Hadoop-trunk-Commit #8763 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/8763/])
HDFS-9377. Fix findbugs warnings in FSDirSnapshotOp. (Mingliang Liu via 
(yzhang: rev 286cc6483fe458894cdd22ff1d8822c304e0d94f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java


> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Fix For: 2.8.0
>
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Yongjun Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992613#comment-14992613
 ] 

Yongjun Zhang commented on HDFS-9377:
-

Thanks [~liuml07]. I will commit it momentarily.


> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Mingliang Liu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992606#comment-14992606
 ] 

Mingliang Liu commented on HDFS-9377:
-

The failing tests are not related.

> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992484#comment-14992484
 ] 

Hadoop QA commented on HDFS-9377:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 7s 
{color} | {color:blue} docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
20s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s 
{color} | {color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s 
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
16s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
13s {color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 55s 
{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in trunk cannot run 
convertXmlToText from findbugs {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s 
{color} | {color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 45s 
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
37s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s 
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s 
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 15s 
{color} | {color:red} Patch generated 1 new checkstyle issues in 
hadoop-hdfs-project/hadoop-hdfs (total was 3, now 4). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 
59s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s 
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 47s 
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 51m 58s {color} 
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_60. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 54m 29s {color} 
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 22s 
{color} | {color:red} Patch generated 58 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 126m 10s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_60 Failed junit tests | 
hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure |
| JDK v1.7.0_79 Failed junit tests | 
hadoop.hdfs.server.namenode.ha.TestEditLogTailer |
|   | 
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary |
| JDK v1.7.0_79 Timed out junit tests | 
org.apache.hadoop.hdfs.server.blockmanagement.TestPendingReplication |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.7.1 Server=1.7.1 
Image:test-patch-base-hadoop-date2015-11-05 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12770695/HDFS-9377.000.patch |
| JIRA Issue |

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992894#comment-14992894
 ] 

Hudson commented on HDFS-9377:
--

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2573 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2573/])
HDFS-9377. Fix findbugs warnings in FSDirSnapshotOp. (Mingliang Liu via 
(yzhang: rev 286cc6483fe458894cdd22ff1d8822c304e0d94f)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Fix For: 2.8.0
>
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993058#comment-14993058
 ] 

Hudson commented on HDFS-9377:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk #2514 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2514/])
HDFS-9377. Fix findbugs warnings in FSDirSnapshotOp. (Mingliang Liu via 
(yzhang: rev 286cc6483fe458894cdd22ff1d8822c304e0d94f)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Fix For: 2.8.0
>
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993004#comment-14993004
 ] 

Hudson commented on HDFS-9377:
--

SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #644 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/644/])
HDFS-9377. Fix findbugs warnings in FSDirSnapshotOp. (Mingliang Liu via 
(yzhang: rev 286cc6483fe458894cdd22ff1d8822c304e0d94f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java


> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Fix For: 2.8.0
>
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992904#comment-14992904
 ] 

Hudson commented on HDFS-9377:
--

FAILURE: Integrated in Hadoop-Yarn-trunk #1367 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/1367/])
HDFS-9377. Fix findbugs warnings in FSDirSnapshotOp. (Mingliang Liu via 
(yzhang: rev 286cc6483fe458894cdd22ff1d8822c304e0d94f)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Fix For: 2.8.0
>
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992900#comment-14992900
 ] 

Hudson commented on HDFS-9377:
--

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #633 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/633/])
HDFS-9377. Fix findbugs warnings in FSDirSnapshotOp. (Mingliang Liu via 
(yzhang: rev 286cc6483fe458894cdd22ff1d8822c304e0d94f)
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Fix For: 2.8.0
>
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-05 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993274#comment-14993274
 ] 

Hudson commented on HDFS-9377:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #576 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/576/])
HDFS-9377. Fix findbugs warnings in FSDirSnapshotOp. (Mingliang Liu via 
(yzhang: rev 286cc6483fe458894cdd22ff1d8822c304e0d94f)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java


> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Fix For: 2.8.0
>
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-04 Thread Yongjun Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990579#comment-14990579
 ] 

Yongjun Zhang commented on HDFS-9377:
-

Thanks [~liuml07] a lot for the good find here!  +1 pending jenkins.

I wish HADOOP-12517 is fixed soon so we won't miss this. Sorry for missing that 
when I did the review.




> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HDFS-9377) Fix findbugs warnings in FSDirSnapshotOp

2015-11-04 Thread Xiao Chen (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990634#comment-14990634
 ] 

Xiao Chen commented on HDFS-9377:
-

Thanks very much for the work guys!
I added a link to the original JIRA, sorry for breaking this.

> Fix findbugs warnings in FSDirSnapshotOp
> 
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
>  Issue Type: Task
>  Components: namenode
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in 
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
>  instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0" 
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563" 
> instanceOccurrenceMax="0">
> Dead store to local variable
> 
> Dead store to sfi in 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
>  primary="true">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="279">
> At FSDirSnapshotOp.java:[lines 41-279]
> 
> 
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> 
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> name="getSnapshotFiles" primary="true" 
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> 
> In method 
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
>  List, String)
> 
> 
> 
> Local variable named sfi
> 
>  classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp" 
> primary="true" 
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java" 
> sourcefile="FSDirSnapshotOp.java" end="175">
> At FSDirSnapshotOp.java:[line 175]
> 
>  name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT" 
> value="true"/>
>  value="sfi"/>
>  value="true"/>
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)