[jira] [Commented] (HDFS-9542) Move BlockIdManager from FSNamesystem to BlockManager
[ https://issues.apache.org/jira/browse/HDFS-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110480#comment-15110480 ] Tsz Wo Nicholas Sze commented on HDFS-9542: --- +1 the patch clean up a lot the Namesystem interface. It's great! > Move BlockIdManager from FSNamesystem to BlockManager > - > > Key: HDFS-9542 > URL: https://issues.apache.org/jira/browse/HDFS-9542 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode >Reporter: Jing Zhao >Assignee: Jing Zhao > Attachments: HDFS-9542.000.patch, HDFS-9542.001.patch > > > Semantically BlockIdManager should be a field in BlockManager instead of > FSNamesystem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9542) Move BlockIdManager from FSNamesystem to BlockManager
[
https://issues.apache.org/jira/browse/HDFS-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110531#comment-15110531
]
Kai Zheng commented on HDFS-9542:
-
Yeah, nice refactoring.
Just wonder if it's a good idea to rename: {{generationStampV1}} =>
{{legacyGenerationStamp}}; {{generationStampV2}} => {{generationStamp}},
similar for other variables, as we have {{legacy block}} and {{block}}.
> Move BlockIdManager from FSNamesystem to BlockManager
> -
>
> Key: HDFS-9542
> URL: https://issues.apache.org/jira/browse/HDFS-9542
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
>Reporter: Jing Zhao
>Assignee: Jing Zhao
> Attachments: HDFS-9542.000.patch, HDFS-9542.001.patch
>
>
> Semantically BlockIdManager should be a field in BlockManager instead of
> FSNamesystem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9542) Move BlockIdManager from FSNamesystem to BlockManager
[ https://issues.apache.org/jira/browse/HDFS-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110985#comment-15110985 ] Vinayakumar B commented on HDFS-9542: - bq. Just wonder if it's a good idea to rename: generationStampV1 => legacyGenerationStamp; generationStampV2 => generationStamp, similar for other variables, as we have legacy block and block. Good to see this. +1 for the current refactor anyway. thanks [~jingzhao]. > Move BlockIdManager from FSNamesystem to BlockManager > - > > Key: HDFS-9542 > URL: https://issues.apache.org/jira/browse/HDFS-9542 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode >Reporter: Jing Zhao >Assignee: Jing Zhao > Attachments: HDFS-9542.000.patch, HDFS-9542.001.patch > > > Semantically BlockIdManager should be a field in BlockManager instead of > FSNamesystem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9542) Move BlockIdManager from FSNamesystem to BlockManager
[ https://issues.apache.org/jira/browse/HDFS-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1521#comment-1521 ] Jing Zhao commented on HDFS-9542: - Thanks for the review, [~szetszwo], [~drankye] and [~vinayrpet]! bq. Just wonder if it's a good idea to rename: generationStampV1 => legacyGenerationStamp; generationStampV2 => generationStamp, similar for other variables, as we have legacy block and block. +1 on the rename. I tried to do this on top of the current patch but looks like all the rename (including renames on corresponding public methods) will increase the patch size a lot. I just created HDFS-9677 and plan to do the rename there. I will commit the current patch shortly. > Move BlockIdManager from FSNamesystem to BlockManager > - > > Key: HDFS-9542 > URL: https://issues.apache.org/jira/browse/HDFS-9542 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode >Reporter: Jing Zhao >Assignee: Jing Zhao > Attachments: HDFS-9542.000.patch, HDFS-9542.001.patch > > > Semantically BlockIdManager should be a field in BlockManager instead of > FSNamesystem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9542) Move BlockIdManager from FSNamesystem to BlockManager
[ https://issues.apache.org/jira/browse/HDFS-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1580#comment-1580 ] Hudson commented on HDFS-9542: -- FAILURE: Integrated in Hadoop-trunk-Commit #9155 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9155/]) HDFS-9542. Move BlockIdManager from FSNamesystem to BlockManager. (jing9: rev c304890c8c7782d835896859f5b7f60b96c306c0) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManagerSafeMode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockIdManager.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSequentialBlockGroupId.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerSafeMode.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicy.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSequentialBlockId.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManager.java > Move BlockIdManager from FSNamesystem to BlockManager > - > > Key: HDFS-9542 > URL: https://issues.apache.org/jira/browse/HDFS-9542 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode >Reporter: Jing Zhao >Assignee: Jing Zhao > Attachments: HDFS-9542.000.patch, HDFS-9542.001.patch > > > Semantically BlockIdManager should be a field in BlockManager instead of > FSNamesystem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9542) Move BlockIdManager from FSNamesystem to BlockManager
[
https://issues.apache.org/jira/browse/HDFS-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107952#comment-15107952
]
Hadoop QA commented on HDFS-9542:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
4s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 56s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 0s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
11s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 15s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 6s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
57s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 47s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 47s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 46s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 30s
{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs: patch generated 7 new +
807 unchanged - 11 fixed = 814 total (was 818) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 2s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 10s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 58s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 72m 36s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 70m 24s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_91. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 175m 19s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests |
hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery |
| | hadoop.hdfs.server.datanode.TestBlockScanner |
| JDK v1.7.0_91 Failed junit tests | hadoop.hdfs.TestDFSUpgradeFromImage |
| | hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12783228/HDFS-9542.001.patch |
| JIRA Issue | HDFS-9542 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit
