[jira] [Updated] (HDFS-10459) getTurnOffTip computes needed block incorrectly for threshold < 1 in b2.7
[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Badger updated HDFS-10459: --- Resolution: Won't Fix Status: Resolved (was: Patch Available) Not a critical fix for 2.7, so closing as won't fix. As for trunk, after speaking offline with [~daryn] and [~kihwal], it looks like truncating (i.e. rounding down) is the easier approach here, so we'll just leave this as is and not change anything. The off by 1 error is already fixed there. > getTurnOffTip computes needed block incorrectly for threshold < 1 in b2.7 > - > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Eric Badger >Assignee: Eric Badger > Attachments: HDFS-10459.001.patch, HDFS-10459.002.patch, > HDFS-10459.003.patch, HDFS-10459-b2.7.002.patch, HDFS-10459-b2.7.003.patch > > > GetTurnOffTip overstates the number of blocks necessary to come out of safe > mode by 1 due to an arbitrary '+1' in the code. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10459) getTurnOffTip computes needed block incorrectly for threshold < 1 in b2.7
[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Badger updated HDFS-10459: --- Attachment: HDFS-10459.003.patch Either missed a test when I initially uploaded the trunk patch or it was added/modified since I put it up. Anyway, here's an updated patch for trunk. This patch applies to trunk and branch-2. > getTurnOffTip computes needed block incorrectly for threshold < 1 in b2.7 > - > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Eric Badger >Assignee: Eric Badger > Attachments: HDFS-10459.001.patch, HDFS-10459.002.patch, > HDFS-10459.003.patch, HDFS-10459-b2.7.002.patch, HDFS-10459-b2.7.003.patch > > > GetTurnOffTip overstates the number of blocks necessary to come out of safe > mode by 1 due to an arbitrary '+1' in the code. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10459) getTurnOffTip computes needed block incorrectly for threshold < 1 in b2.7
[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Badger updated HDFS-10459: --- Attachment: HDFS-10459-b2.7.003.patch Getting rid of '+1' in GetTurnOffTip calculation so that the log message is correct. > getTurnOffTip computes needed block incorrectly for threshold < 1 in b2.7 > - > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Eric Badger >Assignee: Eric Badger > Attachments: HDFS-10459-b2.7.002.patch, HDFS-10459-b2.7.003.patch, > HDFS-10459.001.patch, HDFS-10459.002.patch > > > GetTurnOffTip overstates the number of blocks necessary to come out of safe > mode by 1 due to an arbitrary '+1' in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10459) getTurnOffTip computes needed block incorrectly for threshold < 1 in b2.7
[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Badger updated HDFS-10459: --- Affects Version/s: (was: 2.9.0) 2.7.0 Description: GetTurnOffTip overstates the number of blocks necessary to come out of safe mode by 1 due to an arbitrary '+1' in the code. (was: The computation works on threshold = 1, but not on threshold < 1. I propose making blockThreshold equal to the ceiling of total*threshold. Since we need to be >= blockThreshold to get out of safe mode, >14.9 is the same as =15, since blocks work in integer values. ) Summary: getTurnOffTip computes needed block incorrectly for threshold < 1 in b2.7 (was: getTurnOffTip computes needed block incorrectly for threshold < 1) > getTurnOffTip computes needed block incorrectly for threshold < 1 in b2.7 > - > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Eric Badger >Assignee: Eric Badger > Attachments: HDFS-10459-b2.7.002.patch, HDFS-10459.001.patch, > HDFS-10459.002.patch > > > GetTurnOffTip overstates the number of blocks necessary to come out of safe > mode by 1 due to an arbitrary '+1' in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10459) getTurnOffTip computes needed block incorrectly for threshold < 1
[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Badger updated HDFS-10459: --- Attachment: HDFS-10459-b2.7.002.patch Attaching branch-2.7 patch. > getTurnOffTip computes needed block incorrectly for threshold < 1 > - > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Eric Badger >Assignee: Eric Badger > Attachments: HDFS-10459-b2.7.002.patch, HDFS-10459.001.patch, > HDFS-10459.002.patch > > > The computation works on threshold = 1, but not on threshold < 1. I propose > making blockThreshold equal to the ceiling of total*threshold. Since we need > to be >= blockThreshold to get out of safe mode, >14.9 is the same as =15, > since blocks work in integer values. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10459) getTurnOffTip computes needed block incorrectly for threshold < 1
[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Badger updated HDFS-10459: --- Affects Version/s: (was: 0.23.0) (was: 0.22.0) 2.9.0 Description: The computation works on threshold = 1, but not on threshold < 1. I propose making blockThreshold equal to the ceiling of total*threshold. Since we need to be >= blockThreshold to get out of safe mode, >14.9 is the same as =15, since blocks work in integer values. (was: The fix added in HDFS-2002 only works in cases where threshold < 1, but not when threshold = 1. There is a '+1' added to the computation because of this assumption. I propose that instead of adding a '+1', we just set blockThreshold to be the ceiling of blocksTotal*threshold. Since we need to be >= blockThreshold to get out of safe mode, this will work. >14.9 is the same as =15, since blocks work in integer values. ) Summary: getTurnOffTip computes needed block incorrectly for threshold < 1 (was: getTurnOffTip computes needed block incorrectly for threshold = 1) > getTurnOffTip computes needed block incorrectly for threshold < 1 > - > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Eric Badger >Assignee: Eric Badger > Attachments: HDFS-10459.001.patch > > > The computation works on threshold = 1, but not on threshold < 1. I propose > making blockThreshold equal to the ceiling of total*threshold. Since we need > to be >= blockThreshold to get out of safe mode, >14.9 is the same as =15, > since blocks work in integer values. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10459) getTurnOffTip computes needed block incorrectly for threshold < 1
[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Badger updated HDFS-10459: --- Attachment: HDFS-10459.002.patch Rebasing to trunk. > getTurnOffTip computes needed block incorrectly for threshold < 1 > - > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Eric Badger >Assignee: Eric Badger > Attachments: HDFS-10459.001.patch, HDFS-10459.002.patch > > > The computation works on threshold = 1, but not on threshold < 1. I propose > making blockThreshold equal to the ceiling of total*threshold. Since we need > to be >= blockThreshold to get out of safe mode, >14.9 is the same as =15, > since blocks work in integer values. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10459) getTurnOffTip computes needed block incorrectly for threshold = 1
[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Badger updated HDFS-10459: --- Attachment: HDFS-10459.001.patch Attaching a patch that fixes the issue by making blockThreshold equal to the ceiling of blockTotal*threshold > getTurnOffTip computes needed block incorrectly for threshold = 1 > - > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Eric Badger > Attachments: HDFS-10459.001.patch > > > The fix added in HDFS-2002 only works in cases where threshold < 1, but not > when threshold = 1. There is a '+1' added to the computation because of this > assumption. I propose that instead of adding a '+1', we just set > blockThreshold to be the ceiling of blocksTotal*threshold. Since we need to > be >= blockThreshold to get out of safe mode, this will work. >14.9 is the > same as =15, since blocks work in integer values. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-10459) getTurnOffTip computes needed block incorrectly for threshold = 1
[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Badger updated HDFS-10459: --- Affects Version/s: 0.22.0 0.23.0 Status: Patch Available (was: Open) > getTurnOffTip computes needed block incorrectly for threshold = 1 > - > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 0.23.0, 0.22.0 >Reporter: Eric Badger > Attachments: HDFS-10459.001.patch > > > The fix added in HDFS-2002 only works in cases where threshold < 1, but not > when threshold = 1. There is a '+1' added to the computation because of this > assumption. I propose that instead of adding a '+1', we just set > blockThreshold to be the ceiling of blocksTotal*threshold. Since we need to > be >= blockThreshold to get out of safe mode, this will work. >14.9 is the > same as =15, since blocks work in integer values. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org