[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=215028&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215028 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 21:22 Start Date: 18/Mar/19 21:22 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-474106549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 19 | Maven dependency ordering for branch | | +1 | mvninstall | 1156 | trunk passed | | +1 | compile | 119 | trunk passed | | +1 | checkstyle | 36 | trunk passed | | +1 | mvnsite | 117 | trunk passed | | +1 | shadedclient | 964 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 124 | trunk passed | | +1 | javadoc | 93 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 124 | the patch passed | | +1 | compile | 106 | the patch passed | | +1 | cc | 106 | the patch passed | | +1 | javac | 106 | the patch passed | | +1 | checkstyle | 28 | the patch passed | | +1 | mvnsite | 96 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 935 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 127 | the patch passed | | +1 | javadoc | 82 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 46 | common in the patch passed. | | +1 | unit | 58 | ozone-manager in the patch passed. | | -1 | unit | 519 | integration-test in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 4872 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.om.TestOMDbCheckpointServlet | | | hadoop.ozone.web.TestOzoneRestWithMiniCluster | | | hadoop.ozone.web.TestOzoneVolumes | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.hdds.scm.pipeline.TestPipelineClose | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline | | | hadoop.ozone.scm.TestSCMMXBean | | | hadoop.ozone.container.ozoneimpl.TestOzoneContainer | | | hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode | | | hadoop.ozone.scm.TestXceiverClientManager | | | hadoop.ozone.ozShell.TestOzoneShell | | | hadoop.ozone.scm.pipeline.TestPipelineManagerMXBean | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.ozShell.TestOzoneDatanodeShell | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.om.TestMultipleContainerReadWrite | | | hadoop.ozone.om.TestOmMetrics | | | hadoop.ozone.web.client.TestOzoneClient | | | hadoop.ozone.scm.TestAllocateContainer | | | hadoop.ozone.om.TestScmChillMode | | | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.TestContainerOperations | | | hadoop.ozone.om.TestOzoneManagerConfiguration | | | hadoop.hdds.scm.pipeline.TestNode2PipelineMap | | | hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey | | | hadoop.ozone.scm.TestXceiverClientMetrics | | | hadoop.hdds.scm.container.TestContainerStateManagerIntegration | | | hadoop.ozone.client.rpc.TestBCSID | | | hadoop.ozone.scm.node.TestSCMNodeMetrics | | | hadoop.ozone.om.TestOmBlockVersioning | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.ozShell.TestS3Shell | | | hadoop.ozone.web.client.TestVolume | | | hadoop.ozone.TestContainerStateMachineIdempotency | | | hadoop.ozone.container.TestContainerReplication | | | hadoop.ozone.scm.TestContainerSmallFile | | | hadoop.ozone.client.rpc.TestReadRetries | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler | | | hadoop.ozone.om.TestContainerReportWithKeys | | | hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler |
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=215013&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215013 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 20:52 Start Date: 18/Mar/19 20:52 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-474096290 I have committed this to trunk. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 215013) Time Spent: 4h 40m (was: 4.5h) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 4h 40m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=215010&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215010 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 20:50 Start Date: 18/Mar/19 20:50 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-474095414 Attache the smoke test run which is run locally. [testrun.txt](https://github.com/apache/hadoop/files/2980370/testrun.txt) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 215010) Time Spent: 4h 20m (was: 4h 10m) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 4h 20m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=215014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215014 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 20:55 Start Date: 18/Mar/19 20:55 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on pull request #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 215014) Time Spent: 4h 50m (was: 4h 40m) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > Time Spent: 4h 50m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=215012&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215012 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 20:51 Start Date: 18/Mar/19 20:51 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-474094516 Ran smoke tests locally. Attached the test run log. I don't see any tests being run for secure, but remaining all other tests are passing. Thank You @hanishakoneru for the review. I will commit this shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 215012) Time Spent: 4.5h (was: 4h 20m) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 4.5h > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=215009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215009 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 20:47 Start Date: 18/Mar/19 20:47 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-474094516 Ran smoke tests locally. I don't see any tests being run for secure, but remaining all other tests are passing. Thank You @hanishakoneru for the review. I will commit this shortly. HW13865:smoketest bviswanadham$ ./test.sh - Executing test(s): [basic] Cluster type: ozone Compose file: /Users/bviswanadham/workspace/hadoop-commit/hadoop/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/smoketest/../compose/ozone/docker-compose.yaml Output dir: /Users/bviswanadham/workspace/hadoop-commit/hadoop/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/smoketest/result Command to rerun: ./test.sh --keep --env ozone basic - Removing network ozone_default WARNING: Network ozone_default not found. Creating network "ozone_default" with the default driver Creating ozone_scm_1 ... Creating ozone_datanode_1 ... Creating ozone_datanode_2 ... Creating ozone_datanode_3 ... Creating ozone_om_1 ... Creating ozone_om_1 Creating ozone_datanode_1 Creating ozone_datanode_1 ... done Creating ozone_datanode_2 ... done Creating ozone_om_1 ... done 0 datanode is up and healthy (until now) 0 datanode is up and healthy (until now) 3 datanodes are up and registered to the scm == Basic == Basic.Basic :: Smoketest ozone cluster startup == Check webui static resources | PASS | -- Start freon testing | PASS | -- Basic.Basic :: Smoketest ozone cluster startup| PASS | 2 critical tests, 2 passed, 0 failed 2 tests total, 2 passed, 0 failed == Basic.Ozone-Shell :: Test ozone shell CLI usage == RpcClient with port | PASS | -- RpcClient without host| PASS | -- RpcClient without scheme | PASS | -- Basic.Ozone-Shell :: Test ozone shell CLI usage | PASS | 3 critical tests, 3 passed, 0 failed 3 tests total, 3 passed, 0 failed == Basic | PASS | 5 critical tests, 5 passed, 0 failed 5 tests total, 5 passed, 0 failed == Output: /opt/hadoop/smoketest/result/robot-ozone-basic.xml Stopping ozone_datanode_2 ... done Stopping ozone_datanode_3 ... done Stopping ozone_scm_1 ... done Stopping ozone_datanode_1 ... done Stopping ozone_om_1 ... done Removing ozone_datanode_2 ... done Removing ozone_datanode_3 ... done Removing ozone_scm_1 ... done Removing ozone_datanode_1 ... done Removing ozone_om_1 ... done Removing network ozone_default - Executing test(s): [auditparser] Cluster type: ozone Compose file: /Users/bviswanadham/workspace/hadoop-commit/hadoop/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/smoketest/../compose/ozone/docker-compose.yaml Output dir: /Users/bviswanadham/workspace/hadoop-commit/hado
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214988 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 19:59 Start Date: 18/Mar/19 19:59 Worklog Time Spent: 10m Work Description: hanishakoneru commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-474077516 Thanks @bharatviswa504 The changes LGTM. +1 for merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 214988) Time Spent: 4h (was: 3h 50m) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 4h > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214921&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214921 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 18:16 Start Date: 18/Mar/19 18:16 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-474040232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 62 | Maven dependency ordering for branch | | +1 | mvninstall | 1129 | trunk passed | | +1 | compile | 105 | trunk passed | | +1 | checkstyle | 27 | trunk passed | | +1 | mvnsite | 110 | trunk passed | | +1 | shadedclient | 858 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 100 | trunk passed | | +1 | javadoc | 72 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 11 | Maven dependency ordering for patch | | +1 | mvninstall | 104 | the patch passed | | +1 | compile | 100 | the patch passed | | +1 | cc | 100 | the patch passed | | +1 | javac | 100 | the patch passed | | -0 | checkstyle | 24 | hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | mvnsite | 87 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 795 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 113 | the patch passed | | +1 | javadoc | 69 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 38 | common in the patch passed. | | +1 | unit | 44 | ozone-manager in the patch passed. | | -1 | unit | 418 | integration-test in the patch failed. | | +1 | asflicense | 32 | The patch does not generate ASF License warnings. | | | | 4367 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.om.TestOMDbCheckpointServlet | | | hadoop.ozone.web.TestOzoneRestWithMiniCluster | | | hadoop.ozone.web.TestOzoneVolumes | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.hdds.scm.pipeline.TestPipelineClose | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline | | | hadoop.ozone.scm.TestSCMMXBean | | | hadoop.ozone.container.ozoneimpl.TestOzoneContainer | | | hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode | | | hadoop.ozone.scm.TestXceiverClientManager | | | hadoop.ozone.ozShell.TestOzoneShell | | | hadoop.ozone.scm.pipeline.TestPipelineManagerMXBean | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.ozShell.TestOzoneDatanodeShell | | | hadoop.ozone.om.TestMultipleContainerReadWrite | | | hadoop.ozone.om.TestOmMetrics | | | hadoop.ozone.web.client.TestOzoneClient | | | hadoop.ozone.scm.TestAllocateContainer | | | hadoop.ozone.client.rpc.TestFailureHandlingByClient | | | hadoop.ozone.om.TestScmChillMode | | | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.TestContainerOperations | | | hadoop.ozone.om.TestOzoneManagerConfiguration | | | hadoop.hdds.scm.pipeline.TestNode2PipelineMap | | | hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey | | | hadoop.ozone.scm.TestXceiverClientMetrics | | | hadoop.hdds.scm.container.TestContainerStateManagerIntegration | | | hadoop.ozone.client.rpc.TestBCSID | | | hadoop.ozone.scm.node.TestSCMNodeMetrics | | | hadoop.ozone.om.TestOmBlockVersioning | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.ozShell.TestS3Shell | | | hadoop.ozone.web.client.TestVolume | | | hadoop.ozone.TestContainerStateMachineIdempotency | | | hadoop.ozone.container.TestContainerReplication | | | hadoop.ozone.scm.TestContainerSmallFile | | | hadoop.ozone.client.rpc.TestReadRetries | | | hadoop.ozone.om.TestOzoneManagerHA | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler | | | hadoop.ozone.om.TestContainerReportWithK
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214931 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 18:21 Start Date: 18/Mar/19 18:21 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-474041921 Test failure's failing are failing due to 30 is not within min = 500 or max = 10 This will be taken care in the below jira. https://issues.apache.org/jira/browse/HDDS-1297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 214931) Time Spent: 3h 40m (was: 3.5h) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 3h 40m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214933 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 18:21 Start Date: 18/Mar/19 18:21 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-474042051 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 27 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 19 | Maven dependency ordering for branch | | +1 | mvninstall | 1002 | trunk passed | | +1 | compile | 90 | trunk passed | | +1 | checkstyle | 24 | trunk passed | | +1 | mvnsite | 90 | trunk passed | | +1 | shadedclient | 748 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 91 | trunk passed | | +1 | javadoc | 69 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 91 | the patch passed | | +1 | compile | 88 | the patch passed | | +1 | cc | 88 | the patch passed | | +1 | javac | 88 | the patch passed | | -0 | checkstyle | 20 | hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | mvnsite | 78 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 683 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 106 | the patch passed | | +1 | javadoc | 63 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 36 | common in the patch passed. | | +1 | unit | 34 | ozone-manager in the patch passed. | | -1 | unit | 1135 | integration-test in the patch failed. | | +1 | asflicense | 25 | The patch does not generate ASF License warnings. | | | | 4571 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.scm.TestXceiverClientManager | | | hadoop.ozone.om.TestOmBlockVersioning | | | hadoop.ozone.om.TestContainerReportWithKeys | | | hadoop.ozone.TestContainerOperations | | | hadoop.hdds.scm.container.TestContainerStateManagerIntegration | | | hadoop.hdds.scm.pipeline.TestNode2PipelineMap | | | hadoop.ozone.client.rpc.TestContainerStateMachineFailures | | | hadoop.hdds.scm.pipeline.TestRatisPipelineUtils | | | hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey | | | hadoop.ozone.scm.pipeline.TestSCMPipelineMetrics | | | hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline | | | hadoop.ozone.container.ozoneimpl.TestOzoneContainer | | | hadoop.ozone.web.client.TestVolume | | | hadoop.ozone.ozShell.TestOzoneShell | | | hadoop.ozone.ozShell.TestS3Shell | | | hadoop.ozone.web.client.TestBuckets | | | hadoop.ozone.ozShell.TestOzoneDatanodeShell | | | hadoop.ozone.web.TestOzoneRestWithMiniCluster | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.ozone.scm.TestXceiverClientMetrics | | | hadoop.ozone.web.client.TestOzoneClient | | | hadoop.hdds.scm.pipeline.TestSCMRestart | | | hadoop.ozone.om.TestMultipleContainerReadWrite | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler | | | hadoop.ozone.TestContainerStateMachineIdempotency | | | hadoop.ozone.client.rpc.TestBCSID | | | hadoop.ozone.om.TestOmMetrics | | | hadoop.ozone.scm.TestContainerSmallFile | | | hadoop.ozone.om.TestOzoneManagerConfiguration | | | hadoop.ozone.scm.TestSCMMXBean | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.om.TestOmAcls | | | hadoop.ozone.scm.pipeline.TestPipelineManagerMXBean | | | hadoop.ozone.client.rpc.TestReadRetries | | | hadoop.ozone.om.TestOMDbCheckpointServlet | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.om.TestOzoneManager | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | |
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214890 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 18/Mar/19 17:12 Start Date: 18/Mar/19 17:12 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-474013221 Thank You @hanishakoneru for the review. I have addressed the review comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 214890) Time Spent: 3h 20m (was: 3h 10m) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 3h 20m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214104&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214104 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 15/Mar/19 23:38 Start Date: 15/Mar/19 23:38 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-473473319 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 26 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 51 | Maven dependency ordering for branch | | +1 | mvninstall | 977 | trunk passed | | +1 | compile | 93 | trunk passed | | +1 | checkstyle | 26 | trunk passed | | -1 | mvnsite | 28 | ozone-manager in trunk failed. | | +1 | shadedclient | 741 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 23 | ozone-manager in trunk failed. | | +1 | javadoc | 69 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | +1 | mvninstall | 95 | the patch passed | | +1 | compile | 90 | the patch passed | | +1 | cc | 90 | the patch passed | | +1 | javac | 90 | the patch passed | | +1 | checkstyle | 24 | hadoop-ozone: The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) | | +1 | mvnsite | 85 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 749 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 112 | the patch passed | | +1 | javadoc | 71 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 37 | common in the patch passed. | | +1 | unit | 43 | ozone-manager in the patch passed. | | -1 | unit | 1248 | integration-test in the patch failed. | | +1 | asflicense | 35 | The patch does not generate ASF License warnings. | | | | 4785 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.om.TestMultipleContainerReadWrite | | | hadoop.ozone.client.rpc.TestReadRetries | | | hadoop.ozone.web.client.TestKeys | | | hadoop.ozone.web.client.TestKeysRatis | | | hadoop.ozone.om.TestOzoneManager | | | hadoop.ozone.om.TestScmChillMode | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.client.rpc.TestBCSID | | | hadoop.ozone.web.TestOzoneRestWithMiniCluster | | | hadoop.ozone.client.rpc.TestContainerStateMachine | | | hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode | | | hadoop.ozone.container.TestContainerReplication | | | hadoop.ozone.web.client.TestOzoneClient | | | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler | | | hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion | | | hadoop.ozone.om.TestOmBlockVersioning | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.om.TestContainerReportWithKeys | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline | | | hadoop.ozone.client.rpc.TestContainerStateMachineFailures | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.ozShell.TestOzoneShell | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 848ec59fb1ce 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214078 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 15/Mar/19 22:28 Start Date: 15/Mar/19 22:28 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-473460817 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 503 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 49 | Maven dependency ordering for branch | | +1 | mvninstall | 1024 | trunk passed | | +1 | compile | 104 | trunk passed | | +1 | checkstyle | 24 | trunk passed | | -1 | mvnsite | 27 | ozone-manager in trunk failed. | | +1 | shadedclient | 723 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 24 | ozone-manager in trunk failed. | | +1 | javadoc | 79 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 101 | the patch passed | | +1 | compile | 93 | the patch passed | | +1 | cc | 93 | the patch passed | | +1 | javac | 93 | the patch passed | | +1 | checkstyle | 23 | hadoop-ozone: The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) | | +1 | mvnsite | 85 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 735 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 109 | the patch passed | | +1 | javadoc | 73 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 37 | common in the patch passed. | | +1 | unit | 42 | ozone-manager in the patch passed. | | -1 | unit | 1043 | integration-test in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 5109 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.ozShell.TestOzoneShell | | | hadoop.ozone.om.TestOzoneManager | | | hadoop.ozone.client.rpc.TestReadRetries | | | hadoop.ozone.om.TestScmChillMode | | | hadoop.ozone.web.client.TestKeysRatis | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.om.TestContainerReportWithKeys | | | hadoop.ozone.om.TestMultipleContainerReadWrite | | | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler | | | hadoop.ozone.client.rpc.TestContainerStateMachine | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline | | | hadoop.ozone.client.rpc.TestBCSID | | | hadoop.ozone.web.client.TestKeys | | | hadoop.ozone.client.rpc.TestContainerStateMachineFailures | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.om.TestOmBlockVersioning | | | hadoop.ozone.web.TestOzoneRestWithMiniCluster | | | hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 45cf5d7b3fb9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 16b7862 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | mv
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214077 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 15/Mar/19 22:25 Start Date: 15/Mar/19 22:25 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-473460090 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 25 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 50 | Maven dependency ordering for branch | | +1 | mvninstall | 988 | trunk passed | | +1 | compile | 97 | trunk passed | | +1 | checkstyle | 30 | trunk passed | | -1 | mvnsite | 31 | ozone-manager in trunk failed. | | +1 | shadedclient | 801 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 25 | ozone-manager in trunk failed. | | +1 | javadoc | 84 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 100 | the patch passed | | +1 | compile | 91 | the patch passed | | +1 | cc | 91 | the patch passed | | +1 | javac | 91 | the patch passed | | +1 | checkstyle | 22 | hadoop-ozone: The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) | | +1 | mvnsite | 81 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 685 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 108 | the patch passed | | +1 | javadoc | 62 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 39 | common in the patch passed. | | +1 | unit | 40 | ozone-manager in the patch passed. | | -1 | unit | 603 | integration-test in the patch failed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 4155 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.web.client.TestKeysRatis | | | hadoop.ozone.om.TestOmBlockVersioning | | | hadoop.ozone.om.TestContainerReportWithKeys | | | hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion | | | hadoop.ozone.client.rpc.TestContainerStateMachineFailures | | | hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline | | | hadoop.ozone.ozShell.TestOzoneShell | | | hadoop.ozone.client.rpc.TestContainerStateMachine | | | hadoop.ozone.web.TestOzoneRestWithMiniCluster | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.om.TestMultipleContainerReadWrite | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler | | | hadoop.ozone.client.rpc.TestBCSID | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestReadRetries | | | hadoop.ozone.om.TestOzoneManager | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.om.TestOmInit | | | hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode | | | hadoop.ozone.om.TestScmChillMode | | | hadoop.ozone.web.client.TestKeys | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 7f096b5ed173 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 16b7862 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | mvnsite | https://bu
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214069&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214069 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 15/Mar/19 22:08 Start Date: 15/Mar/19 22:08 Worklog Time Spent: 10m Work Description: hanishakoneru commented on issue #591: HDDS-1250: IIn OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis. URL: https://github.com/apache/hadoop/pull/591#issuecomment-473456453 Thanks for working on this Bharat. LGTM overall. Just one comment - In addAllocateBlock(), we do not need the ExcludeList. ExcludeList is only used while getting the key locations from scm (in allocateBlock) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 214069) Time Spent: 2h 40m (was: 2.5h) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214033&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214033 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 15/Mar/19 20:58 Start Date: 15/Mar/19 20:58 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-473438864 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 7 | https://github.com/apache/hadoop/pull/591 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/10/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 214033) Time Spent: 2.5h (was: 2h 20m) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 2.5h > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214032 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 15/Mar/19 20:57 Start Date: 15/Mar/19 20:57 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-473438659 Thank You @hanishakoneru for the offline discussion. Addressed the suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 214032) Time Spent: 2h 20m (was: 2h 10m) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214026 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 15/Mar/19 20:48 Start Date: 15/Mar/19 20:48 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-473436151 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 0 | Docker mode activated. | | -1 | patch | 6 | https://github.com/apache/hadoop/pull/591 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/9/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 214026) Time Spent: 2h 10m (was: 2h) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214000 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 15/Mar/19 20:05 Start Date: 15/Mar/19 20:05 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-473423858 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 46 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 20 | Maven dependency ordering for branch | | +1 | mvninstall | 1122 | trunk passed | | -1 | compile | 39 | hadoop-ozone in trunk failed. | | +1 | checkstyle | 27 | trunk passed | | -1 | mvnsite | 27 | ozone-manager in trunk failed. | | -1 | mvnsite | 28 | integration-test in trunk failed. | | +1 | shadedclient | 828 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 25 | ozone-manager in trunk failed. | | +1 | javadoc | 72 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | -1 | mvninstall | 20 | ozone-manager in the patch failed. | | -1 | mvninstall | 24 | integration-test in the patch failed. | | -1 | compile | 37 | hadoop-ozone in the patch failed. | | -1 | cc | 37 | hadoop-ozone in the patch failed. | | -1 | javac | 37 | hadoop-ozone in the patch failed. | | -0 | checkstyle | 21 | hadoop-ozone: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2) | | -1 | mvnsite | 23 | ozone-manager in the patch failed. | | -1 | mvnsite | 25 | integration-test in the patch failed. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 784 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 24 | ozone-manager in the patch failed. | | +1 | javadoc | 66 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 38 | common in the patch passed. | | -1 | unit | 24 | ozone-manager in the patch failed. | | -1 | unit | 23 | integration-test in the patch failed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 3658 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 188bdc237bd8 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / ff06ef0 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/8/artifact/out/branch-compile-hadoop-ozone.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/8/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/8/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/8/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/8/artifact/out/patch-mvninstall-hadoop-ozone_ozone-manager.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/8/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/8/artifact/out/patch-compile-hadoop-ozone.txt | | cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/8/artifact/out/patch-compile-hadoop-ozone.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/8/artifact/out/patch-compile-hadoop-ozone.txt | | checkstyle | https://builds.apache.org/job/ha
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=212804&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212804 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 14/Mar/19 01:47 Start Date: 14/Mar/19 01:47 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-472672056 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 28 | Maven dependency ordering for branch | | +1 | mvninstall | 1177 | trunk passed | | +1 | compile | 102 | trunk passed | | +1 | checkstyle | 30 | trunk passed | | -1 | mvnsite | 29 | ozone-manager in trunk failed. | | +1 | shadedclient | 895 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 24 | ozone-manager in trunk failed. | | +1 | javadoc | 76 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | +1 | mvninstall | 102 | the patch passed | | +1 | compile | 94 | the patch passed | | +1 | cc | 94 | the patch passed | | +1 | javac | 94 | the patch passed | | +1 | checkstyle | 22 | the patch passed | | +1 | mvnsite | 82 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 806 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 107 | the patch passed | | +1 | javadoc | 67 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 37 | common in the patch passed. | | +1 | unit | 44 | ozone-manager in the patch passed. | | -1 | unit | 844 | integration-test in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 4799 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.om.TestScmChillMode | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.om.TestOzoneManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 98320ac30ba9 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / f235a94 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/7/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/7/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/7/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/7/testReport/ | | Max. process+thread count | 4271 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/7/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 212804) Time Spent: 1h 50m (was: 1h 40m) > In OM HA
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=212740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212740 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 13/Mar/19 22:30 Start Date: 13/Mar/19 22:30 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-472631703 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 25 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 50 | Maven dependency ordering for branch | | +1 | mvninstall | 1000 | trunk passed | | +1 | compile | 100 | trunk passed | | +1 | checkstyle | 29 | trunk passed | | +1 | mvnsite | 108 | trunk passed | | +1 | shadedclient | 804 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 99 | trunk passed | | +1 | javadoc | 80 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 96 | the patch passed | | +1 | compile | 87 | the patch passed | | +1 | cc | 87 | the patch passed | | +1 | javac | 87 | the patch passed | | -0 | checkstyle | 21 | hadoop-ozone: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) | | +1 | mvnsite | 79 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 694 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 110 | the patch passed | | -1 | javadoc | 20 | hadoop-ozone_ozone-manager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 36 | common in the patch passed. | | +1 | unit | 39 | ozone-manager in the patch passed. | | -1 | unit | 751 | integration-test in the patch failed. | | +1 | asflicense | 32 | The patch does not generate ASF License warnings. | | | | 4348 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.client.rpc.TestFailureHandlingByClient | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.om.TestOzoneManager | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.om.TestScmChillMode | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 45de4fdfd0db 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 6fa2298 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/6/artifact/out/diff-checkstyle-hadoop-ozone.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/6/artifact/out/diff-javadoc-javadoc-hadoop-ozone_ozone-manager.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/6/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/6/testReport/ | | Max. process+thread count | 3643 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/6/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries abo
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=212739&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212739 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 13/Mar/19 22:29 Start Date: 13/Mar/19 22:29 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-472631183 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 25 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 53 | Maven dependency ordering for branch | | +1 | mvninstall | 972 | trunk passed | | +1 | compile | 101 | trunk passed | | +1 | checkstyle | 29 | trunk passed | | +1 | mvnsite | 109 | trunk passed | | +1 | shadedclient | 794 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 98 | trunk passed | | +1 | javadoc | 74 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 100 | the patch passed | | +1 | compile | 94 | the patch passed | | +1 | cc | 94 | the patch passed | | +1 | javac | 94 | the patch passed | | -0 | checkstyle | 23 | hadoop-ozone: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) | | +1 | mvnsite | 84 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 739 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 110 | the patch passed | | -1 | javadoc | 22 | hadoop-ozone_ozone-manager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 38 | common in the patch passed. | | +1 | unit | 41 | ozone-manager in the patch passed. | | -1 | unit | 635 | integration-test in the patch failed. | | +1 | asflicense | 34 | The patch does not generate ASF License warnings. | | | | 4261 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.om.TestOzoneManager | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.om.TestScmChillMode | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 588fde9b8745 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 6fa2298 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/5/artifact/out/diff-checkstyle-hadoop-ozone.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/5/artifact/out/diff-javadoc-javadoc-hadoop-ozone_ozone-manager.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/5/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/5/testReport/ | | Max. process+thread count | 4606 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/5/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ---
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=212688&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212688 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 13/Mar/19 21:21 Start Date: 13/Mar/19 21:21 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-472610721 In this also PR also changed OzoneManagerRequestHandler to implement from RequestHandler, as for UT's we can test it without OzoneManager Start. (And also it will be cleaner). In current code have not implemented MockOzoneManagerHandler. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 212688) Time Spent: 1h 20m (was: 1h 10m) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=212579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212579 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 13/Mar/19 18:04 Start Date: 13/Mar/19 18:04 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-472539893 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 62 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 63 | Maven dependency ordering for branch | | +1 | mvninstall | 1147 | trunk passed | | +1 | compile | 120 | trunk passed | | +1 | checkstyle | 36 | trunk passed | | +1 | mvnsite | 110 | trunk passed | | +1 | shadedclient | 879 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 97 | trunk passed | | +1 | javadoc | 74 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | +1 | mvninstall | 98 | the patch passed | | +1 | compile | 91 | the patch passed | | +1 | cc | 91 | the patch passed | | +1 | javac | 91 | the patch passed | | +1 | checkstyle | 23 | the patch passed | | +1 | mvnsite | 81 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 818 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 112 | the patch passed | | +1 | javadoc | 67 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 38 | common in the patch passed. | | -1 | unit | 42 | ozone-manager in the patch failed. | | -1 | unit | 818 | integration-test in the patch failed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 4835 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.om.TestOzoneManagerHttpServer | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.om.TestScmChillMode | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.om.TestOzoneManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 89ce7a124744 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 1f47fb7 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/4/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/4/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/4/testReport/ | | Max. process+thread count | 4669 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/4/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 212579) Time Spent: 1h 10m (was: 1h) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=212041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212041 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 12/Mar/19 21:00 Start Date: 12/Mar/19 21:00 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-472179088 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 26 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 56 | Maven dependency ordering for branch | | +1 | mvninstall | 1076 | trunk passed | | -1 | compile | 76 | hadoop-ozone in trunk failed. | | +1 | checkstyle | 24 | trunk passed | | -1 | mvnsite | 26 | ozone-manager in trunk failed. | | -1 | mvnsite | 29 | integration-test in trunk failed. | | +1 | shadedclient | 732 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 22 | ozone-manager in trunk failed. | | +1 | javadoc | 68 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 10 | Maven dependency ordering for patch | | -1 | mvninstall | 25 | integration-test in the patch failed. | | -1 | compile | 75 | hadoop-ozone in the patch failed. | | -1 | cc | 75 | hadoop-ozone in the patch failed. | | -1 | javac | 75 | hadoop-ozone in the patch failed. | | +1 | checkstyle | 21 | the patch passed | | -1 | mvnsite | 26 | integration-test in the patch failed. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 712 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 105 | the patch passed | | +1 | javadoc | 30 | common in the patch passed. | | +1 | javadoc | 17 | hadoop-ozone_ozone-manager generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | javadoc | 14 | integration-test in the patch passed. | ||| _ Other Tests _ | | +1 | unit | 34 | common in the patch passed. | | -1 | unit | 33 | ozone-manager in the patch failed. | | -1 | unit | 26 | integration-test in the patch failed. | | +1 | asflicense | 27 | The patch does not generate ASF License warnings. | | | | 3533 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.om.TestOzoneManagerHttpServer | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 0225fa412652 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 24793d2 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/3/artifact/out/branch-compile-hadoop-ozone.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/3/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/3/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/3/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/3/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/3/artifact/out/patch-compile-hadoop-ozone.txt | | cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/3/artifact/out/patch-compile-hadoop-ozone.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/3/artifact/out/patch-compile-hadoop-ozone.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/3/artifact/out/patch-mvns
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=212040&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212040 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 12/Mar/19 21:00 Start Date: 12/Mar/19 21:00 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-472178943 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 22 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 65 | Maven dependency ordering for branch | | +1 | mvninstall | 1009 | trunk passed | | -1 | compile | 78 | hadoop-ozone in trunk failed. | | +1 | checkstyle | 29 | trunk passed | | -1 | mvnsite | 30 | ozone-manager in trunk failed. | | -1 | mvnsite | 35 | integration-test in trunk failed. | | +1 | shadedclient | 799 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 24 | ozone-manager in trunk failed. | | +1 | javadoc | 86 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | -1 | mvninstall | 24 | integration-test in the patch failed. | | -1 | compile | 70 | hadoop-ozone in the patch failed. | | -1 | cc | 70 | hadoop-ozone in the patch failed. | | -1 | javac | 70 | hadoop-ozone in the patch failed. | | +1 | checkstyle | 23 | the patch passed | | -1 | mvnsite | 26 | integration-test in the patch failed. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 736 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 107 | the patch passed | | +1 | javadoc | 35 | common in the patch passed. | | +1 | javadoc | 21 | hadoop-ozone_ozone-manager generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 | javadoc | 19 | integration-test in the patch passed. | ||| _ Other Tests _ | | +1 | unit | 38 | common in the patch passed. | | -1 | unit | 36 | ozone-manager in the patch failed. | | -1 | unit | 28 | integration-test in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 3642 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.om.TestOzoneManagerHttpServer | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 1ceb0eb4745b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 24793d2 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/2/artifact/out/branch-compile-hadoop-ozone.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/2/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/2/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/2/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/2/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/2/artifact/out/patch-compile-hadoop-ozone.txt | | cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/2/artifact/out/patch-compile-hadoop-ozone.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/2/artifact/out/patch-compile-hadoop-ozone.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/2/artifact/out/patch-mvnsi
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=211996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211996 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 12/Mar/19 19:59 Start Date: 12/Mar/19 19:59 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on pull request #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#discussion_r264858772 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java ## @@ -216,6 +216,24 @@ public static boolean isReadOnly( } } + /** + * Return true for the requests which does not need to call SCM via ratis. + * Review comment: Done. Thank You @mukul1987 for the suggestion, moved the newly added code to startTransaction. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 211996) Time Spent: 40m (was: 0.5h) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=211560&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211560 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 12/Mar/19 07:52 Start Date: 12/Mar/19 07:52 Worklog Time Spent: 10m Work Description: mukul1987 commented on pull request #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#discussion_r264554046 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java ## @@ -216,6 +216,24 @@ public static boolean isReadOnly( } } + /** + * Return true for the requests which does not need to call SCM via ratis. + * Review comment: The allocate block call request, can be processed as part of StartTransaction inside Ratis's State Machine. This call is only processed on the leader and not on followers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 211560) Time Spent: 0.5h (was: 20m) > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=211543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211543 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 12/Mar/19 07:07 Start Date: 12/Mar/19 07:07 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591#issuecomment-471882322 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 56 | Maven dependency ordering for branch | | +1 | mvninstall | 1109 | trunk passed | | -1 | compile | 38 | hadoop-ozone in trunk failed. | | +1 | checkstyle | 28 | trunk passed | | +1 | mvnsite | 102 | trunk passed | | +1 | shadedclient | 851 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 96 | trunk passed | | +1 | javadoc | 73 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for patch | | +1 | mvninstall | 97 | the patch passed | | -1 | compile | 32 | hadoop-ozone in the patch failed. | | -1 | cc | 32 | hadoop-ozone in the patch failed. | | -1 | javac | 32 | hadoop-ozone in the patch failed. | | -0 | checkstyle | 20 | hadoop-ozone: The patch generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0) | | +1 | mvnsite | 80 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 807 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 107 | the patch passed | | +1 | javadoc | 65 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 36 | common in the patch passed. | | -1 | unit | 43 | ozone-manager in the patch failed. | | -1 | unit | 824 | integration-test in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 4572 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.om.TestOzoneManagerHttpServer | | | hadoop.ozone.client.rpc.TestFailureHandlingByClient | | | hadoop.ozone.om.TestScmChillMode | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.om.TestOzoneManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-591/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/591 | | JIRA Issue | HDDS-1250 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 0ee0e0a8059c 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / c730786 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/1/artifact/out/branch-compile-hadoop-ozone.txt | | findbugs | v3.1.0-RC1 | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/1/artifact/out/patch-compile-hadoop-ozone.txt | | cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/1/artifact/out/patch-compile-hadoop-ozone.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/1/artifact/out/patch-compile-hadoop-ozone.txt | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/1/artifact/out/diff-checkstyle-hadoop-ozone.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/1/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-591/1/testReport/ | | Max. process+thread count | 4133 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-
[jira] [Work logged] (HDDS-1250) In OM HA AllocateBlock call where connecting to SCM from OM should not happen on Ratis
[ https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=211532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211532 ] ASF GitHub Bot logged work on HDDS-1250: Author: ASF GitHub Bot Created on: 12/Mar/19 05:50 Start Date: 12/Mar/19 05:50 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on pull request #591: HDDS-1250: Initial patch with the proposed fix. URL: https://github.com/apache/hadoop/pull/591 Still, need to add UT's. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 211532) Time Spent: 10m Remaining Estimate: 0h > In OM HA AllocateBlock call where connecting to SCM from OM should not happen > on Ratis > -- > > Key: HDDS-1250 > URL: https://issues.apache.org/jira/browse/HDDS-1250 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > In OM HA, currently when allocateBlock is called, in applyTransaction() on > all OM nodes, we make a call to SCM and write the allocateBlock information > into OM DB. The problem with this is, every OM allocateBlock and appends new > BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's > should have the same block information for a key, even though eventually this > might be changed during key commit) > > The proposed approach is: > 1. Calling SCM for allocation of block will happen outside of ratis, and this > block information is passed and writing to DB will happen via Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
