[jira] [Work logged] (HDFS-16230) Minor bug in TestStorageRestore

2021-09-17 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652530
 ]

ASF GitHub Bot logged work on HDFS-16230:
-

Author: ASF GitHub Bot
Created on: 18/Sep/21 03:53
Start Date: 18/Sep/21 03:53
Worklog Time Spent: 10m 
  Work Description: thomasleplus opened a new pull request #3455:
URL: https://github.com/apache/hadoop/pull/3455


   Strings being immutable, you need to use the trim() method return value.
   
   ### Description of PR
   
   Minor bug in TestStorageRestore.
   
   ### How was this patch tested?
   
   Issue is trivial.
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 652530)
Remaining Estimate: 0h
Time Spent: 10m

> Minor bug in TestStorageRestore
> ---
>
> Key: HDFS-16230
> URL: https://issues.apache.org/jira/browse/HDFS-16230
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: test
>Reporter: Thomas Leplus
>Priority: Trivial
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Strings being immutable, you need to use the trim() method return value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-16230) Minor bug in TestStorageRestore

2021-09-17 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652553&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652553
 ]

ASF GitHub Bot logged work on HDFS-16230:
-

Author: ASF GitHub Bot
Created on: 18/Sep/21 06:41
Start Date: 18/Sep/21 06:41
Worklog Time Spent: 10m 
  Work Description: ayushtkn commented on a change in pull request #3455:
URL: https://github.com/apache/hadoop/pull/3455#discussion_r711520715



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java
##
@@ -294,7 +294,7 @@ public void testDfsAdminCmd() throws Exception {
   restore = fsi.getStorage().getRestoreFailedStorage();
   assertTrue("After check call restore is " + restore, restore);
   String commandOutput = cmdResult.getCommandOutput();
-  commandOutput.trim();
+  commandOutput = commandOutput.trim();
   assertTrue(commandOutput.contains("restoreFailedStorage is set to 
true"));

Review comment:
   I think we can remove ``commandOutput.trim();`` itself. The 
``assertTrue`` is anyway checking ``contains`` which will pass irrespective of 
this ``trim``




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 652553)
Time Spent: 20m  (was: 10m)

> Minor bug in TestStorageRestore
> ---
>
> Key: HDFS-16230
> URL: https://issues.apache.org/jira/browse/HDFS-16230
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: test
>Reporter: Thomas Leplus
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Strings being immutable, you need to use the trim() method return value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-16230) Minor bug in TestStorageRestore

2021-09-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652578
 ]

ASF GitHub Bot logged work on HDFS-16230:
-

Author: ASF GitHub Bot
Created on: 18/Sep/21 09:17
Start Date: 18/Sep/21 09:17
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #3455:
URL: https://github.com/apache/hadoop/pull/3455#issuecomment-922246612


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 46s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  31m 52s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 24s |  |  trunk passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  compile  |   1m 15s |  |  trunk passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 22s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 56s |  |  trunk passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 24s |  |  trunk passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  spotbugs  |   3m  8s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  21m 28s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 14s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 15s |  |  the patch passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javac  |   1m 15s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  8s |  |  the patch passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  javac  |   1m  8s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 50s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 46s |  |  the patch passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 19s |  |  the patch passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  spotbugs  |   3m  5s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  20m 49s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 226m 53s |  |  hadoop-hdfs in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 45s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 321m 55s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3455/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3455 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell |
   | uname | Linux 4d4abcd5db1c 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 
23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 6189a8e38d2f0b6ab340b0e4a76a27da362f013e |
   | Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3455/1/testReport/ |
   | Max. process+thread count | 2942 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3455/1/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
   
   
   This 

[jira] [Work logged] (HDFS-16230) Minor bug in TestStorageRestore

2021-09-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652645&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652645
 ]

ASF GitHub Bot logged work on HDFS-16230:
-

Author: ASF GitHub Bot
Created on: 18/Sep/21 18:04
Start Date: 18/Sep/21 18:04
Worklog Time Spent: 10m 
  Work Description: thomasleplus commented on a change in pull request 
#3455:
URL: https://github.com/apache/hadoop/pull/3455#discussion_r711621922



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java
##
@@ -294,7 +294,7 @@ public void testDfsAdminCmd() throws Exception {
   restore = fsi.getStorage().getRestoreFailedStorage();
   assertTrue("After check call restore is " + restore, restore);
   String commandOutput = cmdResult.getCommandOutput();
-  commandOutput.trim();
+  commandOutput = commandOutput.trim();
   assertTrue(commandOutput.contains("restoreFailedStorage is set to 
true"));

Review comment:
   Indeed. Now I realize that deleting my forked repo rather hastily was a 
mistake :( I've tried various ways to edit this PR branch but didn't succeed. 
It seems that it leaves us with two options: either I close this PR and open a 
new one, or someone with the right permissions edit it. Let me know what you 
think is best. Sorry for the inconvenience.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 652645)
Time Spent: 40m  (was: 0.5h)

> Minor bug in TestStorageRestore
> ---
>
> Key: HDFS-16230
> URL: https://issues.apache.org/jira/browse/HDFS-16230
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: test
>Reporter: Thomas Leplus
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Strings being immutable, you need to use the trim() method return value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-16230) Minor bug in TestStorageRestore

2021-09-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652648&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652648
 ]

ASF GitHub Bot logged work on HDFS-16230:
-

Author: ASF GitHub Bot
Created on: 18/Sep/21 18:27
Start Date: 18/Sep/21 18:27
Worklog Time Spent: 10m 
  Work Description: ayushtkn commented on a change in pull request #3455:
URL: https://github.com/apache/hadoop/pull/3455#discussion_r711624343



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java
##
@@ -294,7 +294,7 @@ public void testDfsAdminCmd() throws Exception {
   restore = fsi.getStorage().getRestoreFailedStorage();
   assertTrue("After check call restore is " + restore, restore);
   String commandOutput = cmdResult.getCommandOutput();
-  commandOutput.trim();
+  commandOutput = commandOutput.trim();
   assertTrue(commandOutput.contains("restoreFailedStorage is set to 
true"));

Review comment:
   See, if you can restore the repository
   
https://docs.github.com/en/repositories/creating-and-managing-repositories/restoring-a-deleted-repository




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 652648)
Time Spent: 50m  (was: 40m)

> Minor bug in TestStorageRestore
> ---
>
> Key: HDFS-16230
> URL: https://issues.apache.org/jira/browse/HDFS-16230
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: test
>Reporter: Thomas Leplus
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Strings being immutable, you need to use the trim() method return value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-16230) Minor bug in TestStorageRestore

2021-09-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652649&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652649
 ]

ASF GitHub Bot logged work on HDFS-16230:
-

Author: ASF GitHub Bot
Created on: 18/Sep/21 18:43
Start Date: 18/Sep/21 18:43
Worklog Time Spent: 10m 
  Work Description: thomasleplus commented on a change in pull request 
#3455:
URL: https://github.com/apache/hadoop/pull/3455#discussion_r711626143



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java
##
@@ -294,7 +294,7 @@ public void testDfsAdminCmd() throws Exception {
   restore = fsi.getStorage().getRestoreFailedStorage();
   assertTrue("After check call restore is " + restore, restore);
   String commandOutput = cmdResult.getCommandOutput();
-  commandOutput.trim();
+  commandOutput = commandOutput.trim();
   assertTrue(commandOutput.contains("restoreFailedStorage is set to 
true"));

Review comment:
   It says I have to ask GitHub support to restore a forked repo. I've 
created a ticket to request that, let's see if they can help. Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 652649)
Time Spent: 1h  (was: 50m)

> Minor bug in TestStorageRestore
> ---
>
> Key: HDFS-16230
> URL: https://issues.apache.org/jira/browse/HDFS-16230
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: test
>Reporter: Thomas Leplus
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Strings being immutable, you need to use the trim() method return value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-16230) Minor bug in TestStorageRestore

2021-09-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652651&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652651
 ]

ASF GitHub Bot logged work on HDFS-16230:
-

Author: ASF GitHub Bot
Created on: 18/Sep/21 18:56
Start Date: 18/Sep/21 18:56
Worklog Time Spent: 10m 
  Work Description: ayushtkn commented on a change in pull request #3455:
URL: https://github.com/apache/hadoop/pull/3455#discussion_r711627442



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java
##
@@ -294,7 +294,7 @@ public void testDfsAdminCmd() throws Exception {
   restore = fsi.getStorage().getRestoreFailedStorage();
   assertTrue("After check call restore is " + restore, restore);
   String commandOutput = cmdResult.getCommandOutput();
-  commandOutput.trim();
+  commandOutput = commandOutput.trim();
   assertTrue(commandOutput.contains("restoreFailedStorage is set to 
true"));

Review comment:
   Your repo seems back
   https://github.com/thomasleplus/hadoop/tree/patch-1




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 652651)
Time Spent: 1h 10m  (was: 1h)

> Minor bug in TestStorageRestore
> ---
>
> Key: HDFS-16230
> URL: https://issues.apache.org/jira/browse/HDFS-16230
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: test
>Reporter: Thomas Leplus
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Strings being immutable, you need to use the trim() method return value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-16230) Minor bug in TestStorageRestore

2021-09-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652652&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652652
 ]

ASF GitHub Bot logged work on HDFS-16230:
-

Author: ASF GitHub Bot
Created on: 18/Sep/21 18:59
Start Date: 18/Sep/21 18:59
Worklog Time Spent: 10m 
  Work Description: thomasleplus commented on a change in pull request 
#3455:
URL: https://github.com/apache/hadoop/pull/3455#discussion_r711627758



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java
##
@@ -294,7 +294,7 @@ public void testDfsAdminCmd() throws Exception {
   restore = fsi.getStorage().getRestoreFailedStorage();
   assertTrue("After check call restore is " + restore, restore);
   String commandOutput = cmdResult.getCommandOutput();
-  commandOutput.trim();
+  commandOutput = commandOutput.trim();
   assertTrue(commandOutput.contains("restoreFailedStorage is set to 
true"));

Review comment:
   Yes, they are quick!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 652652)
Time Spent: 1h 20m  (was: 1h 10m)

> Minor bug in TestStorageRestore
> ---
>
> Key: HDFS-16230
> URL: https://issues.apache.org/jira/browse/HDFS-16230
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: test
>Reporter: Thomas Leplus
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Strings being immutable, you need to use the trim() method return value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-16230) Minor bug in TestStorageRestore

2021-09-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652653&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652653
 ]

ASF GitHub Bot logged work on HDFS-16230:
-

Author: ASF GitHub Bot
Created on: 18/Sep/21 19:05
Start Date: 18/Sep/21 19:05
Worklog Time Spent: 10m 
  Work Description: thomasleplus commented on a change in pull request 
#3455:
URL: https://github.com/apache/hadoop/pull/3455#discussion_r711628321



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java
##
@@ -294,7 +294,7 @@ public void testDfsAdminCmd() throws Exception {
   restore = fsi.getStorage().getRestoreFailedStorage();
   assertTrue("After check call restore is " + restore, restore);
   String commandOutput = cmdResult.getCommandOutput();
-  commandOutput.trim();
+  commandOutput = commandOutput.trim();
   assertTrue(commandOutput.contains("restoreFailedStorage is set to 
true"));

Review comment:
   I pushed the change as requested. Thanks for your patience.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 652653)
Time Spent: 1.5h  (was: 1h 20m)

> Minor bug in TestStorageRestore
> ---
>
> Key: HDFS-16230
> URL: https://issues.apache.org/jira/browse/HDFS-16230
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: test
>Reporter: Thomas Leplus
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Strings being immutable, you need to use the trim() method return value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-16230) Minor bug in TestStorageRestore

2021-09-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652668
 ]

ASF GitHub Bot logged work on HDFS-16230:
-

Author: ASF GitHub Bot
Created on: 19/Sep/21 00:25
Start Date: 19/Sep/21 00:25
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #3455:
URL: https://github.com/apache/hadoop/pull/3455#issuecomment-922393572


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 52s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  31m 43s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 22s |  |  trunk passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  compile  |   1m 14s |  |  trunk passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  checkstyle  |   1m  0s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 23s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 57s |  |  trunk passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 30s |  |  trunk passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  spotbugs  |   3m 10s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  21m 25s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 12s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 14s |  |  the patch passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javac  |   1m 14s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  7s |  |  the patch passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  javac  |   1m  7s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 51s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 15s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 46s |  |  the patch passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 19s |  |  the patch passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  spotbugs  |   3m 10s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  21m  6s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 227m 10s |  |  hadoop-hdfs in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 45s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 322m 34s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3455/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3455 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell |
   | uname | Linux cee30baef7a2 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 
23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / ae46a1a5c9afa6306f688f3dd8ac143278d5e0d5 |
   | Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3455/2/testReport/ |
   | Max. process+thread count | 2848 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3455/2/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
   
   
   This