[jira] [Work logged] (HDFS-16658) BlockManager should output some logs when logEveryBlock is true.
[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=795962=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795962
]
ASF GitHub Bot logged work on HDFS-16658:
-
Author: ASF GitHub Bot
Created on: 28/Jul/22 07:31
Start Date: 28/Jul/22 07:31
Worklog Time Spent: 10m
Work Description: Hexiaoqiao commented on PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#issuecomment-1197772469
Committed to trunk. Thanks @ZanderXu for your contributions. Thanks
@slfan1989 for your comments.
Issue Time Tracking
---
Worklog Id: (was: 795962)
Time Spent: 1.5h (was: 1h 20m)
> BlockManager should output some logs when logEveryBlock is true.
>
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: ZanderXu
>Assignee: ZanderXu
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
>final Block reportedBlock,
>DatanodeStorageInfo storageInfo,
>DatanodeDescriptor delNodeHint,
>boolean logEveryBlock)
> throws IOException {
>
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16658) BlockManager should output some logs when logEveryBlock is true.
[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=795961=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795961
]
ASF GitHub Bot logged work on HDFS-16658:
-
Author: ASF GitHub Bot
Created on: 28/Jul/22 07:30
Start Date: 28/Jul/22 07:30
Worklog Time Spent: 10m
Work Description: Hexiaoqiao merged PR #4559:
URL: https://github.com/apache/hadoop/pull/4559
Issue Time Tracking
---
Worklog Id: (was: 795961)
Time Spent: 1h 20m (was: 1h 10m)
> BlockManager should output some logs when logEveryBlock is true.
>
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: ZanderXu
>Assignee: ZanderXu
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
>final Block reportedBlock,
>DatanodeStorageInfo storageInfo,
>DatanodeDescriptor delNodeHint,
>boolean logEveryBlock)
> throws IOException {
>
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16658) BlockManager should output some logs when logEveryBlock is true.
[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=795938=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795938
]
ASF GitHub Bot logged work on HDFS-16658:
-
Author: ASF GitHub Bot
Created on: 28/Jul/22 05:35
Start Date: 28/Jul/22 05:35
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#issuecomment-1197684967
> The log size is controllable because `logEveryBlock` will control it. And
although it's a block-level log, it only printed the log when the replica of
the block is changed.
>
> Maybe we should think about its use. This log is very helpful for us to
locate some abnormal case about replica of block, such as complete failure,
missing block, etc...
Thanks for your explanation, I understand your changes.
Issue Time Tracking
---
Worklog Id: (was: 795938)
Time Spent: 1h 10m (was: 1h)
> BlockManager should output some logs when logEveryBlock is true.
>
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: ZanderXu
>Assignee: ZanderXu
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
>final Block reportedBlock,
>DatanodeStorageInfo storageInfo,
>DatanodeDescriptor delNodeHint,
>boolean logEveryBlock)
> throws IOException {
>
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16658) BlockManager should output some logs when logEveryBlock is true.
[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=795172=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795172
]
ASF GitHub Bot logged work on HDFS-16658:
-
Author: ASF GitHub Bot
Created on: 26/Jul/22 08:28
Start Date: 26/Jul/22 08:28
Worklog Time Spent: 10m
Work Description: ZanderXu commented on PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#issuecomment-1195172042
Thanks @slfan1989 for your review.
> This command can temporarily modify the log level.
This command can change the log level of the logger. But it will print all
debug log of the logger.
> If you directly modify the log level, will the log size be very large,
after all, this is a block-level log?
The log size is controllable because `logEveryBlock` will control it. And
although it's a block-level log, it only printed the log when the replica of
the block is changed.
Maybe we should think about its use. This log is very helpful for us to
locate some abnormal case about block-level of block, such as complete failure,
missing block, etc...
Issue Time Tracking
---
Worklog Id: (was: 795172)
Time Spent: 1h (was: 50m)
> BlockManager should output some logs when logEveryBlock is true.
>
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: ZanderXu
>Assignee: ZanderXu
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
>final Block reportedBlock,
>DatanodeStorageInfo storageInfo,
>DatanodeDescriptor delNodeHint,
>boolean logEveryBlock)
> throws IOException {
>
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16658) BlockManager should output some logs when logEveryBlock is true.
[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=795145=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795145
]
ASF GitHub Bot logged work on HDFS-16658:
-
Author: ASF GitHub Bot
Created on: 26/Jul/22 06:51
Start Date: 26/Jul/22 06:51
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#issuecomment-1195078382
@ZanderXu Thank you for your contribution, pr looks good, but I want to know
if it can be solved using dynamic debug log?
I remember that hadoop provides a switch that can directly open the debug
log. This command can temporarily modify the log level.
```
hadoop daemonlog --setlevel
```
If you directly modify the log level, will the log size be very large, after
all, this is a block-level log?
Issue Time Tracking
---
Worklog Id: (was: 795145)
Time Spent: 50m (was: 40m)
> BlockManager should output some logs when logEveryBlock is true.
>
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: ZanderXu
>Assignee: ZanderXu
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
>final Block reportedBlock,
>DatanodeStorageInfo storageInfo,
>DatanodeDescriptor delNodeHint,
>boolean logEveryBlock)
> throws IOException {
>
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16658) BlockManager should output some logs when logEveryBlock is true.
[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=794585=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794585
]
ASF GitHub Bot logged work on HDFS-16658:
-
Author: ASF GitHub Bot
Created on: 24/Jul/22 01:55
Start Date: 24/Jul/22 01:55
Worklog Time Spent: 10m
Work Description: ZanderXu commented on code in PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#discussion_r928183934
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##
@@ -3607,7 +3607,7 @@ private Block addStoredBlock(final BlockInfo block,
curReplicaDelta =
(node.isDecommissioned() || node.isDecommissionInProgress()) ? 0 : 1;
if (logEveryBlock) {
-blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
+blockLog.info("BLOCK* addStoredBlock: {} is added to {} (size={})",
Review Comment:
Thanks @Hexiaoqiao for your review. We have released it in our prod
environment and it works well.
`logEveryBlock=true` means that we should output some logs about this block.
And I have checked the callers and they are expected.
Issue Time Tracking
---
Worklog Id: (was: 794585)
Time Spent: 40m (was: 0.5h)
> BlockManager should output some logs when logEveryBlock is true.
>
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: ZanderXu
>Assignee: ZanderXu
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
>final Block reportedBlock,
>DatanodeStorageInfo storageInfo,
>DatanodeDescriptor delNodeHint,
>boolean logEveryBlock)
> throws IOException {
>
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16658) BlockManager should output some logs when logEveryBlock is true.
[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=791388=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-791388
]
ASF GitHub Bot logged work on HDFS-16658:
-
Author: ASF GitHub Bot
Created on: 15/Jul/22 12:39
Start Date: 15/Jul/22 12:39
Worklog Time Spent: 10m
Work Description: Hexiaoqiao commented on code in PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#discussion_r922125850
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##
@@ -3607,7 +3607,7 @@ private Block addStoredBlock(final BlockInfo block,
curReplicaDelta =
(node.isDecommissioned() || node.isDecommissionInProgress()) ? 0 : 1;
if (logEveryBlock) {
-blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
+blockLog.info("BLOCK* addStoredBlock: {} is added to {} (size={})",
Review Comment:
+1. Please double check if it could flood general log in some corner case.
Issue Time Tracking
---
Worklog Id: (was: 791388)
Time Spent: 0.5h (was: 20m)
> BlockManager should output some logs when logEveryBlock is true.
>
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: ZanderXu
>Assignee: ZanderXu
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
>final Block reportedBlock,
>DatanodeStorageInfo storageInfo,
>DatanodeDescriptor delNodeHint,
>boolean logEveryBlock)
> throws IOException {
>
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16658) BlockManager should output some logs when logEveryBlock is true.
[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=790602=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790602
]
ASF GitHub Bot logged work on HDFS-16658:
-
Author: ASF GitHub Bot
Created on: 13/Jul/22 21:10
Start Date: 13/Jul/22 21:10
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#issuecomment-1183681965
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 40m 25s | | trunk passed |
| +1 :green_heart: | compile | 1m 43s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 1m 34s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 20s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 39s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 20s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 42s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 54s | | trunk passed |
| +1 :green_heart: | shadedclient | 26m 17s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 25s | | the patch passed |
| +1 :green_heart: | compile | 1m 36s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 1m 36s | | the patch passed |
| +1 :green_heart: | compile | 1m 29s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 1m 29s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 5s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 31s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 1s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 32s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 44s | | the patch passed |
| +1 :green_heart: | shadedclient | 27m 8s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 368m 59s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 0s | | The patch does not
generate ASF License warnings. |
| | | 488m 44s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4559/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4559 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux d9839405a066 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8
19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / e1406fa52587a55dfd446a4e639ff8972bc1776b |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4559/1/testReport/ |
| Max. process+thread count | 2036 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
[jira] [Work logged] (HDFS-16658) BlockManager should output some logs when logEveryBlock is true.
[
https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=790418=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790418
]
ASF GitHub Bot logged work on HDFS-16658:
-
Author: ASF GitHub Bot
Created on: 13/Jul/22 13:00
Start Date: 13/Jul/22 13:00
Worklog Time Spent: 10m
Work Description: ZanderXu opened a new pull request, #4559:
URL: https://github.com/apache/hadoop/pull/4559
### Description of PR
During locating some abnormal cases about block replication in our prod
environment, I found that BlockManager does not out put some logs in
`addStoredBlock` even though `logEveryBlock` is true.
I feel that we need to change the log level from DEBUG to INFO when
`logEveryBlock` is true. So that we can more easily locate some abnormal cases.
```
private Block addStoredBlock(final BlockInfo block,
final Block reportedBlock,
DatanodeStorageInfo storageInfo,
DatanodeDescriptor delNodeHint,
boolean logEveryBlock)
throws IOException {
if (logEveryBlock) {
blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
node, storedBlock, storedBlock.getNumBytes());
}
...
}
```
Issue Time Tracking
---
Worklog Id: (was: 790418)
Remaining Estimate: 0h
Time Spent: 10m
> BlockManager should output some logs when logEveryBlock is true.
>
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: ZanderXu
>Assignee: ZanderXu
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
>final Block reportedBlock,
>DatanodeStorageInfo storageInfo,
>DatanodeDescriptor delNodeHint,
>boolean logEveryBlock)
> throws IOException {
>
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
