[jira] [Commented] (HDFS-1611) Some logical issues need to address.
[
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022499#comment-13022499
]
Hudson commented on HDFS-1611:
--
Integrated in Hadoop-Hdfs-trunk #643 (See
[https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/])
Some logical issues need to address.
Key: HDFS-1611
URL: https://issues.apache.org/jira/browse/HDFS-1611
Project: Hadoop HDFS
Issue Type: Bug
Components: hdfs client, name-node
Affects Versions: 0.20.1, 0.20.2
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
Priority: Minor
Fix For: 0.23.0
Attachments: HDFS-1611.1.patch, HDFS-1611.patch
Title: Some code level logical issues.
Description:
1. DFSClient:
Consider the below case, if we enable only info, then below log will never
be logged.
if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
ClientDatanodeProtocol.LOG.info(ClientDatanodeProtocol addr= + addr);
}
2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
catch (NotCompliantMBeanException e) {
e.printStackTrace();
}
We can avoid using stackTace(). Better to add log message.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1611) Some logical issues need to address.
[
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13013804#comment-13013804
]
Hudson commented on HDFS-1611:
--
Integrated in Hadoop-Hdfs-trunk-Commit #582 (See
[https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/582/])
HDFS-1611. Fix up some log messages in DFSClient and MBean registration.
Contributed by Uma Maheswara Rao G.
Some logical issues need to address.
Key: HDFS-1611
URL: https://issues.apache.org/jira/browse/HDFS-1611
Project: Hadoop HDFS
Issue Type: Bug
Components: hdfs client, name-node
Affects Versions: 0.20.1, 0.20.2
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
Priority: Minor
Fix For: 0.23.0
Attachments: HDFS-1611.1.patch, HDFS-1611.patch
Title: Some code level logical issues.
Description:
1. DFSClient:
Consider the below case, if we enable only info, then below log will never
be logged.
if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
ClientDatanodeProtocol.LOG.info(ClientDatanodeProtocol addr= + addr);
}
2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
catch (NotCompliantMBeanException e) {
e.printStackTrace();
}
We can avoid using stackTace(). Better to add log message.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1611) Some logical issues need to address.
[
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003247#comment-13003247
]
Todd Lipcon commented on HDFS-1611:
---
For the log message for ClientDatanodeProtocol, I think it's better to change
the log to Debug level, rather than change the guard. It's not that useful of a
log message to be set at INFO level.
Some logical issues need to address.
Key: HDFS-1611
URL: https://issues.apache.org/jira/browse/HDFS-1611
Project: Hadoop HDFS
Issue Type: Bug
Components: hdfs client, name-node
Affects Versions: 0.20.1, 0.20.2
Reporter: Uma Maheswara Rao G
Priority: Minor
Attachments: HDFS-1611.patch
Title: Some code level logical issues.
Description:
1. DFSClient:
Consider the below case, if we enable only info, then below log will never
be logged.
if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
ClientDatanodeProtocol.LOG.info(ClientDatanodeProtocol addr= + addr);
}
2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
catch (NotCompliantMBeanException e) {
e.printStackTrace();
}
We can avoid using stackTace(). Better to add log message.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1611) Some logical issues need to address.
[
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13002653#comment-13002653
]
Uma Maheswara Rao G commented on HDFS-1611:
---
Verification Result:
For ths changes tests not required.
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
(version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test
framework compile.
Tests are not required for this changes.That is the reason for -1.
Some logical issues need to address.
Key: HDFS-1611
URL: https://issues.apache.org/jira/browse/HDFS-1611
Project: Hadoop HDFS
Issue Type: Bug
Components: hdfs client, name-node
Affects Versions: 0.20.1, 0.20.2
Reporter: Uma Maheswara Rao G
Priority: Minor
Attachments: HDFS-1611.patch
Title: Some code level logical issues.
Description:
1. DFSClient:
Consider the below case, if we enable only info, then below log will never
be logged.
if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
ClientDatanodeProtocol.LOG.info(ClientDatanodeProtocol addr= + addr);
}
2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
catch (NotCompliantMBeanException e) {
e.printStackTrace();
}
We can avoid using stackTace(). Better to add log message.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1611) Some logical issues need to address.
[
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13002693#comment-13002693
]
Hadoop QA commented on HDFS-1611:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12472668/HDFS-1611.patch
against trunk revision 1076696.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestFileConcurrentReader
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//console
This message is automatically generated.
Some logical issues need to address.
Key: HDFS-1611
URL: https://issues.apache.org/jira/browse/HDFS-1611
Project: Hadoop HDFS
Issue Type: Bug
Components: hdfs client, name-node
Affects Versions: 0.20.1, 0.20.2
Reporter: Uma Maheswara Rao G
Priority: Minor
Attachments: HDFS-1611.patch
Title: Some code level logical issues.
Description:
1. DFSClient:
Consider the below case, if we enable only info, then below log will never
be logged.
if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
ClientDatanodeProtocol.LOG.info(ClientDatanodeProtocol addr= + addr);
}
2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
catch (NotCompliantMBeanException e) {
e.printStackTrace();
}
We can avoid using stackTace(). Better to add log message.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
