[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885902#action_12885902
]
Steve Loughran commented on HDFS-884:
-
I have a more up to date version on my local git-managed SCM, I will chase it
down and post, though probably not until august, as I'm about to go on vacation
with no laptop for two weeks
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976142#action_12976142
]
Eli Collins commented on HDFS-884:
--
+1 latest patch looks good.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976177#action_12976177
]
Hadoop QA commented on HDFS-884:
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12467196/InvalidDirs.patch
against trunk revision 1053214.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.common.TestDistributedUpgrade
org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
org.apache.hadoop.hdfs.TestDatanodeConfig
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestHDFSTrash
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/62//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/62//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/62//console
This message is automatically generated.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979538#action_12979538
]
Steve Loughran commented on HDFS-884:
-
looks good, though I'm not sure we need the assert statement given that the
constructor does the same check and includes the list of invalid dirs. All the
assert will do is fail early on assert enabled (test) runs, so reducing
coverage of the constructor itself.
This patch will obsolete HDFS-890, which didn't have any code associated with
it anyway.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch,
> InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979817#action_12979817
]
Nigel Daley commented on HDFS-884:
--
>From the patch:
{code}
+try {
+ dn = DataNode.createDataNode(new String[]{}, conf);
+} catch(IOException e) {
+ // expecting exception here
+}
+if(dn != null) dn.shutdown();
{code}
Shouldn't there be a fail() call after the dn assignment line?
If you're updating patch then dn.shutdown() should be on it's own line.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch,
> InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980297#action_12980297
]
Hadoop QA commented on HDFS-884:
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12467853/InvalidDirs.patch
against trunk revision 1056206.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
-1 contrib tests. The patch failed contrib unit tests.
-1 system test framework. The patch failed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/94//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/94//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/94//console
This message is automatically generated.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch,
> InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981024#action_12981024
]
Nigel Daley commented on HDFS-884:
--
Konstantin, if you're trying to kick a new patch build for this you now longer
move it to "Open" and back to "Patch Available". Instead, you must upload a
new patch. Or, if you have permission, you can kick
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/ and enter the issue
number.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch,
> InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981032#action_12981032
]
Jakob Homan commented on HDFS-884:
--
bq, Konstantin, if you're trying to kick a new patch build for this you now
longer move it to "Open" and back to "Patch Available". Instead, you must
upload a new patch.
That makes me sad. Is this a new feature or regression?
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch,
> InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981060#action_12981060
]
Konstantin Shvachko commented on HDFS-884:
--
N> Shouldn't there be a fail() call after the dn assignment line?
See the next line
{code}assertNull("Data-node startup should have failed.", dn);{code}
This will fail the test if the DN starts.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch,
> InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981092#action_12981092
]
Hadoop QA commented on HDFS-884:
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12468207/InvalidDirs.patch
against trunk revision 1057414.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/102//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/102//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/102//console
This message is automatically generated.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch,
> InvalidDirs.patch, InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981212#action_12981212
]
Steve Loughran commented on HDFS-884:
-
no need to thank me, all I provided was a deployment where none of the
directories were valid :)
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch,
> InvalidDirs.patch, InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022448#comment-13022448
]
Hudson commented on HDFS-884:
-
Integrated in Hadoop-Hdfs-trunk #643 (See
[https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/])
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch,
> InvalidDirs.patch, InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023008#comment-13023008
]
Hudson commented on HDFS-884:
-
Integrated in Hadoop-Hdfs-22-branch #35 (See
[https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/])
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch, InvalidDirs.patch,
> InvalidDirs.patch, InvalidDirs.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798286#action_12798286
]
Hadoop QA commented on HDFS-884:
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12429770/HDFS-884.patch
against trunk revision 897068.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/177/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/177/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/177/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/177/console
This message is automatically generated.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798408#action_12798408
]
Steve Loughran commented on HDFS-884:
-
HDFS-890 would extend and obsolete this issue/patch, as instead of reporting
problems, makeInstance should raise an exception listing all failing
directories and the reasons, and at least one nested cause.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805060#action_12805060
]
Hadoop QA commented on HDFS-884:
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431420/HDFS-884.patch
against trunk revision 903098.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/206/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/206/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/206/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/206/console
This message is automatically generated.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-884) DataNode makeInstance should report the directory list when failing to start up
[
https://issues.apache.org/jira/browse/HDFS-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805158#action_12805158
]
Steve Loughran commented on HDFS-884:
-
There are no tests here as it is only logged output, and we don't have a test
setup that captures/analyses logs.
> DataNode makeInstance should report the directory list when failing to start
> up
> ---
>
> Key: HDFS-884
> URL: https://issues.apache.org/jira/browse/HDFS-884
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-884.patch, HDFS-884.patch
>
>
> When {{Datanode.makeInstance()}} cannot work with one of the directories in
> dfs.data.dir, it logs this at warn level (while losing the stack trace).
> It should include the nested exception for better troubleshooting. Then, when
> all dirs in the list fail, an exception is thrown, but this exception does
> not include the list of directories. It should list the absolute path of
> every missing/failing directory, so that whoever sees the exception can see
> where to start looking for problems: either the filesystem or the
> configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
