Re: [hibernate-dev] CGLIB
I fixed the bug where field level annotations are swallowed (patch not applied by the CGLIB team though) http://sourceforge.net/tracker/index.php?func=detailaid=2796998group_id=56933atid=482368 But I could not fix the bug where generics information is simply swallowed (not enough internal knowledge). I think we should focus on Javassist. On 12 mai 2010, at 03:14, Steve Ebersole wrote: I thought one of the issues was that cglib does not handle annotations? nbsp;That's a pretty big 'workaround' if that's the case. -- Sent from my Palm Pre st...@hibernate.org http://hibernate.orgOn May 11, 2010 1:06 PM, Strong Liu lt;st...@redhat.comgt; wrote: these are the issues Steve mentioned below: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4703 https://jira.jboss.org/jira/browse/JBPAPP-2971 to be fair, these issues can be workaround, and we already have patches, users who run into these issues can pick up our patch for cglib and rebuild it themselves. On May 11, 2010, at 10:34 PM, Hardy Ferentschik wrote: gt; Is there any advantage of CGLIB over javassist? gt; gt; On Tue, 11 May 2010 16:24:12 +0200, Steve Ebersole lt;st...@hibernate.orggt; gt; wrote: gt; gt;gt; I think the time has come to drop CGLIB support :( It is just becoming gt;gt; near impossible to get them to respond to issues. We even recently sent gt;gt; them 2 patches of major issues and still cannot get them to apply the gt;gt; changes upstream and cut releases. gt;gt; gt;gt; So that leaves us the choice of deprecating CGLIB support and eventually gt;gt; dropping it altogether or forking it. I personally do not want to fork gt;gt; it, mainly because I do not want to have to maintain it. Anyway lets gt;gt; discuss it this week if need be and we'll vote at the meeting monday. gt;gt; gt; gt; ___ gt; hibernate-dev mailing list gt; hibernate-dev@lists.jboss.org gt; https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] CGLIB
that cglib with annotations issue only shows when using cglib to instrument the domain class in compile time. but I'd agree with drop it, actually i'm happy with that :D, cglib issues has taken too much time from us On May 12, 2010, at 4:10 PM, Emmanuel Bernard wrote: I fixed the bug where field level annotations are swallowed (patch not applied by the CGLIB team though) http://sourceforge.net/tracker/index.php?func=detailaid=2796998group_id=56933atid=482368 But I could not fix the bug where generics information is simply swallowed (not enough internal knowledge). I think we should focus on Javassist. On 12 mai 2010, at 03:14, Steve Ebersole wrote: I thought one of the issues was that cglib does not handle annotations? nbsp;That's a pretty big 'workaround' if that's the case. -- Sent from my Palm Pre st...@hibernate.org http://hibernate.orgOn May 11, 2010 1:06 PM, Strong Liu lt;st...@redhat.comgt; wrote: these are the issues Steve mentioned below: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4703 https://jira.jboss.org/jira/browse/JBPAPP-2971 to be fair, these issues can be workaround, and we already have patches, users who run into these issues can pick up our patch for cglib and rebuild it themselves. On May 11, 2010, at 10:34 PM, Hardy Ferentschik wrote: gt; Is there any advantage of CGLIB over javassist? gt; gt; On Tue, 11 May 2010 16:24:12 +0200, Steve Ebersole lt;st...@hibernate.orggt; gt; wrote: gt; gt;gt; I think the time has come to drop CGLIB support :( It is just becoming gt;gt; near impossible to get them to respond to issues. We even recently sent gt;gt; them 2 patches of major issues and still cannot get them to apply the gt;gt; changes upstream and cut releases. gt;gt; gt;gt; So that leaves us the choice of deprecating CGLIB support and eventually gt;gt; dropping it altogether or forking it. I personally do not want to fork gt;gt; it, mainly because I do not want to have to maintain it. Anyway lets gt;gt; discuss it this week if need be and we'll vote at the meeting monday. gt;gt; gt; gt; ___ gt; hibernate-dev mailing list gt; hibernate-dev@lists.jboss.org gt; https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] CGLIB
Seems it is a simple choice after all. Let's just drop it. --Hardy On Wed, 12 May 2010 10:41:38 +0200, Strong Liu st...@redhat.com wrote: that cglib with annotations issue only shows when using cglib to instrument the domain class in compile time. but I'd agree with drop it, actually i'm happy with that :D, cglib issues has taken too much time from us On May 12, 2010, at 4:10 PM, Emmanuel Bernard wrote: I fixed the bug where field level annotations are swallowed (patch not applied by the CGLIB team though) http://sourceforge.net/tracker/index.php?func=detailaid=2796998group_id=56933atid=482368 But I could not fix the bug where generics information is simply swallowed (not enough internal knowledge). I think we should focus on Javassist. On 12 mai 2010, at 03:14, Steve Ebersole wrote: I thought one of the issues was that cglib does not handle annotations? nbsp;That's a pretty big 'workaround' if that's the case. -- Sent from my Palm Pre st...@hibernate.org http://hibernate.orgOn May 11, 2010 1:06 PM, Strong Liu lt;st...@redhat.comgt; wrote: these are the issues Steve mentioned below: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4703 https://jira.jboss.org/jira/browse/JBPAPP-2971 to be fair, these issues can be workaround, and we already have patches, users who run into these issues can pick up our patch for cglib and rebuild it themselves. On May 11, 2010, at 10:34 PM, Hardy Ferentschik wrote: gt; Is there any advantage of CGLIB over javassist? gt; gt; On Tue, 11 May 2010 16:24:12 +0200, Steve Ebersole lt;st...@hibernate.orggt; gt; wrote: gt; gt;gt; I think the time has come to drop CGLIB support :( It is just becoming gt;gt; near impossible to get them to respond to issues. We even recently sent gt;gt; them 2 patches of major issues and still cannot get them to apply the gt;gt; changes upstream and cut releases. gt;gt; gt;gt; So that leaves us the choice of deprecating CGLIB support and eventually gt;gt; dropping it altogether or forking it. I personally do not want to fork gt;gt; it, mainly because I do not want to have to maintain it. Anyway lets gt;gt; discuss it this week if need be and we'll vote at the meeting monday. gt;gt; gt; gt; ___ gt; hibernate-dev mailing list gt; hibernate-dev@lists.jboss.org gt; https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] CGLIB
Is there any advantage of CGLIB over javassist? On Tue, 11 May 2010 16:24:12 +0200, Steve Ebersole st...@hibernate.org wrote: I think the time has come to drop CGLIB support :( It is just becoming near impossible to get them to respond to issues. We even recently sent them 2 patches of major issues and still cannot get them to apply the changes upstream and cut releases. So that leaves us the choice of deprecating CGLIB support and eventually dropping it altogether or forking it. I personally do not want to fork it, mainly because I do not want to have to maintain it. Anyway lets discuss it this week if need be and we'll vote at the meeting monday. ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] CGLIB
these are the issues Steve mentioned below: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4703 https://jira.jboss.org/jira/browse/JBPAPP-2971 to be fair, these issues can be workaround, and we already have patches, users who run into these issues can pick up our patch for cglib and rebuild it themselves. On May 11, 2010, at 10:34 PM, Hardy Ferentschik wrote: Is there any advantage of CGLIB over javassist? On Tue, 11 May 2010 16:24:12 +0200, Steve Ebersole st...@hibernate.org wrote: I think the time has come to drop CGLIB support :( It is just becoming near impossible to get them to respond to issues. We even recently sent them 2 patches of major issues and still cannot get them to apply the changes upstream and cut releases. So that leaves us the choice of deprecating CGLIB support and eventually dropping it altogether or forking it. I personally do not want to fork it, mainly because I do not want to have to maintain it. Anyway lets discuss it this week if need be and we'll vote at the meeting monday. ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] CGLIB
Afaik it simply a matter of what library you might already be using. nbsp;I have heard it or javassist do one thing better or faster, but I have not seen any evidence of that (nor have I tried to quantify). -- Sent from my Palm Pre st...@hibernate.org http://hibernate.orgOn May 11, 2010 9:34 AM, Hardy Ferentschik lt;hibern...@ferentschik.degt; wrote: Is there any advantage of CGLIB over javassist? On Tue, 11 May 2010 16:24:12 +0200, Steve Ebersole lt;st...@hibernate.orggt; wrote: gt; I think the time has come to drop CGLIB support :( It is just becoming gt; near impossible to get them to respond to issues. We even recently sent gt; them 2 patches of major issues and still cannot get them to apply the gt; changes upstream and cut releases. gt; gt; So that leaves us the choice of deprecating CGLIB support and eventually gt; dropping it altogether or forking it. I personally do not want to fork gt; it, mainly because I do not want to have to maintain it. Anyway lets gt; discuss it this week if need be and we'll vote at the meeting monday. gt; ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] CGLIB
I thought one of the issues was that cglib does not handle annotations? nbsp;That's a pretty big 'workaround' if that's the case. -- Sent from my Palm Pre st...@hibernate.org http://hibernate.orgOn May 11, 2010 1:06 PM, Strong Liu lt;st...@redhat.comgt; wrote: these are the issues Steve mentioned below: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4703 https://jira.jboss.org/jira/browse/JBPAPP-2971 to be fair, these issues can be workaround, and we already have patches, users who run into these issues can pick up our patch for cglib and rebuild it themselves. On May 11, 2010, at 10:34 PM, Hardy Ferentschik wrote: gt; Is there any advantage of CGLIB over javassist? gt; gt; On Tue, 11 May 2010 16:24:12 +0200, Steve Ebersole lt;st...@hibernate.orggt; gt; wrote: gt; gt;gt; I think the time has come to drop CGLIB support :( It is just becoming gt;gt; near impossible to get them to respond to issues. We even recently sent gt;gt; them 2 patches of major issues and still cannot get them to apply the gt;gt; changes upstream and cut releases. gt;gt; gt;gt; So that leaves us the choice of deprecating CGLIB support and eventually gt;gt; dropping it altogether or forking it. I personally do not want to fork gt;gt; it, mainly because I do not want to have to maintain it. Anyway lets gt;gt; discuss it this week if need be and we'll vote at the meeting monday. gt;gt; gt; gt; ___ gt; hibernate-dev mailing list gt; hibernate-dev@lists.jboss.org gt; https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] CGLIB
Since it is really ASM for which we are interested in isolation, I guess we would take the cglib-nodep jar which 'bundles' ASM as net.sf.cglib.asm (perhaps via jarjar as well) and run jarjar on that to repackage net.sf.cglib - org.hibernate.cglib (or some-such). Is that your understanding as well? On May 19, 2008, at 3:45 PM, Max Ross wrote: jarjar can be a good option when you're looking to avoid version conflicts. Guice uses this to depend on a specific version of cglib. On Mon, May 19, 2008 at 1:29 PM, Steve Ebersole [EMAIL PROTECTED] wrote: Our (default) dependency on CGLIB is starting to cause problems due to other libraries using newer versions of ASM (3.x) then the released versions of CGLIB use (2.x). We have now been waiting about a year for a new CGLIB release to use these newer ASM APIs. With 3.3 being eminent, we need to rectify this situation. First, I am going to make javassist the default bytecode provider starting with Hibernate 3.3 (http://opensource.atlassian.com/projects/hibernate/browse/HHH-2506 ). Next, we need to decide what to do with CGLIB moving forward. This seems to be a dead project at this point. From my recollection, the source control for CGLIB does in fact have support for ASM 3.x; so one option would be to do a build of it from HEAD. However, none of us are really bytecode gurus, so thats probably not the best option. The only other option I see is to simply deprecate the integration for CGLIB and recommend against its use. Any other options we should explore here? - Steve Ebersole Project Lead http://hibernate.org [EMAIL PROTECTED] ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev - Steve Ebersole Project Lead http://hibernate.org [EMAIL PROTECTED] ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] CGLIB
jarjar http://code.google.com/p/jarjar/ can be a good option when you're looking to avoid version conflicts. Guice uses this to depend on a specific version of cglib. On Mon, May 19, 2008 at 1:29 PM, Steve Ebersole [EMAIL PROTECTED] wrote: Our (default) dependency on CGLIB is starting to cause problems due to other libraries using newer versions of ASM (3.x) then the released versions of CGLIB use (2.x). We have now been waiting about a year for a new CGLIB release to use these newer ASM APIs. With 3.3 being eminent, we need to rectify this situation. First, I am going to make javassist the default bytecode provider starting with Hibernate 3.3 ( http://opensource.atlassian.com/projects/hibernate/browse/HHH-2506). Next, we need to decide what to do with CGLIB moving forward. This seems to be a dead project at this point. From my recollection, the source control for CGLIB does in fact have support for ASM 3.x; so one option would be to do a build of it from HEAD. However, none of us are really bytecode gurus, so thats probably not the best option. The only other option I see is to simply deprecate the integration for CGLIB and recommend against its use. Any other options we should explore here? - Steve Ebersole Project Lead http://hibernate.org [EMAIL PROTECTED] ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
