Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
Yes, it is the jdk9 job. Sorry, that I forgot to include that info. Mark - Bericht beantwoorden - Van: "Steve Ebersole" Aan: "Mark Rotteveel" , "Sanne Grinovero" CC: "Hibernate.org" Onderwerp: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL Datum: di, feb. 7, 2017 20:11 From which job? The JDK 9 one? Those failures you can ignore On Tue, Feb 7, 2017, 11:52 AM Mark Rotteveel wrote: Thanks! I just received a build failure notification with an ExceptionInInitialiserError, but I can't see how my PR would introduce that error. Any idea, or should I just ignore it? Mark - Bericht beantwoorden - Van: "Sanne Grinovero" Aan: "Mark Rotteveel" CC: "Hibernate.org" Onderwerp: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL Datum: di, feb. 7, 2017 18:08 merged it, and promoted your JIRA account so you can assign issues to yourself. Thanks! Sanne On 7 February 2017 at 15:58, Mark Rotteveel wrote: > Issue: https://hibernate.atlassian.net/browse/HHH-11467 > PR: https://github.com/hibernate/hibernate-orm/pull/1781 > > On 4-2-2017 15:05, Mark Rotteveel wrote: >> Firebird has a problem with some of the SQL generated by Hibernate, in >> some queries Hibernate appends StringHelper.WHITESPACE between >> conditions (specifically in CollectionBinder.bindFilters(boolean)). >> >> The problem is that StringHelper.WHITESPACE contains a formfeed (\f, >> 0x0C), and Firebird does not accept a formfeed as whitespace. >> >> It looks like the usage of StringHelper.WHITESPACE is wrong; the other >> places this constant is used is for splitting/tokenizing strings, and >> not for adding whitespace. >> >> Is there any objection if I replace the usage in >> CollectionBinder.bindFilters(boolean) with a single space (or maybe with >> " \n\t" to produce more similar SQL as previous)? >> >> Mark >> > > > -- > Mark Rotteveel > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
>From which job? The JDK 9 one? Those failures you can ignore On Tue, Feb 7, 2017, 11:52 AM Mark Rotteveel wrote: > Thanks! > I just received a build failure notification with an > ExceptionInInitialiserError, but I can't see how my PR would introduce that > error. > > Any idea, or should I just ignore it? > > Mark > > - Bericht beantwoorden - > Van: "Sanne Grinovero" > Aan: "Mark Rotteveel" > CC: "Hibernate.org" > Onderwerp: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL > Datum: di, feb. 7, 2017 18:08 > > merged it, and promoted your JIRA account so you can assign issues to > yourself. > > Thanks! > Sanne > > On 7 February 2017 at 15:58, Mark Rotteveel wrote: > > Issue: https://hibernate.atlassian.net/browse/HHH-11467 > > PR: https://github.com/hibernate/hibernate-orm/pull/1781 > > > > On 4-2-2017 15:05, Mark Rotteveel wrote: > >> Firebird has a problem with some of the SQL generated by Hibernate, in > >> some queries Hibernate appends StringHelper.WHITESPACE between > >> conditions (specifically in CollectionBinder.bindFilters(boolean)). > >> > >> The problem is that StringHelper.WHITESPACE contains a formfeed (\f, > >> 0x0C), and Firebird does not accept a formfeed as whitespace. > >> > >> It looks like the usage of StringHelper.WHITESPACE is wrong; the other > >> places this constant is used is for splitting/tokenizing strings, and > >> not for adding whitespace. > >> > >> Is there any objection if I replace the usage in > >> CollectionBinder.bindFilters(boolean) with a single space (or maybe with > >> " \n\t" to produce more similar SQL as previous)? > >> > >> Mark > >> > > > > > > -- > > Mark Rotteveel > > ___ > > hibernate-dev mailing list > > hibernate-dev@lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
Thanks! I just received a build failure notification with an ExceptionInInitialiserError, but I can't see how my PR would introduce that error. Any idea, or should I just ignore it? Mark - Bericht beantwoorden - Van: "Sanne Grinovero" Aan: "Mark Rotteveel" CC: "Hibernate.org" Onderwerp: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL Datum: di, feb. 7, 2017 18:08 merged it, and promoted your JIRA account so you can assign issues to yourself. Thanks! Sanne On 7 February 2017 at 15:58, Mark Rotteveel wrote: > Issue: https://hibernate.atlassian.net/browse/HHH-11467 > PR: https://github.com/hibernate/hibernate-orm/pull/1781 > > On 4-2-2017 15:05, Mark Rotteveel wrote: >> Firebird has a problem with some of the SQL generated by Hibernate, in >> some queries Hibernate appends StringHelper.WHITESPACE between >> conditions (specifically in CollectionBinder.bindFilters(boolean)). >> >> The problem is that StringHelper.WHITESPACE contains a formfeed (\f, >> 0x0C), and Firebird does not accept a formfeed as whitespace. >> >> It looks like the usage of StringHelper.WHITESPACE is wrong; the other >> places this constant is used is for splitting/tokenizing strings, and >> not for adding whitespace. >> >> Is there any objection if I replace the usage in >> CollectionBinder.bindFilters(boolean) with a single space (or maybe with >> " \n\t" to produce more similar SQL as previous)? >> >> Mark >> > > > -- > Mark Rotteveel > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
merged it, and promoted your JIRA account so you can assign issues to yourself. Thanks! Sanne On 7 February 2017 at 15:58, Mark Rotteveel wrote: > Issue: https://hibernate.atlassian.net/browse/HHH-11467 > PR: https://github.com/hibernate/hibernate-orm/pull/1781 > > On 4-2-2017 15:05, Mark Rotteveel wrote: >> Firebird has a problem with some of the SQL generated by Hibernate, in >> some queries Hibernate appends StringHelper.WHITESPACE between >> conditions (specifically in CollectionBinder.bindFilters(boolean)). >> >> The problem is that StringHelper.WHITESPACE contains a formfeed (\f, >> 0x0C), and Firebird does not accept a formfeed as whitespace. >> >> It looks like the usage of StringHelper.WHITESPACE is wrong; the other >> places this constant is used is for splitting/tokenizing strings, and >> not for adding whitespace. >> >> Is there any objection if I replace the usage in >> CollectionBinder.bindFilters(boolean) with a single space (or maybe with >> " \n\t" to produce more similar SQL as previous)? >> >> Mark >> > > > -- > Mark Rotteveel > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
Issue: https://hibernate.atlassian.net/browse/HHH-11467 PR: https://github.com/hibernate/hibernate-orm/pull/1781 On 4-2-2017 15:05, Mark Rotteveel wrote: > Firebird has a problem with some of the SQL generated by Hibernate, in > some queries Hibernate appends StringHelper.WHITESPACE between > conditions (specifically in CollectionBinder.bindFilters(boolean)). > > The problem is that StringHelper.WHITESPACE contains a formfeed (\f, > 0x0C), and Firebird does not accept a formfeed as whitespace. > > It looks like the usage of StringHelper.WHITESPACE is wrong; the other > places this constant is used is for splitting/tokenizing strings, and > not for adding whitespace. > > Is there any objection if I replace the usage in > CollectionBinder.bindFilters(boolean) with a single space (or maybe with > " \n\t" to produce more similar SQL as previous)? > > Mark > -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
+1 A separate Jira/PR is better since we can backport to other versions. Vlad On Tue, Feb 7, 2017 at 3:32 PM, andrea boriero wrote: > And naturally a separate jira :) > > On 7 Feb 2017 13:30, andrea boriero wrote: > >> It's better to have a separate. >> >> On 7 Feb 2017 13:17, "Mark Rotteveel" wrote: >> >> On 7-2-2017 14:12, Vlad Mihalcea wrote: >> > +1. >> > >> > I forgot to mention to add a Jira issue. If you don't have time, let me >> > know, and I'll take care of this issue for you. >> >> I was considering doing it as part of my Firebird dialect PR, but if you >> prefer a separate ticket + PR, I can do that as well. >> >> Mark >> -- >> Mark Rotteveel >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> >> >> ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
And naturally a separate jira :) On 7 Feb 2017 13:30, andrea boriero wrote: > It's better to have a separate. > > On 7 Feb 2017 13:17, "Mark Rotteveel" wrote: > > On 7-2-2017 14:12, Vlad Mihalcea wrote: > > +1. > > > > I forgot to mention to add a Jira issue. If you don't have time, let me > > know, and I'll take care of this issue for you. > > I was considering doing it as part of my Firebird dialect PR, but if you > prefer a separate ticket + PR, I can do that as well. > > Mark > -- > Mark Rotteveel > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
Hi Mark, I think it's better to have a separate PR. Thanks On 7 Feb 2017 13:17, "Mark Rotteveel" wrote: On 7-2-2017 14:12, Vlad Mihalcea wrote: > +1. > > I forgot to mention to add a Jira issue. If you don't have time, let me > know, and I'll take care of this issue for you. I was considering doing it as part of my Firebird dialect PR, but if you prefer a separate ticket + PR, I can do that as well. Mark -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
On 7-2-2017 14:12, Vlad Mihalcea wrote: > +1. > > I forgot to mention to add a Jira issue. If you don't have time, let me > know, and I'll take care of this issue for you. I was considering doing it as part of my Firebird dialect PR, but if you prefer a separate ticket + PR, I can do that as well. Mark -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
+1. I forgot to mention to add a Jira issue. If you don't have time, let me know, and I'll take care of this issue for you. Vlad On Tue, Feb 7, 2017 at 2:55 PM, Sanne Grinovero wrote: > Hi Mark, > that's not my area of expertise but it seems like a very reasonable > proposal. Please open a JIRA, I'm sure someone from the right team > will review and merge any such patch. > > Thanks, > Sanne > > > On 7 February 2017 at 12:26, Mark Rotteveel wrote: > > Any comments, or should I take the lack of answers as approval ;) > > > > Mark > > > > On 4-2-2017 15:05, Mark Rotteveel wrote: > >> Firebird has a problem with some of the SQL generated by Hibernate, in > >> some queries Hibernate appends StringHelper.WHITESPACE between > >> conditions (specifically in CollectionBinder.bindFilters(boolean)). > >> > >> The problem is that StringHelper.WHITESPACE contains a formfeed (\f, > >> 0x0C), and Firebird does not accept a formfeed as whitespace. > >> > >> It looks like the usage of StringHelper.WHITESPACE is wrong; the other > >> places this constant is used is for splitting/tokenizing strings, and > >> not for adding whitespace. > >> > >> Is there any objection if I replace the usage in > >> CollectionBinder.bindFilters(boolean) with a single space (or maybe > with > >> " \n\t" to produce more similar SQL as previous)? > >> > >> Mark > >> > > > > > > -- > > Mark Rotteveel > > ___ > > hibernate-dev mailing list > > hibernate-dev@lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
Hi Mark, that's not my area of expertise but it seems like a very reasonable proposal. Please open a JIRA, I'm sure someone from the right team will review and merge any such patch. Thanks, Sanne On 7 February 2017 at 12:26, Mark Rotteveel wrote: > Any comments, or should I take the lack of answers as approval ;) > > Mark > > On 4-2-2017 15:05, Mark Rotteveel wrote: >> Firebird has a problem with some of the SQL generated by Hibernate, in >> some queries Hibernate appends StringHelper.WHITESPACE between >> conditions (specifically in CollectionBinder.bindFilters(boolean)). >> >> The problem is that StringHelper.WHITESPACE contains a formfeed (\f, >> 0x0C), and Firebird does not accept a formfeed as whitespace. >> >> It looks like the usage of StringHelper.WHITESPACE is wrong; the other >> places this constant is used is for splitting/tokenizing strings, and >> not for adding whitespace. >> >> Is there any objection if I replace the usage in >> CollectionBinder.bindFilters(boolean) with a single space (or maybe with >> " \n\t" to produce more similar SQL as previous)? >> >> Mark >> > > > -- > Mark Rotteveel > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
You're right. For CollectionBinder, we shouldn't use the StringHelper.WHITESPACE. We should probably use a simple whitespace character. I guess that was the original intention. Vlad On Tue, Feb 7, 2017 at 2:26 PM, Mark Rotteveel wrote: > Any comments, or should I take the lack of answers as approval ;) > > Mark > > On 4-2-2017 15:05, Mark Rotteveel wrote: > > Firebird has a problem with some of the SQL generated by Hibernate, in > > some queries Hibernate appends StringHelper.WHITESPACE between > > conditions (specifically in CollectionBinder.bindFilters(boolean)). > > > > The problem is that StringHelper.WHITESPACE contains a formfeed (\f, > > 0x0C), and Firebird does not accept a formfeed as whitespace. > > > > It looks like the usage of StringHelper.WHITESPACE is wrong; the other > > places this constant is used is for splitting/tokenizing strings, and > > not for adding whitespace. > > > > Is there any objection if I replace the usage in > > CollectionBinder.bindFilters(boolean) with a single space (or maybe with > > " \n\t" to produce more similar SQL as previous)? > > > > Mark > > > > > -- > Mark Rotteveel > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Form-feed (\f 0x0C) in generated SQL
Any comments, or should I take the lack of answers as approval ;) Mark On 4-2-2017 15:05, Mark Rotteveel wrote: > Firebird has a problem with some of the SQL generated by Hibernate, in > some queries Hibernate appends StringHelper.WHITESPACE between > conditions (specifically in CollectionBinder.bindFilters(boolean)). > > The problem is that StringHelper.WHITESPACE contains a formfeed (\f, > 0x0C), and Firebird does not accept a formfeed as whitespace. > > It looks like the usage of StringHelper.WHITESPACE is wrong; the other > places this constant is used is for splitting/tokenizing strings, and > not for adding whitespace. > > Is there any objection if I replace the usage in > CollectionBinder.bindFilters(boolean) with a single space (or maybe with > " \n\t" to produce more similar SQL as previous)? > > Mark > -- Mark Rotteveel ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
