[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12915452#action_12915452 ] Steven Wong commented on HIVE-1378: --- Thanks, Ning/Zheng/John! Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.5.patch, HIVE-1378.6.patch, HIVE-1378.7.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914346#action_12914346 ] Ning Zhang commented on HIVE-1378: -- @john, should we run a survey on hive-user mailing list to see how many people are still using pre-0.20 hadoop before dropping the support? Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.5.patch, HIVE-1378.6.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914509#action_12914509 ] John Sichi commented on HIVE-1378: -- We did already, and no one responded, so I think Facebook was probably the last holdout. Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.5.patch, HIVE-1378.6.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914598#action_12914598 ] Ning Zhang commented on HIVE-1378: -- Before we decided to drop support for pre-0.20, we should have a separate JIRA to have a list of things that need to clean up: e.g., exclude downloading building hadoop 0.17. In the mean time, the change in the patch to be pre-0.20 compatible should be minimum. Steven, can you take a look the code and see how much it required to be done to be compatible with 0.17? Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.5.patch, HIVE-1378.6.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914756#action_12914756 ] Ning Zhang commented on HIVE-1378: -- +1. testing. Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.5.patch, HIVE-1378.6.patch, HIVE-1378.7.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914236#action_12914236 ] HBase Review Board commented on HIVE-1378: -- Message from: Steven Wong skwsl...@gmail.com --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/828/ --- (Updated 2010-09-23 14:06:40.052031) Review request for Hive Developers. Changes --- New patch moves ArrayList construction and adds back schema mismatch check. Summary --- HIVE-1606 is also fixed as a side effect. This addresses bug HIVE-1378. http://issues.apache.org/jira/browse/HIVE-1378 Diffs (updated) - trunk/build.xml 999712 trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 999712 trunk/conf/hive-default.xml 999712 trunk/data/files/datatypes.txt PRE-CREATION trunk/data/scripts/input20_script 999712 trunk/eclipse-templates/.classpath 999712 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 999712 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 999712 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java 999712 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java 999712 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 999712 trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 999712 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 999712 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 999712 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 999712 trunk/ql/src/test/results/clientpositive/binary_output_format.q.out 999712 trunk/ql/src/test/results/compiler/plan/input20.q.xml 999712 trunk/ql/src/test/results/compiler/plan/input4.q.xml 999712 trunk/ql/src/test/results/compiler/plan/input5.q.xml 999712 trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 999712 Diff: http://review.cloudera.org/r/828/diff Testing --- Thanks, Steven Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.5.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914282#action_12914282 ] Ning Zhang commented on HIVE-1378: -- Changes look good. However there are conflicts when applying to the latest trunk. Can you generate a new one against the latest trunk? I'll start testing once I got the new patch. Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.5.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914305#action_12914305 ] Ning Zhang commented on HIVE-1378: -- OK. This one applied cleanly. I'm starting testing. I think 'svn up' may be able to do more merging than 'patch'. I got the conflict on eclipse-templates/.classpath (it asked me whether I want to reverse apply) and another file. Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.5.patch, HIVE-1378.6.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914335#action_12914335 ] Ning Zhang commented on HIVE-1378: -- Steven, tests passed for hadoop 0.20, but it failed to compile on hadoop 0.17 (ant clean package -Dhadoop.version=0.17.2.1). Can you take a look? Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.5.patch, HIVE-1378.6.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12914341#action_12914341 ] John Sichi commented on HIVE-1378: -- We're supposed to drop support for pre-0.20 Hadoop versions anyway...maybe now is a good time? Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.5.patch, HIVE-1378.6.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913725#action_12913725 ] HBase Review Board commented on HIVE-1378: -- Message from: Ning Zhang n.nin...@gmail.com --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/828/#review1296 --- trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java http://review.cloudera.org/r/828/#comment4365 constructing an ArrayList for every row is very expensive. Do you need a separate copy every row or can share a cache among rows? trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java http://review.cloudera.org/r/828/#comment4364 Removing this changes the behavior: previously it throws an exception and schema mismatch, not it tolerate it. It would be good to remain backward compatibility. - Ning Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.4.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913164#action_12913164 ] HBase Review Board commented on HIVE-1378: -- Message from: Steven Wong skwsl...@gmail.com bq. On 2010-09-20 18:14:21, Zheng Shao wrote: bq. Thanks for taking the time to review it! See my comments below. bq. On 2010-09-20 18:14:21, Zheng Shao wrote: bq. trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java, line 179 bq. http://review.cloudera.org/r/828/diff/3/?file=12162#file12162line179 bq. bq. While this function works for most cases, there is no guarantee that it will work for nested map/array/struct, because toString() is not required to be implemented correctly for Objects in hive. bq. bq. The preferred way would be to use ObjectInspectorUtils/ObjectInspectorConvertors to copy/convert Object, ObjectInspector to Standard Object, and then convert to JDBC objects. bq. It is a good point regarding toString. I didn't try nested container types; I'm trying nested map for the first time now and it doesn't work. Will fix. Will see how ObjectInspector* can help. bq. On 2010-09-20 18:14:21, Zheng Shao wrote: bq. trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java, line 54 bq. http://review.cloudera.org/r/828/diff/3/?file=12173#file12173line54 bq. bq. Can we change the name to serializeField (here and in LazySimpleSerDe)? bq. OK. - Steven --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/828/#review1273 --- Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913336#action_12913336 ] HBase Review Board commented on HIVE-1378: -- Message from: Steven Wong skwsl...@gmail.com --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/828/ --- (Updated 2010-09-21 17:55:31.694691) Review request for Hive Developers. Changes --- Fixed nested map/array/struct. Summary --- HIVE-1606 is also fixed as a side effect. This addresses bug HIVE-1378. http://issues.apache.org/jira/browse/HIVE-1378 Diffs (updated) - trunk/build.xml 997983 trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 997983 trunk/conf/hive-default.xml 997983 trunk/data/files/datatypes.txt PRE-CREATION trunk/data/scripts/input20_script 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 997983 trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 997983 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 997983 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 997983 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 997983 trunk/ql/src/test/results/clientpositive/binary_output_format.q.out 997983 trunk/ql/src/test/results/compiler/plan/input20.q.xml 997983 trunk/ql/src/test/results/compiler/plan/input4.q.xml 997983 trunk/ql/src/test/results/compiler/plan/input5.q.xml 997983 trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 997983 Diff: http://review.cloudera.org/r/828/diff Testing --- Thanks, Steven Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12913338#action_12913338 ] Ning Zhang commented on HIVE-1378: -- Steven, there are conflicts when applying to the latest trunk. Can you regenerate the patch? Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.3.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912652#action_12912652 ] HBase Review Board commented on HIVE-1378: -- Message from: Steven Wong skwsl...@gmail.com bq. On 2010-09-17 23:09:15, Ning Zhang wrote: bq. Looks good in general. Some minor comments. I'll also ask Zheng to review it. Thanks for taking the time to review it! See my comments below. bq. On 2010-09-17 23:09:15, Ning Zhang wrote: bq. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 288 bq. http://review.cloudera.org/r/828/diff/2/?file=11939#file11939line288 bq. bq. Can you also add this parameter to conf/hive-default.xml? This file should contain all user-tunable parameters in HiveConf.java. Will add. bq. On 2010-09-17 23:09:15, Ning Zhang wrote: bq. trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java, line 158 bq. http://review.cloudera.org/r/828/diff/2/?file=11942#file11942line158 bq. bq. check null first? Ditto. bq. On 2010-09-17 23:09:15, Ning Zhang wrote: bq. trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java, line 140 bq. http://review.cloudera.org/r/828/diff/2/?file=11942#file11942line140 bq. bq. should null be checked first? This is copied from the existing code of getInt/getDouble/etc. Null doesn't have to be checked first because X.class.isInstance(obj) handles null obj correctly, i.e. X.class.isInstance(null) is false. My guess is, X.class.isInstance(obj) is checked first because the original coder assumes obj is more likely to be non-null. - Steven --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/828/#review1269 --- Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912682#action_12912682 ] HBase Review Board commented on HIVE-1378: -- Message from: Steven Wong skwsl...@gmail.com --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/828/ --- (Updated 2010-09-20 12:55:10.315466) Review request for Hive Developers. Changes --- Add config to hive-default.xml. Summary --- HIVE-1606 is also fixed as a side effect. This addresses bug HIVE-1378. http://issues.apache.org/jira/browse/HIVE-1378 Diffs (updated) - trunk/build.xml 997983 trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 997983 trunk/conf/hive-default.xml 997983 trunk/data/files/datatypes.txt PRE-CREATION trunk/data/scripts/input20_script 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 997983 trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 997983 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 997983 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 997983 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 997983 trunk/ql/src/test/results/clientpositive/binary_output_format.q.out 997983 trunk/ql/src/test/results/compiler/plan/input20.q.xml 997983 trunk/ql/src/test/results/compiler/plan/input4.q.xml 997983 trunk/ql/src/test/results/compiler/plan/input5.q.xml 997983 trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 997983 Diff: http://review.cloudera.org/r/828/diff Testing --- Thanks, Steven Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912805#action_12912805 ] HBase Review Board commented on HIVE-1378: -- Message from: Zheng Shao zsh...@gmail.com --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/828/#review1273 --- trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java http://review.cloudera.org/r/828/#comment4326 While this function works for most cases, there is no guarantee that it will work for nested map/array/struct, because toString() is not required to be implemented correctly for Objects in hive. The preferred way would be to use ObjectInspectorUtils/ObjectInspectorConvertors to copy/convert Object, ObjectInspector to Standard Object, and then convert to JDBC objects. trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java http://review.cloudera.org/r/828/#comment4325 Can we change the name to serializeField (here and in LazySimpleSerDe)? - Zheng Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.2.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910899#action_12910899 ] Ning Zhang commented on HIVE-1378: -- Looks good in general. I've left some minor comments in the cloudera's review board. I'm not sure if it could be replicated here, but if not, I'll copy them manually. Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910900#action_12910900 ] HBase Review Board commented on HIVE-1378: -- Message from: Ning Zhang n.nin...@gmail.com --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/828/#review1269 --- Looks good in general. Some minor comments. I'll also ask Zheng to review it. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java http://review.cloudera.org/r/828/#comment4317 Can you also add this parameter to conf/hive-default.xml? This file should contain all user-tunable parameters in HiveConf.java. trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java http://review.cloudera.org/r/828/#comment4318 should null be checked first? trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java http://review.cloudera.org/r/828/#comment4319 check null first? - Ning Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910716#action_12910716 ] HBase Review Board commented on HIVE-1378: -- Message from: Steven Wong skwsl...@gmail.com --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/828/ --- (Updated 2010-09-17 11:00:43.924384) Review request for Hive Developers. Summary --- HIVE-1606 is also fixed as a side effect. This addresses bug HIVE-1378. http://issues.apache.org/jira/browse/HIVE-1378 Diffs (updated) - trunk/build.xml 997983 trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 997983 trunk/data/files/datatypes.txt PRE-CREATION trunk/data/scripts/input20_script 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java 997983 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 997983 trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 997983 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 997983 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 997983 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 997983 trunk/ql/src/test/results/clientpositive/binary_output_format.q.out 997983 trunk/ql/src/test/results/compiler/plan/input20.q.xml 997983 trunk/ql/src/test/results/compiler/plan/input4.q.xml 997983 trunk/ql/src/test/results/compiler/plan/input5.q.xml 997983 trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 997983 Diff: http://review.cloudera.org/r/828/diff Testing --- Thanks, Steven Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910758#action_12910758 ] Ning Zhang commented on HIVE-1378: -- Taking a look now. Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.1.patch, HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910444#action_12910444 ] Ning Zhang commented on HIVE-1378: -- Will take a look. Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12910455#action_12910455 ] Ning Zhang commented on HIVE-1378: -- Steven, there are conflicts when applying this patch. Can you regenerate it? Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong Fix For: 0.7.0 Attachments: HIVE-1378.patch In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1378) Return value for map, array, and struct needs to return a string
[ https://issues.apache.org/jira/browse/HIVE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12909057#action_12909057 ] HBase Review Board commented on HIVE-1378: -- Message from: Steven Wong skwsl...@gmail.com --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/828/ --- Review request for Hive Developers. Summary --- HIVE-1606 is also fixed as a side effect. This addresses bug HIVE-1378. http://issues.apache.org/jira/browse/HIVE-1378 Diffs - trunk/build.xml 984947 trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 984947 trunk/data/files/datatypes.txt PRE-CREATION trunk/data/scripts/input20_script 984947 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java 984947 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 984947 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java 984947 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java 984947 trunk/jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 984947 trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 984947 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 984947 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 984947 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 984947 trunk/ql/src/test/results/clientpositive/binary_output_format.q.out 984947 trunk/ql/src/test/results/compiler/plan/input20.q.xml 984947 trunk/ql/src/test/results/compiler/plan/input4.q.xml 984947 trunk/ql/src/test/results/compiler/plan/input5.q.xml 984947 trunk/serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java PRE-CREATION trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 984947 Diff: http://review.cloudera.org/r/828/diff Testing --- Thanks, Steven Return value for map, array, and struct needs to return a string - Key: HIVE-1378 URL: https://issues.apache.org/jira/browse/HIVE-1378 Project: Hadoop Hive Issue Type: Improvement Components: Drivers Reporter: Jerome Boulon Assignee: Steven Wong In order to be able to select/display any data from JDBC Hive driver, return value for map, array, and struct needs to return a string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
