[jira] Commented: (HIVE-1414) automatically invoke .hiverc init script
[ https://issues.apache.org/jira/browse/HIVE-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894750#action_12894750 ] John Sichi commented on HIVE-1414: -- +1. Will commit if tests pass. It would be difficult to add a unit test for the user home location but $HIVE_HOME/bin could be tested by generating a script build/dist/bin/.hiverc as part of the build and then verifying its effects. If someone wants to create a followup for that, go for it. > automatically invoke .hiverc init script > > > Key: HIVE-1414 > URL: https://issues.apache.org/jira/browse/HIVE-1414 > Project: Hadoop Hive > Issue Type: Improvement > Components: Clients >Affects Versions: 0.5.0 >Reporter: John Sichi >Assignee: Edward Capriolo > Fix For: 0.7.0 > > Attachments: hive-1414-2.txt, hive-1414-patch-1.txt > > > Similar to .bashrc but run Hive SQL commands. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1414) automatically invoke .hiverc init script
[ https://issues.apache.org/jira/browse/HIVE-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893005#action_12893005 ] HBase Review Board commented on HIVE-1414: -- Message from: "John Sichi" --- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/393/ --- Review request for Hive Developers. Summary --- Review of HIVE-1414 by jvs. This addresses bug HIVE-1414. http://issues.apache.org/jira/browse/HIVE-1414 Diffs - http://svn.apache.org/repos/asf/hadoop/hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 966480 http://svn.apache.org/repos/asf/hadoop/hive/trunk/docs/stylesheets/project.xml 966480 http://svn.apache.org/repos/asf/hadoop/hive/trunk/docs/xdocs/language_manual/cli.xml PRE-CREATION Diff: http://review.cloudera.org/r/393/diff Testing --- Thanks, John > automatically invoke .hiverc init script > > > Key: HIVE-1414 > URL: https://issues.apache.org/jira/browse/HIVE-1414 > Project: Hadoop Hive > Issue Type: Improvement > Components: Clients >Affects Versions: 0.5.0 >Reporter: John Sichi >Assignee: Edward Capriolo > Fix For: 0.7.0 > > Attachments: hive-1414-2.txt, hive-1414-patch-1.txt > > > Similar to .bashrc but run Hive SQL commands. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1414) automatically invoke .hiverc init script
[ https://issues.apache.org/jira/browse/HIVE-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881206#action_12881206 ] Edward Capriolo commented on HIVE-1414: --- 1 & 3 ok. As for #2 is there every a condition where getenv() or home will be null? I doubt hive would work in the face in either of these conditions. I will add the null checks anyway. > automatically invoke .hiverc init script > > > Key: HIVE-1414 > URL: https://issues.apache.org/jira/browse/HIVE-1414 > Project: Hadoop Hive > Issue Type: Improvement > Components: Clients >Affects Versions: 0.5.0 >Reporter: John Sichi >Assignee: Edward Capriolo > Fix For: 0.7.0 > > Attachments: hive-1414-patch-1.txt > > > Similar to .bashrc but run Hive SQL commands. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1414) automatically invoke .hiverc init script
[
https://issues.apache.org/jira/browse/HIVE-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880992#action_12880992
]
John Sichi commented on HIVE-1414:
--
OK, those choices make sense.
Some review comments:
1) In HIVE-1405, I added a processFile method which takes care of closing the
reader to avoid resource leak. Could you review and commit that patch, and
then update your patch here to call processFile?
2) If either getenv or getProperty returns null, we should skip the
corresponding exists check completely to avoid looking for a filename like
("null/bin/.hiverc")
3) I think your code needs to move up into my processInitFiles location,
otherwise it won't get run for the -f and -e cases. Also, let's say that if -i
is specified, then we skip the .hiverc execution (to match bash -init-file
behavior). Note that .hiverc execution should happen inside of my silent-mode
block so that it does not show up in console output.
> automatically invoke .hiverc init script
>
>
> Key: HIVE-1414
> URL: https://issues.apache.org/jira/browse/HIVE-1414
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Clients
>Affects Versions: 0.5.0
>Reporter: John Sichi
>Assignee: Edward Capriolo
> Attachments: hive-1414-patch-1.txt
>
>
> Similar to .bashrc but run Hive SQL commands.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1414) automatically invoke .hiverc init script
[ https://issues.apache.org/jira/browse/HIVE-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880414#action_12880414 ] Edward Capriolo commented on HIVE-1414: --- Files automatically: ql sourced env[HIVE_HOME]/bin/.hiverc, property(user.home)/.hiverc. I think only the CLI needs these features. Users of hive service are accessing the session though code repetition is not a problem, the same is true with JDBC. CLI users get the most benefit from the .hiverc. What do you think? > automatically invoke .hiverc init script > > > Key: HIVE-1414 > URL: https://issues.apache.org/jira/browse/HIVE-1414 > Project: Hadoop Hive > Issue Type: Improvement > Components: Clients >Affects Versions: 0.5.0 >Reporter: John Sichi >Assignee: Edward Capriolo > Attachments: hive-1414-patch-1.txt > > > Similar to .bashrc but run Hive SQL commands. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1414) automatically invoke .hiverc init script
[ https://issues.apache.org/jira/browse/HIVE-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880267#action_12880267 ] John Sichi commented on HIVE-1414: -- I'm leaving this vague on purpose since there are a few issues which would need to be decided (what the file should be named, where it should be located, whether to invoke from CLI only or also other services when they start up, etc). > automatically invoke .hiverc init script > > > Key: HIVE-1414 > URL: https://issues.apache.org/jira/browse/HIVE-1414 > Project: Hadoop Hive > Issue Type: Improvement > Components: Clients >Affects Versions: 0.5.0 >Reporter: John Sichi > > Similar to .bashrc but run Hive SQL commands. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
