Re: [hugin-ptx] Removing magnifier hiding timer etc. from CPImageCtrl.cpp

[johnfi...@gmail.com]

On Tuesday, February 1, 2022 at 11:31:43 AM UTC-5 Luís Henrique Camargo 
Quiroz wrote:

>
>  What about keeping the views at 200% and just the magnifier (or a 
> bigger one) at the intended 400 and 800%? So the left and right views would 
> show a bigger field of view.
>

I think what I plan to do will fit your needs.  I still want 400% and 800% 
as choices in the menu for overall zoom.  You won't need to use them.

Currently (without any of my changes), the size and zoom level of the 
magnifier itself are set by registry settings in Windows and by ?? in 
Linux.  I forget what the default was for that zoom, but it was at least 
400%.  I want to make the size of the magnifier user settable without 
regedit and I want to change the setting logic for the magnifier's own zoom 
level in addition to making that setting user settable without regedit.

I think the magnifier's own zoom should be set as both a minimum and a 
minimum relative to overall zoom (so it gets the larger of the two).  So 
you might select a magnifier zoom with its minimum at 400% and its relative 
minimum at 800%, in which case at overall zoom 50% or lower, the magnifier 
would be 400%, while at 100% or higher, the magnifier would be at 8 times 
the main zoom.  Alternately, you could set the X% as the minimum (meaning 
only) zoom for the magnifier and the special lowest (labeled "none" rather 
than 100%) relative value.  So for overall zoom below X% the magnifier 
would be X% and for overall zoom at or above X%, the magnifier would go 
away (similar to the go away at 200% existing feature, but more sensible).

> If you find the right part of a scene on my 1280x800 screen a 8xmagnifier 
might instead be a way to get completely lost 

I recently switched the two portrait mode displays on my Fedora system from 
1440x2560 each to 1620x2880 each.  So I have an overall 3240x2880 display.  
So my needs are different from ordinary and I want Hugin to span the range 
between my needs and others.  I want the overall zoom to be higher and I 
need the magnifier itself to occupy more pixels of the physical screen.


-- 
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
--- 
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/fbde42b6-2427-4f76-ab5e-874cf58ae400n%40googlegroups.com.

Re: [hugin-ptx] Removing magnifier hiding timer etc. from CPImageCtrl.cpp

[Gunter Königsmann]

That might be a point: If you want to hit exactly the right pixel on a retina 
display you'll have to resort to a powerful magnifier. If you find the right 
part of a scene on my 1280x800 screen a 8xmagnifier might instead be a way to 
get completely lost while a 1x magnifier will introduce helpful contrast.

-- 
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
--- 
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/E9220ECC-06B6-4396-893F-260A7F588CC6%40gmail.com.

Re: [hugin-ptx] Removing magnifier hiding timer etc. from CPImageCtrl.cpp

[Luís Henrique Camargo Quiroz]

 Hi John!

 I have never really used 200% magnification, and the lack of the
magnifier in it was the culprit. Even if the magnification were low, an
important feature is the "high contrast" the magnifier provides.
 What about keeping the views at 200% and just the magnifier (or a
bigger one) at the intended 400 and 800%? So the left and right views would
show a bigger field of view.  I like to use manual control points, so the
CPs are not on wrong places, never, so the stitched pano will have no great
flaws... for my use case I like a big view, it helps to understand where I
am moving to mouse in the scene. I fear that at 400 or 800% the view will
show very few from the broader scene.

 I thank you in advance for your efforts and ideas for a better Hugin.
Wish you good work and luck!

sincerely,

Luís Henrique


Em ter., 1 de fev. de 2022 às 11:41, johnfi...@gmail.com <
johnfine2...@gmail.com> escreveu:

> If there are no objections (in time before I actually do it) I will make a
> branch and make the small change described here as my first (of I expect
> many) commits on that branch.
>
> If there is any disagreement on details (rather than overall objection to
> the change), please tell me that as well.
>
> There are conditions under which the magnifier for the selected point in
> the control points dialog gets hidden without the point being deselected.
>
> As a user, I find that very inconvenient.  Bruno seemed to agree in
> earlier discussion.
>
> On occasion, I really want to hide the magnifier.  But there is no
> correlation between when it gets hidden by current code and when I want it
> hidden.  I want to add a key (my choice would be 'm') that will temporarily
> hide the magnifier if it wasn't hidden and will bring it back if it was.
> Hiding would only be temporary: other actions make the magnifier appear and
> "hiding" would not suppress that.
>
> I would entirely remove the timer.  It's only purpose is to hide the
> magnifier.  I see no logic to when that timer is used vs. not used.  Maybe
> the original intent was to always have that timer (never let the magnifier
> stay in view for over 2 seconds).  As a user I see* zero* value in timer
> based hiding of the magnifier.  But if others strongly disagree, (with
> significantly more work) I could invent a setting to allow that feature to
> be disabled (rather than take the feature away from everyone).
>
> With my limited understanding of mercurial, I was able to see the timer
> feature was added by ippei in commit 91503d5bebff
> I don't know this environment well enough to know how to find out who
> ippei is nor to find out when/why that commit was made.
>
> I also want to remove all other existing logic for hiding the magnifier,
> such as hiding it when the image itself is zoomed 200%.  Subject to having
> a control point selected to be magnified, I want the new 'm' key operation
> to be the only thing that hides the magnifier.
>
> Separately, I want to commit my changes adding 400% and 800% zoom and my
> changes adjusting the magnifier for higher zoom.  I expect the purpose of
> removing the magnifier at 200% zoom is that it isn't much extra
> magnification.  But I both still would want it even if it was only a little
> extra and want to increase how much extra it is.
>
> Separately, I think the controls over the magnifier that are only in the
> registry on Windows (and I haven't looked for where they are on Fedora)
> ought to be in the GUI settings so they can be changed without regedit (I'm
> very comfortable with regedit but I expect most Windows Hugin users
> aren't).  At the same time a bit more control should be included.
>
> I would tend to want to pretest and commit all those and related features
> all together.  But I have been warned that doing so would make things too
> hard for whoever reviews/merges my changes.  So I think the right size
> first chunk is just the changes related to hiding the magnifier.
>
> --
> A list of frequently asked questions is available at:
> http://wiki.panotools.org/Hugin_FAQ
> ---
> You received this message because you are subscribed to the Google Groups
> "hugin and other free panoramic software" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to hugin-ptx+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/hugin-ptx/22486fd0-4c32-43c2-ad90-49c45c4a7cfbn%40googlegroups.com
> 
> .
>


-- 
-- 
Luis Henrique Camargo Quiroz
http://luishcq.br.tripod.com - http://www.christusrex.org/www2/cantgreg
http://panoramaslh.net/

-- 
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
--- 
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscri

[hugin-ptx] Removing magnifier hiding timer etc. from CPImageCtrl.cpp

[johnfi...@gmail.com]

If there are no objections (in time before I actually do it) I will make a 
branch and make the small change described here as my first (of I expect 
many) commits on that branch.

If there is any disagreement on details (rather than overall objection to 
the change), please tell me that as well.

There are conditions under which the magnifier for the selected point in 
the control points dialog gets hidden without the point being deselected.

As a user, I find that very inconvenient.  Bruno seemed to agree in earlier 
discussion.

On occasion, I really want to hide the magnifier.  But there is no 
correlation between when it gets hidden by current code and when I want it 
hidden.  I want to add a key (my choice would be 'm') that will temporarily 
hide the magnifier if it wasn't hidden and will bring it back if it was.  
Hiding would only be temporary: other actions make the magnifier appear and 
"hiding" would not suppress that.

I would entirely remove the timer.  It's only purpose is to hide the 
magnifier.  I see no logic to when that timer is used vs. not used.  Maybe 
the original intent was to always have that timer (never let the magnifier 
stay in view for over 2 seconds).  As a user I see* zero* value in timer 
based hiding of the magnifier.  But if others strongly disagree, (with 
significantly more work) I could invent a setting to allow that feature to 
be disabled (rather than take the feature away from everyone).

With my limited understanding of mercurial, I was able to see the timer 
feature was added by ippei in commit 91503d5bebff
I don't know this environment well enough to know how to find out who ippei 
is nor to find out when/why that commit was made.

I also want to remove all other existing logic for hiding the magnifier, 
such as hiding it when the image itself is zoomed 200%.  Subject to having 
a control point selected to be magnified, I want the new 'm' key operation 
to be the only thing that hides the magnifier.

Separately, I want to commit my changes adding 400% and 800% zoom and my 
changes adjusting the magnifier for higher zoom.  I expect the purpose of 
removing the magnifier at 200% zoom is that it isn't much extra 
magnification.  But I both still would want it even if it was only a little 
extra and want to increase how much extra it is.

Separately, I think the controls over the magnifier that are only in the 
registry on Windows (and I haven't looked for where they are on Fedora) 
ought to be in the GUI settings so they can be changed without regedit (I'm 
very comfortable with regedit but I expect most Windows Hugin users 
aren't).  At the same time a bit more control should be included.

I would tend to want to pretest and commit all those and related features 
all together.  But I have been warned that doing so would make things too 
hard for whoever reviews/merges my changes.  So I think the right size 
first chunk is just the changes related to hiding the magnifier.

-- 
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
--- 
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/22486fd0-4c32-43c2-ad90-49c45c4a7cfbn%40googlegroups.com.