Re: [hugin-ptx] libpano gcc 8 warnings
Didn't have the time to patch the whole thing. But a first few lines of
the patch would read as attached to this mail - and obviousy would need
an review as everybody gets this kind of thing wrong.
I'm not sure if all the strings we sprintf'ed into actually had the
right length to accomodate the '\0' that ends the string, though...
Kind regards,
Gunter.
--
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/hugin-ptx/fe10e8e0-377a-f722-ac04-5a49fc2af315%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
diff libpano13-2.9.19/adjust.c libpano13-2.9.19-snprintf/adjust.c
419c419,420
< newscript = (char*) malloc( strlen(script) + NUMPTS * 60 ); // One line per pair of points
---
> size_t newscriptlen = strlen(script) + NUMPTS * 60;
> newscript = (char*) malloc( newscriptlen + 1 ); // One line per pair of points
421a423
> newscript[newscriptlen] = '\0';
426c428
< sprintf( newscript, "%s\n%s", script, cdesc );
---
> snprintf( newscript, newscriptlen, "%s\n%s", script, cdesc );
2173,2174c2175,2176
<
< sprintf( message,"Strategy %d\nAverage (rms) distance between Controlpoints \nafter %d iteration(s): %25.15g units", getFcnPanoNperCP(), numIt,result);//average);
---
> message[255] = '\0';
> snprintf( message, 255, "Strategy %d\nAverage (rms) distance between Controlpoints \nafter %d iteration(s): %25.15g units", getFcnPanoNperCP(), numIt,result);//average);
2935c2937
<
---
> line[79] = '\0';
2940c2942
< sprintf( line, "c n%d N%d x%lf y%lf X%lf Y%lf\n", cp[i].num[0], cp[i].num[1],
---
> snprintf( line, 79, "c n%d N%d x%lf y%lf X%lf Y%lf\n", cp[i].num[0], cp[i].num[1],
diff libpano13-2.9.19/correct.c libpano13-2.9.19-snprintf/correct.c
748,749c748,750
< {
< sprintf( percent, "%d", (int) (xul * 100)/(dx>0?dx:1));
---
> {
> percent[7] = '\0';
> snprintf( percent, 7, "%d", (int) (xul * 100)/(dx>0?dx:1));
diff libpano13-2.9.19/file.c libpano13-2.9.19-snprintf/file.c
1408c1408,1409
< sprintf(msg,"width=%d, height=%d, top = %d, bottom = %d, left = %d, right = %d\n",
---
> msg[999] = '\0';
> snprintf(msg, 999, "width=%d, height=%d, top = %d, bottom = %d, left = %d, right = %d\n",
1724,1725c1725,1726
<
< sprintf( &(sLayerName[1]), "%03d", numLayers+1 );
---
> sLayerName[4] = '\n';
> snprintf( &(sLayerName[1]), 4, "%03d", numLayers+1 );
1887c1888,1889
< sprintf(tempString, "%d", 100 / numberImages);
---
> tempString[127] = '\0';
> snprintf(tempString, 127, "%d", 100 / numberImages);
2077,2078c2079,2081
<
< sprintf(&(sLayerName[1]), "%03d", (i+1)%1000 );
---
>
> sLayerName[4] = '\0';
> snprintf(&(sLayerName[1]), 3, "%03d", (i+1)%1000 );
2087c2090
< sprintf(tempString, "%d", i * 100 / numberImages);
---
> snprintf(tempString, 127, "%d", i * 100 / numberImages);
2235c2238
< sprintf( &(sLayerName[1]), "%03d", i+1 );
---
> snprintf( &(sLayerName[1]), 3, "%03d", i+1 );
2807c2810
< char fname[40];
---
> char fname[40];fname[39] = '\0';
2820c2823
< sprintf(fname, "_PTStitcher_tmp_%06d", nTry);
---
> snprintf(fname, 39, "_PTStitcher_tmp_%06d", nTry);
2899c2902
< char outputFilename[MAX_PATH_LENGTH];
---
> char outputFilename[MAX_PATH_LENGTH];outputFilename[MAX_PATH_LENGTH-1] = '\0';
2915c2918
< sprintf( outputFilename, outputPrefix, i );
---
> snprintf( outputFilename, MAX_PATH_LENGTH-1, outputPrefix, i );
diff libpano13-2.9.19/filter.c libpano13-2.9.19-snprintf/filter.c
385,386c385,387
< {
< sprintf( percent, "%d", (int) ((y * 100)/ TrPtr->dest->height));
---
> {
> percent[7] = '\0';
> snprintf( percent, 7, "%d", (int) ((y * 100)/ TrPtr->dest->height));
diff libpano13-2.9.19/optimize.c libpano13-2.9.19-snprintf/optimize.c
97c97
< char msgx[200];
---
> char msgx[200];msgx[199] = '\0';
99c99
< sprintf (msgx,"You have too few control points (%d) or too many parameters (%d). Strange values may result!",o->numData,LM.n);
---
> snprintf (msgx,199,"You have too few control points (%d) or too many parameters (%d). Strange values may result!",o->numData,LM.n);
diff libpano13-2.9.19/ppm.c libpano13-2.9.19-snprintf/ppm.c
198c198
< char header[30];
---
> ch
Re: [hugin-ptx] libpano gcc 8 warnings
On Sun, Sep 23, 2018 at 11:43:38PM +0100, Bruno Postle wrote:
>
>
> On 23 September 2018 13:48:10 BST, Andreas Metzler wrote:
> >
> >building libpano with gcc 8 (instead of 7) triggers a couple of new
> >warnings that might be interesting:
> >
> >parser.c: In function 'ReadImageDescription':
> >parser.c:1854:38: warning: '%s' directive writing up to 65535 bytes
> >into a region of size 256 [-Wformat-overflow=]
> > sprintf( sBuf.destName, "%s", buf );
> > ^~ ~~~
> It looks harmless to me, but my C isn't good enough to say for sure.
The compiler is saying that "sBuf.destName" is declared having a size
of 256, while "buf" is declared as being of size 65536.
When a compiler says such a thing it is usually right.
When this was written, someone probably thought about it and reused
the 65536 byte buffer "buf" for this small task. "buf" Needs to be
65536 bytes long for something else, and is now reused for this
purpose with "max 255" or even less still...
That said... Ignoring these warnings has for years caused serious
security leaks. These warnings didn't exist back then, but we should
take them serious.
In this case,
strncpy ( sBuf.destName, buf, 255);
is a quick rewrite of that specific line that a) avoids the warning
and b) avoids being unsafe even when someone external manages to get
"buf" filled further than expected.
The downside is that the API of strncpy is not convenient and requires
a sBuf.destName[255] = 0; at the end for the code fragment to become
really safe.
I would've liked something along the lines of:
char *mystrncpy (char *dst, char *src, int n)
{
if(!n) return;
n--;
while (*src && n--)
*dst++ = *src++;
*dst++ = 0;
return dst;
}
that always null-terminates the destination string even when the
buffer limit is reached. Alas they did not listen to me when I didn't
know this yet and was only 5 years old.
Roger.
--
+-- Rogier Wolff -- www.harddisk-recovery.nl -- 0800 220 20 20 --
- Datarecovery Services Nederland B.V. Delft. KVK: 30160549 -
| Files foetsie, bestanden kwijt, alle data weg?!
| Blijf kalm en neem contact op met Harddisk-recovery.nl!
--
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/hugin-ptx/20180924130644.GD4427%40BitWizard.nl.
For more options, visit https://groups.google.com/d/optout.
Re: [hugin-ptx] libpano gcc 8 warnings
Can we have a patch? This is exactly the sort of thing that I mess up - Bruno On 24 September 2018 06:04:49 BST, "Gunter Königsmann" wrote: >My advise is to replace the sprintf by an snprintf before the final >release: snprintf requires an additional parameter that tells it how >many >bytes the buffer it is about to write into is long; using an ordinary >sprintf always means you are risking needing to issue an security >update >because someone manages to craft a file that tricks snprintf into >overwriting the stack or a pointer leading to arbitrary code execution >by >using return-oriented programming or similar. > >And always remember: if snprintf knows that the buffer it writes into >is >only 255 bytes long and the string to write is 255 bytes long plus the >null >byte marking the end of the string snprintf won't add a null byte to >its >end => fill the last byte it the target string with a zero and then >tell >snprintf the target is only 254 bytes long. Or make the target string >longer. -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to hugin-ptx+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/0BAA8D62-7BA3-4136-9F65-F26E40AAE0C5%40postle.net. For more options, visit https://groups.google.com/d/optout.
Re: [hugin-ptx] libpano gcc 8 warnings
My advise is to replace the sprintf by an snprintf before the final release: snprintf requires an additional parameter that tells it how many bytes the buffer it is about to write into is long; using an ordinary sprintf always means you are risking needing to issue an security update because someone manages to craft a file that tricks snprintf into overwriting the stack or a pointer leading to arbitrary code execution by using return-oriented programming or similar. And always remember: if snprintf knows that the buffer it writes into is only 255 bytes long and the string to write is 255 bytes long plus the null byte marking the end of the string snprintf won't add a null byte to its end => fill the last byte it the target string with a zero and then tell snprintf the target is only 254 bytes long. Or make the target string longer. Kind regards, Gunter. On Mon, 24 Sep 2018, 06:07 David W. Jones, wrote: > On September 23, 2018 12:43:38 PM HST, Bruno Postle wrote: > > > > > >On 23 September 2018 13:48:10 BST, Andreas Metzler wrote: > >> > >>building libpano with gcc 8 (instead of 7) triggers a couple of new > >>warnings that might be interesting: > >> > >>parser.c: In function 'ReadImageDescription': > >>parser.c:1854:38: warning: '%s' directive writing up to 65535 bytes > >>into a region of size 256 [-Wformat-overflow=] > >> sprintf( sBuf.destName, "%s", buf ); > >> ^~ ~~~ > > > >It looks harmless to me, but my C isn't good enough to say for sure. > > Don't know, either, but I put in an effort compiling a completely > different app that reported those kinds of warnings (trying to fit X bytes > into something Left no debug or log or anything. > > >Along with the earlier typos I'm inclined to release the release > >candidate, since it has been waiting so long, then fixes for these can > >go into the next release. > > > >>Also, the following warnings is thrown a couple of times in the > >>test-suite: > >>Comparing reference images: 2 > >>reference/tiff_m_cropped.tif -> tests/tiff_m_cropped.tif > >>TIFFReadDirectory: Warning, Sum of Photometric type-related color > >>channels and ExtraSamples doesn't match SamplesPerPixel. Defining > >>non-color channels as ExtraSamples.. > > > >Seems like libtiff didn't like something about the files rather than > >the tests themselves failing. > > Sounds like an issue with files themselves, too. Have gotten used to such > warnings with images from my camera. It simply doesn't record some of the > things libtiff seems to look for. > > > David W. Jones > gnomeno...@gmail.com > wandering the landscape of god > http://dancingtreefrog.com > > Sent from my Android device with F/LOSS K-9 Mail. > > -- > A list of frequently asked questions is available at: > http://wiki.panotools.org/Hugin_FAQ > --- > You received this message because you are subscribed to the Google Groups > "hugin and other free panoramic software" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to hugin-ptx+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/hugin-ptx/FB46C7F8-A83C-4EED-B71B-A0D9B0EE90D7%40gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to hugin-ptx+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/CAMcFxV2WpOJ2RDQEuedxNWJKpyKSEfMji0OPmfX-VNpHdOoDMQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: [hugin-ptx] libpano gcc 8 warnings
On September 23, 2018 12:43:38 PM HST, Bruno Postle wrote: > > >On 23 September 2018 13:48:10 BST, Andreas Metzler wrote: >> >>building libpano with gcc 8 (instead of 7) triggers a couple of new >>warnings that might be interesting: >> >>parser.c: In function 'ReadImageDescription': >>parser.c:1854:38: warning: '%s' directive writing up to 65535 bytes >>into a region of size 256 [-Wformat-overflow=] >> sprintf( sBuf.destName, "%s", buf ); >> ^~ ~~~ > >It looks harmless to me, but my C isn't good enough to say for sure. Don't know, either, but I put in an effort compiling a completely different app that reported those kinds of warnings (trying to fit X bytes into something Along with the earlier typos I'm inclined to release the release >candidate, since it has been waiting so long, then fixes for these can >go into the next release. > >>Also, the following warnings is thrown a couple of times in the >>test-suite: >>Comparing reference images: 2 >>reference/tiff_m_cropped.tif -> tests/tiff_m_cropped.tif >>TIFFReadDirectory: Warning, Sum of Photometric type-related color >>channels and ExtraSamples doesn't match SamplesPerPixel. Defining >>non-color channels as ExtraSamples.. > >Seems like libtiff didn't like something about the files rather than >the tests themselves failing. Sounds like an issue with files themselves, too. Have gotten used to such warnings with images from my camera. It simply doesn't record some of the things libtiff seems to look for. David W. Jones gnomeno...@gmail.com wandering the landscape of god http://dancingtreefrog.com Sent from my Android device with F/LOSS K-9 Mail. -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to hugin-ptx+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/FB46C7F8-A83C-4EED-B71B-A0D9B0EE90D7%40gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: [hugin-ptx] libpano gcc 8 warnings
On Sunday, 23 September 2018 at 23:43:38 +0100, Bruno Postle wrote: > > > On 23 September 2018 13:48:10 BST, Andreas Metzler wrote: >> >> building libpano with gcc 8 (instead of 7) triggers a couple of new >> warnings that might be interesting: >> >> parser.c: In function 'ReadImageDescription': >> parser.c:1854:38: warning: '%s' directive writing up to 65535 bytes >> into a region of size 256 [-Wformat-overflow=] >> sprintf( sBuf.destName, "%s", buf ); >> ^~ ~~~ > > It looks harmless to me, but my C isn't good enough to say for sure. I think what it's trying to say is "consider using snprintf ()". > Along with the earlier typos I'm inclined to release the release > candidate, since it has been waiting so long, then fixes for these > can go into the next release. Sounds reasonable to me. Greg -- Sent from my desktop computer. Finger groog...@gmail.com for PGP public key. See complete headers for address and phone numbers. This message is digitally signed. If your Microsoft mail program reports problems, please read http://lemis.com/broken-MUA -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to hugin-ptx+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/20180924034944.GC75165%40eureka.lemis.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Re: [hugin-ptx] libpano gcc 8 warnings
On 23 September 2018 13:48:10 BST, Andreas Metzler wrote: > >building libpano with gcc 8 (instead of 7) triggers a couple of new >warnings that might be interesting: > >parser.c: In function 'ReadImageDescription': >parser.c:1854:38: warning: '%s' directive writing up to 65535 bytes >into a region of size 256 [-Wformat-overflow=] > sprintf( sBuf.destName, "%s", buf ); > ^~ ~~~ It looks harmless to me, but my C isn't good enough to say for sure. Along with the earlier typos I'm inclined to release the release candidate, since it has been waiting so long, then fixes for these can go into the next release. >Also, the following warnings is thrown a couple of times in the >test-suite: >Comparing reference images: 2 >reference/tiff_m_cropped.tif -> tests/tiff_m_cropped.tif >TIFFReadDirectory: Warning, Sum of Photometric type-related color >channels and ExtraSamples doesn't match SamplesPerPixel. Defining >non-color channels as ExtraSamples.. Seems like libtiff didn't like something about the files rather than the tests themselves failing. -- Bruno -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to hugin-ptx+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/580AD240-3A56-4FA5-B74D-74F9559B706B%40postle.net. For more options, visit https://groups.google.com/d/optout.
[hugin-ptx] libpano gcc 8 warnings
Hello, building libpano with gcc 8 (instead of 7) triggers a couple of new warnings that might be interesting: --- parser.c: In function 'ReadImageDescription': parser.c:1854:38: warning: '%s' directive writing up to 65535 bytes into a region of size 256 [-Wformat-overflow=] sprintf( sBuf.destName, "%s", buf ); ^~ ~~~ In file included from /usr/include/stdio.h:862, from filter.h:26, from parser.c:47: /usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output between 1 and 65536 bytes into a destination of size 256 return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1, ^~ __bos (__s), __fmt, __va_arg_pack ()); ~ parser.c:1850:37: warning: '%s' directive writing up to 65535 bytes into a region of size 256 [-Wformat-overflow=] sprintf( sBuf.srcName, "%s", buf); ^~ ~~~ In file included from /usr/include/stdio.h:862, from filter.h:26, from parser.c:47: /usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output between 1 and 65536 bytes into a destination of size 256 return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1, ^~ __bos (__s), __fmt, __va_arg_pack ()); ~ parser.c: In function 'ParseScript': parser.c:453:45: warning: '%s' directive writing up to 65535 bytes into a region of size 512 [-Wformat-overflow=] sprintf( im->name, "%s", buf ); ^~ ~~~ In file included from /usr/include/stdio.h:862, from filter.h:26, from parser.c:47: /usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output between 1 and 65536 bytes into a destination of size 512 return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1, ^~ __bos (__s), __fmt, __va_arg_pack ()); ~ [...] correct.c: In function 'getFrame': correct.c:749:24: warning: '%d' directive writing between 1 and 10 bytes into a region of size 8 [-Wformat-overflow=] sprintf( percent, "%d", (int) (xul * 100)/(dx>0?dx:1)); ^~ correct.c:749:23: note: directive argument in the range [0, 2147483647] sprintf( percent, "%d", (int) (xul * 100)/(dx>0?dx:1)); ^~~~ In file included from /usr/include/stdio.h:862, from filter.h:26, from correct.c:35: /usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output between 2 and 11 bytes into a destination of size 8 return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1, ^~ __bos (__s), __fmt, __va_arg_pack ()); ~ [...] ColourBrightness.c: In function 'ReadHistograms': ColourBrightness.c:1281:55: warning: '%s' directive writing up to 511 bytes into a region of size 486 [-Wformat-overflow=] sprintf(tempString2, "Could not open TIFF file [%s]", tempString); ^~~~ In file included from /usr/include/stdio.h:862, from filter.h:26, from ColourBrightness.c:32: /usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output between 28 and 539 bytes into a destination of size 512 return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1, ^~ __bos (__s), __fmt, __va_arg_pack ()); ~ Also, the following warnings is thrown a couple of times in the test-suite: Comparing reference images: 2 reference/tiff_m_cropped.tif -> tests/tiff_m_cropped.tif TIFFReadDirectory: Warning, Sum of Photometric type-related color channels and ExtraSamples doesn't match SamplesPerPixel. Defining non-color channels as ExtraSamples.. [...] cu Andreas -- `What a good friend you are to him, Dr. Maturin. His other friends are so grateful to you.' `I sew his ears on from time to time, sure' -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to hugin-ptx+unsubscr...@googlegroups.com. To view this discussion on the web visit https://
[hugin-ptx] libpano - Typo fix
Hello,
find attached a trivial patch against libpano13-2.9.20 rc2, fixing two
typos. Found by lintian, perhaps you can apply after the releas (or
before?)
TIA, cu Andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'
--
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/hugin-ptx/20180923124156.GA1310%40argenau.bebt.de.
For more options, visit https://groups.google.com/d/optout.
Description: Fix two typos found by lintian
Resultion/enought
Author: Andreas Metzler
Origin: vendor
Last-Update: 2018-09-23
--- libpano13-2.9.20~rc2+dfsg.orig/parser.c
+++ libpano13-2.9.20~rc2+dfsg/parser.c
@@ -2479,7 +2479,7 @@ char *panoParserFindOLine(char *script,
result = calloc(length + 1, 1);
if (result == NULL) {
-PrintError("Not enought memory");
+PrintError("Not enough memory");
return NULL;
} else {
strncpy(result, ptr, length);
--- libpano13-2.9.20~rc2+dfsg.orig/tiff.c
+++ libpano13-2.9.20~rc2+dfsg/tiff.c
@@ -617,7 +617,7 @@ int panoTiffGetCropInformation(pano_Tiff
return FALSE;
}
if (TIFFGetField(file->tiff, TIFFTAG_YRESOLUTION, &y_resolution) == 0) {
- PrintError("Cropped image contains XPosition and YPosition, but it does not contain Y Resultion. "
+ PrintError("Cropped image contains XPosition and YPosition, but it does not contain Y Resolution. "
"Report to developers you think this is a bug");
return FALSE;
}
Re: [hugin-ptx] libpano with Mercurial
On Tue 13-Nov-2012 at 01:25 -0400, Jim Watters wrote: I just grabbed the tip of libpano but noticed that there is a branch "libpano 13-2.9.18" that is not merged into the default branch. http://panotools.hg.sourceforge.net/hgweb/panotools/libpano/graph Reviewing the changes, I see that the same one have been added to the default branch also, but I was wondering if it should be merged just to keep as few branches open as possible? This was a branch for stabilising the 2.9.18 release, there shouldn't be anything in it that needs to be merged back into 'default'. In mercurial a branch can be marked as closed, so you can close it, this would make sense. -- Bruno -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx
[hugin-ptx] libpano with Mercurial
I use Mercurial infrequently. I just grabbed the tip of libpano but noticed that there is a branch "libpano 13-2.9.18" that is not merged into the default branch. http://panotools.hg.sourceforge.net/hgweb/panotools/libpano/graph Reviewing the changes, I see that the same one have been added to the default branch also, but I was wondering if it should be merged just to keep as few branches open as possible? If so, should revision 758 be merged with revision 756 or to the tip? -- Jim Watters http://photocreations.ca -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx
Re: [hugin-ptx] libpano updated
On Wed, Jan 5, 2011 at 6:51 AM, Kornel Benko wrote: > Nice, but dump.h should be commited too :) > > ... Done -- --dmg --- Daniel M. German http://turingmachine.org -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx
Re: [hugin-ptx] libpano updated
Am Mittwoch, 5. Januar 2011 schrieb D M German: > I have added the Thoby projection for the Nikkor 10.5. It is now in > subversion. I have called it after Michel Thoby who was able to > empirically find it. If this projection helps with other lenses, I'll > add parameters to it. > > The input projection number is 20. > > Would the hugin developers add it to it? the libpano optimizer should be > capable of dealing with this new projection. > > My very preliminary tests seem to imply it is working as expected. Once > it is available in hugin I'll be able to do more testing. > > > > -dmg Nice, but dump.h should be commited too :) ... /usr/bin/gcc -Dpano13_EXPORTS -D__Ansi__ -O3 -DNDEBUG -fPIC -I/usr/src/panotools/trunk/libpano -o CMakeFiles/pano13.dir/dump.c.o -c /usr/src/panotools/trunk/libpano/dump.c /usr/src/panotools/trunk/libpano/dump.c:31: fatal error: dump.h: Datei oder Verzeichnis nicht gefunden Kornel signature.asc Description: This is a digitally signed message part.
[hugin-ptx] libpano updated
I have added the Thoby projection for the Nikkor 10.5. It is now in subversion. I have called it after Michel Thoby who was able to empirically find it. If this projection helps with other lenses, I'll add parameters to it. The input projection number is 20. Would the hugin developers add it to it? the libpano optimizer should be capable of dealing with this new projection. My very preliminary tests seem to imply it is working as expected. Once it is available in hugin I'll be able to do more testing. -dmg -- -- Daniel M. German http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx
[hugin-ptx] libpano svn 1229, compilation error
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I got a redefinition on indianness: PTcommon.c: In function ‘panoCreatePanorama’: PTcommon.c:709: warning: ‘regScript’ may be used uninitialized in this function libtool: compile: gcc -DHAVE_CONFIG_H -I. -DHasJPEG -DHasPNG -DHasTIFF - -DHasZLIB -D__Ansi__=1 -Wall -g -O2 -MT PTcommon.lo -MD -MP -MF .deps/PTcommon.Tpo -c PTcommon.c -o PTcommon.o >/dev/null 2>&1 mv -f .deps/PTcommon.Tpo .deps/PTcommon.Plo /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. - -DHasJPEG -DHasPNG -DHasTIFF -DHasZLIB -D__Ansi__=1 -Wall -g -O2 - -MT ColourBrightness.lo -MD -MP -MF .deps/ColourBrightness.Tpo -c -o ColourBrightness.lo ColourBrightness.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -DHasJPEG -DHasPNG -DHasTIFF - -DHasZLIB -D__Ansi__=1 -Wall -g -O2 -MT ColourBrightness.lo -MD -MP -MF .deps/ColourBrightness.Tpo -c ColourBrightness.c -fPIC -DPIC -o .libs/ColourBrightness.o ColourBrightness.c:49:1: warning: "LITTLE_ENDIAN" redefined In file included from /usr/include/bits/string2.h:52, from /usr/include/string.h:635, from filter.h:27, from ColourBrightness.c:30: /usr/include/endian.h:46:1: warning: this is the location of the previous definition ColourBrightness.c:64:2: error: #error "Either BIG_ENDIAN or LITTLE_ENDIAN must be #defined, but not both." ColourBrightness.c:66:8: warning: extra tokens at end of #endif directive ColourBrightness.c: In function ‘OutputPhotoshopCurve’: ColourBrightness.c:407: warning: implicit declaration of function ‘htons’ make[3]: *** [ColourBrightness.lo] Error 1 Regards Jean-Luc -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.11 (GNU/Linux) iD8DBQFLUfY3Xit3lz9m7V4RAoiGAJ4+Dnp6OkcU73SooC/nOj6etCHEjgCg7s4a oeDusp6VaLJ1afk1u3e5m3w= =Yb+r -END PGP SIGNATURE- -- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx
[hugin-ptx] libpano SVN 1137 fails to build
Hi, I get the following: [...] /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -DHasJPEG -DHasPNG -DHasTIFF -DHasZLIB -D__Ansi__=1 -g -O2 -MT PTDialogs.lo -MD -MP -MF .deps/PTDialogs.Tpo -c -o PTDialogs.lo PTDialogs.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -DHasJPEG -DHasPNG -DHasTIFF -DHasZLIB -D__Ansi__=1 -g -O2 -MT PTDialogs.lo -MD -MP -MF .deps/ PTDialogs.Tpo -c PTDialogs.c -fPIC -DPIC -o .libs/PTDialogs.o In file included from PTDialogs.c:29: sys_ansi.h:44: error: expected ‘)’ before ‘Owner’ sys_ansi.h:45: error: expected ‘)’ before ‘hDlg’ make[2]: *** [PTDialogs.lo] Error 1 I run Debian sid Regards Jean-Luc pgpZ1kpvyV1hs.pgp Description: PGP signature
[hugin-ptx] libpano on windows (WARNING: ADULT LANGUAGE)
What follow is a rant directed at those who push dynamic linking to libpano on Windows at the expenses of statically linked binaries: DO WHAT THE HELL YOU WANT ON AN EXTRA TRACK BUT PLEASE DON'T BREAK WHAT THE EXISTING DEFAULT TRACK THAT HAS WORKED IN THE PAST - SPECIFICALLY THE STATICALLY LINKED VERSION OF THE PANOTOOLS AND OF HUGIN! Dynamic linking on windows sucks. Stop it. Just stop. Any reference to Joel Spolski's recent article about the duct-tape programmer is intended. http://www.joelonsoftware.com/items/2009/09/23.html Yuv --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx -~--~~~~--~~--~--~---
[hugin-ptx] libpano: supporting kfreebsd-*
Hello,
Debian is currently applying the patch quoted below to get libpano13
to build on kfreebsd-*. It would be nice if this could applied.
thanks, cu andreas
==
Author: Cyril Brulebois
http://bugs.debian.org/543998
--- a/configure
+++ b/configure
@@ -19275,7 +19275,7 @@ case "${host_os}" in
HSYS=unknown
HCPU="${host_cpu}"
;;
- linux*)
+ linux*|k*bsd*)
PANO_WIN32_RESOURCE=
HSYS=linux
case "${host_cpu}" in
--- a/configure.ac
+++ b/configure.ac
@@ -27,7 +27,7 @@ case "${host_os}" in
HSYS=unknown
HCPU="${host_cpu}"
;;
- linux*)
+ linux*|k*bsd*)
PANO_WIN32_RESOURCE=
HSYS=linux
dnl
==
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"hugin and other free panoramic software" group.
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---
[hugin-ptx] libpano
I have committed the changes to support tilt of the camera in PToptimizer and PTmender. See the ChangeLog for details. the new parameters are: Tx, Ty, Tz, and Ts (for scale). --dmg -- -- Daniel M. German http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx -~--~~~~--~~--~--~---
[hugin-ptx] Libpano locale fix
http://sourceforge.net/tracker/?func=detail&atid=550441&aid=2826516&group_id=77506 can somebody please apply the patch attached to Hugin's tracker to Libpano? or even better: give Thomas Modes SVN write access to libpano? Yuv --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx -~--~~~~--~~--~--~---
