Re: potential pop3d memory leakage (2.1.16)

2004-03-25 Thread Michael Loftis
Also proxyd.c ignores servername:, I've got a few other patches going 
against mine but right at the top of cmdloop() (line 1427 my file which is 
probably wrong) we have a gethostname and a hostname variable isntead of 
using the common config_servername.  Not bad bug, just inconsistent.

Thanks for the popd_msg patch, I was sort of loathing trying to figure out 
where that one really needed to be!

--On Thursday, March 25, 2004 21:06 -0500 Ken Murchison <[EMAIL PROTECTED]> 
wrote:

Michael Loftis wrote:

First I realise that 2.1.16 is 'dead tree' now, however

inside of openinbox popd_msg is xmalloc-ed but as far as I can tell
NEVER free'd anywhere and is then leaked between sessions.
Can anyone confirm this?
You are correct.  Its been around for a while.  Here's the fix for 2.1

https://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/pop3d.c
.diff?r1=1.142.2.1&r2=1.142.2.3
--
Kenneth Murchison Oceana Matrix Ltd.
Software Engineer 21 Princeton Place
716-662-8973 x26  Orchard Park, NY 14127
--PGP Public Key--http://www.oceana.com/~ken/ksm.pgp


--
Undocumented Features quote of the moment...
"It's not the one bullet with your name on it that you
have to worry about; it's the twenty thousand-odd rounds
labeled `occupant.'"
  --Murphy's Laws of Combat
---
Home Page: http://asg.web.cmu.edu/cyrus
Wiki/FAQ: http://cyruswiki.andrew.cmu.edu
List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html


Re: potential pop3d memory leakage (2.1.16)

2004-03-25 Thread Ken Murchison
Michael Loftis wrote:

First I realise that 2.1.16 is 'dead tree' now, however

inside of openinbox popd_msg is xmalloc-ed but as far as I can tell  
NEVER free'd anywhere and is then leaked between sessions.

Can anyone confirm this?
You are correct.  Its been around for a while.  Here's the fix for 2.1

https://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/pop3d.c.diff?r1=1.142.2.1&r2=1.142.2.3

--
Kenneth Murchison Oceana Matrix Ltd.
Software Engineer 21 Princeton Place
716-662-8973 x26  Orchard Park, NY 14127
--PGP Public Key--http://www.oceana.com/~ken/ksm.pgp
---
Home Page: http://asg.web.cmu.edu/cyrus
Wiki/FAQ: http://cyruswiki.andrew.cmu.edu
List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html