Re: [Intel-gfx] [PATCH] x86/gpu: add TGL stolen memory support

2019-07-16 Thread Thomas Gleixner
On Tue, 16 Jul 2019, Lucas De Marchi wrote:
> On Wed, Jul 17, 2019 at 12:46:42AM +0200, Thomas Gleixner wrote:
> > On Fri, 12 Jul 2019, Lucas De Marchi wrote:
> > 
> > > From: Michel Thierry 
> > > 
> > > Reuse Gen11 stolen memory changes since Tiger Lake uses the same BSM
> > > register (and format).
> > > 
> > > Cc: Thomas Gleixner 
> > > Cc: Ingo Molnar 
> > > Cc: Borislav Petkov 
> > > Cc: "H. Peter Anvin" 
> > > Cc: x...@kernel.org
> > > Signed-off-by: Michel Thierry 
> > > Signed-off-by: Lucas De Marchi 
> > > Reviewed-by: Rodrigo Vivi 
> > > ---
> > >  arch/x86/kernel/early-quirks.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/x86/kernel/early-quirks.c
> > > b/arch/x86/kernel/early-quirks.c
> > > index 6c4f01540833..6f6b1d04dadf 100644
> > > --- a/arch/x86/kernel/early-quirks.c
> > > +++ b/arch/x86/kernel/early-quirks.c
> > > @@ -549,6 +549,7 @@ static const struct pci_device_id intel_early_ids[]
> > > __initconst = {
> > >   INTEL_CNL_IDS(&gen9_early_ops),
> > >   INTEL_ICL_11_IDS(&gen11_early_ops),
> > >   INTEL_EHL_IDS(&gen11_early_ops),
> > > + INTEL_TGL_12_IDS(&gen11_early_ops),
> > 
> > How exactly is this supposed to build?
> > 
> 
> The define for this new platform is on drm-intel repository. For
> previous platforms we waited for an ack and merged through our tree.
> Is that ok?

That's fine, but in future please mention that instead of sending a patch
stand alone which looks like it can be applied without prerequisites.

That said, take it through DRM with:

   Acked-by: Thomas Gleixner 

Thanks,

tglx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] x86/gpu: add TGL stolen memory support

2019-07-16 Thread Lucas De Marchi

On Wed, Jul 17, 2019 at 12:46:42AM +0200, Thomas Gleixner wrote:

On Fri, 12 Jul 2019, Lucas De Marchi wrote:


From: Michel Thierry 

Reuse Gen11 stolen memory changes since Tiger Lake uses the same BSM
register (and format).

Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: Borislav Petkov 
Cc: "H. Peter Anvin" 
Cc: x...@kernel.org
Signed-off-by: Michel Thierry 
Signed-off-by: Lucas De Marchi 
Reviewed-by: Rodrigo Vivi 
---
 arch/x86/kernel/early-quirks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 6c4f01540833..6f6b1d04dadf 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -549,6 +549,7 @@ static const struct pci_device_id intel_early_ids[] 
__initconst = {
INTEL_CNL_IDS(&gen9_early_ops),
INTEL_ICL_11_IDS(&gen11_early_ops),
INTEL_EHL_IDS(&gen11_early_ops),
+   INTEL_TGL_12_IDS(&gen11_early_ops),


How exactly is this supposed to build?



The define for this new platform is on drm-intel repository. For
previous platforms we waited for an ack and merged through our tree.
Is that ok?

thanks
Lucas De Marchi
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] x86/gpu: add TGL stolen memory support

2019-07-16 Thread Thomas Gleixner
On Fri, 12 Jul 2019, Lucas De Marchi wrote:

> From: Michel Thierry 
> 
> Reuse Gen11 stolen memory changes since Tiger Lake uses the same BSM
> register (and format).
> 
> Cc: Thomas Gleixner 
> Cc: Ingo Molnar 
> Cc: Borislav Petkov 
> Cc: "H. Peter Anvin" 
> Cc: x...@kernel.org
> Signed-off-by: Michel Thierry 
> Signed-off-by: Lucas De Marchi 
> Reviewed-by: Rodrigo Vivi 
> ---
>  arch/x86/kernel/early-quirks.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 6c4f01540833..6f6b1d04dadf 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -549,6 +549,7 @@ static const struct pci_device_id intel_early_ids[] 
> __initconst = {
>   INTEL_CNL_IDS(&gen9_early_ops),
>   INTEL_ICL_11_IDS(&gen11_early_ops),
>   INTEL_EHL_IDS(&gen11_early_ops),
> + INTEL_TGL_12_IDS(&gen11_early_ops),

How exactly is this supposed to build?

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] x86/gpu: add TGL stolen memory support

2019-07-12 Thread Lucas De Marchi
From: Michel Thierry 

Reuse Gen11 stolen memory changes since Tiger Lake uses the same BSM
register (and format).

Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: Borislav Petkov 
Cc: "H. Peter Anvin" 
Cc: x...@kernel.org
Signed-off-by: Michel Thierry 
Signed-off-by: Lucas De Marchi 
Reviewed-by: Rodrigo Vivi 
---
 arch/x86/kernel/early-quirks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 6c4f01540833..6f6b1d04dadf 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -549,6 +549,7 @@ static const struct pci_device_id intel_early_ids[] 
__initconst = {
INTEL_CNL_IDS(&gen9_early_ops),
INTEL_ICL_11_IDS(&gen11_early_ops),
INTEL_EHL_IDS(&gen11_early_ops),
+   INTEL_TGL_12_IDS(&gen11_early_ops),
 };
 
 struct resource intel_graphics_stolen_res __ro_after_init = DEFINE_RES_MEM(0, 
0);
-- 
2.21.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx