Re: [Intel-gfx] [PATCH 06/13] drm/mxsfb: Drop drm_vblank_cleanup

[Marek Vasut]

On 06/21/2017 10:28 AM, Daniel Vetter wrote:
> Almost right but still racy, it's called before the interrupts are
> uninstalled. So let's just drop it.
> 
> Cc: Marek Vasut 
> Signed-off-by: Daniel Vetter 

Reviewed-by: Marek Vasut 

> ---
>  drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c 
> b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index d1b9c34c7c00..1853557fef46 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -256,7 +256,6 @@ static void mxsfb_unload(struct drm_device *drm)
>  
>   drm_kms_helper_poll_fini(drm);
>   drm_mode_config_cleanup(drm);
> - drm_vblank_cleanup(drm);
>  
>   pm_runtime_get_sync(drm->dev);
>   drm_irq_uninstall(drm);
> 


-- 
Best regards,
Marek Vasut
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 06/13] drm/mxsfb: Drop drm_vblank_cleanup

[Daniel Vetter]

Almost right but still racy, it's called before the interrupts are
uninstalled. So let's just drop it.

Cc: Marek Vasut 
Signed-off-by: Daniel Vetter 
---
 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c 
b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index d1b9c34c7c00..1853557fef46 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -256,7 +256,6 @@ static void mxsfb_unload(struct drm_device *drm)
 
drm_kms_helper_poll_fini(drm);
drm_mode_config_cleanup(drm);
-   drm_vblank_cleanup(drm);
 
pm_runtime_get_sync(drm->dev);
drm_irq_uninstall(drm);
-- 
2.11.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx