Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
pushed to drm-intel-next with a minor fix (s/References:/Closes:) On 5/22/2023 2:42 PM, Nirmoy Das wrote: i915_active_fini() finalizes the debug object, which can occur before the active retires and deactivates the debug object. Wait for one final time before calling i915_active_fini(); References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311 Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/i915_vma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index 20a44788999e..bad698bece27 100644 --- a/drivers/gpu/drm/i915/i915_vma.c +++ b/drivers/gpu/drm/i915/i915_vma.c @@ -1710,6 +1710,8 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt, if (vm_ddestroy) i915_vm_resv_put(vma->vm); + /* Wait for async active retire */ + i915_active_wait(>active); i915_active_fini(>active); GEM_WARN_ON(vma->resource); i915_vma_free(vma);
Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
Hi Andi, On 5/22/2023 4:56 PM, Andi Shyti wrote: Hi Nirmoy, On Mon, May 22, 2023 at 02:42:05PM +0200, Nirmoy Das wrote: i915_active_fini() finalizes the debug object, which can occur before the active retires and deactivates the debug object. Wait for one final time before calling i915_active_fini(); References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311 Signed-off-by: Nirmoy Das does this need the Fixes: tag? I can't pinpoint anything with a git blame also this is masked by https://gitlab.freedesktop.org/drm/intel/-/issues/6733. Reviewed-by: Andi Shyti Thanks, Nirmoy Andi
Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
On 22.05.2023 14:42, Nirmoy Das wrote: i915_active_fini() finalizes the debug object, which can occur before the active retires and deactivates the debug object. Wait for one final time before calling i915_active_fini(); References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311 Signed-off-by: Nirmoy Das Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/gpu/drm/i915/i915_vma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index 20a44788999e..bad698bece27 100644 --- a/drivers/gpu/drm/i915/i915_vma.c +++ b/drivers/gpu/drm/i915/i915_vma.c @@ -1710,6 +1710,8 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt, if (vm_ddestroy) i915_vm_resv_put(vma->vm); + /* Wait for async active retire */ + i915_active_wait(>active); i915_active_fini(>active); GEM_WARN_ON(vma->resource); i915_vma_free(vma);
Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
Hi Nirmoy, On Mon, May 22, 2023 at 02:42:05PM +0200, Nirmoy Das wrote: > i915_active_fini() finalizes the debug object, which can occur before > the active retires and deactivates the debug object. Wait for one > final time before calling i915_active_fini(); > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311 > Signed-off-by: Nirmoy Das does this need the Fixes: tag? Reviewed-by: Andi Shyti Andi
Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
On Mon, May 22, 2023 at 02:42:05PM +0200, Nirmoy Das wrote: > i915_active_fini() finalizes the debug object, which can occur before > the active retires and deactivates the debug object. Wait for one > final time before calling i915_active_fini(); > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311 > Signed-off-by: Nirmoy Das Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_vma.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c > index 20a44788999e..bad698bece27 100644 > --- a/drivers/gpu/drm/i915/i915_vma.c > +++ b/drivers/gpu/drm/i915/i915_vma.c > @@ -1710,6 +1710,8 @@ static void release_references(struct i915_vma *vma, > struct intel_gt *gt, > if (vm_ddestroy) > i915_vm_resv_put(vma->vm); > > + /* Wait for async active retire */ > + i915_active_wait(>active); > i915_active_fini(>active); > GEM_WARN_ON(vma->resource); > i915_vma_free(vma); > -- > 2.39.0 >
