Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Tue, Nov 22, 2011 at 06:41, Andrew Lutomirski l...@mit.edu wrote: On Thu, Nov 17, 2011 at 1:22 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: Oops, sorry for wasting your time, wrong branch. Can you try the for-poland one? And also please try what happens when enabling the iommu. for-poland with semaphores, rc6, and iommu on seems to work. I'm sending this email from that kernel right now :) Just to double-check: Can you please retest my latest ppgtt branch available at: http://cgit.freedesktop.org/~danvet/drm/log/?h=ppgtt If that works for you with DMAR and semaphores enabled, a tested-by is highly appreciated. Thanks, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Mon, Nov 21, 2011 at 09:41:26PM -0800, Andrew Lutomirski wrote: On Thu, Nov 17, 2011 at 1:22 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: Oops, sorry for wasting your time, wrong branch. Can you try the for-poland one? And also please try what happens when enabling the iommu. for-poland with semaphores, rc6, and iommu on seems to work. I'm sending this email from that kernel right now :) Awesome! Well, not quite because it still blows up for me (but no longer hard-hangs, just gpu death). Can you please attach full dmesg and lspci -nn, I want to check a few things? Thanks a lot, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Thu, Nov 17, 2011 at 1:22 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: Oops, sorry for wasting your time, wrong branch. Can you try the for-poland one? And also please try what happens when enabling the iommu. for-poland with semaphores, rc6, and iommu on seems to work. I'm sending this email from that kernel right now :) --Andy ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Thu, Nov 17, 2011 at 19:31, Nicolas Kalkhof nkalk...@web.de wrote: Hi Daniel, no problem :). Your patches look good! No hangs or stalls so far with semaphores and rc6 switched on. However I had to disable intel_iommu since it freezes my box shortly after firing up X :(. Meh, so ppgtt doesn't seem to help rc6 hangs caused by dmar. Has anything changed wrt how the machine hangs, i.e. can you gather more information via ssh/logs/netconsole/error_state? One other thing still remains: Since the merges for kernel 3.2 came in late october, my cpu/gpu seems to run hotter (approx 10 °C) when idling and after some minutes the cpu load goes up on all cores but the cpu frequency stays low (800 MHz) as well as the gpu (650MHz) and the system is responding well. Yet still additional 5-8 watts are drained from the power supply. Something has to throttle up :(. Oprofile shows that the kernel somewhere hogs the cpu (see dump below). This happens with every kernel from 3.1 up to latest linux-next. I wasn't able to track the bug down yet so I guess I'll better file a bug report on lkml to get someone to verify this. Iirc not the first time I've heard of this. Reporting a bug to lkml sounds like the right thing to do (kernel bugzilla is still down). Thanks for testing, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
Daniel, your ppgtt branch commit hardlocks my machine (SNB Mobile GT2+) as soon as I fire up X with a black screen. No crashdumps/syslogs :( Kernel params are: intel_iommu=off pcie_aspm=force i915.i915_enable_rc6=1. neither i915.semaphores=1 changes that nor does dmesg yield anything fancy. Regards, Nic -Ursprüngliche Nachricht- Von: Daniel Vetter daniel.vet...@ffwll.ch Gesendet: Nov 16, 2011 10:14:18 PM An: Nicolas Kalkhof nkalk...@web.de Betreff: Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default On Wed, Nov 16, 2011 at 21:56, Nicolas Kalkhof nkalk...@web.de wrote: Not quite. On my i7 2620M (Lenovo T420) the gpu frequently hangs when decoding videos (vaapi) and running OpenGL apps/games at the same time. Disabling iommu makes my system relatively stable even with rc6 enabled. I haven't played with the semaphores however. Can you please try my ppgtt branch from my fdo repo at http://cgit.freedesktop.org/~danvet/drm/ ? Note thought that it'll only work on snb/ivb and that suspend/resume is broken. Also, it won't properly re-enable ppgtt when resetting the gpu after a hang. But testing feedback highly appreciated. Thanks, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ SMS schreiben mit WEB.DE FreeMail - einfach, schnell und kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
Oops, sorry for wasting your time, wrong branch. Can you try the for-poland one? And also please try what happens when enabling the iommu. Thanks, Daniel On Thu, Nov 17, 2011 at 09:57, Nicolas Kalkhof nkalk...@web.de wrote: Daniel, your ppgtt branch commit hardlocks my machine (SNB Mobile GT2+) as soon as I fire up X with a black screen. No crashdumps/syslogs :( Kernel params are: intel_iommu=off pcie_aspm=force i915.i915_enable_rc6=1. neither i915.semaphores=1 changes that nor does dmesg yield anything fancy. Regards, Nic -Ursprüngliche Nachricht- Von: Daniel Vetter daniel.vet...@ffwll.ch Gesendet: Nov 16, 2011 10:14:18 PM An: Nicolas Kalkhof nkalk...@web.de Betreff: Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default On Wed, Nov 16, 2011 at 21:56, Nicolas Kalkhof nkalk...@web.de wrote: Not quite. On my i7 2620M (Lenovo T420) the gpu frequently hangs when decoding videos (vaapi) and running OpenGL apps/games at the same time. Disabling iommu makes my system relatively stable even with rc6 enabled. I haven't played with the semaphores however. Can you please try my ppgtt branch from my fdo repo at http://cgit.freedesktop.org/~danvet/drm/ ? Note thought that it'll only work on snb/ivb and that suspend/resume is broken. Also, it won't properly re-enable ppgtt when resetting the gpu after a hang. But testing feedback highly appreciated. Thanks, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ SMS schreiben mit WEB.DE FreeMail - einfach, schnell und kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192 -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
Hi Daniel, no problem :). Your patches look good! No hangs or stalls so far with semaphores and rc6 switched on. However I had to disable intel_iommu since it freezes my box shortly after firing up X :(. One other thing still remains: Since the merges for kernel 3.2 came in late october, my cpu/gpu seems to run hotter (approx 10 °C) when idling and after some minutes the cpu load goes up on all cores but the cpu frequency stays low (800 MHz) as well as the gpu (650MHz) and the system is responding well. Yet still additional 5-8 watts are drained from the power supply. Something has to throttle up :(. Oprofile shows that the kernel somewhere hogs the cpu (see dump below). This happens with every kernel from 3.1 up to latest linux-next. I wasn't able to track the bug down yet so I guess I'll better file a bug report on lkml to get someone to verify this. Regards Nic CPU: Intel Sandy Bridge microarchitecture, speed 2.701e+06 MHz (estimated) Counted CPU_CLK_UNHALTED events (Clock cycles when not halted) with a unit mask of 0x00 (No unit mask) count 10 CPU_CLK_UNHALT...| samples| %| -- 2195235 99.7680 vmlinux 3485 0.1584 oprofiled 478 0.0217 libc-2.13.so 393 0.0179 cfbimgblt 221 0.0100 libcrypt-2.13.so 123 0.0056 libncursesw.so.5.9 99 0.0045 iwlwifi 63 0.0029 bash 57 0.0026 cfbfillrect 39 0.0018 bitblit 37 0.0017 ld-2.13.so 27 0.0012 fbcon 25 0.0011 htop 18 8.2e-04 e1000e 10 4.5e-04 acpid 5 2.3e-04 softcursor 4 1.8e-04 fb 4 1.8e-04 i915 3 1.4e-04 libncurses.so.5.9 2 9.1e-05 grep 2 9.1e-05 login 2 9.1e-05 libpam.so.0.83.1 2 9.1e-05 wpa_supplicant 1 4.5e-05 libnss_compat-2.13.so 1 4.5e-05 pam_access.so 1 4.5e-05 wpa_cli 1 4.5e-05 libglib-2.0.so.0.3000.2 1 4.5e-05 libsyslog-ng.so.0.0.0 -Ursprüngliche Nachricht- Von: Daniel Vetter daniel.vet...@ffwll.ch Gesendet: Nov 17, 2011 10:22:07 AM An: Nicolas Kalkhof nkalk...@web.de Betreff: Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default Oops, sorry for wasting your time, wrong branch. Can you try the for-poland one? And also please try what happens when enabling the iommu. Thanks, Daniel On Thu, Nov 17, 2011 at 09:57, Nicolas Kalkhof nkalk...@web.de wrote: Daniel, your ppgtt branch commit hardlocks my machine (SNB Mobile GT2+) as soon as I fire up X with a black screen. No crashdumps/syslogs :( Kernel params are: intel_iommu=off pcie_aspm=force i915.i915_enable_rc6=1. neither i915.semaphores=1 changes that nor does dmesg yield anything fancy. Regards, Nic -Ursprüngliche Nachricht- Von: Daniel Vetter daniel.vet...@ffwll.ch Gesendet: Nov 16, 2011 10:14:18 PM An: Nicolas Kalkhof nkalk...@web.de Betreff: Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default On Wed, Nov 16, 2011 at 21:56, Nicolas Kalkhof nkalk...@web.de wrote: Not quite. On my i7 2620M (Lenovo T420) the gpu frequently hangs when decoding videos (vaapi) and running OpenGL apps/games at the same time. Disabling iommu makes my system relatively stable even with rc6 enabled. I haven't played with the semaphores however. Can you please try my ppgtt branch from my fdo repo at http://cgit.freedesktop.org/~danvet/drm/ ? Note thought that it'll only work on snb/ivb and that suspend/resume is broken. Also, it won't properly re-enable ppgtt when resetting the gpu after a hang. But testing feedback highly appreciated. Thanks, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ SMS schreiben mit WEB.DE FreeMail - einfach, schnell und kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192 -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ SMS schreiben mit WEB.DE FreeMail - einfach, schnell und kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Mon, Nov 14, 2011 at 21:39, Eugeni Dodonov eugeni.dodo...@intel.com wrote: Semaphores seem to fix most of the hangs on SNB and IVB, and do not cause any known regressions as of now. Let's re-enable them by default to provide a wider testing and coverage. Acked-by: Keith Packard kei...@keithp.com CC: Jesse Barnes jbar...@virtuousgeek.org CC: Daniel Vetter daniel.vet...@ffwll.ch Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42696 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40564 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862 Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com Semaphores are still broken on my snb in combination with DMAR. ppgtt seems to slightly change the failure mode and probably helps in tracking this down, but without ppgtt it's a hard hang a few seconds after login. So we need to check whether DMAR is enabled (on the entire system, i.e. the variable exported for the ilk workaround is not good enough) on snb and then disable it by default. So in this current form: Nacked-by: Daniel Vetter daniel.vet...@ffwll.ch (still causes easily reproducible hard-hangs) I don't have anything against enabling this by default on ivb. -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Wed, 16 Nov 2011 16:49:40 +0100, Daniel Vetter daniel.vet...@ffwll.ch wrote: So we need to check whether DMAR is enabled (on the entire system, i.e. the variable exported for the ilk workaround is not good enough) Can you figure out what *would* be sufficient? Getting semaphores turned on for the 99% who aren't enabling VT-d would be a fairly nice performance improvement. -- keith.pack...@intel.com pgp2bBgO64y9R.pgp Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Wed, Nov 16, 2011 at 15:24, Andrew Lutomirski l...@mit.edu wrote: AFAICT my snb laptop has always been stable with semaphores and VT-d enabled. Is this problem possibly restricted to just desktop machines? I'm happy to test, since my box that can reproduce the hang instantly is still around. I cannot reproduce those issues on any mobile SNB, but I am out of desktop ones. So perhaps it is a clue. Jesse, Keith, Daniel, what if we add something like: ... .has_semaphores=1, .has_rc6=1 ... to i915_drv.c intel_sandybridge_m_info, and take them into account when using default values for those settings? -- Eugeni Dodonov http://eugeni.dodonov.net/ ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Wed, 16 Nov 2011 17:05:37 -0200 Eugeni Dodonov eug...@dodonov.net wrote: On Wed, Nov 16, 2011 at 15:24, Andrew Lutomirski l...@mit.edu wrote: AFAICT my snb laptop has always been stable with semaphores and VT-d enabled. Is this problem possibly restricted to just desktop machines? I'm happy to test, since my box that can reproduce the hang instantly is still around. I cannot reproduce those issues on any mobile SNB, but I am out of desktop ones. So perhaps it is a clue. Jesse, Keith, Daniel, what if we add something like: ... .has_semaphores=1, .has_rc6=1 ... to i915_drv.c intel_sandybridge_m_info, and take them into account when using default values for those settings? Something like that is fine with me, or just doing it in modeset_init for certain chipsets. -- Jesse Barnes, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Wed, Nov 16, 2011 at 18:16, Keith Packard kei...@keithp.com wrote: On Wed, 16 Nov 2011 16:49:40 +0100, Daniel Vetter daniel.vet...@ffwll.ch wrote: So we need to check whether DMAR is enabled (on the entire system, i.e. the variable exported for the ilk workaround is not good enough) Can you figure out what *would* be sufficient? Getting semaphores turned on for the 99% who aren't enabling VT-d would be a fairly nice performance improvement. Last time I've played around with all the combinations, only intel_iommu=off was good enough to prevent the hang. intel_iommu=igd_off still hangs (which is what the current value exported by the dmar code dopends on, iirc). If I remember things correctly, intel_iommu=off also reliably works around issues for all reporters (both semaphores and rc6). And for reproducing it, at least here the key ingredient seems to be a kde4 desktop. Spare the jokes ;-) -Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
Not quite. On my i7 2620M (Lenovo T420) the gpu frequently hangs when decoding videos (vaapi) and running OpenGL apps/games at the same time. Disabling iommu makes my system relatively stable even with rc6 enabled. I haven't played with the semaphores however. -- Nic -Ursprüngliche Nachricht- Von: Andrew Lutomirski l...@mit.edu Gesendet: Nov 16, 2011 6:24:54 PM An: Keith Packard kei...@keithp.com Betreff: Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default On Wed, Nov 16, 2011 at 9:16 AM, Keith Packard kei...@keithp.com wrote: On Wed, 16 Nov 2011 16:49:40 +0100, Daniel Vetter daniel.vet...@ffwll.ch wrote: So we need to check whether DMAR is enabled (on the entire system, i.e. the variable exported for the ilk workaround is not good enough) Can you figure out what *would* be sufficient? Getting semaphores turned on for the 99% who aren't enabling VT-d would be a fairly nice performance improvement. AFAICT my snb laptop has always been stable with semaphores and VT-d enabled. Is this problem possibly restricted to just desktop machines? I'm happy to test, since my box that can reproduce the hang instantly is still around. Also, rc6-by-default would be very nice. It decreases the total power consumption on my laptop from over 13W to around 8W. That's huge. --Andy ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ___ SMS schreiben mit WEB.DE FreeMail - einfach, schnell und kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Wed, Nov 16, 2011 at 21:56, Nicolas Kalkhof nkalk...@web.de wrote: Not quite. On my i7 2620M (Lenovo T420) the gpu frequently hangs when decoding videos (vaapi) and running OpenGL apps/games at the same time. Disabling iommu makes my system relatively stable even with rc6 enabled. I haven't played with the semaphores however. Can you please try my ppgtt branch from my fdo repo at http://cgit.freedesktop.org/~danvet/drm/ ? Note thought that it'll only work on snb/ivb and that suspend/resume is broken. Also, it won't properly re-enable ppgtt when resetting the gpu after a hang. But testing feedback highly appreciated. Thanks, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Wed, 16 Nov 2011 21:18:13 +0100, Daniel Vetter daniel.vet...@ffwll.ch wrote: Last time I've played around with all the combinations, only intel_iommu=off was good enough to prevent the hang. intel_iommu=igd_off still hangs (which is what the current value exported by the dmar code dopends on, iirc). If I remember things correctly, intel_iommu=off also reliably works around issues for all reporters (both semaphores and rc6). So, the dmar_disabled flag would suffice? Should be trivial to export that and check in our driver. -- keith.pack...@intel.com pgpzri5pUuZyX.pgp Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Wed, 16 Nov 2011 21:56:37 +0100 (CET), Nicolas Kalkhof nkalk...@web.de wrote: Not quite. On my i7 2620M (Lenovo T420) the gpu frequently hangs when decoding videos (vaapi) and running OpenGL apps/games at the same time. Disabling iommu makes my system relatively stable even with rc6 enabled. I haven't played with the semaphores however. So, if we disabled rc6 when iommu is enabled (dmar_disable = 0), we should be in good shape then. -- keith.pack...@intel.com pgpeKemZMe720.pgp Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/2] drm/i915: re-enable semaphores by default
On Mon, 14 Nov 2011 18:39:14 -0200 Eugeni Dodonov eugeni.dodo...@intel.com wrote: Semaphores seem to fix most of the hangs on SNB and IVB, and do not cause any known regressions as of now. Let's re-enable them by default to provide a wider testing and coverage. Acked-by: Keith Packard kei...@keithp.com CC: Jesse Barnes jbar...@virtuousgeek.org CC: Daniel Vetter daniel.vet...@ffwll.ch Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42696 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40564 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862 Signed-off-by: Eugeni Dodonov eugeni.dodo...@intel.com --- drivers/gpu/drm/i915/i915_drv.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index cc531bb..71f887a 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -58,10 +58,10 @@ module_param_named(powersave, i915_powersave, int, 0600); MODULE_PARM_DESC(powersave, Enable powersavings, fbc, downclocking, etc. (default: true)); -unsigned int i915_semaphores __read_mostly = 0; +unsigned int i915_semaphores __read_mostly = 1; module_param_named(semaphores, i915_semaphores, int, 0600); MODULE_PARM_DESC(semaphores, - Use semaphores for inter-ring sync (default: false)); + Use semaphores for inter-ring sync (default: true)); unsigned int i915_enable_rc6 __read_mostly = 0; module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600); I think we should keep them enabled; if one or two fat cats in the 1% still have issues we can debug those without bringing down performance for the other 99%. Acked-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
