[PHP-DEV] Re: RFC for new INI's
Hi Eric. On 10.02.2009 3:27 Uhr, Eric Stewart wrote: A new RFC for PHP's proposed INI files have been added to the wiki. Below is a direct link to the page. http://wiki.php.net/rfc/newinis I love the settings for production, but I think you reversed the meaning of allow_call_time_pass_reference - if it is allowed no warning will be issued. So, to make your intention of ; Default Value: On (Issue warnings) ; Development Value: On (Issue warnings) ; Production Value: Off (Suppress warnings) work, you need to write that the other way around - 'Off' means 'issue warnings'... It is: Development Value: Off (Issue warnings) Production Value: On (Suppress warnings) In production session.bug_compat_42 is off, but according to the summary you want it to be on for development (so that warnings about it are shown, I assume). In the development php.ini the actual values for both settings are off, though. And I am not sure about register_argc_argv having different values in both files. I understand ot being off in production for speed reasons, but if it just works in development and suddenly stops working in production... But that's a minor issues. All in all like the proposed settings! Regards, Karsten -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: RFC for new INI's
2009/2/10 Karsten Dambekalns kars...@typo3.org: Hi Eric. On 10.02.2009 3:27 Uhr, Eric Stewart wrote: A new RFC for PHP's proposed INI files have been added to the wiki. Below is a direct link to the page. http://wiki.php.net/rfc/newinis I love the settings for production, but I think you reversed the meaning of allow_call_time_pass_reference - if it is allowed no warning will be issued. So, to make your intention of ; Default Value: On (Issue warnings) ; Development Value: On (Issue warnings) ; Production Value: Off (Suppress warnings) work, you need to write that the other way around - 'Off' means 'issue warnings'... It is: Development Value: Off (Issue warnings) Production Value: On (Suppress warnings) In production session.bug_compat_42 is off, but according to the summary you want it to be on for development (so that warnings about it are shown, I assume). In the development php.ini the actual values for both settings are off, though. And I am not sure about register_argc_argv having different values in both files. I understand ot being off in production for speed reasons, but if it just works in development and suddenly stops working in production... But that's a minor issues. All in all like the proposed settings! Regards, Karsten -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php Regarding ... ; Section headers (e.g. [Foo]) are also silently ignored, even though ; they might mean something in the future. This is no longer true. See http://docs.php.net/manual/en/ini.sections.php I would suggest changing this to ... ; Section headers (e.g. [Foo]) are also silently ignored, even though ; they might mean something in the future. The exception to this rule is ; section headers starting with [HOST= and [PATH= ; See : http://www.php.net/manual/en/ini.sections.php; Regards, Richard Quadling. -- - Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498r=213474731 Standing on the shoulders of some very clever giants! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: RFC for new INI's
2009/2/10 Richard Quadling rquadl...@googlemail.com: 2009/2/10 Karsten Dambekalns kars...@typo3.org: Hi Eric. On 10.02.2009 3:27 Uhr, Eric Stewart wrote: A new RFC for PHP's proposed INI files have been added to the wiki. Below is a direct link to the page. http://wiki.php.net/rfc/newinis I love the settings for production, but I think you reversed the meaning of allow_call_time_pass_reference - if it is allowed no warning will be issued. So, to make your intention of ; Default Value: On (Issue warnings) ; Development Value: On (Issue warnings) ; Production Value: Off (Suppress warnings) work, you need to write that the other way around - 'Off' means 'issue warnings'... It is: Development Value: Off (Issue warnings) Production Value: On (Suppress warnings) In production session.bug_compat_42 is off, but according to the summary you want it to be on for development (so that warnings about it are shown, I assume). In the development php.ini the actual values for both settings are off, though. And I am not sure about register_argc_argv having different values in both files. I understand ot being off in production for speed reasons, but if it just works in development and suddenly stops working in production... But that's a minor issues. All in all like the proposed settings! Regards, Karsten -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php Regarding ... ; Section headers (e.g. [Foo]) are also silently ignored, even though ; they might mean something in the future. This is no longer true. See http://docs.php.net/manual/en/ini.sections.php I would suggest changing this to ... ; Section headers (e.g. [Foo]) are also silently ignored, even though ; they might mean something in the future. The exception to this rule is ; section headers starting with [HOST= and [PATH= ; See : http://www.php.net/manual/en/ini.sections.php; Regards, Richard Quadling. -- - Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498r=213474731 Standing on the shoulders of some very clever giants! Better grammar. ; Section headers (e.g. [Foo]) are also silently ignored, even though ; they might mean something in the future. The exceptions to this rule are ; section headers starting with [HOST= or [PATH= ; See : http://www.php.net/manual/en/ini.sections.php; -- - Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498r=213474731 Standing on the shoulders of some very clever giants! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Invalid read at zend_objects_store_del_ref_by_handle #47353
Hi,
this is a small script to reproduce that problem :
?php
class A
{
function __destruct()
{
$myArray = array();
for($i = 1; $i = 2000; $i++) {
if(!isset($myArray[$i]))
$myArray[$i] = array();
$ref = $myArray[$i];
$ref[] = new stdClass();
}
}
}
$a = new A();
?
Note : that is dependent of the size of the array. With a value of 1000,
I haven't got the error.
I verify that problem on PHP 5.2.6 (debian lenny), php5.2-200902060730
and php5.3-200902101330.
And I report a bug : http://bugs.php.net/bug.php?id=47353
Thanks,
Olivier
Antony Dovgal a écrit :
On 07.02.2009 01:34, Olivier Bonvalet wrote:
And... if I'm not able to identify which part of the script do that ?
Remove parts of the code one by one, trying to see which parts affect it and
which do not.
Finally you should get only those parts of the code, which are required to
reproduce it.
I don't know valgrind, is it possible to obtain some informations about
the partion of code which produce that ?
It does show the part of the code which produces it, but the problem is
that it's part of C code, not PHP code and your issue happens on shutdown,
which means something somewhere went wrong BEFORE that point.
I suppose the name of the C functions should help to identify that, no ?
And zend_objects_store_del_ref is about object creation or destruction ?
Object destruction, right.
And, it's an object created thought zim_PDOStatement_fetchObject ?
It seems so, yes.
It makes sense to start looking into that direction if you want to create a reproduce script.
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] RFC for new INI's
Eric Stewart wrote: A new RFC for PHP's proposed INI files have been added to the wiki. Below is a direct link to the page. http://wiki.php.net/rfc/newinis Eric Lee Stewart ericleestew...@gmail.com Eric, Thanks for the work put into this. My comments follow. Chris - The section on devel prod setting differences looks nice but it does become a maintenance task. Since diffing files is easy (and relatively obvious), I'd suggest removing this section from the files. You may want to keep it in the RFC text so reviewers can get a quick idea of the intent of the differences. It's also not immediately obvious from this section whether the given values are the defaults, or what is set in each file, or set in the other file. In the section on extensions. IIRC, you can now use absolute paths. Change all http://us2.php.net/manual/en/; to http://www.php.net/manual/; (Maybe the doc team can confirm whether to keep the en) oci8.events and oci8.old_oci_close_semantics are boolean, so we can take this opportunity to change the 1 and 0 to On and Off. -- Email: christopher.jo...@oracle.com Tel: +1 650 506 8630 Twitter: http://twitter.com/ghrdFree PHP Book: http://tinyurl.com/UGPOM -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] ini value of On = 1 and Off = ? (Re: [PHP-DEV] RFC for new INI's)
Sorry to hijack, but ... Christopher Jones wrote: oci8.events and oci8.old_oci_close_semantics are boolean, so we can take this opportunity to change the 1 and 0 to On and Off. ... I've never understood why writing On/Off is a good idea, when it is not intuitive that the value returned from ini_get() is of a different content (not meaning, however). Or has this changed in more recent versions? mar...@dev01:~$ php -dregister_globals=Off -r 'var_dump(ini_get(register_globals));' string(0) mar...@dev01:~$ php -dregister_globals=On -r 'var_dump(ini_get(register_globals));' string(1) 1 mar...@dev01:~$ php -dregister_globals=0 -r 'var_dump(ini_get(register_globals));' string(1) 0 mar...@dev01:~$ php -dregister_globals=1 -r 'var_dump(ini_get(register_globals));' string(1) 1 mar...@dev01:~$ php -v PHP 5.2.5-3+lenny1 with Suhosin-Patch 0.9.6.2 (cli) (built: May 27 2008 21:47:08) regards, - Markus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] ini value of On = 1 and Off = ? (Re: [PHP-DEV] RFC for new INI's)
Markus Fischer wrote: Sorry to hijack, but ... Christopher Jones wrote: oci8.events and oci8.old_oci_close_semantics are boolean, so we can take this opportunity to change the 1 and 0 to On and Off. ... I've never understood why writing On/Off is a good idea, It improves human readability of php.ini, making it clear that the parameter value range is not numeric. when it is not intuitive that the value returned from ini_get() is of a different content (not meaning, however). It could possibly be argued there is an inconsistency somewhere, but then PHP type juggling and comparison have their own charm. Chris -- Email: christopher.jo...@oracle.com Tel: +1 650 506 8630 Twitter: http://twitter.com/ghrdFree PHP Book: http://tinyurl.com/UGPOM -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] RFC for new INI's
Hi, Some suggestions: Links: Instead of forcing language to english, allow autodetection from http headers. Before: http://www.php.net/manual/en/ini.core.php#ini.user-dir After: http://www.php.net/ini.core#ini.user-dir Also some things I think are not appropriate: extension_dir = ./ enable_dl = On Setting extension_dir to this value allows an attacker to execute code using dl(). I believe at least enable_dl should be disabled on production systems. Regarding register_argc_argv, you write: ; Development Value: On ; Production Value: Off However it's off in both case (which seems better to me anyway). Just a matter of fixing comments? For now that's everything that I saw, I'll take another look later :) Mark Le mardi 10 février 2009 à 08:17 -0800, Christopher Jones a écrit : Eric Stewart wrote: A new RFC for PHP's proposed INI files have been added to the wiki. Below is a direct link to the page. http://wiki.php.net/rfc/newinis Eric Lee Stewart ericleestew...@gmail.com Eric, Thanks for the work put into this. My comments follow. Chris - The section on devel prod setting differences looks nice but it does become a maintenance task. Since diffing files is easy (and relatively obvious), I'd suggest removing this section from the files. You may want to keep it in the RFC text so reviewers can get a quick idea of the intent of the differences. It's also not immediately obvious from this section whether the given values are the defaults, or what is set in each file, or set in the other file. In the section on extensions. IIRC, you can now use absolute paths. Change all http://us2.php.net/manual/en/; to http://www.php.net/manual/; (Maybe the doc team can confirm whether to keep the en) oci8.events and oci8.old_oci_close_semantics are boolean, so we can take this opportunity to change the 1 and 0 to On and Off. -- Email: christopher.jo...@oracle.com Tel: +1 650 506 8630 Twitter: http://twitter.com/ghrdFree PHP Book: http://tinyurl.com/UGPOM -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
