Re: [PHP-DEV] multi-jobs run-tests.php

2010-02-22 Thread Pierre Joye
hi,

There is an on-going work on run-test (which began as part of last
year GSoC). I would begin there instead of working on the current
run-test.php. Parallel testing is part of the new features as well, in
a portable way (like not only where pcntl is available).

Thanks for your work,

Cheers,
--
Pierre

On Mon, Feb 22, 2010 at 2:11 AM, Raphael Geissert geiss...@php.net wrote:
 Hi,

 I've spent the last hours working on making run-tests.php be able to run
 tests in parallel. The main reason being the time it takes to run the whole
 testsuite even on multicore CPUs.

 Attached is the first set of changes needed. It uses pcntl's fork and
 sysvmsg to send some of the results back to the parent process.

 Main functionalities still work, but the summary doesn't include failed
 tests.

 I plan to move away from sysvmsg because with the current implementation
 killing the parent process can leave message queues open (nothing that can't
 be fixed by adding a proper exit handler) and sysvmsg is not enabled by
 default. Probably to something php://memory-based.

 To support all the features under multi-jobs mode I think the proper fix is
 to cleanup the code so that run_test() stores the state information via an
 interface. This would make the code cleaner and would let multi-jobs mode
 just change the state-storing interface.

 How should I handle this? just by committing the changes? first sending them
 here (to internals)? by contacting somebody else?

 Cheers,
 --
 Raphael Geissert
 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php




-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] multi-jobs run-tests.php

2010-02-22 Thread Pierre Joye
forgot to add the link to the repo:

http://svn.php.net/viewvc/php/phpruntests/

On Mon, Feb 22, 2010 at 9:20 AM, Pierre Joye pierre@gmail.com wrote:
 hi,

 There is an on-going work on run-test (which began as part of last
 year GSoC). I would begin there instead of working on the current
 run-test.php. Parallel testing is part of the new features as well, in
 a portable way (like not only where pcntl is available).

 Thanks for your work,

 Cheers,
 --
 Pierre

 On Mon, Feb 22, 2010 at 2:11 AM, Raphael Geissert geiss...@php.net wrote:
 Hi,

 I've spent the last hours working on making run-tests.php be able to run
 tests in parallel. The main reason being the time it takes to run the whole
 testsuite even on multicore CPUs.

 Attached is the first set of changes needed. It uses pcntl's fork and
 sysvmsg to send some of the results back to the parent process.

 Main functionalities still work, but the summary doesn't include failed
 tests.

 I plan to move away from sysvmsg because with the current implementation
 killing the parent process can leave message queues open (nothing that can't
 be fixed by adding a proper exit handler) and sysvmsg is not enabled by
 default. Probably to something php://memory-based.

 To support all the features under multi-jobs mode I think the proper fix is
 to cleanup the code so that run_test() stores the state information via an
 interface. This would make the code cleaner and would let multi-jobs mode
 just change the state-storing interface.

 How should I handle this? just by committing the changes? first sending them
 here (to internals)? by contacting somebody else?

 Cheers,
 --
 Raphael Geissert
 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php




 --
 Pierre

 @pierrejoye | http://blog.thepimp.net | http://www.libgd.org




-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?

2010-02-22 Thread Pierre Joye
hi,

Please don't commit this change. I remember some issues with strtol
(portability, BC breaks, etc.). Please wait until we figured them out,
or find back in the archives why strtol could be a bad idea.

On Mon, Feb 22, 2010 at 2:21 AM, Raphael Geissert geiss...@php.net wrote:
 Raphael Geissert wrote:

 If there's no objection, I would like to remove them entirely and use
 strtol in php_filter_int.


 By the way, I don't think that the fact that strtol is locale-aware should
 be a reason to make the change. Since scripts are expected to use the value
 returned by filter_var() there should be no problem with the fact that
 strings such as 100'000 are accepted as a valid integer, under certain
 locales.

 Cheers,
 --
 Raphael Geissert

 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php





-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-DEV] PHP 6 Bug Summary Report

2010-02-22 Thread internals
 PHP 6 Bug Database summary - http://bugs.php.net/

 Num Status Summary (109 total -- which includes 47 feature requests)
===[Apache related]===
47061 Open   User not logged under Apache
===[Apache2 related]==
44083 Open   virtual() not outputting results if zlib.output_compression = 
On
===[Arrays related]===
35277 Suspended  incorrect recursion detection
41758 Assigned   SORT_LOCALE_STRING broken for sort() in PHP6
43109 Open   array_intersect() emits unexpected no of notices when 2d array 
is passed as arg
48478 Open   Super-globals cannot be accessed with literal keys
===[COM related]==
45836 Open   cannot use com 
===[Compile Failure]==
42606 Open   unicode/constants.c relies on ICU draft api
44502 Suspended  Compiling ok with MySQL 5.0
49421 Open   Make failure with MySQL 6 and PHP 6.0-dev
50101 Open   [PATCH] - Avoid name clash between global and local variable
50237 Open   [PATCH] - Enable correct behaviour when building PHP6 with 
Sun's compilers 
===[Date/time related]
46948 Assigned   ext/date/lib/parse_tz.c:99: Memory leak: buffer
===[Filesystem function related]==
42110 Open   fgetcsv doesn't handle \n correctly in multiline csv record
44034 Open   FILE_IGNORE_NEW_LINES in FILE does not work as expected when 
lines end in \r\n
46688 Open   Return values differ from 5.3 and are also inconsistent
46689 Open   Downcoded notices suggest unfinished code in file system?
46990 Assigned   Passing UTF8 strings to filesystem functions produce wrong 
filenames
49479 Open   move_uploaded_file is dead
===[GD related]===
34992 Assigned   imageconvolution does not respect alpha
43899 Assigned   Problem in displaying right to left connected languages (like 
persian, arabic)
===[HTTP related]=
49273 Open   setcookie() segfaults the php process when adding a positive 
expires value
===[I18N and L10N related]
42471 Open   locale_set_default returns true on invalid locales
===[ICONV related]
48538 Open   iconv_strlen() does not reject invalid charset on PHP6
===[mcrypt related]===
46834 Assigned   Range of mcrypt functions fail on PHP 6.0
===[MySQL related]
44076 Assigned   mysql_result returns nothing with blob
===[ODBC related]=
39756 Open   [PATCH] Crashes in fetching resultsets with LONG ASCII columns 
from MaxDB
===[OpenSSL related]==
25614 Assigned   openssl_pkey_get_public() fails when given a private key
===[PDO related]==
35368 Suspended  PDO query does not work properly with serialize
49270 Open   configure fails if PHP source folder path contains spaces
50420 Open   pdo_sqlite.so: undefined symbol: sqlite3_libversion
50818 Open   SQLSTATE[HY093]: Invalid parameter number: parameter was not 
defined
===[Performance problem]==
50157 Open   [patch] Replace !strlen(...) with !*...
50238 Analyzed   [PATCH] - Using #defines to improve the performance of the 
TSRMG macro
50436 Open   [PATCH] - Improving multi-threaded performance by propagating 
TSRMLS_C
===[PostgreSQL related]===
48265 Open   Source and result of database have different encodings.
===[Program Execution]
39992 Open   proc_terminate() leaves children of child running
43784 Assigned   escapeshellarg removes % from given string
===[Reproducible crash]===
45107 Open   setting ext_dir to ./ (and other ini settings) causes apache 
crash
===[Scripting Engine problem]=
47154 Open   Object properties unset after setting.
49945 Open   Array in multipart/form-data
===[Session related]==
44860 Open   session_encode() fails for php_binary serializer
===[SimpleXML related]
48601 Open   xpath() returns FALSE for legitimate query
===[SPL 

Re: [PHP-DEV] Patch for ext/openssl to support CN_match with asterisk

2010-02-22 Thread Bostjan Skufca
Below is the valgrind output. Seem like it is OpenSSL's fault? Thus I am not
filling another bug report. Or can you do anything about it?

b.


==12933==
==12933== IN SUMMARY: 563339 errors from 307 contexts (suppressed: 69 from
1)
==12933==
==12933== malloc/free: in use at exit: 1,628 bytes in 44 blocks.
==12933== malloc/free: 25,390 allocs, 25,346 frees, 3,335,313 bytes
allocated.
==12933==
==12933== searching for pointers to 44 not-freed blocks.
==12933== checked 1,023,180 bytes.
==12933==
==12933==
==12933== 348 bytes in 30 blocks are definitely lost in loss record 2 of 3
==12933==at 0x40237B9: malloc (in
/usr/lib/valgrind/x86-linux/vgpreload_memcheck.so)
==12933==by 0x4261D9A: default_malloc_ex (in
/usr/local/openssl-0.9.8l-1/lib/libcrypto.so.0.9.8)
==12933==
==12933== LEAK SUMMARY:
==12933==definitely lost: 348 bytes in 30 blocks.
==12933==  possibly lost: 0 bytes in 0 blocks.
==12933==still reachable: 1,280 bytes in 14 blocks.
==12933== suppressed: 0 bytes in 0 blocks.
==12933== Reachable blocks (those to which a pointer was found) are not
shown.
==12933== To see them, rerun with: --leak-check=full --show-reachable=yes
--12933--  memcheck: sanity checks: 165 cheap, 8 expensive
--12933--  memcheck: auxmaps: 0 auxmap entries (0k, 0M) in use
--12933--  memcheck: auxmaps_L1: 0 searches, 0 cmps, ratio 0:10
--12933--  memcheck: auxmaps_L2: 0 searches, 0 nodes
--12933--  memcheck: SMs: n_issued  = 102 (1632k, 1M)
--12933--  memcheck: SMs: n_deissued= 9 (144k, 0M)
--12933--  memcheck: SMs: max_noaccess  = 65535 (1048560k, 1023M)
--12933--  memcheck: SMs: max_undefined = 3 (48k, 0M)
--12933--  memcheck: SMs: max_defined   = 737 (11792k, 11M)
--12933--  memcheck: SMs: max_non_DSM   = 98 (1568k, 1M)
--12933--  memcheck: max sec V bit nodes:1189 (60k, 0M)
--12933--  memcheck: set_sec_vbits8 calls: 167151 (new: 1189, updates:
165962)
--12933--  memcheck: max shadow mem size:   1932k, 1M
--12933-- translate:fast SP updates identified: 83,889 ( 93.1%)
--12933-- translate:   generic_known SP updates identified: 4,337 (  4.8%)
--12933-- translate: generic_unknown SP updates identified: 1,816 (  2.0%)
--12933-- tt/tc: 87,945 tt lookups requiring 121,849 probes
--12933-- tt/tc: 87,945 fast-cache updates, 4 flushes
--12933--  transtab: new28,388 (755,681 - 12,187,193; ratio 161:10)
[0 scs]
--12933--  transtab: dumped 0 (0 - ??)
--12933--  transtab: discarded  186 (3,146 - ??)
--12933-- scheduler: 16,567,751 jumps (bb entries).
--12933-- scheduler: 165/111,191 major/minor sched events.
--12933--sanity: 166 cheap, 8 expensive checks.
--12933--exectx: 12,289 lists, 11,746 contexts (avg 0 per list)
--12933--exectx: 614,084 searches, 611,160 full compares (995 per 1000)
--12933--exectx: 1,029,878 cmp2, 839,523 cmp4, 0 cmpAll
--12933--  errormgr: 318 supplist searches, 318 comparisons during search
--12933--  errormgr: 563,408 errlist searches, 2,219,261 comparisons during
search


On 21 February 2010 14:51, Pierre Joye pierre@gmail.com wrote:

 hi,

 can you run it through valgrind and paste the output in a new bug report
 please?

 Cheers,

 On Sun, Feb 21, 2010 at 2:47 AM, Bostjan Skufca bost...@a2o.si wrote:
  a) If you would like to see an example of memory leak, here is how I
  reproduce it.
 
  1. Clone this git repository:
  http://github.com/bostjan/PHP-application-server
 
  2. Copy/move/Symlink contents to /opt/daemons/AppSrv
 
  3. cd to /opt/daemons/AppSrv/demos/demo_https
 
  4. start the daemon: ./demo -d5
  - binds and listens on port 3
  - does not fork into background
  7. execute ./client_openssl_nocert
 
  5. with another shell go to: /opt/daemons/AppSrv/demos/demo_https
 
  6. execute this: while (true); do ./client_curl; done
 
  7. start another shell and watch increasing residental memory of PHP
  server process
 
 
 
  b) If you would like to see an example of stale openssl_x509 resource
  bug, here is how I reproduce it.
  Follow the steps 1-5 above
 
  6. execute ./client_openssl
  - make some input, double return
  - watch at server console how correct CN appears two times
 
  7. execute ./client_openssl_nocert
  - watch at server console how STALE CN from previous connection appears
 
  8. execute ./client_openssl_nocert
  - and the bug is gone to hiding
 
  9. If you repeat steps 6-8 bug reappears/redissapears.
 
 
 
  I hope this helps,
  b.
 
 
 
  On 21 February 2010 01:45, Bostjan Skufca bost...@a2o.si wrote:
  The patch includes code which is very similar but it's functionality
  goes just the other way around.
 
  The original code takes remote CN and if that contains asterisk, it
  tries to 'limited-wildcard-match' of CN_match against remote CN
  (remote CN is the pattern in this case, if you will).
 
  On the other hand, added code checks if CN_match contains asterisk and
  if so, it does 'limited-wildcard-match' of REMOTE CN against CN_match
  pattern.
 
 
  The original version 'could' be 

[PHP-DEV] TNBT beta online at http://bugs-beta.php.net/

2010-02-22 Thread Jani Taskinen
FYI: I installed the new bug tracker to ez1.php.net for easier 
testing. Feel free to test it and comment to this thread. If the DNS has 
not propagated yet, just add this to your hosts file:


  128.39.198.38 bugs-beta.php.net

Keep in mind it's NOT totally new, it's simply been cleaned up and 
some tiny featurettes have been added / merged from PEAR bug tracker:


  - Bug type (Bug, Feature/Change Request or Documentation problem)
* This allows more fine-grained categorization, per pacakge

  - Changelog and SVN commits separate from regular comments

  - Patches / file attachements

  - Categories in DB instead of file
* TODO: Online editor for categories (or s.c. pseudo packages)

  - Preview for reporting new bugs

  - Everything is UTF-8 now
* f.e. http://bugs-beta.php.net/bug.php?id=51065edit=1 vs.
   http://bugs.php.net/bug.php?id=51065edit=1

  - Something I don't remember anymore.. :D

I wish this inspires more people to get involved and not waste time on 
the current bugs.php.net anymore. :)


--Jani


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?

2010-02-22 Thread Derick Rethans
On Mon, 22 Feb 2010, Pierre Joye wrote:

 On Mon, Feb 22, 2010 at 2:21 AM, Raphael Geissert geiss...@php.net wrote:
  Raphael Geissert wrote:
 
  If there's no objection, I would like to remove them entirely and use
  strtol in php_filter_int.
 
  By the way, I don't think that the fact that strtol is locale-aware should
  be a reason to make the change. Since scripts are expected to use the value
  returned by filter_var() there should be no problem with the fact that
  strings such as 100'000 are accepted as a valid integer, under certain
  locales.
 
 Please don't commit this change. I remember some issues with strtol
 (portability, BC breaks, etc.). Please wait until we figured them out,
 or find back in the archives why strtol could be a bad idea.

Poratability was indeed the reason, as well as the locale issues that 
you mention (POSIX locales==useless). Please don't commit this.

regards,
Derick

-- 
http://derickrethans.nl | http://xdebug.org
twitter: @derickr

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] TNBT beta online at http://bugs-beta.php.net/

2010-02-22 Thread Richard Quadling
On 22 February 2010 13:58, Jani Taskinen jani.taski...@iki.fi wrote:
 FYI: I installed the new bug tracker to ez1.php.net for easier testing.
 Feel free to test it and comment to this thread. If the DNS has not
 propagated yet, just add this to your hosts file:

  128.39.198.38 bugs-beta.php.net

 Keep in mind it's NOT totally new, it's simply been cleaned up and some
 tiny featurettes have been added / merged from PEAR bug tracker:

  - Bug type (Bug, Feature/Change Request or Documentation problem)
    * This allows more fine-grained categorization, per pacakge

  - Changelog and SVN commits separate from regular comments

  - Patches / file attachements

  - Categories in DB instead of file
    * TODO: Online editor for categories (or s.c. pseudo packages)

  - Preview for reporting new bugs

  - Everything is UTF-8 now
    * f.e. http://bugs-beta.php.net/bug.php?id=51065edit=1 vs.
           http://bugs.php.net/bug.php?id=51065edit=1

  - Something I don't remember anymore.. :D

 I wish this inspires more people to get involved and not waste time on the
 current bugs.php.net anymore. :)

 --Jani


 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php



A couple of low level things

1 - Can/should the PHP Versions include release candidates?

2 - Is Package affected: the right label?

3 - A patch file created using cvs diff -u ... cvs ?


Regards,

Richard.


-- 
-
Richard Quadling
Standing on the shoulders of some very clever giants!
EE : http://www.experts-exchange.com/M_248814.html
EE4Free : http://www.experts-exchange.com/becomeAnExpert.jsp
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498r=213474731
ZOPA : http://uk.zopa.com/member/RQuadling

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] multi-jobs run-tests.php

2010-02-22 Thread Raphael Geissert
Hi Pierre,

Pierre Joye wrote:
 There is an on-going work on run-test (which began as part of last
 year GSoC). I would begin there instead of working on the current
 run-test.php. Parallel testing is part of the new features as well, in
 a portable way (like not only where pcntl is available).
 

Ah, I see, great. 
From a quick look at the code it looks like it also uses pcntl.

Is there any plan to switch to that other implementation?

No work has been done in something like the threads extension, has there?

Cheers,
-- 
Raphael Geissert

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] multi-jobs run-tests.php

2010-02-22 Thread Jess Portnoy

Hello all,

While on the subject of run-tests.php, any plans for it to support web 
server SAPIs and not just CLI/CGI?
I've looked at http://qa.php.net/projects.php and saw no such bullet but 
I thought asking anyhow won't hurt.


Thanks,

May the source be with you,
Best regards,
Jess Portnoy



Raphael Geissert wrote:

Hi Pierre,

Pierre Joye wrote:
  

There is an on-going work on run-test (which began as part of last
year GSoC). I would begin there instead of working on the current
run-test.php. Parallel testing is part of the new features as well, in
a portable way (like not only where pcntl is available).




Ah, I see, great. 
From a quick look at the code it looks like it also uses pcntl.


Is there any plan to switch to that other implementation?

No work has been done in something like the threads extension, has there?

Cheers,
  


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] multi-jobs run-tests.php

2010-02-22 Thread Johannes Schlüter
On Mon, 2010-02-22 at 10:50 -0600, Raphael Geissert wrote:
 Ah, I see, great. 
 From a quick look at the code it looks like it also uses pcntl.
 
 Is there any plan to switch to that other implementation?
 
 No work has been done in something like the threads extension, has there?

Why would you need threads? - Won't some async process control be
enough? - The test manager doesn't have to be parallelized, it should
just run multiple tests at once. And yes, I'm very interested I have a
64 way SPARC machine which currently needs 7 days for a gcov run which,
in theory, might be reduced to 7/64 days ...

Another interesting thing might be directory-wide skipif so we don't
have to run two PHP interpreters per test.

But when working on all kinds of things there one should look on the
rewrite by Zoe (and others) which should be nicer for modification than
the grown code of the existing run-tests.php

johannes


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] TNBT beta online at http://bugs-beta.php.net/

2010-02-22 Thread Jani Taskinen

22.2.2010 17:28, Richard Quadling wrote:

A couple of low level things


Nitpicking, are we? :D


1 - Can/should the PHP Versions include release candidates?


Yes, they're outdated. This is one part that should be automated/centralized, 
it's enough PITA for the RMs already to remember all the places to update.


I'll added note to TODO about it.


2 - Is Package affected: the right label?


Yes, sort of. Remember this has origins in pear/pecl. And the ultimate goal has 
been to have single tracker to allow moving reports easily around.



3 - A patch file created using cvs diff -u ... cvs ?


Fixed. :) And thanks for noticing. (not yet updated on the bugs-beta site, no 
access from home :)


--Jani


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] TNBT beta online at http://bugs-beta.php.net/

2010-02-22 Thread Johannes Schlüter
Hi,

On Mon, 2010-02-22 at 15:58 +0200, Jani Taskinen wrote:
 FYI: I installed the new bug tracker to ez1.php.net for easier 
 testing. Feel free to test it and comment to this thread. If the DNS has 

Great!

- Patches / file attachements

I like the idea of calling it patch so users won't immediatly upload
large big applications. Is there a size limit?

- Something I don't remember anymore.. :D

The !Quick resolve dropdown box seems to be missing. Is that
intentional?

Anybody working on a target milestone Feature?

johannes


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] TNBT beta online at http://bugs-beta.php.net/

2010-02-22 Thread Jani Taskinen

22.2.2010 19:15, Johannes Schlüter wrote:

- Patches / file attachements


I like the idea of calling it patch so users won't immediatly upload
large big applications. Is there a size limit?


No limits apart from what is set in either httpd.conf or php.ini, also, they 
need to be text format.


Again, this is simply copy of what PEAR bug tracker has had for ages. Or at 
least one point had, dunno what they might be using right now.



The !Quick resolve dropdown box seems to be missing. Is that
intentional?


For some reason it's not shown if you're not logged in.
Should it be? :)


Anybody working on a target milestone Feature?


There's nobody working on anything except me randomly when I have had time..
Feel free. I'd rather see people improving on this than wasting time on the 
current horrid mess of php-bugs-web..


--Jani

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?

2010-02-22 Thread Raphael Geissert
Derick Rethans wrote:
 On Mon, 22 Feb 2010, Pierre Joye wrote:
 Please don't commit this change. I remember some issues with strtol
 (portability, BC breaks, etc.). Please wait until we figured them out,
 or find back in the archives why strtol could be a bad idea.
 
 Poratability was indeed the reason, as well as the locale issues that
 you mention (POSIX locales==useless). Please don't commit this.
 

Ok. Sean came up with a different patch which is being tested right now.
If all the tests pass then I'm going to commit it.

Cheers,
-- 
Raphael Geissert

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?

2010-02-22 Thread Pierre Joye
On Tue, Feb 23, 2010 at 12:13 AM, Raphael Geissert geiss...@php.net wrote:
 Derick Rethans wrote:
 On Mon, 22 Feb 2010, Pierre Joye wrote:
 Please don't commit this change. I remember some issues with strtol
 (portability, BC breaks, etc.). Please wait until we figured them out,
 or find back in the archives why strtol could be a bad idea.

 Poratability was indeed the reason, as well as the locale issues that
 you mention (POSIX locales==useless). Please don't commit this.


 Ok. Sean came up with a different patch which is being tested right now.
 If all the tests pass then I'm going to commit it.

What patch? Please do not commit anything there without first posting
to the list. There were enough breakage in this area, no need to
introduce new ones again.

Thanks for your understanding,

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?

2010-02-22 Thread Derick Rethans
On Mon, 22 Feb 2010, Raphael Geissert wrote:

 Derick Rethans wrote:
  On Mon, 22 Feb 2010, Pierre Joye wrote:
  Please don't commit this change. I remember some issues with strtol
  (portability, BC breaks, etc.). Please wait until we figured them out,
  or find back in the archives why strtol could be a bad idea.
  
  Poratability was indeed the reason, as well as the locale issues that
  you mention (POSIX locales==useless). Please don't commit this.
  
 
 Ok. Sean came up with a different patch which is being tested right now.
 If all the tests pass then I'm going to commit it.

What exactly are you trying to fix here?

Derick

-- 
http://derickrethans.nl | http://xdebug.org
twitter: @derickr

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?

2010-02-22 Thread Raphael Geissert
Derick Rethans wrote:

 What exactly are you trying to fix here?
 

gcc 4.4's optimiser removes the overflow check present in 
php_filter_parse_int and ZEND_HANDLE_NUMERIC (but I can't touch that part of 
the code anyway...) which prevents the overflow from being detected.

Cheers,
-- 
Raphael Geissert

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php