Re: [PHP-DEV] Request for php-src karma

[Kalle Sommer Nielsen]

2016-11-18 16:33 GMT+01:00 Taoguang Chen :
> I'm requesting php-src karma and security karma (r...@php.net 
> ), and I’m gladly willing to help with some security 
> issues. I had already submitted a lot of security issues in past.
>
> https://bugs.php.net/search.php?search_for==0=All_by==DESC=display=All_type=All=All_os==_id==_email=taoguangchen%40icloud.com_age=0_updated=0
>  
> 

ccing stas for this, as he is the main go to guy for this (and the one
that seems to have been assigned to most of the issues you have
reported)

-- 
regards,

Kalle Sommer Nielsen
ka...@php.net

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Request for php-src karma

[Taoguang Chen]

I'm requesting php-src karma and security karma (r...@php.net 
), and I’m gladly willing to help with some security 
issues. I had already submitted a lot of security issues in past.

https://bugs.php.net/search.php?search_for==0=All_by==DESC=display=All_type=All=All_os==_id==_email=taoguangchen%40icloud.com_age=0_updated=0
 

Re: [PHP-DEV] Request for php-src karma

[Christoph Becker]

Anatol Belski wrote:

 Christoph, please don't forget to note the changes in the NEWS and/or
 UPGRADING where appropriate. Also don't forget to check the lower
 branches where your fixes could be profitable.

Thanks for the hints.  As I understand it, I should inform the release
managers about changes in the respective branches.[1][2]  What is the
best way to do so?

[1] https://wiki.php.net/vcs/gitworkflow?s[]=releases[]=manager
[2] https://bugs.php.net/bug.php?id=68812#1433889583 (stas' comment)

-- 
Christoph M. Becker

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Request for php-src karma

[Christoph Becker]

Hi Anatol,

Anatol Belski wrote:

 Hi Christoph,
 
 -Original Message-
 From: Christoph Becker [mailto:cmbecke...@gmx.de]
 Sent: Thursday, June 11, 2015 1:03 PM
 To: Anatol Belski; internals@lists.php.net
 Subject: Re: [PHP-DEV] Request for php-src karma

 Anatol Belski wrote:

 Christoph, please don't forget to note the changes in the NEWS and/or
 UPGRADING where appropriate. Also don't forget to check the lower
 branches where your fixes could be profitable.

 Thanks for the hints.  As I understand it, I should inform the release 
 managers
 about changes in the respective branches.[1][2]  What is the best way to do 
 so?

 [1] https://wiki.php.net/vcs/gitworkflow?s[]=releases[]=manager
 [2] https://bugs.php.net/bug.php?id=68812#1433889583 (stas' comment)

 Please note also that there is a number of README files in the php-src dir, 
 like this one http://git.php.net/?p=php-src.git;a=blob;f=README.GIT-RULES . 
 In general, if you fix a bug and it's worth it to mention, you just push a 
 patch and add note into the NEWS. If in doubt, better to ask the RM whether 
 the patch is ok for that particular branch, of course.
 
 Pushing to the 5.4 branch is another story as only security fixes go in 
 there, so it has to be cleared out explicitly. The same will apply to any 
 other branch in security mode later, fe 5.5 which active development period 
 ends soon. Also as far as I see, the patch from the ticket you link was not 
 merged up as in accordance to the git workflow.
 
 The NEWS file has to be updated in all the active branches but master, 
 usually. Otherwise, if a fix in master only - so only NEWS in master. As we 
 now have no explicit PHP-7.0 branch, NEWS should be updated in master as well 
 until PHP-5.4 is EOL.

Thanks for the explanation.  That clarifies my questions. :)

-- 
Christoph M. Becker


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] Request for php-src karma

[Anatol Belski]

Hi Christoph,

 -Original Message-
 From: Christoph Becker [mailto:cmbecke...@gmx.de]
 Sent: Thursday, June 11, 2015 1:03 PM
 To: Anatol Belski; internals@lists.php.net
 Subject: Re: [PHP-DEV] Request for php-src karma
 
 Anatol Belski wrote:
 
  Christoph, please don't forget to note the changes in the NEWS and/or
  UPGRADING where appropriate. Also don't forget to check the lower
  branches where your fixes could be profitable.
 
 Thanks for the hints.  As I understand it, I should inform the release 
 managers
 about changes in the respective branches.[1][2]  What is the best way to do 
 so?
 
 [1] https://wiki.php.net/vcs/gitworkflow?s[]=releases[]=manager
 [2] https://bugs.php.net/bug.php?id=68812#1433889583 (stas' comment)
 
Please note also that there is a number of README files in the php-src dir, 
like this one http://git.php.net/?p=php-src.git;a=blob;f=README.GIT-RULES . In 
general, if you fix a bug and it's worth it to mention, you just push a patch 
and add note into the NEWS. If in doubt, better to ask the RM whether the patch 
is ok for that particular branch, of course.

Pushing to the 5.4 branch is another story as only security fixes go in there, 
so it has to be cleared out explicitly. The same will apply to any other branch 
in security mode later, fe 5.5 which active development period ends soon. Also 
as far as I see, the patch from the ticket you link was not merged up as in 
accordance to the git workflow.

The NEWS file has to be updated in all the active branches but master, usually. 
Otherwise, if a fix in master only - so only NEWS in master. As we now have no 
explicit PHP-7.0 branch, NEWS should be updated in master as well until PHP-5.4 
is EOL.

Regards

Anatol


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Request for php-src karma

[Christoph Becker]

Hi!

I'm requesting php-src karma (cmb@), mainly for bug-fix purposes.  I
have already submitted several PRs[1], and several of them have already
been merged.

It seems to me that it might save time, if I can commit obvious and
uncontroversial fixes directly instead of making PRs first.

Thanks for your consideration.

[1]
https://github.com/php/php-src/pulls?utf8=%E2%9C%93q=is%3Apr+author%3Acmb69

-- 
Christoph M. Becker

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Request for php-src karma

[Rasmus Lerdorf]

On 06/10/2015 03:25 PM, Christoph Becker wrote:
 Hi!
 
 I'm requesting php-src karma (cmb@), mainly for bug-fix purposes.  I
 have already submitted several PRs[1], and several of them have already
 been merged.
 
 It seems to me that it might save time, if I can commit obvious and
 uncontroversial fixes directly instead of making PRs first.

Done and thanks for all your help and patience on bugs.php.net.

-Rasmus




signature.asc
Description: OpenPGP digital signature

RE: [PHP-DEV] Request for php-src karma

[Anatol Belski]

Hi Rasmus,

 -Original Message-
 From: Rasmus Lerdorf [mailto:ras...@lerdorf.com]
 Sent: Thursday, June 11, 2015 12:41 AM
 To: Christoph Becker; internals@lists.php.net
 Subject: Re: [PHP-DEV] Request for php-src karma
 
 On 06/10/2015 03:25 PM, Christoph Becker wrote:
  Hi!
 
  I'm requesting php-src karma (cmb@), mainly for bug-fix purposes.  I
  have already submitted several PRs[1], and several of them have
  already been merged.
 
  It seems to me that it might save time, if I can commit obvious and
  uncontroversial fixes directly instead of making PRs first.
 
 Done and thanks for all your help and patience on bugs.php.net.
 
Thanks for giving Christoph the appropriate access, he's a very valuable 
extension to the team.

Christoph, please don't forget to note the changes in the NEWS and/or UPGRADING 
where appropriate. Also don't forget to check the lower branches where your 
fixes could be profitable.

Thanks.

Anatol



--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php