Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
> > I can sense we are all feeling like upping the value here. > > If we take it slow and move from 2MB to 8MB that would ease into it, and > see how it goes in our next release ? > > Do we RFC this? Who is volunteering to make it, > There is already a PR in GitHub the author should have Priority on this, otherwise I volunteer myself to help the author and work on this together.
Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
On Thu, 8 Sep 2022, 12:59 Christoph M. Becker, wrote: > On 08.09.2022 at 13:01, Andreas Heigl wrote: > > > On 08.09.22 12:35, Jakub Zelenka wrote: > > > >> On Wed, Sep 7, 2022 at 3:28 PM Christoph M. Becker > >> wrote: > >> > >>> On 07.09.2022 at 15:57, Misha wrote: > >>> > We spend a lot of time to increase limits for uploads file in PHP. > Can we > increase it in php.ini? > > Current value is 2Mb. Its so small value, when photo image can take > 8Mb > >>> on > iPhone X. > We should increase it to 50Mb, because DevOps engineers do useless > work > trying to change it. > > I have prepared PR for it https://github.com/php/php-src/pull/9315 > >>> > >>> I'm not against increasing the sizes, but 50MB might be too much. > >>> > >>> Anyway, only changing the php.ini files doesn't make sense in my > >>> opinion, since they're probably only used on Windows, and they should > >>> reflect the actual default values[1]. > >> > >> It's true that those particular ini files are not directly used on > >> Linux > >> but distros often base their changes on them and the distro provided > ones > >> are actually used. So it means that main defaults in main.c are most > >> likely > >> not used. Although I agree they should be changed too so it is > >> consistent. > > > > No matter which value we preset, it will most certainly not be adequate. > > > > So people *will* have to set it according to their needs. And if they > > didn't so far, then they are happy with the current setting. > > > > Don't get me wrong: I'm not against changing that value. > > > > But is it really an issue that needs solving? It's a default value of a > > configuration file. When I'm unhappy with the default, I change it to a > > more suitable value. When I'm not able to do that... perhaps I should > > leave my fingers not only from the config file... > > It might be worth to point out that we're using these defaults since PHP > 4.0 (at least), so reconsidering sensible defaults might be appropriate. > I can sense we are all feeling like upping the value here. If we take it slow and move from 2MB to 8MB that would ease into it, and see how it goes in our next release ? Do we RFC this? Who is volunteering to make it, if so? :-) > -- > Christoph M. Becker > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: https://www.php.net/unsub.php > >
Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
On 08.09.2022 at 13:01, Andreas Heigl wrote: > On 08.09.22 12:35, Jakub Zelenka wrote: > >> On Wed, Sep 7, 2022 at 3:28 PM Christoph M. Becker >> wrote: >> >>> On 07.09.2022 at 15:57, Misha wrote: >>> We spend a lot of time to increase limits for uploads file in PHP. Can we increase it in php.ini? Current value is 2Mb. Its so small value, when photo image can take 8Mb >>> on iPhone X. We should increase it to 50Mb, because DevOps engineers do useless work trying to change it. I have prepared PR for it https://github.com/php/php-src/pull/9315 >>> >>> I'm not against increasing the sizes, but 50MB might be too much. >>> >>> Anyway, only changing the php.ini files doesn't make sense in my >>> opinion, since they're probably only used on Windows, and they should >>> reflect the actual default values[1]. >> >> It's true that those particular ini files are not directly used on >> Linux >> but distros often base their changes on them and the distro provided ones >> are actually used. So it means that main defaults in main.c are most >> likely >> not used. Although I agree they should be changed too so it is >> consistent. > > No matter which value we preset, it will most certainly not be adequate. > > So people *will* have to set it according to their needs. And if they > didn't so far, then they are happy with the current setting. > > Don't get me wrong: I'm not against changing that value. > > But is it really an issue that needs solving? It's a default value of a > configuration file. When I'm unhappy with the default, I change it to a > more suitable value. When I'm not able to do that... perhaps I should > leave my fingers not only from the config file... It might be worth to point out that we're using these defaults since PHP 4.0 (at least), so reconsidering sensible defaults might be appropriate. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
Hey all. On 08.09.22 12:35, Jakub Zelenka wrote: On Wed, Sep 7, 2022 at 3:28 PM Christoph M. Becker wrote: On 07.09.2022 at 15:57, Misha wrote: We spend a lot of time to increase limits for uploads file in PHP. Can we increase it in php.ini? Current value is 2Mb. Its so small value, when photo image can take 8Mb on iPhone X. We should increase it to 50Mb, because DevOps engineers do useless work trying to change it. I have prepared PR for it https://github.com/php/php-src/pull/9315 I'm not against increasing the sizes, but 50MB might be too much. Anyway, only changing the php.ini files doesn't make sense in my opinion, since they're probably only used on Windows, and they should reflect the actual default values[1]. It's true that those particular ini files are not directly used on Linux but distros often base their changes on them and the distro provided ones are actually used. So it means that main defaults in main.c are most likely not used. Although I agree they should be changed too so it is consistent. No matter which value we preset, it will most certainly not be adequate. So people *will* have to set it according to their needs. And if they didn't so far, then they are happy with the current setting. Don't get me wrong: I'm not against changing that value. But is it really an issue that needs solving? It's a default value of a configuration file. When I'm unhappy with the default, I change it to a more suitable value. When I'm not able to do that... perhaps I should leave my fingers not only from the config file... My 0.02€ Cheers Andreas -- ,,, (o o) +-ooO-(_)-Ooo-+ | Andreas Heigl | | mailto:andr...@heigl.org N 50°22'59.5" E 08°23'58" | | https://andreas.heigl.org | +-+ | https://hei.gl/appointmentwithandreas | +-+ OpenPGP_0xA8D5437ECE724FE5.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
On Wed, Sep 7, 2022 at 3:28 PM Christoph M. Becker wrote: > On 07.09.2022 at 15:57, Misha wrote: > > > We spend a lot of time to increase limits for uploads file in PHP. Can we > > increase it in php.ini? > > > > Current value is 2Mb. Its so small value, when photo image can take 8Mb > on > > iPhone X. > > We should increase it to 50Mb, because DevOps engineers do useless work > > trying to change it. > > > > I have prepared PR for it https://github.com/php/php-src/pull/9315 > > I'm not against increasing the sizes, but 50MB might be too much. > > Anyway, only changing the php.ini files doesn't make sense in my > opinion, since they're probably only used on Windows, and they should > reflect the actual default values[1]. > > It's true that those particular ini files are not directly used on Linux but distros often base their changes on them and the distro provided ones are actually used. So it means that main defaults in main.c are most likely not used. Although I agree they should be changed too so it is consistent. Regards Jakub
Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
On Wed, Sep 7, 2022 at 10:47 PM Kris Craig wrote: > On Wed, Sep 7, 2022 at 11:38 AM juan carlos morales < > dev.juan.mora...@gmail.com> wrote: > > > I looked for a potential problem out of doing such a change but I could > not > > find anything. > > > > Then I'd say it's a no-brainer. The current 2 MB limit is simply outdated > and needs to be increased to something a little more realistic. > > That said, I think 50 MB may be pushing it. How about 20 MB, instead? > > That's the obvious question; why 50MB? Why not 10, 20 or [fill in the blank]MB? I have no objection in principle to increasing the shipped default but whatever number is picked, most devops/sysadmins are going to change it to suit their needs. I would classify this as an unnecessary but harmless change, since you should be tuning your engine configuration in any public facing deployment anyway.
Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
On Wed, 7 Sept 2022 at 19:37, juan carlos morales < dev.juan.mora...@gmail.com> wrote: > By the Way... This needs an RFC right? > No it does not. Best regards, George P. Banyard
Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
On 9/7/22 16:46, Kris Craig wrote: Lets respect the RFC protocol and wait the specified time to see if someone else comes with something. By the Way... This needs an RFC right? Yes, most definitely. Does it, though? It's not a new feature, it's a very small change (lines-of-code-wise), and it won't break BC for anyone. I'd suggest getting feedback from the list and making any changes requested. If there's not any major push-back, I don't think this needs to go through the RFC process. Maybe I'm wrong, though. If so, speak up and add some "major push-back" to this thread. ;-) -- Cheers, Ben OpenPGP_signature Description: OpenPGP digital signature
Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
On Wed, Sep 7, 2022 at 11:38 AM juan carlos morales < dev.juan.mora...@gmail.com> wrote: > I looked for a potential problem out of doing such a change but I could not > find anything. > Then I'd say it's a no-brainer. The current 2 MB limit is simply outdated and needs to be increased to something a little more realistic. That said, I think 50 MB may be pushing it. How about 20 MB, instead? > > But for sure such a change should be well marked in case is merge. > > I did not take look at the PR as that can wait also. > > Lets respect the RFC protocol and wait the specified time to see if someone > else comes with something. > > By the Way... This needs an RFC right? > Yes, most definitely.
Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
I looked for a potential problem out of doing such a change but I could not find anything. But for sure such a change should be well marked in case is merge. I did not take look at the PR as that can wait also. Lets respect the RFC protocol and wait the specified time to see if someone else comes with something. By the Way... This needs an RFC right?
