[jira] [Work logged] (ARTEMIS-4291) Some metrics do not have the "broker" tag
[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=863182=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863182
]
ASF GitHub Bot logged work on ARTEMIS-4291:
---
Author: ASF GitHub Bot
Created on: 01/Jun/23 05:58
Start Date: 01/Jun/23 05:58
Worklog Time Spent: 10m
Work Description: naude-r commented on PR #4487:
URL:
https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1571402949
Thank you for the additional metrics!
Issue Time Tracking
---
Worklog Id: (was: 863182)
Time Spent: 3h 10m (was: 3h)
> Some metrics do not have the "broker" tag
> -
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Roelof Naude
>Priority: Minor
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (AMQ-9246) Upgrade to jettison 1.5.4
[ https://issues.apache.org/jira/browse/AMQ-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved AMQ-9246. --- Resolution: Fixed > Upgrade to jettison 1.5.4 > - > > Key: AMQ-9246 > URL: https://issues.apache.org/jira/browse/AMQ-9246 > Project: ActiveMQ > Issue Type: Task > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.19.0, 5.17.5, 5.18.2 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9246) Upgrade to jettison 1.5.4
[ https://issues.apache.org/jira/browse/AMQ-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728227#comment-17728227 ] ASF subversion and git services commented on AMQ-9246: -- Commit 81558fbed0b6da3663e8dba7c8b58549b471b395 in activemq's branch refs/heads/activemq-5.17.x from JB Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=81558fbed0 ] [AMQ-9246] Upgrade to Jettison 1.5.4 (cherry picked from commit 2a5213c6818ba0afe443a422d7c4732a72c572f6) > Upgrade to jettison 1.5.4 > - > > Key: AMQ-9246 > URL: https://issues.apache.org/jira/browse/AMQ-9246 > Project: ActiveMQ > Issue Type: Task > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.19.0, 5.17.5, 5.18.2 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9246) Upgrade to jettison 1.5.4
[ https://issues.apache.org/jira/browse/AMQ-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728226#comment-17728226 ] ASF subversion and git services commented on AMQ-9246: -- Commit 2aa25fd1d753b9725e2565a8d8b092a5560d168d in activemq's branch refs/heads/activemq-5.18.x from JB Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=2aa25fd1d7 ] [AMQ-9246] Upgrade to Jettison 1.5.4 (cherry picked from commit 2a5213c6818ba0afe443a422d7c4732a72c572f6) > Upgrade to jettison 1.5.4 > - > > Key: AMQ-9246 > URL: https://issues.apache.org/jira/browse/AMQ-9246 > Project: ActiveMQ > Issue Type: Task > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.19.0, 5.17.5, 5.18.2 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9246) Upgrade to jettison 1.5.4
[ https://issues.apache.org/jira/browse/AMQ-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728225#comment-17728225 ] ASF subversion and git services commented on AMQ-9246: -- Commit 7b5c3332546724325e96a575b848132ddc162cdc in activemq's branch refs/heads/main from JB Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=7b5c333254 ] Merge pull request #1011 from jbonofre/AMQ-9246 [AMQ-9246] Upgrade to Jettison 1.5.4 > Upgrade to jettison 1.5.4 > - > > Key: AMQ-9246 > URL: https://issues.apache.org/jira/browse/AMQ-9246 > Project: ActiveMQ > Issue Type: Task > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.19.0, 5.17.5, 5.18.2 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9246) Upgrade to jettison 1.5.4
[ https://issues.apache.org/jira/browse/AMQ-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728224#comment-17728224 ] ASF subversion and git services commented on AMQ-9246: -- Commit 2a5213c6818ba0afe443a422d7c4732a72c572f6 in activemq's branch refs/heads/main from JB Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=2a5213c681 ] [AMQ-9246] Upgrade to Jettison 1.5.4 > Upgrade to jettison 1.5.4 > - > > Key: AMQ-9246 > URL: https://issues.apache.org/jira/browse/AMQ-9246 > Project: ActiveMQ > Issue Type: Task > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.19.0, 5.17.5, 5.18.2 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9246) Upgrade to jettison 1.5.4
[ https://issues.apache.org/jira/browse/AMQ-9246?focusedWorklogId=863181=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863181 ] ASF GitHub Bot logged work on AMQ-9246: --- Author: ASF GitHub Bot Created on: 01/Jun/23 05:48 Start Date: 01/Jun/23 05:48 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1011: URL: https://github.com/apache/activemq/pull/1011 Issue Time Tracking --- Worklog Id: (was: 863181) Time Spent: 20m (was: 10m) > Upgrade to jettison 1.5.4 > - > > Key: AMQ-9246 > URL: https://issues.apache.org/jira/browse/AMQ-9246 > Project: ActiveMQ > Issue Type: Task > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.19.0, 5.17.5, 5.18.2 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4299) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/ARTEMIS-4299?focusedWorklogId=863179=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863179 ] ASF GitHub Bot logged work on ARTEMIS-4299: --- Author: ASF GitHub Bot Created on: 01/Jun/23 05:28 Start Date: 01/Jun/23 05:28 Worklog Time Spent: 10m Work Description: brusdev commented on PR #4496: URL: https://github.com/apache/activemq-artemis/pull/4496#issuecomment-1571370370 @clebertsuconic this PR is fine, maybe the build error was caused by a maven cache issue. I created a new PR: #4498 Issue Time Tracking --- Worklog Id: (was: 863179) Time Spent: 1h (was: 50m) > Upgrade json-smart to 2.4.11 > > > Key: ARTEMIS-4299 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4299 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4299) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/ARTEMIS-4299?focusedWorklogId=863178=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863178 ] ASF GitHub Bot logged work on ARTEMIS-4299: --- Author: ASF GitHub Bot Created on: 01/Jun/23 05:24 Start Date: 01/Jun/23 05:24 Worklog Time Spent: 10m Work Description: brusdev opened a new pull request, #4498: URL: https://github.com/apache/activemq-artemis/pull/4498 (no comment) Issue Time Tracking --- Worklog Id: (was: 863178) Time Spent: 50m (was: 40m) > Upgrade json-smart to 2.4.11 > > > Key: ARTEMIS-4299 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4299 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4299) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/ARTEMIS-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728163#comment-17728163 ] ASF subversion and git services commented on ARTEMIS-4299: -- Commit 2ef43a0be172ab8d5b11868ef7e6aff074cf4b97 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=2ef43a0be1 ] Revert "ARTEMIS-4299 Upgrade json-smart to 2.4.11" This reverts commit d943213cae95394ec2da9eac6728c7d166256893. This is being reverted until the build could be fixed. > Upgrade json-smart to 2.4.11 > > > Key: ARTEMIS-4299 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4299 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4299) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/ARTEMIS-4299?focusedWorklogId=863158=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863158 ] ASF GitHub Bot logged work on ARTEMIS-4299: --- Author: ASF GitHub Bot Created on: 31/May/23 22:49 Start Date: 31/May/23 22:49 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4496: URL: https://github.com/apache/activemq-artemis/pull/4496#issuecomment-1571064231 @brusdev I am reverting this PR as it is breaking the build. Issue Time Tracking --- Worklog Id: (was: 863158) Time Spent: 0.5h (was: 20m) > Upgrade json-smart to 2.4.11 > > > Key: ARTEMIS-4299 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4299 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4299) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/ARTEMIS-4299?focusedWorklogId=863159=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863159 ] ASF GitHub Bot logged work on ARTEMIS-4299: --- Author: ASF GitHub Bot Created on: 31/May/23 22:49 Start Date: 31/May/23 22:49 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4496: URL: https://github.com/apache/activemq-artemis/pull/4496#issuecomment-1571064490 @jbertram ^^ Issue Time Tracking --- Worklog Id: (was: 863159) Time Spent: 40m (was: 0.5h) > Upgrade json-smart to 2.4.11 > > > Key: ARTEMIS-4299 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4299 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4294) Support text WebSocket encoding
[ https://issues.apache.org/jira/browse/ARTEMIS-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728145#comment-17728145 ] ASF subversion and git services commented on ARTEMIS-4294: -- Commit c4501f6793ab0e59e88bf6c4dba06b39ade84889 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c4501f6793 ] ARTEMIS-4294 support text-encoded WebSocket frames > Support text WebSocket encoding > --- > > Key: ARTEMIS-4294 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4294 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Minor > Fix For: 2.29.0 > > Time Spent: 40m > Remaining Estimate: 0h > > WebSocket frames can be encoded as either [binary or > text|https://datatracker.ietf.org/doc/html/rfc6455#section-11.8]. Currently > the broker always encodes them as binary. The broker should support an > acceptor URL parameter to change the encoding to text. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4294) Support text WebSocket encoding
[ https://issues.apache.org/jira/browse/ARTEMIS-4294?focusedWorklogId=863153=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863153 ] ASF GitHub Bot logged work on ARTEMIS-4294: --- Author: ASF GitHub Bot Created on: 31/May/23 21:34 Start Date: 31/May/23 21:34 Worklog Time Spent: 10m Work Description: jbertram merged PR #4493: URL: https://github.com/apache/activemq-artemis/pull/4493 Issue Time Tracking --- Worklog Id: (was: 863153) Time Spent: 40m (was: 0.5h) > Support text WebSocket encoding > --- > > Key: ARTEMIS-4294 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4294 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Minor > Fix For: 2.29.0 > > Time Spent: 40m > Remaining Estimate: 0h > > WebSocket frames can be encoded as either [binary or > text|https://datatracker.ietf.org/doc/html/rfc6455#section-11.8]. Currently > the broker always encodes them as binary. The broker should support an > acceptor URL parameter to change the encoding to text. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4299) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/ARTEMIS-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728144#comment-17728144 ] ASF subversion and git services commented on ARTEMIS-4299: -- Commit d943213cae95394ec2da9eac6728c7d166256893 in activemq-artemis's branch refs/heads/main from Domenico Francesco Bruscino [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d943213cae ] ARTEMIS-4299 Upgrade json-smart to 2.4.11 > Upgrade json-smart to 2.4.11 > > > Key: ARTEMIS-4299 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4299 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4299) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/ARTEMIS-4299?focusedWorklogId=863152=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863152 ] ASF GitHub Bot logged work on ARTEMIS-4299: --- Author: ASF GitHub Bot Created on: 31/May/23 21:33 Start Date: 31/May/23 21:33 Worklog Time Spent: 10m Work Description: jbertram merged PR #4496: URL: https://github.com/apache/activemq-artemis/pull/4496 Issue Time Tracking --- Worklog Id: (was: 863152) Time Spent: 20m (was: 10m) > Upgrade json-smart to 2.4.11 > > > Key: ARTEMIS-4299 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4299 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[ https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=863145=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863145 ] ASF GitHub Bot logged work on ARTEMIS-4238: --- Author: ASF GitHub Bot Created on: 31/May/23 20:16 Start Date: 31/May/23 20:16 Worklog Time Spent: 10m Work Description: jbertram merged PR #4435: URL: https://github.com/apache/activemq-artemis/pull/4435 Issue Time Tracking --- Worklog Id: (was: 863145) Time Spent: 1h 50m (was: 1h 40m) > transaction timeout ActivationConfigProperty is no longer working > - > > Key: ARTEMIS-4238 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4238 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.28.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > ARTEMIS-3707 has created a regression where the transactionTimeout > ActivationConfigProperty is no longer working properly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[ https://issues.apache.org/jira/browse/ARTEMIS-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728127#comment-17728127 ] ASF subversion and git services commented on ARTEMIS-4238: -- Commit 903e5888af404269da34c79b10829f820b26ba5c in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=903e5888af ] ARTEMIS-4238 deprecate transactionTimeout activation config prop > transaction timeout ActivationConfigProperty is no longer working > - > > Key: ARTEMIS-4238 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4238 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.28.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > ARTEMIS-3707 has created a regression where the transactionTimeout > ActivationConfigProperty is no longer working properly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863137=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863137 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/May/23 19:42 Start Date: 31/May/23 19:42 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1570835609 > Minor suggestion: > > > apt install tree curl -y > > can be replaced with existing tools: > > * tree -> ls -l (easy one) > * curl -> wget (more complex) This is performed in the builder section. This section is executed one time at the beginning of the pipeline. Any subsequent pipeline runs in the future will have this command cached and it will never be rerun as it is done just at the beginning. I tuned the Dockerfile to cache the things that are static like apt packages and add the dynamic parts of the app e.g. artemis at the end. Issue Time Tracking --- Worklog Id: (was: 863137) Time Spent: 9h 20m (was: 9h 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 9h 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863131=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863131 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 31/May/23 19:21 Start Date: 31/May/23 19:21 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1570801090 Minor suggestion: > apt install tree curl -y can be replaced with existing tools: - tree -> ls -l (easy one) - curl -> wget (more complex) Issue Time Tracking --- Worklog Id: (was: 863131) Time Spent: 9h 10m (was: 9h) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 9h 10m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4298) Journal Retention Duplicated files during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728106#comment-17728106 ] ASF subversion and git services commented on ARTEMIS-4298: -- Commit c5be8b72c14860ccff0eafec0315f4383330fc42 in activemq-artemis's branch refs/heads/main from clebert [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c5be8b72c1 ] ARTEMIS-4298 and ARTEMIS-4215 Fixing duplicated entries on historyFiles on journalRetention during a replication This is Fixing BackupSyncJournalTest::testReplicationDuringSync ARTEMIS-4215 introduced a failure on the testsuite. However the failure is non related to the Buffer itself. it introduced a race that unveiled ARTEMIS-4298. > Journal Retention Duplicated files during replication > - > > Key: ARTEMIS-4298 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4298 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.29.0 > > Time Spent: 10m > Remaining Estimate: 0h > > During a replication the server could move to a different file and create a > backup file. > Before activation we check the .bkp files and move them. Replication is > causing a duplicate that could lead to the server not being activated. > the commit from ARTEMIS-4215 Unveiled this issue. as BackupSyncJournalTest. > The commit to fix the test from ARTEMIS-4215 itself represents a new issue > found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4215) JournalFlush might never happen when journal-sync-* is false
[ https://issues.apache.org/jira/browse/ARTEMIS-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728107#comment-17728107 ] ASF subversion and git services commented on ARTEMIS-4215: -- Commit c5be8b72c14860ccff0eafec0315f4383330fc42 in activemq-artemis's branch refs/heads/main from clebert [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c5be8b72c1 ] ARTEMIS-4298 and ARTEMIS-4215 Fixing duplicated entries on historyFiles on journalRetention during a replication This is Fixing BackupSyncJournalTest::testReplicationDuringSync ARTEMIS-4215 introduced a failure on the testsuite. However the failure is non related to the Buffer itself. it introduced a race that unveiled ARTEMIS-4298. > JournalFlush might never happen when journal-sync-* is false > > > Key: ARTEMIS-4215 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4215 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Anton Roskvist >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > When journal-sync-* is false then flushes to journal will only ever happen > once the buffer is full or when the broker is cleanly shut down, regardless > of how much time passes. This means that if the broker is started with these > settings a crash/kill -9 will for sure loose messages, regardless of how much > time passes since the messages where sent. > This started with version 2.18.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4298) Journal Retention Duplicated files during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-4298?focusedWorklogId=863125=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863125 ] ASF GitHub Bot logged work on ARTEMIS-4298: --- Author: ASF GitHub Bot Created on: 31/May/23 18:58 Start Date: 31/May/23 18:58 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4495: URL: https://github.com/apache/activemq-artemis/pull/4495 Issue Time Tracking --- Worklog Id: (was: 863125) Remaining Estimate: 0h Time Spent: 10m > Journal Retention Duplicated files during replication > - > > Key: ARTEMIS-4298 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4298 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.29.0 > > Time Spent: 10m > Remaining Estimate: 0h > > During a replication the server could move to a different file and create a > backup file. > Before activation we check the .bkp files and move them. Replication is > causing a duplicate that could lead to the server not being activated. > the commit from ARTEMIS-4215 Unveiled this issue. as BackupSyncJournalTest. > The commit to fix the test from ARTEMIS-4215 itself represents a new issue > found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4297) Allow regex in no-cache exception config
[
https://issues.apache.org/jira/browse/ARTEMIS-4297?focusedWorklogId=863123=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863123
]
ASF GitHub Bot logged work on ARTEMIS-4297:
---
Author: ASF GitHub Bot
Created on: 31/May/23 18:37
Start Date: 31/May/23 18:37
Worklog Time Spent: 10m
Work Description: clebertsuconic merged PR #4494:
URL: https://github.com/apache/activemq-artemis/pull/4494
Issue Time Tracking
---
Worklog Id: (was: 863123)
Time Spent: 20m (was: 10m)
> Allow regex in no-cache exception config
>
>
> Key: ARTEMIS-4297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4297
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the {{LDAPLoginModule}} supports the ability to configure a list of
> exceptions which should skip the broker's authentication cache (see
> ARTEMIS-4101). The configuration should support regular expressions so that
> it's simpler to cover a wide range of exception types.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4297) Allow regex in no-cache exception config
[
https://issues.apache.org/jira/browse/ARTEMIS-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728100#comment-17728100
]
ASF subversion and git services commented on ARTEMIS-4297:
--
Commit e7de2c700172024be1749b0cbf1207761a6f101e in activemq-artemis's branch
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=e7de2c7001 ]
ARTEMIS-4297 allow regex in no-cache exception config
> Allow regex in no-cache exception config
>
>
> Key: ARTEMIS-4297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4297
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the {{LDAPLoginModule}} supports the ability to configure a list of
> exceptions which should skip the broker's authentication cache (see
> ARTEMIS-4101). The configuration should support regular expressions so that
> it's simpler to cover a wide range of exception types.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4291) Some metrics do not have the "broker" tag
[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=863120=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863120
]
ASF GitHub Bot logged work on ARTEMIS-4291:
---
Author: ASF GitHub Bot
Created on: 31/May/23 18:29
Start Date: 31/May/23 18:29
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #4487:
URL:
https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1570714527
BTW, thanks for the contribution!
Issue Time Tracking
---
Worklog Id: (was: 863120)
Time Spent: 3h (was: 2h 50m)
> Some metrics do not have the "broker" tag
> -
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Roelof Naude
>Priority: Minor
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4291) Some metrics do not have the "broker" tag
[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=863118=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863118
]
ASF GitHub Bot logged work on ARTEMIS-4291:
---
Author: ASF GitHub Bot
Created on: 31/May/23 18:15
Start Date: 31/May/23 18:15
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #4487:
URL:
https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1570696276
I just sent #4497 to deal with the metrics you were adding manually before.
Once merged & released you can use `broker.xml` to configure those.
Issue Time Tracking
---
Worklog Id: (was: 863118)
Time Spent: 2h 50m (was: 2h 40m)
> Some metrics do not have the "broker" tag
> -
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Roelof Naude
>Priority: Minor
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4292) Support additional Micrometer system metrics
[ https://issues.apache.org/jira/browse/ARTEMIS-4292?focusedWorklogId=863117=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863117 ] ASF GitHub Bot logged work on ARTEMIS-4292: --- Author: ASF GitHub Bot Created on: 31/May/23 18:13 Start Date: 31/May/23 18:13 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4497: URL: https://github.com/apache/activemq-artemis/pull/4497 This commit exposes Micrometer's system metrics for: - file descriptors - processor - uptime Issue Time Tracking --- Worklog Id: (was: 863117) Remaining Estimate: 0h Time Spent: 10m > Support additional Micrometer system metrics > > > Key: ARTEMIS-4292 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4292 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The broker already supports optional metrics for the JVM and Netty, but > Micrometer has a number of other metrics which would be useful to support as > well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4298) Journal Retention Duplicated files during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic updated ARTEMIS-4298: - Fix Version/s: 2.29.0 > Journal Retention Duplicated files during replication > - > > Key: ARTEMIS-4298 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4298 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.29.0 > > > During a replication the server could move to a different file and create a > backup file. > Before activation we check the .bkp files and move them. Replication is > causing a duplicate that could lead to the server not being activated. > the commit from ARTEMIS-4215 Unveiled this issue. as BackupSyncJournalTest. > The commit to fix the test from ARTEMIS-4215 itself represents a new issue > found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (ARTEMIS-4298) Journal Retention Duplicated files during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on ARTEMIS-4298 started by Clebert Suconic. > Journal Retention Duplicated files during replication > - > > Key: ARTEMIS-4298 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4298 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.29.0 > > > During a replication the server could move to a different file and create a > backup file. > Before activation we check the .bkp files and move them. Replication is > causing a duplicate that could lead to the server not being activated. > the commit from ARTEMIS-4215 Unveiled this issue. as BackupSyncJournalTest. > The commit to fix the test from ARTEMIS-4215 itself represents a new issue > found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4300) Wrong links in docs
Daniel Martin created ARTEMIS-4300: -- Summary: Wrong links in docs Key: ARTEMIS-4300 URL: https://issues.apache.org/jira/browse/ARTEMIS-4300 Project: ActiveMQ Artemis Issue Type: Bug Reporter: Daniel Martin The URLs linking the words "routing types" and "this functionality" (at least) don't work in https://activemq.apache.org/components/artemis/documentation/latest/address-settings.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4291) Some metrics do not have the "broker" tag
[
https://issues.apache.org/jira/browse/ARTEMIS-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728087#comment-17728087
]
ASF subversion and git services commented on ARTEMIS-4291:
--
Commit 40425d422abe8e6121510a5f7bb18af12c22f147 in activemq-artemis's branch
refs/heads/main from Roelof Naude
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=40425d422a ]
ARTEMIS-4291 Add the "broker" tag in a consistent manner to all exported
metrics.
Some scrapers, e.g. prometheus, add an "instance" tag. This value may not be
the same as
the broker name, which results in these metrics becoming more difficult to
match up with
the corresponding broker.
> Some metrics do not have the "broker" tag
> -
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Roelof Naude
>Priority: Minor
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4291) Some metrics do not have the "broker" tag
[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=863115=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863115
]
ASF GitHub Bot logged work on ARTEMIS-4291:
---
Author: ASF GitHub Bot
Created on: 31/May/23 17:45
Start Date: 31/May/23 17:45
Worklog Time Spent: 10m
Work Description: jbertram merged PR #4487:
URL: https://github.com/apache/activemq-artemis/pull/4487
Issue Time Tracking
---
Worklog Id: (was: 863115)
Time Spent: 2h 40m (was: 2.5h)
> Some metrics do not have the "broker" tag
> -
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Roelof Naude
>Priority: Minor
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4299) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/ARTEMIS-4299?focusedWorklogId=863111=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863111 ] ASF GitHub Bot logged work on ARTEMIS-4299: --- Author: ASF GitHub Bot Created on: 31/May/23 17:18 Start Date: 31/May/23 17:18 Worklog Time Spent: 10m Work Description: brusdev opened a new pull request, #4496: URL: https://github.com/apache/activemq-artemis/pull/4496 (no comment) Issue Time Tracking --- Worklog Id: (was: 863111) Remaining Estimate: 0h Time Spent: 10m > Upgrade json-smart to 2.4.11 > > > Key: ARTEMIS-4299 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4299 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4299) Upgrade json-smart to 2.4.11
Domenico Francesco Bruscino created ARTEMIS-4299: Summary: Upgrade json-smart to 2.4.11 Key: ARTEMIS-4299 URL: https://issues.apache.org/jira/browse/ARTEMIS-4299 Project: ActiveMQ Artemis Issue Type: Dependency upgrade Reporter: Domenico Francesco Bruscino Assignee: Domenico Francesco Bruscino -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4298) Journal Retention Duplicated files during replication
Clebert Suconic created ARTEMIS-4298: Summary: Journal Retention Duplicated files during replication Key: ARTEMIS-4298 URL: https://issues.apache.org/jira/browse/ARTEMIS-4298 Project: ActiveMQ Artemis Issue Type: Bug Reporter: Clebert Suconic During a replication the server could move to a different file and create a backup file. Before activation we check the .bkp files and move them. Replication is causing a duplicate that could lead to the server not being activated. the commit from ARTEMIS-4215 Unveiled this issue. as BackupSyncJournalTest. The commit to fix the test from ARTEMIS-4215 itself represents a new issue found. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQ-9261) Upgrade to maven-enforcer-plugin 3.3.0
Jean-Baptiste Onofré created AMQ-9261: - Summary: Upgrade to maven-enforcer-plugin 3.3.0 Key: AMQ-9261 URL: https://issues.apache.org/jira/browse/AMQ-9261 Project: ActiveMQ Issue Type: Task Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Fix For: 5.19.0, 5.18.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQ-9260) Upgrade to maven-assembly-plugin 3.6.0
Jean-Baptiste Onofré created AMQ-9260: - Summary: Upgrade to maven-assembly-plugin 3.6.0 Key: AMQ-9260 URL: https://issues.apache.org/jira/browse/AMQ-9260 Project: ActiveMQ Issue Type: Task Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Fix For: 5.19.0, 5.18.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (AMQ-9235) Update Jenkins to use JDK 20
[ https://issues.apache.org/jira/browse/AMQ-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved AMQ-9235. --- Resolution: Fixed > Update Jenkins to use JDK 20 > > > Key: AMQ-9235 > URL: https://issues.apache.org/jira/browse/AMQ-9235 > Project: ActiveMQ > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Replace JDK 19 testing with JDK 20 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (AMQ-9236) Cleanup compiler warnings in kahadb-store
[ https://issues.apache.org/jira/browse/AMQ-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned AMQ-9236: - Assignee: Jean-Baptiste Onofré > Cleanup compiler warnings in kahadb-store > - > > Key: AMQ-9236 > URL: https://issues.apache.org/jira/browse/AMQ-9236 > Project: ActiveMQ > Issue Type: Task >Affects Versions: 5.19.0, 5.18.1 >Reporter: Matt Pavlovich >Assignee: Jean-Baptiste Onofré >Priority: Major > > Minor compiler clean-ups brought on by JDK and Java language updates > Caused by activemq-protobuf project -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9235) Update Jenkins to use JDK 20
[
https://issues.apache.org/jira/browse/AMQ-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728063#comment-17728063
]
Jean-Baptiste Onofré commented on AMQ-9235:
---
{{Jenkinsfile}} on {{main}} branch now includes a stage with JDK20.
> Update Jenkins to use JDK 20
>
>
> Key: AMQ-9235
> URL: https://issues.apache.org/jira/browse/AMQ-9235
> Project: ActiveMQ
> Issue Type: Task
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Replace JDK 19 testing with JDK 20
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (ARTEMIS-4295) artemis-docker: replace 'tree' command with 'ls -l'
[
https://issues.apache.org/jira/browse/ARTEMIS-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexey Markevich closed ARTEMIS-4295.
-
Resolution: Won't Fix
> artemis-docker: replace 'tree' command with 'ls -l'
> ---
>
> Key: ARTEMIS-4295
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4295
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 2.28.0
>Reporter: Alexey Markevich
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> 'tree' command is not available in base image, so cloud build failed:
> {code:java}
> ./prepare-docker.sh: 188: tree: not found{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (AMQ-9246) Upgrade to jettison 1.5.4
[ https://issues.apache.org/jira/browse/AMQ-9246?focusedWorklogId=863108=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863108 ] ASF GitHub Bot logged work on AMQ-9246: --- Author: ASF GitHub Bot Created on: 31/May/23 16:55 Start Date: 31/May/23 16:55 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1011: URL: https://github.com/apache/activemq/pull/1011 (no comment) Issue Time Tracking --- Worklog Id: (was: 863108) Remaining Estimate: 0h Time Spent: 10m > Upgrade to jettison 1.5.4 > - > > Key: AMQ-9246 > URL: https://issues.apache.org/jira/browse/AMQ-9246 > Project: ActiveMQ > Issue Type: Task > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.19.0, 5.17.5, 5.18.2 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4215) JournalFlush might never happen when journal-sync-* is false
[ https://issues.apache.org/jira/browse/ARTEMIS-4215?focusedWorklogId=863107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863107 ] ASF GitHub Bot logged work on ARTEMIS-4215: --- Author: ASF GitHub Bot Created on: 31/May/23 16:53 Start Date: 31/May/23 16:53 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4495: URL: https://github.com/apache/activemq-artemis/pull/4495 (no comment) Issue Time Tracking --- Worklog Id: (was: 863107) Time Spent: 50m (was: 40m) > JournalFlush might never happen when journal-sync-* is false > > > Key: ARTEMIS-4215 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4215 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Anton Roskvist >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > When journal-sync-* is false then flushes to journal will only ever happen > once the buffer is full or when the broker is cleanly shut down, regardless > of how much time passes. This means that if the broker is started with these > settings a crash/kill -9 will for sure loose messages, regardless of how much > time passes since the messages where sent. > This started with version 2.18.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9245) Upgrade to Spring 5.3.27
[ https://issues.apache.org/jira/browse/AMQ-9245?focusedWorklogId=863103=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863103 ] ASF GitHub Bot logged work on AMQ-9245: --- Author: ASF GitHub Bot Created on: 31/May/23 16:49 Start Date: 31/May/23 16:49 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1010: URL: https://github.com/apache/activemq/pull/1010 (no comment) Issue Time Tracking --- Worklog Id: (was: 863103) Remaining Estimate: 0h Time Spent: 10m > Upgrade to Spring 5.3.27 > > > Key: AMQ-9245 > URL: https://issues.apache.org/jira/browse/AMQ-9245 > Project: ActiveMQ > Issue Type: Task > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.17.5, 5.18.2 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4295) artemis-docker: replace 'tree' command with 'ls -l'
[
https://issues.apache.org/jira/browse/ARTEMIS-4295?focusedWorklogId=863099=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863099
]
ASF GitHub Bot logged work on ARTEMIS-4295:
---
Author: ASF GitHub Bot
Created on: 31/May/23 16:43
Start Date: 31/May/23 16:43
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #4490:
URL:
https://github.com/apache/activemq-artemis/pull/4490#issuecomment-1570569761
A PR with this change has already been submitted. See #4453.
Issue Time Tracking
---
Worklog Id: (was: 863099)
Time Spent: 20m (was: 10m)
> artemis-docker: replace 'tree' command with 'ls -l'
> ---
>
> Key: ARTEMIS-4295
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4295
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 2.28.0
>Reporter: Alexey Markevich
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> 'tree' command is not available in base image, so cloud build failed:
> {code:java}
> ./prepare-docker.sh: 188: tree: not found{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4295) artemis-docker: replace 'tree' command with 'ls -l'
[
https://issues.apache.org/jira/browse/ARTEMIS-4295?focusedWorklogId=863100=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863100
]
ASF GitHub Bot logged work on ARTEMIS-4295:
---
Author: ASF GitHub Bot
Created on: 31/May/23 16:43
Start Date: 31/May/23 16:43
Worklog Time Spent: 10m
Work Description: jbertram closed pull request #4490: ARTEMIS-4295
artemis-docker: replace 'tree' command with 'ls -l'
URL: https://github.com/apache/activemq-artemis/pull/4490
Issue Time Tracking
---
Worklog Id: (was: 863100)
Time Spent: 0.5h (was: 20m)
> artemis-docker: replace 'tree' command with 'ls -l'
> ---
>
> Key: ARTEMIS-4295
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4295
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 2.28.0
>Reporter: Alexey Markevich
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> 'tree' command is not available in base image, so cloud build failed:
> {code:java}
> ./prepare-docker.sh: 188: tree: not found{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (AMQ-9245) Upgrade to Spring 5.3.27
[ https://issues.apache.org/jira/browse/AMQ-9245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-9245: -- Summary: Upgrade to Spring 5.3.27 (was: Upgrade to Spring 5.3.26) > Upgrade to Spring 5.3.27 > > > Key: AMQ-9245 > URL: https://issues.apache.org/jira/browse/AMQ-9245 > Project: ActiveMQ > Issue Type: Task > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.17.5, 5.18.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (AMQ-9250) CVE-2023-20860 - Update spring framework to resolve security vulnerability
[ https://issues.apache.org/jira/browse/AMQ-9250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved AMQ-9250. --- Resolution: Duplicate > CVE-2023-20860 - Update spring framework to resolve security vulnerability > -- > > Key: AMQ-9250 > URL: https://issues.apache.org/jira/browse/AMQ-9250 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: AMQP >Affects Versions: 5.18.1 >Reporter: Ben >Assignee: Jean-Baptiste Onofré >Priority: Major > > Vulnerability scans are reporting > [https://nvd.nist.gov/vuln/detail/CVE-2023-20860] exists in ActiveMQ 5.18.1. > Please update this spring dependency to 5.3.26 (or later) to resolve this > CVE. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-9250) CVE-2023-20860 - Update spring framework to resolve security vulnerability
[ https://issues.apache.org/jira/browse/AMQ-9250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-9250: -- Fix Version/s: (was: 5.19.0) (was: 5.18.2) > CVE-2023-20860 - Update spring framework to resolve security vulnerability > -- > > Key: AMQ-9250 > URL: https://issues.apache.org/jira/browse/AMQ-9250 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: AMQP >Affects Versions: 5.18.1 >Reporter: Ben >Assignee: Jean-Baptiste Onofré >Priority: Major > > Vulnerability scans are reporting > [https://nvd.nist.gov/vuln/detail/CVE-2023-20860] exists in ActiveMQ 5.18.1. > Please update this spring dependency to 5.3.26 (or later) to resolve this > CVE. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-9250) CVE-2023-20860 - Update spring framework to resolve security vulnerability
[ https://issues.apache.org/jira/browse/AMQ-9250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-9250: -- Fix Version/s: 5.19.0 5.18.2 > CVE-2023-20860 - Update spring framework to resolve security vulnerability > -- > > Key: AMQ-9250 > URL: https://issues.apache.org/jira/browse/AMQ-9250 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: AMQP >Affects Versions: 5.18.1 >Reporter: Ben >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.19.0, 5.18.2 > > > Vulnerability scans are reporting > [https://nvd.nist.gov/vuln/detail/CVE-2023-20860] exists in ActiveMQ 5.18.1. > Please update this spring dependency to 5.3.26 (or later) to resolve this > CVE. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (AMQ-9250) CVE-2023-20860 - Update spring framework to resolve security vulnerability
[ https://issues.apache.org/jira/browse/AMQ-9250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned AMQ-9250: - Assignee: Jean-Baptiste Onofré > CVE-2023-20860 - Update spring framework to resolve security vulnerability > -- > > Key: AMQ-9250 > URL: https://issues.apache.org/jira/browse/AMQ-9250 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: AMQP >Affects Versions: 5.18.1 >Reporter: Ben >Assignee: Jean-Baptiste Onofré >Priority: Major > > Vulnerability scans are reporting > [https://nvd.nist.gov/vuln/detail/CVE-2023-20860] exists in ActiveMQ 5.18.1. > Please update this spring dependency to 5.3.26 (or later) to resolve this > CVE. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4297) Allow regex in no-cache exception config
[
https://issues.apache.org/jira/browse/ARTEMIS-4297?focusedWorklogId=863088=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863088
]
ASF GitHub Bot logged work on ARTEMIS-4297:
---
Author: ASF GitHub Bot
Created on: 31/May/23 16:20
Start Date: 31/May/23 16:20
Worklog Time Spent: 10m
Work Description: jbertram opened a new pull request, #4494:
URL: https://github.com/apache/activemq-artemis/pull/4494
(no comment)
Issue Time Tracking
---
Worklog Id: (was: 863088)
Remaining Estimate: 0h
Time Spent: 10m
> Allow regex in no-cache exception config
>
>
> Key: ARTEMIS-4297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4297
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the {{LDAPLoginModule}} supports the ability to configure a list of
> exceptions which should skip the broker's authentication cache (see
> ARTEMIS-4101). The configuration should support regular expressions so that
> it's simpler to cover a wide range of exception types.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4294) Support text WebSocket encoding
[
https://issues.apache.org/jira/browse/ARTEMIS-4294?focusedWorklogId=863078=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863078
]
ASF GitHub Bot logged work on ARTEMIS-4294:
---
Author: ASF GitHub Bot
Created on: 31/May/23 15:37
Start Date: 31/May/23 15:37
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4493:
URL: https://github.com/apache/activemq-artemis/pull/4493#discussion_r1211906696
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/protocol/websocket/WebSocketFrameEncoderType.java:
##
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.core.server.protocol.websocket;
+
+public enum WebSocketFrameEncoderType {
+ BINARY, TEXT;
+
+ public static WebSocketFrameEncoderType valueOfType(String type) {
+ switch (type) {
+ case "binary":
+return BINARY;
+ case "text":
+return TEXT;
+ default:
+return null;
Review Comment:
Instead of returning null here why not just throw an exception that
indicates that this is an invalid argument here to avoid any chance of NPE later
##
artemis-server/src/test/java/org/apache/activemq/artemis/core/server/protocol/websocket/WebSocketFrameEncoderTest.java:
##
@@ -60,11 +61,22 @@ public class WebSocketFrameEncoderTest {
@Before
public void setUp() throws Exception {
- spy = spy(new WebSocketFrameEncoder(maxFramePayloadLength));
+ binarySpy = spy(new WebSocketFrameEncoder(maxFramePayloadLength,
WebSocketFrameEncoderType.BINARY));
+ textSpy = spy(new WebSocketFrameEncoder(maxFramePayloadLength,
WebSocketFrameEncoderType.TEXT));
}
@Test
- public void testWriteNonByteBuf() throws Exception {
+ public void testWriteNonByteBufBinary() throws Exception {
+ testWriteNonByteBuf(binarySpy);
+ }
+
+
Review Comment:
Extra newline
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java:
##
@@ -158,7 +160,12 @@ public void channelRead(ChannelHandlerContext ctx, Object
msg) throws Exception
}
stompMaxFramePayloadLength = stompMaxFramePayloadLength != -1 ?
stompMaxFramePayloadLength :
TransportConstants.DEFAULT_WEB_SOCKET_MAX_FRAME_PAYLOAD_LENGTH;
int webSocketMaxFramePayloadLength =
ConfigurationHelper.getIntProperty(TransportConstants.WEB_SOCKET_MAX_FRAME_PAYLOAD_LENGTH,
-1, nettyAcceptor.getConfiguration());
- ctx.pipeline().addLast("websocket-handler", new
WebSocketServerHandler(websocketSubprotocolIds, webSocketMaxFramePayloadLength
!= -1 ? webSocketMaxFramePayloadLength : stompMaxFramePayloadLength));
+ String encoderConfigType =
ConfigurationHelper.getStringProperty(TransportConstants.WEB_SOCKET_ENCODER_TYPE,
TransportConstants.DEFAULT_WEB_SOCKET_ENCODER_TYPE,
nettyAcceptor.getConfiguration());
+ WebSocketFrameEncoderType encoderType =
WebSocketFrameEncoderType.valueOfType(encoderConfigType);
+ if (encoderType == null) {
Review Comment:
As noted below I'd just have the 'valuefType' method validate and throw
instead of needing to check here
Issue Time Tracking
---
Worklog Id: (was: 863078)
Time Spent: 0.5h (was: 20m)
> Support text WebSocket encoding
> ---
>
> Key: ARTEMIS-4294
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4294
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Minor
> Fix For: 2.29.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> WebSocket frames can be encoded as either [binary or
> text|https://datatracker.ietf.org/doc/html/rfc6455#section-11.8]. Currently
> the broker always encodes them as binary. The broker should support an
> acceptor URL parameter to change the encoding to text.
--
This
[jira] [Created] (ARTEMIS-4297) Allow regex in no-cache exception config
Justin Bertram created ARTEMIS-4297:
---
Summary: Allow regex in no-cache exception config
Key: ARTEMIS-4297
URL: https://issues.apache.org/jira/browse/ARTEMIS-4297
Project: ActiveMQ Artemis
Issue Type: Improvement
Reporter: Justin Bertram
Assignee: Justin Bertram
Currently the {{LDAPLoginModule}} supports the ability to configure a list of
exceptions which should skip the broker's authentication cache (see
ARTEMIS-4101). The configuration should support regular expressions so that
it's simpler to cover a wide range of exception types.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4294) Support text WebSocket encoding
[ https://issues.apache.org/jira/browse/ARTEMIS-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-4294: Priority: Minor (was: Major) > Support text WebSocket encoding > --- > > Key: ARTEMIS-4294 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4294 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Minor > Fix For: 2.29.0 > > Time Spent: 20m > Remaining Estimate: 0h > > WebSocket frames can be encoded as either [binary or > text|https://datatracker.ietf.org/doc/html/rfc6455#section-11.8]. Currently > the broker always encodes them as binary. The broker should support an > acceptor URL parameter to change the encoding to text. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4294) Support text WebSocket encoding
[ https://issues.apache.org/jira/browse/ARTEMIS-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-4294. - Fix Version/s: 2.29.0 Resolution: Fixed > Support text WebSocket encoding > --- > > Key: ARTEMIS-4294 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4294 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.29.0 > > Time Spent: 20m > Remaining Estimate: 0h > > WebSocket frames can be encoded as either [binary or > text|https://datatracker.ietf.org/doc/html/rfc6455#section-11.8]. Currently > the broker always encodes them as binary. The broker should support an > acceptor URL parameter to change the encoding to text. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4294) Support text WebSocket encoding
[ https://issues.apache.org/jira/browse/ARTEMIS-4294?focusedWorklogId=863057=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863057 ] ASF GitHub Bot logged work on ARTEMIS-4294: --- Author: ASF GitHub Bot Created on: 31/May/23 14:15 Start Date: 31/May/23 14:15 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4493: URL: https://github.com/apache/activemq-artemis/pull/4493#issuecomment-1570324051 Something weird happened on `WebSocketFrameEncoder.java` with the EOLs so the whole file got changed. I think it originally used CRLF instead of just LF. Issue Time Tracking --- Worklog Id: (was: 863057) Time Spent: 20m (was: 10m) > Support text WebSocket encoding > --- > > Key: ARTEMIS-4294 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4294 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > WebSocket frames can be encoded as either [binary or > text|https://datatracker.ietf.org/doc/html/rfc6455#section-11.8]. Currently > the broker always encodes them as binary. The broker should support an > acceptor URL parameter to change the encoding to text. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4294) Support text WebSocket encoding
[ https://issues.apache.org/jira/browse/ARTEMIS-4294?focusedWorklogId=863056=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863056 ] ASF GitHub Bot logged work on ARTEMIS-4294: --- Author: ASF GitHub Bot Created on: 31/May/23 14:13 Start Date: 31/May/23 14:13 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4493: URL: https://github.com/apache/activemq-artemis/pull/4493 (no comment) Issue Time Tracking --- Worklog Id: (was: 863056) Remaining Estimate: 0h Time Spent: 10m > Support text WebSocket encoding > --- > > Key: ARTEMIS-4294 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4294 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > WebSocket frames can be encoded as either [binary or > text|https://datatracker.ietf.org/doc/html/rfc6455#section-11.8]. Currently > the broker always encodes them as binary. The broker should support an > acceptor URL parameter to change the encoding to text. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4291) Some metrics do not have the "broker" tag
[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=862981=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862981
]
ASF GitHub Bot logged work on ARTEMIS-4291:
---
Author: ASF GitHub Bot
Created on: 31/May/23 10:14
Start Date: 31/May/23 10:14
Worklog Time Spent: 10m
Work Description: naude-r opened a new pull request, #4487:
URL: https://github.com/apache/activemq-artemis/pull/4487
ARTEMIS-4291 Add the "broker" tag in a consistent manner to all exported
metrics.
Some scrapers, e.g. prometheus, add an "instance" tag. This value may not be
the same as
the broker name, which results in these metrics becoming more difficult to
match up with
the corresponding broker.
Issue Time Tracking
---
Worklog Id: (was: 862981)
Time Spent: 2.5h (was: 2h 20m)
> Some metrics do not have the "broker" tag
> -
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Roelof Naude
>Priority: Minor
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4291) Some metrics do not have the "broker" tag
[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=862980=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862980
]
ASF GitHub Bot logged work on ARTEMIS-4291:
---
Author: ASF GitHub Bot
Created on: 31/May/23 10:13
Start Date: 31/May/23 10:13
Worklog Time Spent: 10m
Work Description: naude-r closed pull request #4487: ARTEMIS-4291 Add the
"broker" tag in a consistent manner
URL: https://github.com/apache/activemq-artemis/pull/4487
Issue Time Tracking
---
Worklog Id: (was: 862980)
Time Spent: 2h 20m (was: 2h 10m)
> Some metrics do not have the "broker" tag
> -
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Roelof Naude
>Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4291) Some metrics do not have the "broker" tag
[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=862979=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862979
]
ASF GitHub Bot logged work on ARTEMIS-4291:
---
Author: ASF GitHub Bot
Created on: 31/May/23 10:13
Start Date: 31/May/23 10:13
Worklog Time Spent: 10m
Work Description: naude-r commented on PR #4487:
URL:
https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1569907193
> > Yes, that makes sense. Before I merge it can you add a test to ensure
that the {{broker}} tag is set on the JVM & Netty metrics as expected? You
could modify
{{org.apache.activemq.artemis.tests.integration.plugin.JvmMetricsTest}} for the
JVM metrics. However, we don't have an existing test for the Netty metrics so
you could copy the aforementioned {{JvmMetricsTest}} and modify it for the
Netty use-case.
> > To be clear, just about every commit needs a test to validate the change
is working as expected and to mitigate against future regressions.
>
> certainly. will get to it either today or tomorrow.
test cases added as requested.
Issue Time Tracking
---
Worklog Id: (was: 862979)
Time Spent: 2h 10m (was: 2h)
> Some metrics do not have the "broker" tag
> -
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Roelof Naude
>Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4291) Some metrics do not have the "broker" tag
[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=862918=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862918
]
ASF GitHub Bot logged work on ARTEMIS-4291:
---
Author: ASF GitHub Bot
Created on: 31/May/23 06:04
Start Date: 31/May/23 06:04
Worklog Time Spent: 10m
Work Description: naude-r commented on PR #4487:
URL:
https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1569549272
> Yes, that makes sense. Before I merge it can you add a test to ensure that
the {{broker}} tag is set on the JVM & Netty metrics as expected? You could
modify {{org.apache.activemq.artemis.tests.integration.plugin.JvmMetricsTest}}
for the JVM metrics. However, we don't have an existing test for the Netty
metrics so you could copy the aforementioned {{JvmMetricsTest}} and modify it
for the Netty use-case.
>
> To be clear, just about every commit needs a test to validate the change
is working as expected and to mitigate against future regressions.
certainly. will get to it either today or tomorrow.
Issue Time Tracking
---
Worklog Id: (was: 862918)
Time Spent: 2h (was: 1h 50m)
> Some metrics do not have the "broker" tag
> -
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Roelof Naude
>Priority: Minor
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
