[jira] [Commented] (AMQ-9330) Polling empty queue via REST returns 500 Server Error
[ https://issues.apache.org/jira/browse/AMQ-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793285#comment-17793285 ] Pratap commented on AMQ-9330: - Thank you, [~jbonofre]. Can we expect this to be resolved in 5.18.4? > Polling empty queue via REST returns 500 Server Error > - > > Key: AMQ-9330 > URL: https://issues.apache.org/jira/browse/AMQ-9330 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.18.2 >Reporter: Michael Hoyt >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.18.4 > > > In AMQ 5.18.1 Polling an empty queue via the REST api returned a 204 No > Content response. In 5.18.2 that same method now returns a 500 Server Error > response. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4526) Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests
Clebert Suconic created ARTEMIS-4526: Summary: Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests Key: ARTEMIS-4526 URL: https://issues.apache.org/jira/browse/ARTEMIS-4526 Project: ActiveMQ Artemis Issue Type: Test Affects Versions: 2.31.2 Reporter: Clebert Suconic Assignee: Clebert Suconic Fix For: 2.32.0 ShutdownOnCriticalIOErrorMoveNextTest was actually my "inspiration" to have created the isolated tests module in the first place, so it would be reasonable to move it there as well. the issue comes down to the test simulating a server failure where the server would go down abruptly causing the VM to drop / exit. In this test the nature of failure is leaving a partial shutdown where server executors are still hanging around causing a cascade leak of server pools still running. So it is completely expected to have these threads "leaking". Hence this test should be moved into the isolated-tests. there is no semantic / server change as part of this task. It's just moving a test to a better place. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4526) Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4526?focusedWorklogId=894079&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894079 ] ASF GitHub Bot logged work on ARTEMIS-4526: --- Author: ASF GitHub Bot Created on: 05/Dec/23 14:32 Start Date: 05/Dec/23 14:32 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4703: URL: https://github.com/apache/activemq-artemis/pull/4703 …ation-tests-isolated ShutdownOnCriticalIOErrorMoveNextTest was actually my "inspiration" to have created the isolated tests module in the first place, so it would be reasonable to move it there as well. the issue comes down to the test simulating a server failure where the server would go down abruptly causing the VM to drop / exit. In this test the nature of failure is leaving a partial shutdown where server executors are still hanging around causing a cascade leak of server pools still running. So it is completely expected to have these threads "leaking". Hence this test should be moved into the isolated-tests. there is no semantic / server change as part of this task. It's just moving a test to a better place. Issue Time Tracking --- Worklog Id: (was: 894079) Remaining Estimate: 0h Time Spent: 10m > Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests > -- > > Key: ARTEMIS-4526 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4526 > Project: ActiveMQ Artemis > Issue Type: Test >Affects Versions: 2.31.2 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 10m > Remaining Estimate: 0h > > ShutdownOnCriticalIOErrorMoveNextTest was actually my "inspiration" to have > created the isolated tests module in the first place, so it would be > reasonable to move it there as well. > the issue comes down to the test simulating a server failure where the server > would go down abruptly causing the VM to drop / exit. In this test the nature > of failure is leaving a partial shutdown where server executors are still > hanging around causing a cascade leak of server pools still running. > So it is completely expected to have these threads "leaking". Hence this test > should be moved into the isolated-tests. > there is no semantic / server change as part of this task. It's just moving a > test to a better place. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[
https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894084
]
ASF GitHub Bot logged work on ARTEMIS-4498:
---
Author: ASF GitHub Bot
Created on: 05/Dec/23 15:00
Start Date: 05/Dec/23 15:00
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4702:
URL: https://github.com/apache/activemq-artemis/pull/4702#discussion_r1415763793
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##
@@ -1881,7 +1904,8 @@ public int getEncodeSize() {
BufferHelper.sizeOfNullableInteger(idCacheSize) +
BufferHelper.sizeOfNullableSimpleString(pageFullMessagePolicy != null
? pageFullMessagePolicy.toString() : null) +
BufferHelper.sizeOfNullableInteger(prefetchPageBytes) +
- BufferHelper.sizeOfNullableInteger(prefetchPageMessages);
Review Comment:
why? I added a new record for AddressSettings, right?
Issue Time Tracking
---
Worklog Id: (was: 894084)
Time Spent: 3h 20m (was: 3h 10m)
> Enable management for internal addresses & queues
> -
>
> Key: ARTEMIS-4498
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4498
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Anton Roskvist
>Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Originally "internal" addresses and queues weren't meant to be exposed via
> management. However, due to a bug where the "internal" attribute of a queue
> was not persisted properly such queues have been exposed to management for a
> long time. This was fixed via ARTEMIS-4396, but users still want the ability
> to manage internal queues because it is extremely helpful when trying to
> troubleshoot issues. Therefore, this functionality should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[
https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894085
]
ASF GitHub Bot logged work on ARTEMIS-4498:
---
Author: ASF GitHub Bot
Created on: 05/Dec/23 15:01
Start Date: 05/Dec/23 15:01
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4702:
URL: https://github.com/apache/activemq-artemis/pull/4702#discussion_r1415765011
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##
@@ -1881,7 +1904,8 @@ public int getEncodeSize() {
BufferHelper.sizeOfNullableInteger(idCacheSize) +
BufferHelper.sizeOfNullableSimpleString(pageFullMessagePolicy != null
? pageFullMessagePolicy.toString() : null) +
BufferHelper.sizeOfNullableInteger(prefetchPageBytes) +
- BufferHelper.sizeOfNullableInteger(prefetchPageMessages);
Review Comment:
I wouldn't bother about this.. it's not going to be used.. the new record
would be used.
Although shouldn't we always enable management for internal addresses?
Issue Time Tracking
---
Worklog Id: (was: 894085)
Time Spent: 3.5h (was: 3h 20m)
> Enable management for internal addresses & queues
> -
>
> Key: ARTEMIS-4498
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4498
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Anton Roskvist
>Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Originally "internal" addresses and queues weren't meant to be exposed via
> management. However, due to a bug where the "internal" attribute of a queue
> was not persisted properly such queues have been exposed to management for a
> long time. This was fixed via ARTEMIS-4396, but users still want the ability
> to manage internal queues because it is extremely helpful when trying to
> troubleshoot issues. Therefore, this functionality should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4526) Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793322#comment-17793322 ] ASF subversion and git services commented on ARTEMIS-4526: -- Commit ffaa057ce1d68c1a3ee2e8e4bc8ba6d47c19fdba in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=ffaa057ce1 ] ARTEMIS-4526 Moving ShutdownOnCriticalIOErrorMoveNextTest into integration-tests-isolated ShutdownOnCriticalIOErrorMoveNextTest was actually my "inspiration" to have created the isolated tests module in the first place, so it would be reasonable to move it there as well. the issue comes down to the test simulating a server failure where the server would go down abruptly causing the VM to drop / exit. In this test the nature of failure is leaving a partial shutdown where server executors are still hanging around causing a cascade leak of server pools still running. So it is completely expected to have these threads "leaking". Hence this test should be moved into the isolated-tests. there is no semantic / server change as part of this task. It's just moving a test to a better place. > Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests > -- > > Key: ARTEMIS-4526 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4526 > Project: ActiveMQ Artemis > Issue Type: Test >Affects Versions: 2.31.2 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ShutdownOnCriticalIOErrorMoveNextTest was actually my "inspiration" to have > created the isolated tests module in the first place, so it would be > reasonable to move it there as well. > the issue comes down to the test simulating a server failure where the server > would go down abruptly causing the VM to drop / exit. In this test the nature > of failure is leaving a partial shutdown where server executors are still > hanging around causing a cascade leak of server pools still running. > So it is completely expected to have these threads "leaking". Hence this test > should be moved into the isolated-tests. > there is no semantic / server change as part of this task. It's just moving a > test to a better place. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4526) Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4526?focusedWorklogId=894089&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894089 ] ASF GitHub Bot logged work on ARTEMIS-4526: --- Author: ASF GitHub Bot Created on: 05/Dec/23 15:14 Start Date: 05/Dec/23 15:14 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4703: URL: https://github.com/apache/activemq-artemis/pull/4703 Issue Time Tracking --- Worklog Id: (was: 894089) Time Spent: 20m (was: 10m) > Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests > -- > > Key: ARTEMIS-4526 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4526 > Project: ActiveMQ Artemis > Issue Type: Test >Affects Versions: 2.31.2 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ShutdownOnCriticalIOErrorMoveNextTest was actually my "inspiration" to have > created the isolated tests module in the first place, so it would be > reasonable to move it there as well. > the issue comes down to the test simulating a server failure where the server > would go down abruptly causing the VM to drop / exit. In this test the nature > of failure is leaving a partial shutdown where server executors are still > hanging around causing a cascade leak of server pools still running. > So it is completely expected to have these threads "leaking". Hence this test > should be moved into the isolated-tests. > there is no semantic / server change as part of this task. It's just moving a > test to a better place. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894090&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894090 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 05/Dec/23 15:16 Start Date: 05/Dec/23 15:16 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4702: URL: https://github.com/apache/activemq-artemis/pull/4702#issuecomment-1840998602 Can't we just always allow management of internal queues? that was my point on the other PR. Issue Time Tracking --- Worklog Id: (was: 894090) Time Spent: 3h 40m (was: 3.5h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (ARTEMIS-4526) Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4526. Resolution: Fixed > Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests > -- > > Key: ARTEMIS-4526 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4526 > Project: ActiveMQ Artemis > Issue Type: Test >Affects Versions: 2.31.2 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ShutdownOnCriticalIOErrorMoveNextTest was actually my "inspiration" to have > created the isolated tests module in the first place, so it would be > reasonable to move it there as well. > the issue comes down to the test simulating a server failure where the server > would go down abruptly causing the VM to drop / exit. In this test the nature > of failure is leaving a partial shutdown where server executors are still > hanging around causing a cascade leak of server pools still running. > So it is completely expected to have these threads "leaking". Hence this test > should be moved into the isolated-tests. > there is no semantic / server change as part of this task. It's just moving a > test to a better place. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4525) determinstic webapp directory names
[
https://issues.apache.org/jira/browse/ARTEMIS-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793335#comment-17793335
]
Stephen Higgs commented on ARTEMIS-4525:
PR: https://github.com/apache/activemq-artemis/pull/4701
> determinstic webapp directory names
> ---
>
> Key: ARTEMIS-4525
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4525
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.2
>Reporter: Stephen Higgs
>Priority: Major
>
> The current directory structure for the ${ARTMES_INSTANCE}/tmp/webapps has a
> naming structure like:
> {code}
> jetty-localhost-8161-artemis-plugin_war-_artemis-plugin-any-7963231925855599146
> {code}
> Writing policies for security frameworks like fapolicyd is difficult with
> directory names that include random characters.
> The webapp directory names can be simplified and determinstic.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[
https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894109&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894109
]
ASF GitHub Bot logged work on ARTEMIS-4498:
---
Author: ASF GitHub Bot
Created on: 05/Dec/23 16:28
Start Date: 05/Dec/23 16:28
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4702:
URL: https://github.com/apache/activemq-artemis/pull/4702#discussion_r1415924035
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##
@@ -1881,7 +1904,8 @@ public int getEncodeSize() {
BufferHelper.sizeOfNullableInteger(idCacheSize) +
BufferHelper.sizeOfNullableSimpleString(pageFullMessagePolicy != null
? pageFullMessagePolicy.toString() : null) +
BufferHelper.sizeOfNullableInteger(prefetchPageBytes) +
- BufferHelper.sizeOfNullableInteger(prefetchPageMessages);
Review Comment:
Indeed. I'll remove those changes.
Issue Time Tracking
---
Worklog Id: (was: 894109)
Time Spent: 3h 50m (was: 3h 40m)
> Enable management for internal addresses & queues
> -
>
> Key: ARTEMIS-4498
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4498
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Anton Roskvist
>Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Originally "internal" addresses and queues weren't meant to be exposed via
> management. However, due to a bug where the "internal" attribute of a queue
> was not persisted properly such queues have been exposed to management for a
> long time. This was fixed via ARTEMIS-4396, but users still want the ability
> to manage internal queues because it is extremely helpful when trying to
> troubleshoot issues. Therefore, this functionality should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894114 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 05/Dec/23 16:43 Start Date: 05/Dec/23 16:43 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4702: URL: https://github.com/apache/activemq-artemis/pull/4702#issuecomment-1841186201 After thinking about this more I think we should go with #4670. Issue Time Tracking --- Worklog Id: (was: 894114) Time Spent: 4h 10m (was: 4h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 4h 10m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894113 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 05/Dec/23 16:43 Start Date: 05/Dec/23 16:43 Worklog Time Spent: 10m Work Description: jbertram closed pull request #4702: ARTEMIS-4498 enable management for internal addresses & queues URL: https://github.com/apache/activemq-artemis/pull/4702 Issue Time Tracking --- Worklog Id: (was: 894113) Time Spent: 4h (was: 3h 50m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 4h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894115 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 05/Dec/23 16:44 Start Date: 05/Dec/23 16:44 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1841189826 @AntonRoskvist, thinking about this more I want to go with this PR rather than #4702. Issue Time Tracking --- Worklog Id: (was: 894115) Time Spent: 4h 20m (was: 4h 10m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 4h 20m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4525) determinstic webapp directory names
[
https://issues.apache.org/jira/browse/ARTEMIS-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram updated ARTEMIS-4525:
Priority: Minor (was: Major)
> determinstic webapp directory names
> ---
>
> Key: ARTEMIS-4525
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4525
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.2
>Reporter: Stephen Higgs
>Priority: Minor
>
> The current directory structure for the ${ARTMES_INSTANCE}/tmp/webapps has a
> naming structure like:
> {code}
> jetty-localhost-8161-artemis-plugin_war-_artemis-plugin-any-7963231925855599146
> {code}
> Writing policies for security frameworks like fapolicyd is difficult with
> directory names that include random characters.
> The webapp directory names can be simplified and determinstic.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4525) determinstic webapp directory names
[
https://issues.apache.org/jira/browse/ARTEMIS-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram updated ARTEMIS-4525:
Fix Version/s: 2.32.0
> determinstic webapp directory names
> ---
>
> Key: ARTEMIS-4525
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4525
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.2
>Reporter: Stephen Higgs
>Priority: Minor
> Fix For: 2.32.0
>
>
> The current directory structure for the ${ARTMES_INSTANCE}/tmp/webapps has a
> naming structure like:
> {code}
> jetty-localhost-8161-artemis-plugin_war-_artemis-plugin-any-7963231925855599146
> {code}
> Writing policies for security frameworks like fapolicyd is difficult with
> directory names that include random characters.
> The webapp directory names can be simplified and determinstic.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (ARTEMIS-4525) determinstic webapp directory names
[
https://issues.apache.org/jira/browse/ARTEMIS-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram reassigned ARTEMIS-4525:
---
Assignee: Stephen Higgs (was: Justin Bertram)
> determinstic webapp directory names
> ---
>
> Key: ARTEMIS-4525
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4525
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.2
>Reporter: Stephen Higgs
>Assignee: Stephen Higgs
>Priority: Minor
> Fix For: 2.32.0
>
>
> The current directory structure for the ${ARTMES_INSTANCE}/tmp/webapps has a
> naming structure like:
> {code}
> jetty-localhost-8161-artemis-plugin_war-_artemis-plugin-any-7963231925855599146
> {code}
> Writing policies for security frameworks like fapolicyd is difficult with
> directory names that include random characters.
> The webapp directory names can be simplified and determinstic.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4525) determinstic webapp directory names
[
https://issues.apache.org/jira/browse/ARTEMIS-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793361#comment-17793361
]
ASF subversion and git services commented on ARTEMIS-4525:
--
Commit 15dd24754ae8c6c2dd646fbd214f7a76b33b1197 in activemq-artemis's branch
refs/heads/main from Stephen Higgs
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=15dd24754a ]
ARTEMIS-4525 determinstic webapp directory names
This commit uses the war file name as the webapp directory name instead
of the default directory name that includes random charcters.
> determinstic webapp directory names
> ---
>
> Key: ARTEMIS-4525
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4525
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.2
>Reporter: Stephen Higgs
>Assignee: Stephen Higgs
>Priority: Minor
> Fix For: 2.32.0
>
>
> The current directory structure for the ${ARTMES_INSTANCE}/tmp/webapps has a
> naming structure like:
> {code}
> jetty-localhost-8161-artemis-plugin_war-_artemis-plugin-any-7963231925855599146
> {code}
> Writing policies for security frameworks like fapolicyd is difficult with
> directory names that include random characters.
> The webapp directory names can be simplified and determinstic.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4525) Deterministic webapp directory names
[
https://issues.apache.org/jira/browse/ARTEMIS-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram updated ARTEMIS-4525:
Summary: Deterministic webapp directory names (was: determinstic webapp
directory names)
> Deterministic webapp directory names
>
>
> Key: ARTEMIS-4525
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4525
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.2
>Reporter: Stephen Higgs
>Assignee: Stephen Higgs
>Priority: Minor
> Fix For: 2.32.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current directory structure for the ${ARTMES_INSTANCE}/tmp/webapps has a
> naming structure like:
> {code}
> jetty-localhost-8161-artemis-plugin_war-_artemis-plugin-any-7963231925855599146
> {code}
> Writing policies for security frameworks like fapolicyd is difficult with
> directory names that include random characters.
> The webapp directory names can be simplified and determinstic.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4525) determinstic webapp directory names
[
https://issues.apache.org/jira/browse/ARTEMIS-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram resolved ARTEMIS-4525.
-
Resolution: Fixed
> determinstic webapp directory names
> ---
>
> Key: ARTEMIS-4525
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4525
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.2
>Reporter: Stephen Higgs
>Assignee: Stephen Higgs
>Priority: Minor
> Fix For: 2.32.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current directory structure for the ${ARTMES_INSTANCE}/tmp/webapps has a
> naming structure like:
> {code}
> jetty-localhost-8161-artemis-plugin_war-_artemis-plugin-any-7963231925855599146
> {code}
> Writing policies for security frameworks like fapolicyd is difficult with
> directory names that include random characters.
> The webapp directory names can be simplified and determinstic.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4525) determinstic webapp directory names
[
https://issues.apache.org/jira/browse/ARTEMIS-4525?focusedWorklogId=894118&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894118
]
ASF GitHub Bot logged work on ARTEMIS-4525:
---
Author: ASF GitHub Bot
Created on: 05/Dec/23 17:13
Start Date: 05/Dec/23 17:13
Worklog Time Spent: 10m
Work Description: asfgit closed pull request #4701: ARTEMIS-4525
deterministic webapp directory names
URL: https://github.com/apache/activemq-artemis/pull/4701
Issue Time Tracking
---
Worklog Id: (was: 894118)
Remaining Estimate: 0h
Time Spent: 10m
> determinstic webapp directory names
> ---
>
> Key: ARTEMIS-4525
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4525
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.2
>Reporter: Stephen Higgs
>Assignee: Stephen Higgs
>Priority: Minor
> Fix For: 2.32.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current directory structure for the ${ARTMES_INSTANCE}/tmp/webapps has a
> naming structure like:
> {code}
> jetty-localhost-8161-artemis-plugin_war-_artemis-plugin-any-7963231925855599146
> {code}
> Writing policies for security frameworks like fapolicyd is difficult with
> directory names that include random characters.
> The webapp directory names can be simplified and determinstic.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] (ARTEMIS-4525) determinstic webapp directory names
[ https://issues.apache.org/jira/browse/ARTEMIS-4525 ]
Justin Bertram deleted comment on ARTEMIS-4525:
-
was (Author: shiggs):
PR: https://github.com/apache/activemq-artemis/pull/4701
> determinstic webapp directory names
> ---
>
> Key: ARTEMIS-4525
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4525
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.2
>Reporter: Stephen Higgs
>Assignee: Stephen Higgs
>Priority: Minor
> Fix For: 2.32.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The current directory structure for the ${ARTMES_INSTANCE}/tmp/webapps has a
> naming structure like:
> {code}
> jetty-localhost-8161-artemis-plugin_war-_artemis-plugin-any-7963231925855599146
> {code}
> Writing policies for security frameworks like fapolicyd is difficult with
> directory names that include random characters.
> The webapp directory names can be simplified and determinstic.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4526) Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793375#comment-17793375 ] ASF subversion and git services commented on ARTEMIS-4526: -- Commit c3963b4284d51b7bf8bdd6110e8505ea3a0b27b0 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c3963b4284 ] ARTEMIS-4526 Using TemporaryFolder on ShutdownOnCriticalIOErrorMoveNextTest > Move ShutdownOnCriticalIOErrorMoveNextTest into Isolated tests > -- > > Key: ARTEMIS-4526 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4526 > Project: ActiveMQ Artemis > Issue Type: Test >Affects Versions: 2.31.2 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 20m > Remaining Estimate: 0h > > ShutdownOnCriticalIOErrorMoveNextTest was actually my "inspiration" to have > created the isolated tests module in the first place, so it would be > reasonable to move it there as well. > the issue comes down to the test simulating a server failure where the server > would go down abruptly causing the VM to drop / exit. In this test the nature > of failure is leaving a partial shutdown where server executors are still > hanging around causing a cascade leak of server pools still running. > So it is completely expected to have these threads "leaking". Hence this test > should be moved into the isolated-tests. > there is no semantic / server change as part of this task. It's just moving a > test to a better place. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4522) Slow-Consumer-Handling may get delayed significantly on occupied pool
[
https://issues.apache.org/jira/browse/ARTEMIS-4522?focusedWorklogId=894134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894134
]
ASF GitHub Bot logged work on ARTEMIS-4522:
---
Author: ASF GitHub Bot
Created on: 05/Dec/23 18:50
Start Date: 05/Dec/23 18:50
Worklog Time Spent: 10m
Work Description: MrEasy commented on PR #4699:
URL:
https://github.com/apache/activemq-artemis/pull/4699#issuecomment-1841422362
> @MrEasy, you've got a handful of checkstyle violations:
> ```
> Also, your commits should be squashed.
Reduced violence and squashed
Issue Time Tracking
---
Worklog Id: (was: 894134)
Time Spent: 1h 10m (was: 1h)
> Slow-Consumer-Handling may get delayed significantly on occupied pool
> -
>
> Key: ARTEMIS-4522
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4522
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Rico Neubauer
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Slack discussion with [~jbertram] see here:
> [https://the-asf.slack.com/archives/CFL910J30/p1699520764243169]
> h2. Initial Description
> consumers-window-size set to 0 and there some queues, that are heavily used
> and have consumers attached, that allow for a concurrency of 500 messages
> (larger than thread-pool-client-size).
> After some time - unclear what triggers it - the behavior becomes bad in the
> way that from those queues only 1-5 messages are fetched and immediately
> processed, but then there is a pause of 10 seconds before the next 1-5
> messages are fetched. This continues.
> In the thread-dumps, several like the following can be seen:
> {noformat}
> "Thread-0 (ActiveMQ-client-global-threads)" #640 daemon prio=5 os_prio=0
> cpu=899719.36ms elapsed=354425.44s tid=0x7f904c02e850 nid=0x150d29
> runnable [0x7f8fdbae5000]
>java.lang.Thread.State: TIMED_WAITING (parking)
> at jdk.internal.misc.Unsafe.park(java.base@17.0.5/Native Method)
> - parking to wait for <0x0003f6c9d1d0> (a
> org.apache.activemq.artemis.utils.AbstractLatch$CountSync)
> at
> java.util.concurrent.locks.LockSupport.parkNanos(java.base@17.0.5/LockSupport.java:252)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(java.base@17.0.5/AbstractQueuedSynchronizer.java:717)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(java.base@17.0.5/AbstractQueuedSynchronizer.java:1074)
> at
> org.apache.activemq.artemis.utils.AbstractLatch.await(AbstractLatch.java:115)
> at
> org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl.startSlowConsumer(ClientConsumerImpl.java:869)
> at
> org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl.callOnMessage(ClientConsumerImpl.java:1025)
> at
> org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl$Runner.run(ClientConsumerImpl.java:1154)
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:65)
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase$$Lambda$2008/0x0007ce20c000.run(Unknown
> Source)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@17.0.5/ThreadPoolExecutor.java:1136)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@17.0.5/ThreadPoolExecutor.java:635)
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> {noformat}
> which corresponds to code location with a 10 seconds sleep here:
> [https://github.com/apache/activemq-artemis/blob/main/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerImpl.java#L854|https://github.com/seeburger-ag/activemq-artemis/blob/main/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerImpl.java#L854]
> It seems it always needs to wait until the 10 seconds are reached, which is
> unexpected, since the latch should count-down before, after having sent the
> credit to the server. We could assume some bug, that maybe increments the
> latch, but misses to decrement, so it is not able to reach 0 ever again, but
> that's speculative.
> h2. Evaluation
> See slack for details, it boils down to the thread-pool in use being out of
> free threads, so the slow-consumer-handling is not able to run in good time.
> Affected versions: all since at least 2.22.0 up to current - probably since
> "ever", in
[jira] [Created] (AMQ-9411) Update javadoc reference to javax.script.. pool bean
Matt Pavlovich created AMQ-9411:
---
Summary: Update javadoc reference to javax.script.. pool bean
Key: AMQ-9411
URL: https://issues.apache.org/jira/browse/AMQ-9411
Project: ActiveMQ
Issue Type: Improvement
Reporter: Matt Pavlovich
activemq-spring has this generated in the xsd comments.
{noformat}
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (AMQ-9411) Update javadoc reference to javax.script.. pool bean
[
https://issues.apache.org/jira/browse/AMQ-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Pavlovich updated AMQ-9411:
Fix Version/s: 6.1.0
> Update javadoc reference to javax.script.. pool bean
>
>
> Key: AMQ-9411
> URL: https://issues.apache.org/jira/browse/AMQ-9411
> Project: ActiveMQ
> Issue Type: Improvement
>Reporter: Matt Pavlovich
>Priority: Trivial
> Fix For: 6.1.0
>
>
> activemq-spring has this generated in the xsd comments.
> {noformat}
> class="javax.script.ScriptEngineFactory.PooledConnectionFactoryFactoryBean">
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (AMQ-9411) Update javadoc reference to javax.script.. pool bean
[
https://issues.apache.org/jira/browse/AMQ-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Pavlovich reassigned AMQ-9411:
---
Assignee: Matt Pavlovich
> Update javadoc reference to javax.script.. pool bean
>
>
> Key: AMQ-9411
> URL: https://issues.apache.org/jira/browse/AMQ-9411
> Project: ActiveMQ
> Issue Type: Improvement
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Trivial
> Fix For: 6.1.0
>
>
> activemq-spring has this generated in the xsd comments.
> {noformat}
> class="javax.script.ScriptEngineFactory.PooledConnectionFactoryFactoryBean">
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894154&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894154 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 05/Dec/23 19:43 Start Date: 05/Dec/23 19:43 Worklog Time Spent: 10m Work Description: AntonRoskvist commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1841505518 Alright, I'll just leave it as is then Issue Time Tracking --- Worklog Id: (was: 894154) Time Spent: 4.5h (was: 4h 20m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 4.5h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
