[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation
[ https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012844#comment-16012844 ] ASF GitHub Bot commented on ARTEMIS-1163: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1269 > Refactory connection factory client creation > > > Key: ARTEMIS-1163 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1163 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.2.0 >Reporter: Klaus Boeing >Priority: Minor > > The implementation of the ActiveMQJMSClient class currently has several > conditionals for creating a connecction factory according to the > JMSFactoryType. > I think it is convenient to tailor the implementation so that the connection > factory creation logic is in the JMSFactoryType itself, simplifying the code > and making it easier to maintain. > Follow the adjustment made > https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation
[ https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012843#comment-16012843 ] ASF subversion and git services commented on ARTEMIS-1163: -- Commit 7b5f141a4c98f6c851818a74e7424d5113e3a1fb in activemq-artemis's branch refs/heads/master from [~klausboeing] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=7b5f141 ] ARTEMIS-1163 Refactory to polimorphic connectionfactory creation Move logic to create a connectionfactory from the ActiveMQJMSClient class to the JMSFactoryType enum to eliminate conditional logic in favor of polymorphism. > Refactory connection factory client creation > > > Key: ARTEMIS-1163 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1163 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.2.0 >Reporter: Klaus Boeing >Priority: Minor > > The implementation of the ActiveMQJMSClient class currently has several > conditionals for creating a connecction factory according to the > JMSFactoryType. > I think it is convenient to tailor the implementation so that the connection > factory creation logic is in the JMSFactoryType itself, simplifying the code > and making it easier to maintain. > Follow the adjustment made > https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation
[ https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010810#comment-16010810 ] ASF GitHub Bot commented on ARTEMIS-1163: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1269 YOu have a bit of a mess on your PR right now. you could ammend all your committs into one.. You have the initial one, then a rever, another revert (that I had some trouble rebasing)... that is.. a mess.. I could figure out how to fix it.. I will run some tests and merge it.. Tip: git rebase -i HEAD~4 git push origin -f > Refactory connection factory client creation > > > Key: ARTEMIS-1163 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1163 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.2.0 >Reporter: Klaus Boeing >Priority: Minor > > The implementation of the ActiveMQJMSClient class currently has several > conditionals for creating a connecction factory according to the > JMSFactoryType. > I think it is convenient to tailor the implementation so that the connection > factory creation logic is in the JMSFactoryType itself, simplifying the code > and making it easier to maintain. > Follow the adjustment made > https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation
[ https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009498#comment-16009498 ] ASF GitHub Bot commented on ARTEMIS-1163: - Github user klausboeing commented on the issue: https://github.com/apache/activemq-artemis/pull/1269 @jbertram Exactly this point I would like to know. Thank you. > Refactory connection factory client creation > > > Key: ARTEMIS-1163 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1163 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.2.0 >Reporter: Klaus Boeing >Priority: Minor > > The implementation of the ActiveMQJMSClient class currently has several > conditionals for creating a connecction factory according to the > JMSFactoryType. > I think it is convenient to tailor the implementation so that the connection > factory creation logic is in the JMSFactoryType itself, simplifying the code > and making it easier to maintain. > Follow the adjustment made > https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation
[ https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009486#comment-16009486 ] ASF GitHub Bot commented on ARTEMIS-1163: - Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1269 @klausboeing, I'm not exactly sure what you're asking. Once the PR is merged I'll close the JIRA. At this point you need to squash the two commits together into a single commit. > Refactory connection factory client creation > > > Key: ARTEMIS-1163 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1163 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.2.0 >Reporter: Klaus Boeing >Priority: Minor > > The implementation of the ActiveMQJMSClient class currently has several > conditionals for creating a connecction factory according to the > JMSFactoryType. > I think it is convenient to tailor the implementation so that the connection > factory creation logic is in the JMSFactoryType itself, simplifying the code > and making it easier to maintain. > Follow the adjustment made > https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation
[ https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009479#comment-16009479 ] ASF GitHub Bot commented on ARTEMIS-1163: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1269 Nice PR though. Just need to make sure checkstyke is passing. > Refactory connection factory client creation > > > Key: ARTEMIS-1163 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1163 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.2.0 >Reporter: Klaus Boeing >Priority: Minor > > The implementation of the ActiveMQJMSClient class currently has several > conditionals for creating a connecction factory according to the > JMSFactoryType. > I think it is convenient to tailor the implementation so that the connection > factory creation logic is in the JMSFactoryType itself, simplifying the code > and making it easier to maintain. > Follow the adjustment made > https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1163) Refactory connection factory client creation
[ https://issues.apache.org/jira/browse/ARTEMIS-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009475#comment-16009475 ] ASF GitHub Bot commented on ARTEMIS-1163: - Github user klausboeing commented on the issue: https://github.com/apache/activemq-artemis/pull/1269 @jbertram I made the adjustments as needed. How will the ARTEMIS-1163 ticket be processed? Thanks for listening. > Refactory connection factory client creation > > > Key: ARTEMIS-1163 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1163 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.2.0 >Reporter: Klaus Boeing >Priority: Minor > > The implementation of the ActiveMQJMSClient class currently has several > conditionals for creating a connecction factory according to the > JMSFactoryType. > I think it is convenient to tailor the implementation so that the connection > factory creation logic is in the JMSFactoryType itself, simplifying the code > and making it easier to maintain. > Follow the adjustment made > https://github.com/klausboeing/activemq-artemis/commit/5d62ca789b8c49234067b57cea3d245ee3b8bf1e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
