[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155431#comment-16155431 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1511 thanks! > Incomplete comment in default broker.xml file > - > > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > Fix For: 2.3.0 > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155430#comment-16155430 ] ASF subversion and git services commented on ARTEMIS-1385: -- Commit 12f085a93438aa97329555fd38a1b2bfb52c5096 in activemq-artemis's branch refs/heads/master from [~sknot] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=12f085a ] ARTEMIS-1385 fixed incomplete comment and typo (appendix) > Incomplete comment in default broker.xml file > - > > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > Fix For: 2.3.0 > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155432#comment-16155432 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1511 > Incomplete comment in default broker.xml file > - > > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > Fix For: 2.3.0 > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155368#comment-16155368 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1511 appendix is not a very good commit name... when reading logs (git log) you're supposed to give enough context so you don't need to open JIRA or anything else to know what was the change. For two reasons: i - it's not practical... ii - If tomorrow there's no more JIRA, at least you have context on what was the change. > Incomplete comment in default broker.xml file > - > > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > Fix For: 2.3.0 > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155166#comment-16155166 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1511 retest this please > Incomplete comment in default broker.xml file > - > > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > Fix For: 2.3.0 > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154929#comment-16154929 ] ASF GitHub Bot commented on ARTEMIS-1385: - GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1511 ARTEMIS-1385 appendix I have missed some files (probably grepped at wrong branch) You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1385-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1511 commit a27f40dd426910c15e33f2f3686f7e7e5c7354a9 Author: Stanislav Knot Date: 2017-09-06T07:26:00Z ARTEMIS-1385 appendix > Incomplete comment in default broker.xml file > - > > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > Fix For: 2.3.0 > > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153678#comment-16153678 ] ASF subversion and git services commented on ARTEMIS-1385: -- Commit e9c601dd2ca3070338731ed391fdb5bb991c873d in activemq-artemis's branch refs/heads/master from [~sknot] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e9c601d ] ARTEMIS-1385 fixed uncomplete comment and typo > Incomplete comment in default broker.xml file > - > > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153679#comment-16153679 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1509 > Incomplete comment in default broker.xml file > - > > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153676#comment-16153676 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1509#discussion_r136994236 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt --- @@ -1,6 +1,6 @@ > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153677#comment-16153677 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1509#discussion_r136994424 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt --- @@ -1,6 +1,6 @@ > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153636#comment-16153636 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1509#discussion_r136987322 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt --- @@ -1,6 +1,6 @@ > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153626#comment-16153626 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1509#discussion_r136984584 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt --- @@ -1,6 +1,6 @@ > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153617#comment-16153617 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1509#discussion_r136983654 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt --- @@ -1,6 +1,6 @@ > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153221#comment-16153221 ] ASF GitHub Bot commented on ARTEMIS-1385: - Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1509#discussion_r136912715 --- Diff: docs/user-manual/en/configuration-index.md --- @@ -112,7 +112,7 @@ system-property-prefix | Prefix for replacing configuration settings using Bean [transaction-timeout](transaction-config.md "Resource Manager Configuration") | how long (in ms) before a transaction can be removed from the resource manager after create time. Default=30 [transaction-timeout-scan-period](transaction-config.md "Resource Manager Configuration") | how often (in ms) to scan for timeout transactions. Default=1000 [wild-card-routing-enabled](wildcard-routing.md "Routing Messages With Wild Cards")| true means that the server supports wild card routing. Default=true -[network-check-NIC](network-isolation.md) | The network internet card to be used on InetAddress.isReacheable +[network-check-NIC](network-isolation.md) | The network internet controller to be used on InetAddress.isReacheable --- End diff -- NIC is Network Interface Controller. I had to google that and I guess it won't be obvious to more people. Maybe write the abbreviation and the meaning in parens after it, so that people learn this right away. Also, it may not be entirely obvious what are the NIC names. Something like eth0 on Linux? What it is on Windows? How can I list them? Any alternatives to this for older systems, that do not have the more robust "enp0s25" style naming and eth0 and eth1 may be randomly switched; or is that no longer a problem? > Incomplete comment in default broker.xml file > - > > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1385) Incomplete comment in default broker.xml file
[ https://issues.apache.org/jira/browse/ARTEMIS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153191#comment-16153191 ] ASF GitHub Bot commented on ARTEMIS-1385: - GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1509 ARTEMIS-1385 fixed uncomplete comment and typo You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis-1 ARTEMIS-1385 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1509.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1509 commit a6c0789e4da2b2f4b5854db8b3e67bb770d86c2f Author: Stanislav Knot Date: 2017-09-05T07:09:01Z ARTEMIS-1385 fixed uncomplete comment and typo > Incomplete comment in default broker.xml file > - > > Key: ARTEMIS-1385 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1385 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Martyn Taylor > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
