[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417602#comment-16417602 ] ASF subversion and git services commented on ARTEMIS-1590: -- Commit 2a0b9039a31b6d045e27a149772e62f0d1c7c100 in activemq-artemis's branch refs/heads/1.x from [~jmesnil] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=2a0b903 ] [ARTEMIS-1590] Properties-based SQLProvider (cherry picked from commit 938fbd81cbe242504ff6563aa7301e681f80a61c) > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil >Priority: Major > Fix For: 2.5.0 > > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324025#comment-16324025 ] ASF subversion and git services commented on ARTEMIS-1590: -- Commit 938fbd81cbe242504ff6563aa7301e681f80a61c in activemq-artemis's branch refs/heads/master from [~jmesnil] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=938fbd8 ] [ARTEMIS-1590] Properties-based SQLProvider Replace GenericSQLProvider and other implementation by a single PropertySQLProvider that uses properties to define SQL queries. SQL queries are loaded from the journal-sql.properties file. Queries specific to a DB dialect can be specified by adding a suffix to the key of the generic property. For example, the generic property to create a file Table is: create-file-table = CREATE TABLE %s (ID BIGINT AUTO_INCREMENT, ...) This property can be customized for Derby by using the create-file-table.derby property: create-file-table.derby=CREATE TABLE %s (ID BIGINT NOT NULL GENERATED ALWAYS AS IDENTITY (START WITH 1, INCREMENT BY 1),... JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324027#comment-16324027 ] ASF GitHub Bot commented on ARTEMIS-1590: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1756 > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324026#comment-16324026 ] ASF subversion and git services commented on ARTEMIS-1590: -- Commit 938fbd81cbe242504ff6563aa7301e681f80a61c in activemq-artemis's branch refs/heads/master from [~jmesnil] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=938fbd8 ] [ARTEMIS-1590] Properties-based SQLProvider Replace GenericSQLProvider and other implementation by a single PropertySQLProvider that uses properties to define SQL queries. SQL queries are loaded from the journal-sql.properties file. Queries specific to a DB dialect can be specified by adding a suffix to the key of the generic property. For example, the generic property to create a file Table is: create-file-table = CREATE TABLE %s (ID BIGINT AUTO_INCREMENT, ...) This property can be customized for Derby by using the create-file-table.derby property: create-file-table.derby=CREATE TABLE %s (ID BIGINT NOT NULL GENERATED ALWAYS AS IDENTITY (START WITH 1, INCREMENT BY 1),... JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323989#comment-16323989 ] ASF GitHub Bot commented on ARTEMIS-1590: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1756 @jmesnil Perfect! Thanks for this PR, it is making JDBC customizations much simpler & cleaner :+1: > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323984#comment-16323984 ] ASF GitHub Bot commented on ARTEMIS-1590: - Github user jmesnil commented on the issue: https://github.com/apache/activemq-artemis/pull/1756 @franz1981 done :) > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323766#comment-16323766 ] ASF GitHub Bot commented on ARTEMIS-1590: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1756 @jmesnil Could you please squash the commits? :) > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322981#comment-16322981 ] ASF GitHub Bot commented on ARTEMIS-1590: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1756 @mtaylor @jmesnil I've run the CI tests and it seems good enough to me, I'll merge it tomorrow (in few hours), probably would be good to squash some commits to make it more compact > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322642#comment-16322642 ] ASF GitHub Bot commented on ARTEMIS-1590: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1756 @mtaylor @jmesnil Before merging it I will re-run a CI round on it first: can't say but I couldn't check the current (seems ailed) Jenkins results > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318665#comment-16318665 ] ASF GitHub Bot commented on ARTEMIS-1590: - Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1756#discussion_r160451205 --- Diff: artemis-jdbc-store/src/main/resources/journal-sql.properties --- @@ -0,0 +1,63 @@ +# Generic SQL statements --- End diff -- It is needed to add on top: ``` # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. ``` > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318555#comment-16318555 ] ASF GitHub Bot commented on ARTEMIS-1590: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1756 @jmesnil > Is there a way to trigger it again? Not sure but maybe just forcing another push it will restart a CI job? > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318509#comment-16318509 ] ASF GitHub Bot commented on ARTEMIS-1590: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1756 @jmesnil I'm looking into it :+1: > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318305#comment-16318305 ] ASF GitHub Bot commented on ARTEMIS-1590: - Github user jmesnil commented on the issue: https://github.com/apache/activemq-artemis/pull/1756 The CI is reporting an error but the build has already disappeared from its history. Is there a way to trigger it again? > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316403#comment-16316403 ] ASF GitHub Bot commented on ARTEMIS-1590: - GitHub user jmesnil opened a pull request: https://github.com/apache/activemq-artemis/pull/1756 [ARTEMIS-1590] Properties-based SQLProvider Replace GenericSQLProvider and other implementation by a single PropertySQLProvider that uses properties to define SQL queries. SQL queries are loaded from the journal-sql.properties file. Queries specific to a DB dialect can be specified by adding a suffix to the key of the generic property. For example, the generic property to create a file Table is: ``` create-file-table = CREATE TABLE %s (ID BIGINT AUTO_INCREMENT, ...) ``` This property can be customized for Derby by using the `create-file-table.derby` property: ``` create-file-table.derby=CREATE TABLE %s (ID BIGINT NOT NULL GENERATED ALWAYS AS IDENTITY (START WITH 1, INCREMENT BY 1),... ``` JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1590 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jmesnil/activemq-artemis ARTEMIS-1590_JDBC_PropertySQLProvider Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1756.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1756 commit 69e352015f5e33bc833976acea7e2edabafe1273 Author: Jeff Mesnil Date: 2018-01-05T10:54:48Z [ARTEMIS-1590] Properties-based SQLProvider Replace GenericSQLProvider and other implementation by a single PropertySQLProvider that uses properties to define SQL queries. SQL queries are loaded from the journal-sql.properties file. Queries specific to a DB dialect can be specified by adding a suffix to the key of the generic property. For example, the generic property to create a file Table is: create-file-table = CREATE TABLE %s (ID BIGINT AUTO_INCREMENT, ...) This property can be customized for Derby by using the create-file-table.derby property: create-file-table.derby=CREATE TABLE %s (ID BIGINT NOT NULL GENERATED ALWAYS AS IDENTITY (START WITH 1, INCREMENT BY 1),... JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Use properties to configure JDBC store SQLProvider > -- > > Key: ARTEMIS-1590 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1590 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.4.0 >Reporter: Jeff Mesnil > > This follow up the conversation started on activemq-dev mailing list[1] to > use a properties-based implementation for Artemis SQLProvider to ease > maintenance and support of different databases and their dialects. > [1] > http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3ccaaeh2wf_ajyvzfaglczfwpdmcwlpydsrnio_4+k+mthdzph...@mail.gmail.com%3e -- This message was sent by Atlassian JIRA (v6.4.14#64029)
