[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596887=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596887 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 20:35 Start Date: 14/May/21 20:35 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632787098 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: Hmmm.. this feature could also be used for Disaster and Recovery options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596887) Time Spent: 3h 20m (was: 3h 10m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596879=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596879 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 20:04 Start Date: 14/May/21 20:04 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632767871 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: @michaelandrepearce some time ago, I talked to an Architect at my job who wanted to get diffs from the broker and send over to another site from time to time. This kind of feature would be useful for such case maybe? It wouldn't hurt to have it though.. it's just an additional option. I am thinking to have a commented out xml on the broker.xml that will have 7 days, 10G as the config. So if users just uncomment that they will have the 7 days and 10G max disk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596879) Time Spent: 3h 10m (was: 3h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596867=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596867 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 19:37 Start Date: 14/May/21 19:37 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632753627 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: > files is good if you care about you max disk usage. But I think for time, hours is too coarse. and seconds covers everything up to hours nicely. Initial idea was for it to be coarse as it would be days/weeks retention, intent is to time machine back after say an incident that gets found out after the fact and work out what could have happened. I’m not sure how useful seconds here would be tbh. That said if the value is a long having it just as simple ms like retention is in kafka just simplifies config, everyone is able to convert days/weeks to ms and the we have a simple config, not having to deal with variants -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596867) Time Spent: 3h (was: 2h 50m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596861=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596861 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 19:34 Start Date: 14/May/21 19:34 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632753627 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: > files is good if you care about you max disk usage. But I think for time, hours is too coarse. and seconds covers everything up to hours nicely. Initial idea was for it to be coarse as it wood be days/weeks, intent is to time machine back after say an incident that gets found out after the fact and work out what could have happened. I’m not sure how useful seconds here would be tbh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596861) Time Spent: 2h 50m (was: 2h 40m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596859=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596859 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 19:31 Start Date: 14/May/21 19:31 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632752395 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: `` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596859) Time Spent: 2h 40m (was: 2.5h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596729=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596729 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 15:58 Start Date: 14/May/21 15:58 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632630456 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: yep, I agree, time and space, probably need both, to limit disk usage in case the time limits is too large. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596729) Time Spent: 2.5h (was: 2h 20m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596711=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596711 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 15:06 Start Date: 14/May/21 15:06 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632592880 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: I would suggest a timebased config item/attribute and a separate files/size based config item/attribute to allow this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596711) Time Spent: 2h 20m (was: 2h 10m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596708=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596708 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 15:05 Start Date: 14/May/21 15:05 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632592880 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: I would suggest a timebased config item and a files/size based config item -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596708) Time Spent: 2h (was: 1h 50m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596710=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596710 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 15:05 Start Date: 14/May/21 15:05 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632592880 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: I would suggest a timebased config item and a separate files/size based config item to allow this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596710) Time Spent: 2h 10m (was: 2h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596706=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596706 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 15:03 Start Date: 14/May/21 15:03 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632591760 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: What if you want to limit by files and time at same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596706) Time Spent: 1h 50m (was: 1h 40m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596701=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596701 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 14:48 Start Date: 14/May/21 14:48 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632578418 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: period does not work for files: maybe: `` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596701) Time Spent: 1h 40m (was: 1.5h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596700=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596700 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 14:46 Start Date: 14/May/21 14:46 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632579850 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596700) Time Spent: 1.5h (was: 1h 20m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596698=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596698 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 14:44 Start Date: 14/May/21 14:44 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632578418 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: period does not work for files: maybe: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596698) Time Spent: 1h 20m (was: 1h 10m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596684=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596684 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 14:26 Start Date: 14/May/21 14:26 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632565882 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: files is good if you care about you max disk usage. But I think for time, hours is too coarse. and seconds covers everything up to hours nicely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596684) Time Spent: 1h 10m (was: 1h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596633=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596633 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 12:58 Start Date: 14/May/21 12:58 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632508629 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: @gtully I thought about using max-files for such cases.. Humans are usually slow to react... .. perhaps we could have this ``` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596633) Time Spent: 1h (was: 50m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596631=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596631 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 12:57 Start Date: 14/May/21 12:57 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632508629 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: @gtully I thought about using max-files for such cases.. Humans are usually slow to react... .. perhaps we could have this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596631) Time Spent: 40m (was: 0.5h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596632=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596632 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 12:57 Start Date: 14/May/21 12:57 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632508846 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java ## @@ -668,6 +668,25 @@ Configuration addDiscoveryGroupConfiguration(String key, */ Configuration setJournalDirectory(String dir); + String getJournalHistory(); + + File getJournalHistoryLocation(); + + /** +* Sets the file system directory used to store historical backup journal. +*/ + Configuration setJournalHistory(String dir); + + int getJournalHistoryMaxDays(); + + Configuration setJournalHistoryMaxDays(int days); Review comment: Oooo... I like the name retention!!! Really nice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596632) Time Spent: 50m (was: 40m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 50m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596540=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596540 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 07:58 Start Date: 14/May/21 07:58 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632352294 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: this config looks neat, but I think "journal-retention" is a better name, and I think in high volume scenarios second granularity will be necessary to capture use cases less than days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596540) Time Spent: 0.5h (was: 20m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596538=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596538 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 07:51 Start Date: 14/May/21 07:51 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632350082 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java ## @@ -668,6 +668,25 @@ Configuration addDiscoveryGroupConfiguration(String key, */ Configuration setJournalDirectory(String dir); + String getJournalHistory(); + + File getJournalHistoryLocation(); + + /** +* Sets the file system directory used to store historical backup journal. +*/ + Configuration setJournalHistory(String dir); + + int getJournalHistoryMaxDays(); + + Configuration setJournalHistoryMaxDays(int days); Review comment: This is a neat feature. I think I would call it something else from a configuration perspective. journalRetention or just retention configured with a: int retentionLimit > 0 enum retentionUnit (seconds/days/numFiles) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596538) Time Spent: 20m (was: 10m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596386 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 13/May/21 22:24 Start Date: 13/May/21 22:24 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596386) Remaining Estimate: 0h Time Spent: 10m > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
