[jira] [Work logged] (ARTEMIS-4171) Potential large message file leak
[ https://issues.apache.org/jira/browse/ARTEMIS-4171?focusedWorklogId=856590=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856590 ] ASF GitHub Bot logged work on ARTEMIS-4171: --- Author: ASF GitHub Bot Created on: 12/Apr/23 22:48 Start Date: 12/Apr/23 22:48 Worklog Time Spent: 10m Work Description: clebertsuconic closed pull request #4430: ARTEMIS-4171/ARTEMIS-4233 Large Message Send URL: https://github.com/apache/activemq-artemis/pull/4430 Issue Time Tracking --- Worklog Id: (was: 856590) Time Spent: 1h 10m (was: 1h) > Potential large message file leak > - > > Key: ARTEMIS-4171 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4171 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > If an exception is thrown during the sending of a large message (e.g. from a > plugin) the large message file can be orphaned on disk. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4171) Potential large message file leak
[
https://issues.apache.org/jira/browse/ARTEMIS-4171?focusedWorklogId=856141=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856141
]
ASF GitHub Bot logged work on ARTEMIS-4171:
---
Author: ASF GitHub Bot
Created on: 11/Apr/23 14:16
Start Date: 11/Apr/23 14:16
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4430:
URL: https://github.com/apache/activemq-artemis/pull/4430#discussion_r1162887459
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
##
@@ -1130,14 +1130,16 @@ private void sendContinuations(final int packetSize,
try {
session.send(session.getCurrentTransaction(),
EmbedMessageUtil.extractEmbedded((ICoreMessage) message.toMessage(),
storageManager), false, producers.get(senderID), false);
-} catch (Exception e) {
- message.deleteFile();
- throw e;
} catch (Throwable e) {
-
logger.warn("");
- logger.warn("Throwable on currentLargeMessage {}",
message.getMessageID(), e);
-
logger.warn("");
-
+ logger.warn(e.getMessage(), e);
Review Comment:
The code this method is calling looks to throw exceptions in fairly
'typical' situations, e.g security checks, disk usage checks. I think starting
to log a full stacktrace for every one of them, when it specifically didnt
before (presumably as the code calling this method should either handle, or
itself print, them), is likely asking for a lot of new questions. Along the
lines of the more typical 'I suddenly got this new error \'.
Issue Time Tracking
---
Worklog Id: (was: 856141)
Time Spent: 1h (was: 50m)
> Potential large message file leak
> -
>
> Key: ARTEMIS-4171
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4171
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> If an exception is thrown during the sending of a large message (e.g. from a
> plugin) the large message file can be orphaned on disk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4171) Potential large message file leak
[
https://issues.apache.org/jira/browse/ARTEMIS-4171?focusedWorklogId=856123=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856123
]
ASF GitHub Bot logged work on ARTEMIS-4171:
---
Author: ASF GitHub Bot
Created on: 11/Apr/23 13:21
Start Date: 11/Apr/23 13:21
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4430:
URL: https://github.com/apache/activemq-artemis/pull/4430#discussion_r1162809029
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
##
@@ -1130,14 +1130,16 @@ private void sendContinuations(final int packetSize,
try {
session.send(session.getCurrentTransaction(),
EmbedMessageUtil.extractEmbedded((ICoreMessage) message.toMessage(),
storageManager), false, producers.get(senderID), false);
-} catch (Exception e) {
- message.deleteFile();
- throw e;
} catch (Throwable e) {
-
logger.warn("");
- logger.warn("Throwable on currentLargeMessage {}",
message.getMessageID(), e);
-
logger.warn("");
-
+ logger.warn(e.getMessage(), e);
Review Comment:
I thought the system was not really supposed to throw an exception at this
stage, and logging it would be only beneficial to finding what's going in a
production system.
I'm dealing with other cases where it's being hard to identify issues, and I
was trying to avoid that pattern here.
One thing is sending an expected exception to the client... (expected as
it's something related to the client's configuration...etc..) the other is a
server's exception not logging anything and only the client being informed
about it.
Issue Time Tracking
---
Worklog Id: (was: 856123)
Time Spent: 50m (was: 40m)
> Potential large message file leak
> -
>
> Key: ARTEMIS-4171
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4171
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> If an exception is thrown during the sending of a large message (e.g. from a
> plugin) the large message file can be orphaned on disk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4171) Potential large message file leak
[
https://issues.apache.org/jira/browse/ARTEMIS-4171?focusedWorklogId=855766=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-855766
]
ASF GitHub Bot logged work on ARTEMIS-4171:
---
Author: ASF GitHub Bot
Created on: 10/Apr/23 11:13
Start Date: 10/Apr/23 11:13
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4430:
URL: https://github.com/apache/activemq-artemis/pull/4430#discussion_r1161638521
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
##
@@ -1130,14 +1130,16 @@ private void sendContinuations(final int packetSize,
try {
session.send(session.getCurrentTransaction(),
EmbedMessageUtil.extractEmbedded((ICoreMessage) message.toMessage(),
storageManager), false, producers.get(senderID), false);
-} catch (Exception e) {
- message.deleteFile();
- throw e;
} catch (Throwable e) {
-
logger.warn("");
- logger.warn("Throwable on currentLargeMessage {}",
message.getMessageID(), e);
-
logger.warn("");
-
+ logger.warn(e.getMessage(), e);
Review Comment:
Putting this here and removing the 'catch(Exception e)' means it will begin
printing warnings with stacktraces for _every_ exception thrown in send now, vs
none before, even though its still throwing the exception onward, to someplace
that may also print it if not handling it specifically. Its not clear to me
thats desirable now if it was specifically avoided before, I expect it to
generate a bunch of stacktraces people will then report as 'new errors' as they
arent used to it.
Previously it only logged warning for the 'unhandled' Error's it then
swallowed. You've changed it to rethrow those too. Perhaps just make a debug
log for the Exceptions if wanting to add potential visibility, and retain the
warning level for the Throwables?
Using 't' is more common for throwables than 'e'.
Issue Time Tracking
---
Worklog Id: (was: 855766)
Time Spent: 40m (was: 0.5h)
> Potential large message file leak
> -
>
> Key: ARTEMIS-4171
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4171
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If an exception is thrown during the sending of a large message (e.g. from a
> plugin) the large message file can be orphaned on disk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4171) Potential large message file leak
[ https://issues.apache.org/jira/browse/ARTEMIS-4171?focusedWorklogId=855546=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-855546 ] ASF GitHub Bot logged work on ARTEMIS-4171: --- Author: ASF GitHub Bot Created on: 07/Apr/23 16:26 Start Date: 07/Apr/23 16:26 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4430: URL: https://github.com/apache/activemq-artemis/pull/4430 This is not really supposed to happen but I'm dealing with it just in case. In case it happened I would like to see the message removed and an exception thrown to the client Issue Time Tracking --- Worklog Id: (was: 855546) Time Spent: 0.5h (was: 20m) > Potential large message file leak > - > > Key: ARTEMIS-4171 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4171 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > If an exception is thrown during the sending of a large message (e.g. from a > plugin) the large message file can be orphaned on disk. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4171) Potential large message file leak
[ https://issues.apache.org/jira/browse/ARTEMIS-4171?focusedWorklogId=845759=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845759 ] ASF GitHub Bot logged work on ARTEMIS-4171: --- Author: ASF GitHub Bot Created on: 16/Feb/23 04:32 Start Date: 16/Feb/23 04:32 Worklog Time Spent: 10m Work Description: jbertram closed pull request #4372: ARTEMIS-4171 potential large message file leak URL: https://github.com/apache/activemq-artemis/pull/4372 Issue Time Tracking --- Worklog Id: (was: 845759) Remaining Estimate: 0h Time Spent: 10m > Potential large message file leak > - > > Key: ARTEMIS-4171 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4171 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > If an exception is thrown during the sending of a large message (e.g. from a > plugin) the large message file can be orphaned on disk. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4171) Potential large message file leak
[ https://issues.apache.org/jira/browse/ARTEMIS-4171?focusedWorklogId=845760=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845760 ] ASF GitHub Bot logged work on ARTEMIS-4171: --- Author: ASF GitHub Bot Created on: 16/Feb/23 04:32 Start Date: 16/Feb/23 04:32 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4372: URL: https://github.com/apache/activemq-artemis/pull/4372#issuecomment-1432498585 Replaced by #4373. Issue Time Tracking --- Worklog Id: (was: 845760) Time Spent: 20m (was: 10m) > Potential large message file leak > - > > Key: ARTEMIS-4171 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4171 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > If an exception is thrown during the sending of a large message (e.g. from a > plugin) the large message file can be orphaned on disk. -- This message was sent by Atlassian Jira (v8.20.10#820010)
