[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878256=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878256 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 21:47 Start Date: 24/Aug/23 21:47 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1692456421 > prefers stability in one of previous PR I made a mistake and broke artemis-log-annotation-processor. And PR check passed. This is my own expirience of using this project as developer. Feel free to keep such behaviour. > why the change should be accepted get rid of reflection is the main point Issue Time Tracking --- Worklog Id: (was: 878256) Time Spent: 4h 20m (was: 4h 10m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 4h 20m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878243=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878243 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 19:11 Start Date: 24/Aug/23 19:11 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1692266650 > I listed them in jira... The bullet points you provided in the Jira and here in the PR are _not_ a use-case. They are simply a summary of what you changed. There is no real explanation of _why_ the existing code is problematic or _how_ your change benefits the project. Perhaps those things are obvious to you, but they are not obvious to me and likely not obvious to many other developers and users. > And still no any valuable cons Generally speaking, the project prefers stability and continuity as that typically mitigates risk for our users - something which is greatly valued. Therefore, anybody who is proposing a change must make an understandable case for _why_ the change should be accepted. > Aren't listed pros enough? At this point the pros you've listed are not enough. Issue Time Tracking --- Worklog Id: (was: 878243) Time Spent: 4h 10m (was: 4h) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 4h 10m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878219=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878219 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 16:36 Start Date: 24/Aug/23 16:36 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1692040983 you're doing compile time validation.. sure.but that's a small gain compared to other things. as I said I would rather keep it this way. Issue Time Tracking --- Worklog Id: (was: 878219) Time Spent: 4h (was: 3h 50m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 4h > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878215=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878215 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 16:19 Start Date: 24/Aug/23 16:19 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1692016060 > than this Aren't listed pros enough? Issue Time Tracking --- Worklog Id: (was: 878215) Time Spent: 3h 50m (was: 3h 40m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 3h 50m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878204=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878204 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 15:16 Start Date: 24/Aug/23 15:16 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1691877917 @amarkevich Jboss Logging used to be part of this project.. and we used it in the past.. and we want to keep the same standard in this. what's your point on this? this change is not going to happen. we can spend time into something more positive than this. Issue Time Tracking --- Worklog Id: (was: 878204) Time Spent: 3h 40m (was: 3.5h) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 3h 40m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878201=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878201 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 15:06 Start Date: 24/Aug/23 15:06 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1691860956 > interface must not have knowledge its not mandatory. I see this interface like a centralized place where all log annotations collected Issue Time Tracking --- Worklog Id: (was: 878201) Time Spent: 3.5h (was: 3h 20m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 3.5h > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878200=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878200 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 15:04 Start Date: 24/Aug/23 15:04 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1691857979 > you're not hiding the annotation yep - logger implementation details are hidden > Jboss Logging is not a part of this project > use a concrete implementation directly current log processor generates message prefix general way and protect log messages from being corrupted by mistake Issue Time Tracking --- Worklog Id: (was: 878200) Time Spent: 3h 20m (was: 3h 10m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 3h 20m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878197=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878197 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 14:54 Start Date: 24/Aug/23 14:54 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1691838912 the annotation generates the implementation, and the interface must not have knowledge about the implementation, done thought the little framework. if I could instantiate directly, we would just get rid of the processor and go straight to the implementation always. Issue Time Tracking --- Worklog Id: (was: 878197) Time Spent: 3h 10m (was: 3h) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 3h 10m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878196=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878196 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 14:52 Start Date: 24/Aug/23 14:52 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1691835891 Man, this is painting the bike shed.. you're not hiding the annotation.. Look how Jboss Logging used to work.. we don't want to diverge here. If I was up to do new LoggingImplementation. I would just get rid of the annotation and use a concrete implementation directly. and please, don't do that. Issue Time Tracking --- Worklog Id: (was: 878196) Time Spent: 3h (was: 2h 50m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 3h > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878193=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878193 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 14:45 Start Date: 24/Aug/23 14:45 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1691824453 > _concrete use-case_ I listed them in jira: - compilation error instead of runtime exception in case of logger annotation processor issue; - get rid of java.lang.reflect.* & java.security.* usage for logger case - hide logger implementation And still no any valuable cons Issue Time Tracking --- Worklog Id: (was: 878193) Time Spent: 2h 50m (was: 2h 40m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 2h 50m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878164=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878164 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 13:37 Start Date: 24/Aug/23 13:37 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1691694000 I still don't understand the _concrete use-case_ for this change. It seems more like [bikeshedding](https://en.wiktionary.org/wiki/bikeshedding) at the moment. Issue Time Tracking --- Worklog Id: (was: 878164) Time Spent: 2h 40m (was: 2.5h) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 2h 40m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=878071=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878071 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 07:48 Start Date: 24/Aug/23 07:48 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1691182583 > Interfaces shouldn't have the implementation defined in there. So in case abstract class with annotations will be used instead of current interface - it can be approved? Issue Time Tracking --- Worklog Id: (was: 878071) Time Spent: 2.5h (was: 2h 20m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 2.5h > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877998=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877998 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 24/Aug/23 03:34 Start Date: 24/Aug/23 03:34 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1690942314 We don't see it that way. Interfaces shouldn't have the implementation defined in there. The factory provides somewhat an abstraction. We can agree to disagree here. Issue Time Tracking --- Worklog Id: (was: 877998) Time Spent: 2h 20m (was: 2h 10m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877960=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877960 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 23/Aug/23 21:17 Start Date: 23/Aug/23 21:17 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1690651955 I see this interface as place where annotation can be generally placed. And log processor logic is well-known (_impl class suffix), like jpa modelgen: `The name of the metamodel class is derived from the name of the managed class by appending "_" to the name of the managed class.` Having this rule documented - its official way to instantiate logger implementation. Issue Time Tracking --- Worklog Id: (was: 877960) Time Spent: 2h 10m (was: 2h) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877958=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877958 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 23/Aug/23 21:06 Start Date: 23/Aug/23 21:06 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1690638813 It's not prohibited. just not desirable. The dependency between the interface and its implementation is supposed to be determined at runtime by that class. If we keep the dependency explicit by just a new instance, perhaps we could just get rid of the whole processing.. but it's not something I'm looking to do at this point. Issue Time Tracking --- Worklog Id: (was: 877958) Time Spent: 2h (was: 1h 50m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877957=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877957 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 23/Aug/23 21:03 Start Date: 23/Aug/23 21:03 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1690635168 Log Annotation Processor looks like any other regular annotation processors such as Lombok, Mapstruct or jpa-codegen, when generated code can be used directly in the code. There is no any reasonable points why its prohibited in this case. Issue Time Tracking --- Worklog Id: (was: 877957) Time Spent: 1h 50m (was: 1h 40m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case > - hide logger implementation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877925=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877925 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 23/Aug/23 18:13 Start Date: 23/Aug/23 18:13 Worklog Time Spent: 10m Work Description: clebertsuconic closed pull request #4582: ARTEMIS-4393 Explicit logger implementation instantiation URL: https://github.com/apache/activemq-artemis/pull/4582 Issue Time Tracking --- Worklog Id: (was: 877925) Time Spent: 1h 40m (was: 1.5h) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 1h 40m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877924=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877924 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 23/Aug/23 18:12 Start Date: 23/Aug/23 18:12 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1690415066 -1000 on this.. sorry!!! The whole point of the BundleFactory is not require knowing the implementation from the Interface, and having the Factory figuring out what to do. I don't mind about this reflection here as it's only happening once.. it's more trouble really. the framework where this came from is Jboss Logging, where we are doing exactly what it was done before, except that we did that to fix some licensing and to be able to use SLF4J. I hate to block a PR from someone but I strongly disagree with this one man! sorry about that! Issue Time Tracking --- Worklog Id: (was: 877924) Time Spent: 1.5h (was: 1h 20m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 1.5h > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877375=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877375 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 22/Aug/23 00:06 Start Date: 22/Aug/23 00:06 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1687221889 > keep the interface not knowing about the implementations its better to hide logger implementation - done Issue Time Tracking --- Worklog Id: (was: 877375) Time Spent: 1h 20m (was: 1h 10m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877363 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 21/Aug/23 20:46 Start Date: 21/Aug/23 20:46 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1687020310 > any test tests running during PR are green anyway Issue Time Tracking --- Worklog Id: (was: 877363) Time Spent: 1h 10m (was: 1h) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877334=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877334 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 21/Aug/23 16:07 Start Date: 21/Aug/23 16:07 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1686613926 > in case artemis-log-annotation-processor broken @LogBundle consumers will be built successfully but raise CNFE in runtime Surely this is an uncommon event, and even if it does happen then any test or release validation will fail, right? Issue Time Tracking --- Worklog Id: (was: 877334) Time Spent: 1h (was: 50m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877313=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877313 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 21/Aug/23 15:22 Start Date: 21/Aug/23 15:22 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1686539693 > a problem with compile-time vs. runtime issues here in case artemis-log-annotation-processor broken @LogBundle consumers will be built successfully but raise CNFE in runtime Issue Time Tracking --- Worklog Id: (was: 877313) Time Spent: 50m (was: 40m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877300=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877300 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 21/Aug/23 14:31 Start Date: 21/Aug/23 14:31 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1686446446 @amarkevich can we keep as it was before here? Issue Time Tracking --- Worklog Id: (was: 877300) Time Spent: 40m (was: 0.5h) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877299=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877299 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 21/Aug/23 14:25 Start Date: 21/Aug/23 14:25 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1686437016 I prefer to leave the Bundle as it was there before and not depend on the generated implementation from the interface. I prefer to keep the interface not knowing about the implementations.. which that was the real use case. (Say we could even expand the logger for new functionality). Issue Time Tracking --- Worklog Id: (was: 877299) Time Spent: 0.5h (was: 20m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877296=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877296 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 21/Aug/23 14:21 Start Date: 21/Aug/23 14:21 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4582: URL: https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1686428906 What's the use-case for this? I've never had a problem with compile-time vs. runtime issues here. Issue Time Tracking --- Worklog Id: (was: 877296) Time Spent: 20m (was: 10m) > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4393) Explicit logger implementation instantiation
[ https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877280=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877280 ] ASF GitHub Bot logged work on ARTEMIS-4393: --- Author: ASF GitHub Bot Created on: 21/Aug/23 13:41 Start Date: 21/Aug/23 13:41 Worklog Time Spent: 10m Work Description: amarkevich opened a new pull request, #4582: URL: https://github.com/apache/activemq-artemis/pull/4582 - compilation error instead of runtime exception in case of logger annotation processor issue; - get rid of java.lang.reflect.* & java.security.* usage for logger case Issue Time Tracking --- Worklog Id: (was: 877280) Remaining Estimate: 0h Time Spent: 10m > Explicit logger implementation instantiation > > > Key: ARTEMIS-4393 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4393 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.30.0 >Reporter: Alexey Markevich >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > - compilation error instead of runtime exception in case of logger annotation > processor issue; > - get rid of java.lang.reflect.* & java.security.* usage for logger case -- This message was sent by Atlassian Jira (v8.20.10#820010)
