[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=914193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914193 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 11/Apr/24 14:28 Start Date: 11/Apr/24 14:28 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856 Issue Time Tracking --- Worklog Id: (was: 914193) Time Spent: 8h 20m (was: 8h 10m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 8h 20m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=913750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913750 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 09/Apr/24 17:10 Start Date: 09/Apr/24 17:10 Worklog Time Spent: 10m Work Description: AntonRoskvist commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2045712012 @clebertsuconic Yes the test is still passing so I suppose they are manageable, however at least from my own testing I have been unable to collect any metrics for both the SnF queues and the notifications queues. Removing the check for `isInternal()` in `org.apache.activemq.artemis.core.server.management.impl.ManagementServiceImpl#registerQueue()` seems to fix that though but then I guess it will also display all of the OpenWire Advisories as well. I tried the web console on this PR as well and in there I can see that the filters added for `internal` are working but looking at the tree I see that though addresses are visible for these destinations, their queues are not. Issue Time Tracking --- Worklog Id: (was: 913750) Time Spent: 8h 10m (was: 8h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 8h 10m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=913747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913747 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 09/Apr/24 16:44 Start Date: 09/Apr/24 16:44 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2045639103 (I closed it by accident) @AntonRoskvist if you could take a look please? management on SNF still enabled per your tests. Issue Time Tracking --- Worklog Id: (was: 913747) Time Spent: 8h (was: 7h 50m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 8h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=913746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913746 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 09/Apr/24 16:43 Start Date: 09/Apr/24 16:43 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4856: URL: https://github.com/apache/activemq-artemis/pull/4856 (no comment) Issue Time Tracking --- Worklog Id: (was: 913746) Time Spent: 7h 50m (was: 7h 40m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 7h 50m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=913743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913743 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 09/Apr/24 16:20 Start Date: 09/Apr/24 16:20 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2045594854 @AntonRoskvist we have management enabled on all the queues: basically your test is still here: https://github.com/clebertsuconic/activemq-artemis/blob/56e8fbb50934cb8c451e2ae5b764df64da06481f/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/SimpleSymmetricClusterTest.java#L369-L416 what I did was to remove all the extra code around specifying types, and I'm just making everything manageable. if you're missing any parts, please let me know. Issue Time Tracking --- Worklog Id: (was: 913743) Time Spent: 7h 40m (was: 7.5h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 7h 40m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=913742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913742 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 09/Apr/24 16:20 Start Date: 09/Apr/24 16:20 Worklog Time Spent: 10m Work Description: clebertsuconic closed pull request #4856: ARTEMIS-4498 - Expose internal queues for management and observability URL: https://github.com/apache/activemq-artemis/pull/4856 Issue Time Tracking --- Worklog Id: (was: 913742) Time Spent: 7.5h (was: 7h 20m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 7.5h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=913712&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913712 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 09/Apr/24 13:32 Start Date: 09/Apr/24 13:32 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2045191260 As far as I know I changed the SNF to always register management. What am I missing ? Issue Time Tracking --- Worklog Id: (was: 913712) Time Spent: 7h 10m (was: 7h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 7h 10m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=913713&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913713 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 09/Apr/24 13:33 Start Date: 09/Apr/24 13:33 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2045192210 I should be basically always registering any queue. Did I miss that ? Issue Time Tracking --- Worklog Id: (was: 913713) Time Spent: 7h 20m (was: 7h 10m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 7h 20m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=913642&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913642 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 09/Apr/24 08:05 Start Date: 09/Apr/24 08:05 Worklog Time Spent: 10m Work Description: AntonRoskvist commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2044391474 @clebertsuconic this doesn't quite do it for me as the change still leaves out management and metrics for the internal queues. In my use case I'm primarily looking for metrics on the clusters SnF queues as well as the notification queues. Perhaps the servers `createQueue` could get overloaded with a variant that inhibits creation of management objects that can be used for the relevant MQTT and OpenWire destinations? Issue Time Tracking --- Worklog Id: (was: 913642) Time Spent: 7h (was: 6h 50m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 7h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=913524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913524 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 08/Apr/24 20:53 Start Date: 08/Apr/24 20:53 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2043625204 @AntonRoskvist , @andytaylor can we settle with these changes? I added the "internal attribute" to the AddressControl as well. @andytaylor if you could take a look at the changes made to the web console here please? Issue Time Tracking --- Worklog Id: (was: 913524) Time Spent: 6h 50m (was: 6h 40m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 6h 50m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=910348&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910348 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 18/Mar/24 14:53 Start Date: 18/Mar/24 14:53 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2004134298 @AntonRoskvist I would rather delay this fix and do a proper fix in the next release. I'm looking to fix this before the next release, which may be a shorter release (timewise on when we are releasing it). Issue Time Tracking --- Worklog Id: (was: 910348) Time Spent: 6h 40m (was: 6.5h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 6h 40m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=910346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910346 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 18/Mar/24 14:35 Start Date: 18/Mar/24 14:35 Worklog Time Spent: 10m Work Description: AntonRoskvist commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2004087999 @clebertsuconic I agree that everything should be manageable, except perhaps for some protocol specific queues as you stated. Since the property "internal" is used to filter weather or not an address or queue should get exposed for management or not ( as of now ) and said protocol managers rely on this to filter Advisories for instance, a new property might be needed to decide if the destination should be manageable or not, instead of the current "internal" that has other uses, besides deciding manageability. Since that change would take some more work to implement it is out of scope for this release, which I 100% agree with. My interim solution/idea/example is to leave all this logic as is, with the only change being to manually register management for addresses and queues under "Notifications, SnF and AMQPMirror(which already ran this for the queues)". i.e. get management/metrics for the most critical parts for the upcoming release. This would later be replaced by the aforementioned "proper" change. (I don't like doing things that way but I'm weighing it against the usefulness of these destinations metrics I thought I'd ask at least) Issue Time Tracking --- Worklog Id: (was: 910346) Time Spent: 6.5h (was: 6h 20m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 6.5h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=910332&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910332 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 18/Mar/24 13:40 Start Date: 18/Mar/24 13:40 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2003937354 I don't understand your interim solution? you're forcing the registration if address =management address? I think everything should be manageable. (I have been bitten by that before) you may want to hidden certain address from the console, that could reappear after a toggle is selected. (maybe we hide internal addresses?) functionally I think we should have a flag to hide certain control queues only... (that I don't have a name for them yet). MQTT and OpenWire protocol managers have a few... even those should be able to reappear after a select toggle on the console. Issue Time Tracking --- Worklog Id: (was: 910332) Time Spent: 6h 20m (was: 6h 10m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 6h 20m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=910320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910320 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 18/Mar/24 12:41 Start Date: 18/Mar/24 12:41 Worklog Time Spent: 10m Work Description: AntonRoskvist commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2003807846 @clebertsuconic Perhaps a simpler interim solution could be used in the mean-time, doing something like what I've added here: https://github.com/AntonRoskvist/activemq-artemis/tree/interim_ARTEMIS-4498 If you'd rather wait for the proper fix then that's fine too of course. Issue Time Tracking --- Worklog Id: (was: 910320) Time Spent: 6h 10m (was: 6h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 6h 10m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=910230&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910230 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 16/Mar/24 15:35 Start Date: 16/Mar/24 15:35 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-2002022693 Hmmm... I think I figured out what's going on. When we implemented openWire advisors, we used an internal queue that was meant to be hidden. I'm not sure it will be sanitary to have open wire connections to a server and showing all the advisors on the admin console. It's different though from SNFs from Mirroring and Clustering. Perhaps we would need a separation from those, but I would rather add an attribute for hidden=true, rather than manageable. And have the code somewhat simpler. I will leave this PR open for now and not merge it before the release. Perhaps I will wait the new admin console merged before moving into this since we will probably want to show the advisors in certain cases. Issue Time Tracking --- Worklog Id: (was: 910230) Time Spent: 6h (was: 5h 50m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 6h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=910152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910152 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 15/Mar/24 17:00 Start Date: 15/Mar/24 17:00 Worklog Time Spent: 10m Work Description: clebertsuconic closed pull request #4670: ARTEMIS-4498 - Expose internal queues for management and observability URL: https://github.com/apache/activemq-artemis/pull/4670 Issue Time Tracking --- Worklog Id: (was: 910152) Time Spent: 5h 40m (was: 5.5h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 5h 40m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=910153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910153 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 15/Mar/24 17:00 Start Date: 15/Mar/24 17:00 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-277343 this is superseded by https://github.com/apache/activemq-artemis/pull/4856 Issue Time Tracking --- Worklog Id: (was: 910153) Time Spent: 5h 50m (was: 5h 40m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 5h 50m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=910151&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910151 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 15/Mar/24 16:59 Start Date: 15/Mar/24 16:59 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4856: URL: https://github.com/apache/activemq-artemis/pull/4856#issuecomment-276630 @AntonRoskvist this is your PR. I simplified it by removing the isManaged.. I have been having issues myself when I was in phone calls with customers.. and I strongly believe we should keep everything manageable. The only intent for the internal queue was about redistribution and load balancing... Having those managed should always be preferable. and I have a strong opinion about this since it bit myself in production. (Just a heads up in case anyone wants to argue that :) )... (kind of half joking here, but It's true). I want to have this merged before the release on monday. Issue Time Tracking --- Worklog Id: (was: 910151) Time Spent: 5.5h (was: 5h 20m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 5.5h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=910150&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910150 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 15/Mar/24 16:57 Start Date: 15/Mar/24 16:57 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4856: URL: https://github.com/apache/activemq-artemis/pull/4856 (no comment) Issue Time Tracking --- Worklog Id: (was: 910150) Time Spent: 5h 20m (was: 5h 10m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 5h 20m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=909859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909859 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 14/Mar/24 10:22 Start Date: 14/Mar/24 10:22 Worklog Time Spent: 10m Work Description: AntonRoskvist commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1997111086 @clebertsuconic Pinging as per your request on the dev list to consider this PR for the 2.33.0 release. If anything's looking odd I can attempt to address it with high prio. Thanks Issue Time Tracking --- Worklog Id: (was: 909859) Time Spent: 5h 10m (was: 5h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 5h 10m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=896049&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-896049 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 18/Dec/23 10:55 Start Date: 18/Dec/23 10:55 Worklog Time Spent: 10m Work Description: AntonRoskvist commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1860136459 @jbertram This should address the issues you noted. In addition I also set the `MQTT_SESSION_STORE` as "non manageable" since that is the destination that caused a few of the previous tests to fail (it always gets created if the broker starts with the mqtt-module enabled). Consequently, I reverted the changes made to `queueMetrics.groovy` because they are no longer needed. Issue Time Tracking --- Worklog Id: (was: 896049) Time Spent: 5h (was: 4h 50m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 5h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=895863&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895863 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 15/Dec/23 14:37 Start Date: 15/Dec/23 14:37 Worklog Time Spent: 10m Work Description: AntonRoskvist commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1857985072 @jbertram Right, I see it now. I have added a "manageable" property to control this behavior as you suggested and I'm now running through the full test suite. If it's looking good and I have the time I'll send a new commit some time later today. Thanks! Issue Time Tracking --- Worklog Id: (was: 895863) Time Spent: 4h 50m (was: 4h 40m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 4h 50m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=895731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895731 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 14/Dec/23 21:19 Start Date: 14/Dec/23 21:19 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1856621399 The previous failures have been resolved, but these are failing now: - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalQueue[useDefault=true,supportAdvisory=false,suppressJmx=false] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalAddress[useDefault=true,supportAdvisory=false,suppressJmx=false] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalQueue[useDefault=false,supportAdvisory=true,suppressJmx=false] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalAddress[useDefault=false,supportAdvisory=true,suppressJmx=false] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalQueue[useDefault=false,supportAdvisory=true,suppressJmx=true] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalAddress[useDefault=false,supportAdvisory=true,suppressJmx=true] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalQueue[useDefault=false,supportAdvisory=false,suppressJmx=true] - o.a.a.a.t.i.o.m.OpenWireManagementTest.testHiddenInternalAddress[useDefault=false,supportAdvisory=false,suppressJmx=true] The problem is that we can't simply change the test here because folks really do want to ignore the management objects for OpenWire advisory resources. Therefore, I think we need to add a new queue attribute (e.g. `manageable`) at least for the broker to use in cases like this. A different solution would be to leave the semantics of _internal_ the way they are now but just change the store-and-forward queues so that they aren't internal by default and ensure that users have access to set the property on any queue via management. Thoughts? Issue Time Tracking --- Worklog Id: (was: 895731) Time Spent: 4h 40m (was: 4.5h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 4h 40m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894154&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894154 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 05/Dec/23 19:43 Start Date: 05/Dec/23 19:43 Worklog Time Spent: 10m Work Description: AntonRoskvist commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1841505518 Alright, I'll just leave it as is then Issue Time Tracking --- Worklog Id: (was: 894154) Time Spent: 4.5h (was: 4h 20m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 4.5h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894115 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 05/Dec/23 16:44 Start Date: 05/Dec/23 16:44 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1841189826 @AntonRoskvist, thinking about this more I want to go with this PR rather than #4702. Issue Time Tracking --- Worklog Id: (was: 894115) Time Spent: 4h 20m (was: 4h 10m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 4h 20m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894113 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 05/Dec/23 16:43 Start Date: 05/Dec/23 16:43 Worklog Time Spent: 10m Work Description: jbertram closed pull request #4702: ARTEMIS-4498 enable management for internal addresses & queues URL: https://github.com/apache/activemq-artemis/pull/4702 Issue Time Tracking --- Worklog Id: (was: 894113) Time Spent: 4h (was: 3h 50m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 4h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894114 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 05/Dec/23 16:43 Start Date: 05/Dec/23 16:43 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4702: URL: https://github.com/apache/activemq-artemis/pull/4702#issuecomment-1841186201 After thinking about this more I think we should go with #4670. Issue Time Tracking --- Worklog Id: (was: 894114) Time Spent: 4h 10m (was: 4h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 4h 10m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[
https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894109&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894109
]
ASF GitHub Bot logged work on ARTEMIS-4498:
---
Author: ASF GitHub Bot
Created on: 05/Dec/23 16:28
Start Date: 05/Dec/23 16:28
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4702:
URL: https://github.com/apache/activemq-artemis/pull/4702#discussion_r1415924035
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##
@@ -1881,7 +1904,8 @@ public int getEncodeSize() {
BufferHelper.sizeOfNullableInteger(idCacheSize) +
BufferHelper.sizeOfNullableSimpleString(pageFullMessagePolicy != null
? pageFullMessagePolicy.toString() : null) +
BufferHelper.sizeOfNullableInteger(prefetchPageBytes) +
- BufferHelper.sizeOfNullableInteger(prefetchPageMessages);
Review Comment:
Indeed. I'll remove those changes.
Issue Time Tracking
---
Worklog Id: (was: 894109)
Time Spent: 3h 50m (was: 3h 40m)
> Enable management for internal addresses & queues
> -
>
> Key: ARTEMIS-4498
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4498
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Anton Roskvist
>Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Originally "internal" addresses and queues weren't meant to be exposed via
> management. However, due to a bug where the "internal" attribute of a queue
> was not persisted properly such queues have been exposed to management for a
> long time. This was fixed via ARTEMIS-4396, but users still want the ability
> to manage internal queues because it is extremely helpful when trying to
> troubleshoot issues. Therefore, this functionality should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894090&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894090 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 05/Dec/23 15:16 Start Date: 05/Dec/23 15:16 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4702: URL: https://github.com/apache/activemq-artemis/pull/4702#issuecomment-1840998602 Can't we just always allow management of internal queues? that was my point on the other PR. Issue Time Tracking --- Worklog Id: (was: 894090) Time Spent: 3h 40m (was: 3.5h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[
https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894085
]
ASF GitHub Bot logged work on ARTEMIS-4498:
---
Author: ASF GitHub Bot
Created on: 05/Dec/23 15:01
Start Date: 05/Dec/23 15:01
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4702:
URL: https://github.com/apache/activemq-artemis/pull/4702#discussion_r1415765011
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##
@@ -1881,7 +1904,8 @@ public int getEncodeSize() {
BufferHelper.sizeOfNullableInteger(idCacheSize) +
BufferHelper.sizeOfNullableSimpleString(pageFullMessagePolicy != null
? pageFullMessagePolicy.toString() : null) +
BufferHelper.sizeOfNullableInteger(prefetchPageBytes) +
- BufferHelper.sizeOfNullableInteger(prefetchPageMessages);
Review Comment:
I wouldn't bother about this.. it's not going to be used.. the new record
would be used.
Although shouldn't we always enable management for internal addresses?
Issue Time Tracking
---
Worklog Id: (was: 894085)
Time Spent: 3.5h (was: 3h 20m)
> Enable management for internal addresses & queues
> -
>
> Key: ARTEMIS-4498
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4498
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Anton Roskvist
>Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Originally "internal" addresses and queues weren't meant to be exposed via
> management. However, due to a bug where the "internal" attribute of a queue
> was not persisted properly such queues have been exposed to management for a
> long time. This was fixed via ARTEMIS-4396, but users still want the ability
> to manage internal queues because it is extremely helpful when trying to
> troubleshoot issues. Therefore, this functionality should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[
https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=894084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894084
]
ASF GitHub Bot logged work on ARTEMIS-4498:
---
Author: ASF GitHub Bot
Created on: 05/Dec/23 15:00
Start Date: 05/Dec/23 15:00
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4702:
URL: https://github.com/apache/activemq-artemis/pull/4702#discussion_r1415763793
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##
@@ -1881,7 +1904,8 @@ public int getEncodeSize() {
BufferHelper.sizeOfNullableInteger(idCacheSize) +
BufferHelper.sizeOfNullableSimpleString(pageFullMessagePolicy != null
? pageFullMessagePolicy.toString() : null) +
BufferHelper.sizeOfNullableInteger(prefetchPageBytes) +
- BufferHelper.sizeOfNullableInteger(prefetchPageMessages);
Review Comment:
why? I added a new record for AddressSettings, right?
Issue Time Tracking
---
Worklog Id: (was: 894084)
Time Spent: 3h 20m (was: 3h 10m)
> Enable management for internal addresses & queues
> -
>
> Key: ARTEMIS-4498
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4498
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Anton Roskvist
>Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Originally "internal" addresses and queues weren't meant to be exposed via
> management. However, due to a bug where the "internal" attribute of a queue
> was not persisted properly such queues have been exposed to management for a
> long time. This was fixed via ARTEMIS-4396, but users still want the ability
> to manage internal queues because it is extremely helpful when trying to
> troubleshoot issues. Therefore, this functionality should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=893882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893882 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 04/Dec/23 20:51 Start Date: 04/Dec/23 20:51 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1839456056 @AntonRoskvist, FWIW I think this was a good PR. I didn't want to ask you to make all the changes to implement what I eventually sent in #4702. However, now that I've sent it and it's all green I think you can close this one. Thanks! Issue Time Tracking --- Worklog Id: (was: 893882) Time Spent: 3h 10m (was: 3h) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 3h 10m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=893859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893859 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 04/Dec/23 19:35 Start Date: 04/Dec/23 19:35 Worklog Time Spent: 10m Work Description: AntonRoskvist commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1839344642 Excellent, looks good! Let me know when/if I should close this. Issue Time Tracking --- Worklog Id: (was: 893859) Time Spent: 3h (was: 2h 50m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4498) Enable management for internal addresses & queues
[ https://issues.apache.org/jira/browse/ARTEMIS-4498?focusedWorklogId=893851&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893851 ] ASF GitHub Bot logged work on ARTEMIS-4498: --- Author: ASF GitHub Bot Created on: 04/Dec/23 19:03 Start Date: 04/Dec/23 19:03 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4670: URL: https://github.com/apache/activemq-artemis/pull/4670#issuecomment-1839285668 I went a different direction on this. You can see it on #4702. See the updated description on [ARTEMIS-4498](https://issues.apache.org/jira/browse/ARTEMIS-4498) for additional details. Issue Time Tracking --- Worklog Id: (was: 893851) Time Spent: 2h 50m (was: 2h 40m) > Enable management for internal addresses & queues > - > > Key: ARTEMIS-4498 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4498 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > Originally "internal" addresses and queues weren't meant to be exposed via > management. However, due to a bug where the "internal" attribute of a queue > was not persisted properly such queues have been exposed to management for a > long time. This was fixed via ARTEMIS-4396, but users still want the ability > to manage internal queues because it is extremely helpful when trying to > troubleshoot issues. Therefore, this functionality should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
