[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[ https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=898271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898271 ] ASF GitHub Bot logged work on ARTEMIS-4554: --- Author: ASF GitHub Bot Created on: 05/Jan/24 21:52 Start Date: 05/Jan/24 21:52 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4731: URL: https://github.com/apache/activemq-artemis/pull/4731 (no comment) Issue Time Tracking --- Worklog Id: (was: 898271) Remaining Estimate: 0h Time Spent: 10m > Upgrade to latest Java for Docker images > - > > Key: ARTEMIS-4554 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4554 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[ https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=898472&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898472 ] ASF GitHub Bot logged work on ARTEMIS-4554: --- Author: ASF GitHub Bot Created on: 08/Jan/24 15:45 Start Date: 08/Jan/24 15:45 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4731: URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1444864748 ## artemis-docker/Dockerfile-centos7-19: ## @@ -17,7 +17,7 @@ # ActiveMQ Artemis -FROM eclipse-temurin:11-centos7 +FROM eclipse-temurin:19-jdk-centos7 Review Comment: This change probably doesnt make sense. Java 19 isnt really supported anymore, so similarly the Temurin Java 19 based images [are not either](https://github.com/docker-library/docs/blob/master/eclipse-temurin/README.md#supported-tags-and-respective-dockerfile-links). I'd either leave it at 11 until centos7 itself soon isnt (EOL in June) or use the Java 17 image variant, since both those JDKs/images will already be more up to date in terms of Java security fixes than the Java 19 one ever will be. Issue Time Tracking --- Worklog Id: (was: 898472) Time Spent: 20m (was: 10m) > Upgrade to latest Java for Docker images > - > > Key: ARTEMIS-4554 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4554 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[ https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=898703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898703 ] ASF GitHub Bot logged work on ARTEMIS-4554: --- Author: ASF GitHub Bot Created on: 09/Jan/24 14:41 Start Date: 09/Jan/24 14:41 Worklog Time Spent: 10m Work Description: jbertram commented on code in PR #4731: URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1446177154 ## artemis-docker/Dockerfile-centos7-19: ## @@ -17,7 +17,7 @@ # ActiveMQ Artemis -FROM eclipse-temurin:11-centos7 +FROM eclipse-temurin:19-jdk-centos7 Review Comment: Fixed. Issue Time Tracking --- Worklog Id: (was: 898703) Time Spent: 0.5h (was: 20m) > Upgrade to latest Java for Docker images > - > > Key: ARTEMIS-4554 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4554 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[
https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=898729&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898729
]
ASF GitHub Bot logged work on ARTEMIS-4554:
---
Author: ASF GitHub Bot
Created on: 09/Jan/24 15:46
Start Date: 09/Jan/24 15:46
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1446252165
##
artemis-docker/prepare-docker.sh:
##
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker
image:
# Go to $ARTEMIS_DIST_DIR
$ cd $ARTEMIS_DIST_DIR
- # For CentOS with full JDK 11
- $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+ # For CentOS with full JDK 17
+ $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
- # For Ubuntu with full JDK 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+ # For Ubuntu with full JDK 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
- # For Ubuntu with just JRE 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+ # For Ubuntu with just JRE 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
- # For Alpine with full JDK 17
- $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+ # For Alpine with full JDK 21
+ $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
- # For Alpine with just JRE 11
- $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+ # For Alpine with just JRE 21
+ $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
# For Ubuntu on Linux ARMv7/ARM64 with full JDK
- $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f
./docker/Dockerfile-ubuntu-11 .
+ $ docker buildx build --platform linux/arm64,linux/arm/v8 --push -t
{your-repository}/apache-artemis:2.16.0 -f ./docker/Dockerfile-ubuntu-21 .
Review Comment:
Didnt notice this one before...not sure it makes sense since ARM v8
essentially is arm64, so its not clear thats command is something people should
use (also be inconsistent with the comment above it still noting ARMv7). Could
be worth just switching it to only linux/arm64 though at this point.
Also, should the "2.16.0" not just be replaced with a version placeholder
given its usually going to be incorrect (assuming they arent actually using
2.16.0).
Issue Time Tracking
---
Worklog Id: (was: 898729)
Time Spent: 40m (was: 0.5h)
> Upgrade to latest Java for Docker images
> -
>
> Key: ARTEMIS-4554
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4554
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[
https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=898732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898732
]
ASF GitHub Bot logged work on ARTEMIS-4554:
---
Author: ASF GitHub Bot
Created on: 09/Jan/24 16:02
Start Date: 09/Jan/24 16:02
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1446286926
##
artemis-docker/prepare-docker.sh:
##
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker
image:
# Go to $ARTEMIS_DIST_DIR
$ cd $ARTEMIS_DIST_DIR
- # For CentOS with full JDK 11
- $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+ # For CentOS with full JDK 17
+ $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
- # For Ubuntu with full JDK 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+ # For Ubuntu with full JDK 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
- # For Ubuntu with just JRE 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+ # For Ubuntu with just JRE 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
- # For Alpine with full JDK 17
- $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+ # For Alpine with full JDK 21
+ $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
- # For Alpine with just JRE 11
- $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+ # For Alpine with just JRE 21
+ $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
# For Ubuntu on Linux ARMv7/ARM64 with full JDK
- $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f
./docker/Dockerfile-ubuntu-11 .
+ $ docker buildx build --platform linux/arm64,linux/arm/v8 --push -t
{your-repository}/apache-artemis:2.16.0 -f ./docker/Dockerfile-ubuntu-21 .
Review Comment:
Fixed.
Issue Time Tracking
---
Worklog Id: (was: 898732)
Time Spent: 50m (was: 40m)
> Upgrade to latest Java for Docker images
> -
>
> Key: ARTEMIS-4554
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4554
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[
https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=898742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898742
]
ASF GitHub Bot logged work on ARTEMIS-4554:
---
Author: ASF GitHub Bot
Created on: 09/Jan/24 16:40
Start Date: 09/Jan/24 16:40
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1446337356
##
artemis-docker/prepare-docker.sh:
##
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker
image:
# Go to $ARTEMIS_DIST_DIR
$ cd $ARTEMIS_DIST_DIR
- # For CentOS with full JDK 11
- $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+ # For CentOS with full JDK 17
+ $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
- # For Ubuntu with full JDK 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+ # For Ubuntu with full JDK 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
- # For Ubuntu with just JRE 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+ # For Ubuntu with just JRE 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
- # For Alpine with full JDK 17
- $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+ # For Alpine with full JDK 21
+ $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
- # For Alpine with just JRE 11
- $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+ # For Alpine with just JRE 21
+ $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
- # For Ubuntu on Linux ARMv7/ARM64 with full JDK
- $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f
./docker/Dockerfile-ubuntu-11 .
+ # Multi-platform for Ubuntu on Linux AMD64 & ARM64/V8 with full JDK
+ $ docker buildx build --platform linux/amd64,linux/arm64/v8 --push -t
{your-repository}/apache-artemis:{your-version} -f
./docker/Dockerfile-ubuntu-21 .
Review Comment:
Think the ARM bits should just be ARM64 and linux/arm64, i.e. left as it
was to start with rather than changed to ARM64/V8 and linux/arm64/v8, looking
at examples from
https://docs.docker.com/build/building/multi-platform/#cross-compilation
```suggestion
# Multi-platform for Ubuntu on Linux AMD64 & ARM64 with full JDK
$ docker buildx build --platform linux/amd64,linux/arm64 --push -t
{your-repository}/apache-artemis:{your-version} -f
./docker/Dockerfile-ubuntu-21 .
```
Issue Time Tracking
---
Worklog Id: (was: 898742)
Time Spent: 1h (was: 50m)
> Upgrade to latest Java for Docker images
> -
>
> Key: ARTEMIS-4554
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4554
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[
https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=898777&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898777
]
ASF GitHub Bot logged work on ARTEMIS-4554:
---
Author: ASF GitHub Bot
Created on: 09/Jan/24 19:39
Start Date: 09/Jan/24 19:39
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1446521042
##
artemis-docker/prepare-docker.sh:
##
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker
image:
# Go to $ARTEMIS_DIST_DIR
$ cd $ARTEMIS_DIST_DIR
- # For CentOS with full JDK 11
- $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+ # For CentOS with full JDK 17
+ $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
- # For Ubuntu with full JDK 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+ # For Ubuntu with full JDK 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
- # For Ubuntu with just JRE 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+ # For Ubuntu with just JRE 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
- # For Alpine with full JDK 17
- $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+ # For Alpine with full JDK 21
+ $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
- # For Alpine with just JRE 11
- $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+ # For Alpine with just JRE 21
+ $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
- # For Ubuntu on Linux ARMv7/ARM64 with full JDK
- $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f
./docker/Dockerfile-ubuntu-11 .
+ # Multi-platform for Ubuntu on Linux AMD64 & ARM64/V8 with full JDK
+ $ docker buildx build --platform linux/amd64,linux/arm64/v8 --push -t
{your-repository}/apache-artemis:{your-version} -f
./docker/Dockerfile-ubuntu-21 .
Review Comment:
The reason I chose `linux/arm64/v8` instead of `linux/arm64` is because
that's what is reported for the `eclipse-temurin:21-jdk` [base
image](https://hub.docker.com/layers/library/eclipse-temurin/21-jdk/images/sha256-dd7c71ee2e3564d88178b9cdd8dbe83c337d13bf19d0c3038c6f6b3b33186488?context=explore)
being used in the example. I've also used `--platform linux/amd64,linux/arm64`
in my work on
[ARTEMIS-4556](https://issues.apache.org/jira/browse/ARTEMIS-4556) and it works
fine although `linux/arm64` works fine as well. I'm honestly not sure which one
should be preferred.
Issue Time Tracking
---
Worklog Id: (was: 898777)
Time Spent: 1h 10m (was: 1h)
> Upgrade to latest Java for Docker images
> -
>
> Key: ARTEMIS-4554
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4554
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[
https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=898948&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898948
]
ASF GitHub Bot logged work on ARTEMIS-4554:
---
Author: ASF GitHub Bot
Created on: 10/Jan/24 11:50
Start Date: 10/Jan/24 11:50
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1447282732
##
artemis-docker/prepare-docker.sh:
##
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker
image:
# Go to $ARTEMIS_DIST_DIR
$ cd $ARTEMIS_DIST_DIR
- # For CentOS with full JDK 11
- $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+ # For CentOS with full JDK 17
+ $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
- # For Ubuntu with full JDK 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+ # For Ubuntu with full JDK 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
- # For Ubuntu with just JRE 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+ # For Ubuntu with just JRE 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
- # For Alpine with full JDK 17
- $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+ # For Alpine with full JDK 21
+ $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
- # For Alpine with just JRE 11
- $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+ # For Alpine with just JRE 21
+ $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
- # For Ubuntu on Linux ARMv7/ARM64 with full JDK
- $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f
./docker/Dockerfile-ubuntu-11 .
+ # Multi-platform for Ubuntu on Linux AMD64 & ARM64/V8 with full JDK
+ $ docker buildx build --platform linux/amd64,linux/arm64/v8 --push -t
{your-repository}/apache-artemis:{your-version} -f
./docker/Dockerfile-ubuntu-21 .
Review Comment:
My understanding was they are essentially interchangeable, especially in
this case with cross compiling against the bare 'linux/arm64' saying much the
same thing as 'linux/arm/v8' because v8 was the original arm64. There could be
more specific variants being produced in cases it might need to be explicitly
distingish for a particular image, especially e.g if there are to be different
supported variants of the image at the same time for different instruction
classes and using a specific one is required in certain cases.
For comparison, we also only tend to use 'linux/amd64' for images but there
are also multiple variants of AMD64/x86-64 as well now to distinguish different
instruction additions over time through feature levels, e.g the [docs I
referenced for docker
buildx](https://docs.docker.com/build/building/multi-platform/#cross-compilation)
demonstrates those too such as linux/amd64/v2 and linux/amd64/v3. In the past,
most stuff was built for just AMD64 'v1' but that increasingly isnt true
anymore.
As a related example to both of these, RHEL9 binaries are actually compiled
for AMD64v2 feature level however the UBI9 images dont use linux/amd64/v2 for
the os/arch name but [simply
linux/amd64](https://hub.docker.com/layers/redhat/ubi9/latest/images/sha256-3b696988fc62a88631898d24bde1f2bfb703fe6530f36ad9b98baff9ad4c73fc?context=explore).
The UBI9 image ARM bits are also published for simply linux/arm64 as another
comparison.
(Aside, its still being explored [whether RHEL10 will be compiled for
AMD64/v3](https://developers.redhat.com/articles/2024/01/02/exploring-x86-64-v3-red-hat-enterprise-linux-10)...I
would guess the images will just continue to use simply linux/amd64 for the
os/arch name even if they are for/require v3).
So e.g perhaps in future we could want/need to add linux/arm64/v9 in
addition to linux/arm64 (or linux/arm64/v8) if we ever wanted to publish e.g v8
and v9 aimed images with different content at the same time to support some
specific native instruction usages (dont see that happening for a while,
personally), but otherwise we would likely just have one version and folks
would all still just get the 'linux/arm64' image.
Actually, doing some more searching, this issue around the docker buildx
stuff suggests that in some cases at least ['linux/arm64/v8' could just result
in 'linux/arm64' output without specified variant since its not actually to
expectation](https://github.com/moby/buildkit/issues/4039) and comments
indicating instead it expects just linux/arm64 or its said it could have been
linux/arm/v8 if specifying v8 (i.e no 64 in that syntax). Though another
comme
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[
https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=899010&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899010
]
ASF GitHub Bot logged work on ARTEMIS-4554:
---
Author: ASF GitHub Bot
Created on: 10/Jan/24 15:18
Start Date: 10/Jan/24 15:18
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1447529539
##
artemis-docker/prepare-docker.sh:
##
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker
image:
# Go to $ARTEMIS_DIST_DIR
$ cd $ARTEMIS_DIST_DIR
- # For CentOS with full JDK 11
- $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+ # For CentOS with full JDK 17
+ $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
- # For Ubuntu with full JDK 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+ # For Ubuntu with full JDK 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
- # For Ubuntu with just JRE 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+ # For Ubuntu with just JRE 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
- # For Alpine with full JDK 17
- $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+ # For Alpine with full JDK 21
+ $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
- # For Alpine with just JRE 11
- $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+ # For Alpine with just JRE 21
+ $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
- # For Ubuntu on Linux ARMv7/ARM64 with full JDK
- $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f
./docker/Dockerfile-ubuntu-11 .
+ # Multi-platform for Ubuntu on Linux AMD64 & ARM64/V8 with full JDK
+ $ docker buildx build --platform linux/amd64,linux/arm64/v8 --push -t
{your-repository}/apache-artemis:{your-version} -f
./docker/Dockerfile-ubuntu-21 .
Review Comment:
Simplifying to `linux/arm64` sounds good to me.
I actually ran into the issue you linked where the image I built with
`linux/arm64/v8` reported just `linux/arm64` when I looked at it on Docker Hub.
I was confused at first, but now it makes sense.
Issue Time Tracking
---
Worklog Id: (was: 899010)
Time Spent: 1h 40m (was: 1.5h)
> Upgrade to latest Java for Docker images
> -
>
> Key: ARTEMIS-4554
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4554
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[
https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=899009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899009
]
ASF GitHub Bot logged work on ARTEMIS-4554:
---
Author: ASF GitHub Bot
Created on: 10/Jan/24 15:18
Start Date: 10/Jan/24 15:18
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1447529539
##
artemis-docker/prepare-docker.sh:
##
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker
image:
# Go to $ARTEMIS_DIST_DIR
$ cd $ARTEMIS_DIST_DIR
- # For CentOS with full JDK 11
- $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+ # For CentOS with full JDK 17
+ $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
- # For Ubuntu with full JDK 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+ # For Ubuntu with full JDK 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
- # For Ubuntu with just JRE 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+ # For Ubuntu with just JRE 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
- # For Alpine with full JDK 17
- $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+ # For Alpine with full JDK 21
+ $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
- # For Alpine with just JRE 11
- $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+ # For Alpine with just JRE 21
+ $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
- # For Ubuntu on Linux ARMv7/ARM64 with full JDK
- $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f
./docker/Dockerfile-ubuntu-11 .
+ # Multi-platform for Ubuntu on Linux AMD64 & ARM64/V8 with full JDK
+ $ docker buildx build --platform linux/amd64,linux/arm64/v8 --push -t
{your-repository}/apache-artemis:{your-version} -f
./docker/Dockerfile-ubuntu-21 .
Review Comment:
Simplifying to `linux/arm64` sounds good to me.
I actually ran into the issue you linked where the image I built with
`linux/arm64/v8` reported just `linux/arm64` when I looked at it on Docker Hub.
Issue Time Tracking
---
Worklog Id: (was: 899009)
Time Spent: 1.5h (was: 1h 20m)
> Upgrade to latest Java for Docker images
> -
>
> Key: ARTEMIS-4554
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4554
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[
https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=899011&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899011
]
ASF GitHub Bot logged work on ARTEMIS-4554:
---
Author: ASF GitHub Bot
Created on: 10/Jan/24 15:18
Start Date: 10/Jan/24 15:18
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1447529539
##
artemis-docker/prepare-docker.sh:
##
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker
image:
# Go to $ARTEMIS_DIST_DIR
$ cd $ARTEMIS_DIST_DIR
- # For CentOS with full JDK 11
- $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+ # For CentOS with full JDK 17
+ $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
- # For Ubuntu with full JDK 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+ # For Ubuntu with full JDK 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
- # For Ubuntu with just JRE 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+ # For Ubuntu with just JRE 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
- # For Alpine with full JDK 17
- $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+ # For Alpine with full JDK 21
+ $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
- # For Alpine with just JRE 11
- $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+ # For Alpine with just JRE 21
+ $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
- # For Ubuntu on Linux ARMv7/ARM64 with full JDK
- $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f
./docker/Dockerfile-ubuntu-11 .
+ # Multi-platform for Ubuntu on Linux AMD64 & ARM64/V8 with full JDK
+ $ docker buildx build --platform linux/amd64,linux/arm64/v8 --push -t
{your-repository}/apache-artemis:{your-version} -f
./docker/Dockerfile-ubuntu-21 .
Review Comment:
Simplifying to `linux/arm64` sounds good to me.
I actually ran into the issue you linked where the image I built with
`linux/arm64/v8` reported just `linux/arm64` when I looked at it on Docker Hub.
I was confused at first, but now it makes more sense.
Issue Time Tracking
---
Worklog Id: (was: 899011)
Time Spent: 1h 50m (was: 1h 40m)
> Upgrade to latest Java for Docker images
> -
>
> Key: ARTEMIS-4554
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4554
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4554) Upgrade to latest Java for Docker images
[ https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=899021&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899021 ] ASF GitHub Bot logged work on ARTEMIS-4554: --- Author: ASF GitHub Bot Created on: 10/Jan/24 16:06 Start Date: 10/Jan/24 16:06 Worklog Time Spent: 10m Work Description: gemmellr merged PR #4731: URL: https://github.com/apache/activemq-artemis/pull/4731 Issue Time Tracking --- Worklog Id: (was: 899021) Time Spent: 2h (was: 1h 50m) > Upgrade to latest Java for Docker images > - > > Key: ARTEMIS-4554 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4554 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
