[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=923046=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923046
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 11/Jun/24 22:54
Start Date: 11/Jun/24 22:54
Worklog Time Spent: 10m
Work Description: joshb1050 commented on PR #4966:
URL:
https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2161730473
@jbertram thank you—it's strange since I did run `mvn checkstyle:check` and
`mvn -Pdev install` and both passed with the checkstyle error. It's also
unclear given that `check` passed for 2 of the 3 failures. I have corrected the
latest one that I see on CI though.
Issue Time Tracking
---
Worklog Id: (was: 923046)
Time Spent: 1h 50m (was: 1h 40m)
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=923041=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923041
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 11/Jun/24 22:00
Start Date: 11/Jun/24 22:00
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #4966:
URL:
https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2161671151
For what it's worth you can run checkstyle locally using:
```
mvn -Pdev install
```
See the [hacking
guide](https://activemq.apache.org/components/artemis/documentation/hacking-guide/#using-the-dev-profile)
for more details.
Issue Time Tracking
---
Worklog Id: (was: 923041)
Time Spent: 1h 40m (was: 1.5h)
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=923039=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923039
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 11/Jun/24 21:47
Start Date: 11/Jun/24 21:47
Worklog Time Spent: 10m
Work Description: joshb1050 commented on PR #4966:
URL:
https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2161654314
Checkstyle is fixed now as well.
Issue Time Tracking
---
Worklog Id: (was: 923039)
Time Spent: 1.5h (was: 1h 20m)
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=923037=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923037
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 11/Jun/24 21:45
Start Date: 11/Jun/24 21:45
Worklog Time Spent: 10m
Work Description: joshb1050 commented on code in PR #4966:
URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635514051
##
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##
@@ -4457,6 +4457,15 @@
+
Review Comment:
This is done.
Issue Time Tracking
---
Worklog Id: (was: 923037)
Time Spent: 1h 10m (was: 1h)
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=923038=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923038
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 11/Jun/24 21:45
Start Date: 11/Jun/24 21:45
Worklog Time Spent: 10m
Work Description: joshb1050 commented on code in PR #4966:
URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635514337
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##
@@ -1604,6 +1619,10 @@ public void decode(ActiveMQBuffer buffer, boolean
tryCompatible) {
prefetchPageMessages = BufferHelper.readNullableInteger(buffer);
}
+ if (buffer.readableBytes() > 0) {
+ intermediateMessageBufferInitialSize =
BufferHelper.readNullableInteger(buffer);
+ }
+
Review Comment:
Missed that—done now.
Issue Time Tracking
---
Worklog Id: (was: 923038)
Time Spent: 1h 20m (was: 1h 10m)
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=923034=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923034
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 11/Jun/24 21:22
Start Date: 11/Jun/24 21:22
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4966:
URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635493471
##
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##
@@ -4457,6 +4457,15 @@
+
Review Comment:
Specify the default value here as with the other elements (i.e. `8192`).
Issue Time Tracking
---
Worklog Id: (was: 923034)
Time Spent: 1h (was: 50m)
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=923033=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923033
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 11/Jun/24 21:20
Start Date: 11/Jun/24 21:20
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4966:
URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635493471
##
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##
@@ -4457,6 +4457,15 @@
+
Review Comment:
Specify the default value here as with the other elements.
Issue Time Tracking
---
Worklog Id: (was: 923033)
Time Spent: 50m (was: 40m)
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=923032=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923032
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 11/Jun/24 21:19
Start Date: 11/Jun/24 21:19
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4966:
URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1635492310
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##
@@ -1604,6 +1619,10 @@ public void decode(ActiveMQBuffer buffer, boolean
tryCompatible) {
prefetchPageMessages = BufferHelper.readNullableInteger(buffer);
}
+ if (buffer.readableBytes() > 0) {
+ intermediateMessageBufferInitialSize =
BufferHelper.readNullableInteger(buffer);
+ }
+
Review Comment:
Notice the comment below. This code should be removed.
Issue Time Tracking
---
Worklog Id: (was: 923032)
Time Spent: 40m (was: 0.5h)
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=922855=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922855
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 10/Jun/24 18:12
Start Date: 10/Jun/24 18:12
Worklog Time Spent: 10m
Work Description: joshb1050 commented on PR #4966:
URL:
https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2159000754
Thanks @jbertram! I have updated my PR to make this configurable on a
per-address basis and via XML as well. I have also added tests for the
functionality. Please let me know if there is a different approach I should be
taking here.
Issue Time Tracking
---
Worklog Id: (was: 922855)
Time Spent: 0.5h (was: 20m)
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=922678=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922678
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 07/Jun/24 21:57
Start Date: 07/Jun/24 21:57
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #4966:
URL:
https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2155625196
Thanks for the PR!
I think this would be better as an address-setting so you could easily
configure large swaths of queues. Right now there's no way to configure this
via `broker.xml`. It can only be configured if you're directly creating the
queue(s) programmatically.
Lastly, there's no tests or documentation for this new setting. Tests are
mandatory to ensure the functionality works properly and to mitigate future
regressions.
Issue Time Tracking
---
Worklog Id: (was: 922678)
Time Spent: 20m (was: 10m)
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4809) Make intermediateMessageReferences initial capacity configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=922644=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922644
]
ASF GitHub Bot logged work on ARTEMIS-4809:
---
Author: ASF GitHub Bot
Created on: 07/Jun/24 19:40
Start Date: 07/Jun/24 19:40
Worklog Time Spent: 10m
Work Description: joshb1050 opened a new pull request, #4966:
URL: https://github.com/apache/activemq-artemis/pull/4966
In some setups, there could be a few hundred thousand queues that are
created due to many consumers that are connecting. However, most of these are
empty and stay empty for the entire day since there aren't necessarily messages
to be sent. The 8K `intermediateMessageReferences` instantiates an `64KB`
buffer (`Object[]`). This means we have large allocation and live heap that
ultimately remains empty for almost the entire day.
In this commit, we introduce `intermediate-message-buffer-initial-size`,
which defaults to the current value of `8192`. It can be set programmatically
via
`QueueConfiguration#setIntermediateMessageBufferInitialSize(int)`.
Note that this must be a power of 2.
Issue Time Tracking
---
Worklog Id: (was: 922644)
Remaining Estimate: 0h
Time Spent: 10m
> Make intermediateMessageReferences initial capacity configurable
>
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
