[jira] [Updated] (AMBARI-24907) Update service metainfo to declare LDAP integration support
[
https://issues.apache.org/jira/browse/AMBARI-24907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated AMBARI-24907:
Labels: pull-request-available (was: )
> Update service metainfo to declare LDAP integration support
> ---
>
> Key: AMBARI-24907
> URL: https://issues.apache.org/jira/browse/AMBARI-24907
> Project: Ambari
> Issue Type: Task
> Components: ambari-sever
>Affects Versions: 2.7.0
>Reporter: Sandor Molnar
>Assignee: Sandor Molnar
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> Update service metainfo to declare LDAP integration support. The following
> tag may be optionally set in a service's metainfo.xml file:
> {noformat}
>
> true
>
> {
> "equals": [
> "ranger-admin-site/ranger.authentication.method",
> "LDAP"
> ]
> }
>
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (AMBARI-24911) Infra Manager: stop running jobs before Infra Manager is stopped
[ https://issues.apache.org/jira/browse/AMBARI-24911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa resolved AMBARI-24911. - Resolution: Works for Me > Infra Manager: stop running jobs before Infra Manager is stopped > > > Key: AMBARI-24911 > URL: https://issues.apache.org/jira/browse/AMBARI-24911 > Project: Ambari > Issue Type: Improvement > Components: ambari-infra >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 2.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AMBARI-24911) Infra Manager: stop running jobs before Infra Manager is stopped
Krisztian Kasa created AMBARI-24911: --- Summary: Infra Manager: stop running jobs before Infra Manager is stopped Key: AMBARI-24911 URL: https://issues.apache.org/jira/browse/AMBARI-24911 Project: Ambari Issue Type: Improvement Components: ambari-infra Affects Versions: 2.8.0 Reporter: Krisztian Kasa Assignee: Krisztian Kasa Fix For: 2.8.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24901) Handle complex "Add Service" request in ServiceResourceProvider
[
https://issues.apache.org/jira/browse/AMBARI-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doroszlai, Attila updated AMBARI-24901:
---
Resolution: Implemented
Status: Resolved (was: Patch Available)
> Handle complex "Add Service" request in ServiceResourceProvider
> ---
>
> Key: AMBARI-24901
> URL: https://issues.apache.org/jira/browse/AMBARI-24901
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
>Reporter: Doroszlai, Attila
>Assignee: Doroszlai, Attila
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Related to AMBARI-24881, change {{ServiceResourceProvider}} to handle the
> complex "Add Service" request. So far only stub logic is needed, details of
> the service creation will be filled later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-2491) Security Wizard: show which principals and keytabs need to be created on which hosts
[
https://issues.apache.org/jira/browse/AMBARI-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688722#comment-16688722
]
ASF GitHub Bot commented on AMBARI-2491:
asfgit commented on issue #11: [AMBARI-2491] Grafana: Fix for Storm Components
and Storm Kafka Offse…
URL: https://github.com/apache/ambari-metrics/pull/11#issuecomment-439211171
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Metrics-Github-PR-Builder/23/
Test PASSed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Security Wizard: show which principals and keytabs need to be created on
> which hosts
>
>
> Key: AMBARI-2491
> URL: https://issues.apache.org/jira/browse/AMBARI-2491
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-web
>Affects Versions: 1.2.5
>Reporter: Andrii Tkach
>Assignee: Andrii Tkach
>Priority: Critical
> Labels: pull-request-available
> Fix For: 1.2.5
>
> Attachments: AMBARI-2491.patch,
> host-component-principal-keytab-display.png
>
>
> Currently it is very difficult to know what principals and keytabs need to be
> created on which hosts.
> We should present this information to the end user in a format that is easy
> to consume.
> The user running the wizard may not be the one who will be creating keytabs
> and principals. We can expose the capability to download a csv file and send
> it to the appropriate person who may parse the data to create a script to
> generate principals/keytabs (or do so manually).
> Display the attached as a popup after Configure Services step is done.
> Let's show it as a popup so that we don't affect any existing navigation/flow.
> For generating the content:
> Keytab paths are based on the user input
> Principal names are based on the user input
> NameNode host: show the nn and HTTP principals and keytab paths
> JobTracker host: show the jt principal and keytab path
> Oozie Server host: show the oozie and HTTP principals and keytab paths
> Nagios Server host: show the nagios principal and keytab path
> HBase Master host: show the hbase principal and keytab path
> Hive Server host: show the hive principal and keytab path
> WebHCat Server host: show the HTTP principal and keytab path
> ZooKeeper Server host: show the zookeeper principal and keytab path
> DataNode host: show the dn principal and keytab path
> TaskTracker host: show the tt principal and keytab path
> RegionServer host: show the hbase principal and keytab path
> If there are duplicated principals on the same host, display it only once.
> Clickng on "Download CSV" downloads the CSV file
> ("host-principal-keytab-list.csv"). The same content, except each row is a
> comma-delimited list with a \n at the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-2491) Security Wizard: show which principals and keytabs need to be created on which hosts
[
https://issues.apache.org/jira/browse/AMBARI-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688711#comment-16688711
]
ASF GitHub Bot commented on AMBARI-2491:
ishanbha opened a new pull request #11: [AMBARI-2491] Grafana: Fix for Storm
Components and Storm Kafka Offse…
URL: https://github.com/apache/ambari-metrics/pull/11
…t dashboards.
## What changes were proposed in this pull request?
Get correct values from the object templateSrv in datasource.js
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Security Wizard: show which principals and keytabs need to be created on
> which hosts
>
>
> Key: AMBARI-2491
> URL: https://issues.apache.org/jira/browse/AMBARI-2491
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-web
>Affects Versions: 1.2.5
>Reporter: Andrii Tkach
>Assignee: Andrii Tkach
>Priority: Critical
> Labels: pull-request-available
> Fix For: 1.2.5
>
> Attachments: AMBARI-2491.patch,
> host-component-principal-keytab-display.png
>
>
> Currently it is very difficult to know what principals and keytabs need to be
> created on which hosts.
> We should present this information to the end user in a format that is easy
> to consume.
> The user running the wizard may not be the one who will be creating keytabs
> and principals. We can expose the capability to download a csv file and send
> it to the appropriate person who may parse the data to create a script to
> generate principals/keytabs (or do so manually).
> Display the attached as a popup after Configure Services step is done.
> Let's show it as a popup so that we don't affect any existing navigation/flow.
> For generating the content:
> Keytab paths are based on the user input
> Principal names are based on the user input
> NameNode host: show the nn and HTTP principals and keytab paths
> JobTracker host: show the jt principal and keytab path
> Oozie Server host: show the oozie and HTTP principals and keytab paths
> Nagios Server host: show the nagios principal and keytab path
> HBase Master host: show the hbase principal and keytab path
> Hive Server host: show the hive principal and keytab path
> WebHCat Server host: show the HTTP principal and keytab path
> ZooKeeper Server host: show the zookeeper principal and keytab path
> DataNode host: show the dn principal and keytab path
> TaskTracker host: show the tt principal and keytab path
> RegionServer host: show the hbase principal and keytab path
> If there are duplicated principals on the same host, display it only once.
> Clickng on "Download CSV" downloads the CSV file
> ("host-principal-keytab-list.csv"). The same content, except each row is a
> comma-delimited list with a \n at the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-2491) Security Wizard: show which principals and keytabs need to be created on which hosts
[
https://issues.apache.org/jira/browse/AMBARI-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated AMBARI-2491:
---
Labels: pull-request-available (was: )
> Security Wizard: show which principals and keytabs need to be created on
> which hosts
>
>
> Key: AMBARI-2491
> URL: https://issues.apache.org/jira/browse/AMBARI-2491
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-web
>Affects Versions: 1.2.5
>Reporter: Andrii Tkach
>Assignee: Andrii Tkach
>Priority: Critical
> Labels: pull-request-available
> Fix For: 1.2.5
>
> Attachments: AMBARI-2491.patch,
> host-component-principal-keytab-display.png
>
>
> Currently it is very difficult to know what principals and keytabs need to be
> created on which hosts.
> We should present this information to the end user in a format that is easy
> to consume.
> The user running the wizard may not be the one who will be creating keytabs
> and principals. We can expose the capability to download a csv file and send
> it to the appropriate person who may parse the data to create a script to
> generate principals/keytabs (or do so manually).
> Display the attached as a popup after Configure Services step is done.
> Let's show it as a popup so that we don't affect any existing navigation/flow.
> For generating the content:
> Keytab paths are based on the user input
> Principal names are based on the user input
> NameNode host: show the nn and HTTP principals and keytab paths
> JobTracker host: show the jt principal and keytab path
> Oozie Server host: show the oozie and HTTP principals and keytab paths
> Nagios Server host: show the nagios principal and keytab path
> HBase Master host: show the hbase principal and keytab path
> Hive Server host: show the hive principal and keytab path
> WebHCat Server host: show the HTTP principal and keytab path
> ZooKeeper Server host: show the zookeeper principal and keytab path
> DataNode host: show the dn principal and keytab path
> TaskTracker host: show the tt principal and keytab path
> RegionServer host: show the hbase principal and keytab path
> If there are duplicated principals on the same host, display it only once.
> Clickng on "Download CSV" downloads the CSV file
> ("host-principal-keytab-list.csv"). The same content, except each row is a
> comma-delimited list with a \n at the end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (AMBARI-24910) Grafana: Fix for Storm Components and Storm Kafka Offset dashboards
Ishan Bhatt created AMBARI-24910: Summary: Grafana: Fix for Storm Components and Storm Kafka Offset dashboards Key: AMBARI-24910 URL: https://issues.apache.org/jira/browse/AMBARI-24910 Project: Ambari Issue Type: Bug Components: ambari-metrics Reporter: Ishan Bhatt Assignee: Ishan Bhatt Fix For: 2.8.0 These two dashboards error out if no data point is provided. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24906) JSON document validation for "Add Service" request
[ https://issues.apache.org/jira/browse/AMBARI-24906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688704#comment-16688704 ] Hudson commented on AMBARI-24906: - FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #10300 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10300/]) [Ambari-24906] JSON validation for AddServiceRequest (#2617) (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=6f7b0a9542a3f4c013faa90a4303a31238cc5c78]) * (add) ambari-server/src/test/resources/add_service_api/invalid_configurables.txt * (edit) ambari-server/src/main/java/org/apache/ambari/server/topology/Configurable.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/AddServiceRequest.java * (add) ambari-server/src/main/java/org/apache/ambari/server/topology/ConfigurableHelper.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/topology/ConfigurationFactory.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurableTest.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/AddServiceRequestTest.java * (add) ambari-server/src/test/resources/add_service_api/request_invalid_3.json > JSON document validation for "Add Service" request > -- > > Key: AMBARI-24906 > URL: https://issues.apache.org/jira/browse/AMBARI-24906 > Project: Ambari > Issue Type: Task > Components: ambari-server >Reporter: Balázs Bence Sári >Assignee: Balázs Bence Sári >Priority: Critical > Fix For: trunk > > > Validation logic needs to be implemented for JSON deserialization of the > Configuration object embedded into an AddService request. The rest of the > request is already validated by Jackson and the constructor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[ https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688697#comment-16688697 ] ASF GitHub Bot commented on AMBARI-24833: - asfgit commented on issue #25: AMBARI-24833. Extend cloud log rolling options URL: https://github.com/apache/ambari-logsearch/pull/25#issuecomment-439202536 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/50/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log Feeder: send logs to cloud storage (gcs/s3 etc.) > > > Key: AMBARI-24833 > URL: https://issues.apache.org/jira/browse/AMBARI-24833 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.7.0 >Reporter: Olivér Szabó >Assignee: Olivér Szabó >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24909) Parallel Client Fixes for Server Side Tasks
[ https://issues.apache.org/jira/browse/AMBARI-24909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688681#comment-16688681 ] Hudson commented on AMBARI-24909: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10299 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10299/]) [AMBARI-24909] Parallel Client Fixes for Server Side Tasks (#2618) (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=60d313463ce52c8df5c2268491a70c8cd38eb6a8]) * (edit) ambari-common/src/main/python/resource_management/libraries/script/script.py * (edit) ambari-server/src/main/java/org/apache/ambari/server/stack/upgrade/orchestrate/ParallelClientGroupingBuilder.java > Parallel Client Fixes for Server Side Tasks > --- > > Key: AMBARI-24909 > URL: https://issues.apache.org/jira/browse/AMBARI-24909 > Project: Ambari > Issue Type: Bug > Components: ambari-server >Reporter: Nate Cole >Assignee: Nate Cole >Priority: Critical > Labels: pull-request-available > Fix For: 2.8.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The fix for parallel clients (AMBARI-24873) was broken for server-side action > tasks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24901) Handle complex "Add Service" request in ServiceResourceProvider
[
https://issues.apache.org/jira/browse/AMBARI-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688680#comment-16688680
]
Hudson commented on AMBARI-24901:
-
SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10299 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/10299/])
AMBARI-24901. Handle complex "Add Service" request in (github:
[https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=1d87a0a1ee8d5202ed1894bc2917fc8ab7d569fa])
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/AddServiceRequestTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/AddServiceRequest.java
* (add)
ambari-server/src/main/java/org/apache/ambari/server/topology/addservice/AddServiceInfo.java
* (add)
ambari-server/src/main/java/org/apache/ambari/server/topology/addservice/ResourceProviderAdapter.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
* (add)
ambari-server/src/main/java/org/apache/ambari/server/topology/addservice/AddServiceOrchestrator.java
> Handle complex "Add Service" request in ServiceResourceProvider
> ---
>
> Key: AMBARI-24901
> URL: https://issues.apache.org/jira/browse/AMBARI-24901
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
>Reporter: Doroszlai, Attila
>Assignee: Doroszlai, Attila
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Related to AMBARI-24881, change {{ServiceResourceProvider}} to handle the
> complex "Add Service" request. So far only stub logic is needed, details of
> the service creation will be filled later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (AMBARI-24906) JSON document validation for "Add Service" request
[ https://issues.apache.org/jira/browse/AMBARI-24906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balázs Bence Sári resolved AMBARI-24906. Resolution: Fixed > JSON document validation for "Add Service" request > -- > > Key: AMBARI-24906 > URL: https://issues.apache.org/jira/browse/AMBARI-24906 > Project: Ambari > Issue Type: Task > Components: ambari-server >Reporter: Balázs Bence Sári >Assignee: Balázs Bence Sári >Priority: Critical > Fix For: trunk > > > Validation logic needs to be implemented for JSON deserialization of the > Configuration object embedded into an AddService request. The rest of the > request is already validated by Jackson and the constructor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24871) Create an Ambari-server class that is called as an entry point to encrypt service configuration sensitive data
[ https://issues.apache.org/jira/browse/AMBARI-24871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688650#comment-16688650 ] Hudson commented on AMBARI-24871: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10298 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10298/]) AMBARI-24871 fix checkstyle violation (benyoka) (#2620) (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=09f376681cd8043ce63aee0bc40cfb919bdfe991]) * (edit) ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialProvider.java > Create an Ambari-server class that is called as an entry point to encrypt > service configuration sensitive data > -- > > Key: AMBARI-24871 > URL: https://issues.apache.org/jira/browse/AMBARI-24871 > Project: Ambari > Issue Type: Task > Components: ambari-server >Affects Versions: 2.8.0 >Reporter: Dmitry Lysnichenko >Assignee: Dmitry Lysnichenko >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Time Spent: 5h > Remaining Estimate: 0h > > Create a java class that is called as an entry point to encrypt service > configuration sensitive data. This script will be called from a python script > just like it is done for pre-checks, or for upgrade catalogs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (AMBARI-24909) Parallel Client Fixes for Server Side Tasks
[ https://issues.apache.org/jira/browse/AMBARI-24909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Cole resolved AMBARI-24909. Resolution: Fixed > Parallel Client Fixes for Server Side Tasks > --- > > Key: AMBARI-24909 > URL: https://issues.apache.org/jira/browse/AMBARI-24909 > Project: Ambari > Issue Type: Bug > Components: ambari-server >Reporter: Nate Cole >Assignee: Nate Cole >Priority: Critical > Labels: pull-request-available > Fix For: 2.8.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The fix for parallel clients (AMBARI-24873) was broken for server-side action > tasks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688599#comment-16688599
]
ASF GitHub Bot commented on AMBARI-24895:
-
adoroszlai commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233995622
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
##
@@ -49,7 +49,7 @@
// TODO: use swagger
public class InfraClient implements AutoCloseable {
- private static final Logger LOG = LoggerFactory.getLogger(InfraClient.class);
+ private static final Logger logger =
LoggerFactory.getLogger(InfraClient.class);
Review comment:
What you mean is a "compile-time constant".
https://docs.oracle.com/javase/tutorial/java/javaOO/classvars.html
No matter which definition of constant you prefer, the naming conventions I
was alluding to in my comment applies to `static final`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688589#comment-16688589
]
ASF GitHub Bot commented on AMBARI-24895:
-
oleewere commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233993364
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
##
@@ -49,7 +49,7 @@
// TODO: use swagger
public class InfraClient implements AutoCloseable {
- private static final Logger LOG = LoggerFactory.getLogger(InfraClient.class);
+ private static final Logger logger =
LoggerFactory.getLogger(InfraClient.class);
Review comment:
@adoroszlai what the compiler thinks it is
(https://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.28),
primitives/arrays or classes/objects where the state cannot change anyhow.
object immutability is not enough here, like Logger is an interface. but
another opposite example that can be constant is a list (created from a static
method), which has final add/remove methods. also worth to check what you can
use in annotations.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24876) BE: Performance Tune service Configs Pages
[
https://issues.apache.org/jira/browse/AMBARI-24876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated AMBARI-24876:
Labels: pull-request-available (was: )
> BE: Performance Tune service Configs Pages
> --
>
> Key: AMBARI-24876
> URL: https://issues.apache.org/jira/browse/AMBARI-24876
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
>Affects Versions: 2.7.0
>Reporter: Myroslav Papirkovskyi
>Assignee: Myroslav Papirkovskyi
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> Need to be able to show configuration in less than 2 seconds. The heaviest
> part of configurations loading is recommendations request. Now for 2k cluster
> recommendations request is taking about 12 seconds:
> {code:java}
> /api/v1/stacks/HDP/versions/3.0/recommendations
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24909) Parallel Client Fixes for Server Side Tasks
[ https://issues.apache.org/jira/browse/AMBARI-24909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated AMBARI-24909: Labels: pull-request-available (was: ) > Parallel Client Fixes for Server Side Tasks > --- > > Key: AMBARI-24909 > URL: https://issues.apache.org/jira/browse/AMBARI-24909 > Project: Ambari > Issue Type: Bug > Components: ambari-server >Reporter: Nate Cole >Assignee: Nate Cole >Priority: Critical > Labels: pull-request-available > Fix For: 2.8.0 > > > The fix for parallel clients (AMBARI-24873) was broken for server-side action > tasks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[ https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688522#comment-16688522 ] Hudson commented on AMBARI-24895: - SUCCESS: Integrated in Jenkins build Ambari-Infra-master-Commit #18 (See [https://builds.apache.org/job/Ambari-Infra-master-Commit/18/]) AMBARI-24895 - Infra Manager: code clean up (#15) (github: [https://gitbox.apache.org/repos/asf?p=ambari-infra.git&a=commit&h=da6bdb96d920432a47a25b698ce8e7cdec7f3c96]) * (edit) ambari-infra-solr-plugin/src/main/java/org/apache/ambari/infra/solr/metrics/reporters/ScheduledAMSReporter.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingConfiguration.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentArchivingPropertyMap.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrProperties.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemProcessor.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingPropertyMap.java * (delete) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/cleanup/CleanUpParameters.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Uploader.java * (edit) ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/AbstractRetryCommand.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/JobScheduler.java * (edit) ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/UpdateStateFileZkCommand.java * (edit) ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/ExportJobsSteps.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyJobListener.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/security/HadoopCredentialStore.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriter.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDAO.java * (edit) ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrPropertiesTest.java * (delete) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingProperties.java * (edit) ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/util/ShardUtils.java * (delete) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrParameters.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyStepListener.java * (edit) ambari-infra-solr-plugin/src/main/java/org/apache/ambari/infra/solr/metrics/reporters/MetricsUtils.java * (edit) ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/solr/metrics/MockMetricsServer.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3AccessCsv.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/doc/InfraManagerApiDocStorage.java * (delete) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DeletingParameters.java * (delete) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentArchivingProperties.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/cleanup/CleanUpProperties.java * (edit) ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/SecureSolrZNodeZkCommand.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/SolrDAOBase.java * (add) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DeletingProperties.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/cleanup/CleanUpConfiguration.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileNameSuffixFormatter.java * (edit) ambari-infra-solr-plugin/src/main/java/org/apache/ambari/infra/solr/metrics/reporters/SolrMetricsSink.java * (edit) ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/solr/metrics/MetricsIT.java * (add) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/ArchivingProperties.java * (edit) ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java * (edit) ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/AbstractFileAction.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentArchivingConfiguration.java * (edit) ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java * (
[jira] [Resolved] (AMBARI-24895) Infra Manager: code clean up
[ https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa resolved AMBARI-24895. - Resolution: Fixed > Infra Manager: code clean up > > > Key: AMBARI-24895 > URL: https://issues.apache.org/jira/browse/AMBARI-24895 > Project: Ambari > Issue Type: Task > Components: ambari-infra >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > > * rename LOG -> logger > * remove slf4j use log4j2 > * merge Job Properties and Job Parameter classes -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688526#comment-16688526
]
ASF GitHub Bot commented on AMBARI-24895:
-
adoroszlai commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233971124
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/Solr.java
##
@@ -41,7 +41,7 @@
import org.slf4j.LoggerFactory;
public class Solr {
- private static final Logger LOG = LoggerFactory.getLogger(Solr.class);
+ private static final Logger logger = LoggerFactory.getLogger(Solr.class);
Review comment:
Thanks @kasakrisz!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688525#comment-16688525
]
ASF GitHub Bot commented on AMBARI-24895:
-
adoroszlai commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233970961
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
##
@@ -49,7 +49,7 @@
// TODO: use swagger
public class InfraClient implements AutoCloseable {
- private static final Logger LOG = LoggerFactory.getLogger(InfraClient.class);
+ private static final Logger logger =
LoggerFactory.getLogger(InfraClient.class);
Review comment:
@oleewere what's a constant?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688519#comment-16688519
]
ASF GitHub Bot commented on AMBARI-24895:
-
kasakrisz closed pull request #15: AMBARI-24895 - Infra Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ambari-infra-manager-it/pom.xml b/ambari-infra-manager-it/pom.xml
index 68d43529..f1f296bc 100644
--- a/ambari-infra-manager-it/pom.xml
+++ b/ambari-infra-manager-it/pom.xml
@@ -157,6 +157,16 @@
hadoop-hdfs-client
${hadoop.version}
+
+ org.apache.logging.log4j
+ log4j-api
+ 2.11.1
+
+
+ org.apache.logging.log4j
+ log4j-core
+ 2.11.1
+
diff --git
a/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
b/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
index ddc4f000..fdccbab9 100644
---
a/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
+++
b/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
@@ -39,8 +39,8 @@
import org.apache.http.impl.client.CloseableHttpClient;
import org.apache.http.impl.client.DefaultHttpRequestRetryHandler;
import org.apache.http.impl.client.HttpClientBuilder;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import com.fasterxml.jackson.core.JsonParseException;
import com.fasterxml.jackson.core.type.TypeReference;
@@ -49,7 +49,7 @@
// TODO: use swagger
public class InfraClient implements AutoCloseable {
- private static final Logger LOG = LoggerFactory.getLogger(InfraClient.class);
+ private static final Logger logger = LogManager.getLogger(InfraClient.class);
private final CloseableHttpClient httpClient;
private final URI baseUrl;
@@ -77,7 +77,7 @@ private HttpResponse execute(HttpRequestBase post) {
try (CloseableHttpResponse response = httpClient.execute(post)) {
String responseBodyText =
IOUtils.toString(response.getEntity().getContent(), Charset.defaultCharset());
int statusCode = response.getStatusLine().getStatusCode();
- LOG.info("Response code {} body {} ", statusCode, responseBodyText);
+ logger.info("Response code {} body {} ", statusCode, responseBodyText);
if (!(200 <= statusCode && statusCode <= 299))
throw new RuntimeException("Error while executing http request: " +
responseBodyText);
return new HttpResponse(statusCode, responseBodyText);
diff --git
a/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/Solr.java
b/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/Solr.java
index 0dcc91a9..7bc952ae 100644
--- a/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/Solr.java
+++ b/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/Solr.java
@@ -31,17 +31,17 @@
import org.apache.http.impl.client.CloseableHttpClient;
import org.apache.http.impl.client.DefaultHttpRequestRetryHandler;
import org.apache.http.impl.client.HttpClientBuilder;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.apache.solr.client.solrj.SolrClient;
import org.apache.solr.client.solrj.SolrQuery;
import org.apache.solr.client.solrj.SolrServerException;
import org.apache.solr.client.solrj.impl.LBHttpSolrClient;
import org.apache.solr.client.solrj.response.QueryResponse;
import org.apache.solr.common.SolrInputDocument;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
public class Solr {
- private static final Logger LOG = LoggerFactory.getLogger(Solr.class);
+ private static final Logger logger = LogManager.getLogger(Solr.class);
public static final String AUDIT_LOGS_COLLECTION = "audit_logs";
public static final String HADOOP_LOGS_COLLECTION = "hadoop_logs";
private static final int SOLR_PORT = 8983;
@@ -85,7 +85,7 @@ public void add(SolrInputDocument solrInputDocument) {
}
public void createSolrCollection(String collectionName) {
-LOG.info("Creating collection");
+logger.info("Creating collection");
runCommand(new String[]{"docker", "exec", "docker_solr_1", "solr",
"create_collection", "-force", "-c", collectionName, "-d",
Paths.get(configSetPath, "configsets", collectionName, "conf").toString(),
"-n", collectionName + "_conf"});
}
diff --git
a/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/TestUtil.java
b/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/TestUtil.java
index f48e1073..8f19ce98 1
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[ https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688517#comment-16688517 ] ASF GitHub Bot commented on AMBARI-24895: - asfgit commented on issue #15: AMBARI-24895 - Infra Manager: code clean up URL: https://github.com/apache/ambari-infra/pull/15#issuecomment-439153527 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ambari-Infra-Github-PR-Builder/23/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Infra Manager: code clean up > > > Key: AMBARI-24895 > URL: https://issues.apache.org/jira/browse/AMBARI-24895 > Project: Ambari > Issue Type: Task > Components: ambari-infra >Affects Versions: 2.8.0 >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > > * rename LOG -> logger > * remove slf4j use log4j2 > * merge Job Properties and Job Parameter classes -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688491#comment-16688491
]
ASF GitHub Bot commented on AMBARI-24833:
-
swagle commented on a change in pull request #25: AMBARI-24833. Extend cloud
log rolling options
URL: https://github.com/apache/ambari-logsearch/pull/25#discussion_r233960818
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/CloudStorageDestination.java
##
@@ -19,7 +19,7 @@
package org.apache.ambari.logfeeder.conf;
public enum CloudStorageDestination {
- HDFS("hdfs"), S3("s3"), GCS("gcs"), ADLS("adls"), NONE("none");
+ HDFS("hdfs"), S3("s3"), GCS("gcs"), ADLS("adls"), WASB("wasb"), NONE("none");
Review comment:
Makes sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688488#comment-16688488
]
ASF GitHub Bot commented on AMBARI-24833:
-
oleewere commented on a change in pull request #25: AMBARI-24833. Extend cloud
log rolling options
URL: https://github.com/apache/ambari-logsearch/pull/25#discussion_r233959595
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/CloudStorageDestination.java
##
@@ -19,7 +19,7 @@
package org.apache.ambari.logfeeder.conf;
public enum CloudStorageDestination {
- HDFS("hdfs"), S3("s3"), GCS("gcs"), ADLS("adls"), NONE("none");
+ HDFS("hdfs"), S3("s3"), GCS("gcs"), ADLS("adls"), WASB("wasb"), NONE("none");
Review comment:
it is something for logfeeder level, but as we are not supporting core
gcs/wasb yet it won't be needed anyway, default-fs is used, if hdfs client will
figure out the right filesystem
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (AMBARI-24909) Parallel Client Fixes for Server Side Tasks
Nate Cole created AMBARI-24909: -- Summary: Parallel Client Fixes for Server Side Tasks Key: AMBARI-24909 URL: https://issues.apache.org/jira/browse/AMBARI-24909 Project: Ambari Issue Type: Bug Components: ambari-server Reporter: Nate Cole Assignee: Nate Cole Fix For: 2.8.0 The fix for parallel clients (AMBARI-24873) was broken for server-side action tasks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[
https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688465#comment-16688465
]
ASF GitHub Bot commented on AMBARI-24833:
-
swagle commented on a change in pull request #25: AMBARI-24833. Extend cloud
log rolling options
URL: https://github.com/apache/ambari-logsearch/pull/25#discussion_r233954847
##
File path:
ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/CloudStorageDestination.java
##
@@ -19,7 +19,7 @@
package org.apache.ambari.logfeeder.conf;
public enum CloudStorageDestination {
- HDFS("hdfs"), S3("s3"), GCS("gcs"), ADLS("adls"), NONE("none");
+ HDFS("hdfs"), S3("s3"), GCS("gcs"), ADLS("adls"), WASB("wasb"), NONE("none");
Review comment:
Do we need to add secure mode enums? (adlss, wasbs) are the ones that I know
exist.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log Feeder: send logs to cloud storage (gcs/s3 etc.)
>
>
> Key: AMBARI-24833
> URL: https://issues.apache.org/jira/browse/AMBARI-24833
> Project: Ambari
> Issue Type: Bug
> Components: ambari-logsearch
>Affects Versions: 2.7.0
>Reporter: Olivér Szabó
>Assignee: Olivér Szabó
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (AMBARI-24908) OneFS mpack should include webhdfs enable setting - Default Enabled
Andrew Huff created AMBARI-24908: Summary: OneFS mpack should include webhdfs enable setting - Default Enabled Key: AMBARI-24908 URL: https://issues.apache.org/jira/browse/AMBARI-24908 Project: Ambari Issue Type: Bug Components: ambari-server, contrib Affects Versions: 3.0.0 Environment: HDP 3.0 and Isilon 8.2.0 Reporter: Andrew Huff The Isilon management pack should include the 'dfs.webhdfs.enabled' configuration in the hdfs_site.xml file as it is needed by the Ambari Agent. This previous Jira incorrectly removed the setting which was originally set to 'false', however, Isilon has since increased its support for WebHDFS. The previous Jira assumed that by removing the setting the Ambari Agent would default to 'true' for this setting. This does not appear to be the case. https://issues.apache.org/jira/browse/AMBARI-24539 https://github.com/apache/ambari/pull/2170 This setting needs to be added back to the Isilon management pack with a default value of 'true'. This value should also be user configurable 'overrideable = true'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24871) Create an Ambari-server class that is called as an entry point to encrypt service configuration sensitive data
[ https://issues.apache.org/jira/browse/AMBARI-24871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688446#comment-16688446 ] Hudson commented on AMBARI-24871: - FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #10297 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10297/]) AMBARI-24871. Create an Ambari-server class that is called as an entr… (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=2bfbef2cab3cac2c4720dca0942fed8d3efd9bc9]) * (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProviderTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationHandler.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/security/encryption/AESEncryptionService.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/security/encryption/MasterKeyServiceTest.java * (add) ambari-server/src/test/java/org/apache/ambari/server/security/encryption/SensitiveDataEncryptionTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialProvider.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/security/encryption/EncryptionServiceTest.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/security/encryption/CredentialProviderTest.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/utils/PasswordUtils.java * (add) ambari-server/src/main/java/org/apache/ambari/server/security/encryption/SensitiveDataEncryption.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/configuration/ComponentSSLConfiguration.java * (edit) ambari-server/src/test/java/org/apache/ambari/server/utils/PasswordUtilsTest.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/security/encryption/MasterKeyServiceImpl.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialStoreServiceImpl.java * (edit) ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > Create an Ambari-server class that is called as an entry point to encrypt > service configuration sensitive data > -- > > Key: AMBARI-24871 > URL: https://issues.apache.org/jira/browse/AMBARI-24871 > Project: Ambari > Issue Type: Task > Components: ambari-server >Affects Versions: 2.8.0 >Reporter: Dmitry Lysnichenko >Assignee: Dmitry Lysnichenko >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Time Spent: 4.5h > Remaining Estimate: 0h > > Create a java class that is called as an entry point to encrypt service > configuration sensitive data. This script will be called from a python script > just like it is done for pre-checks, or for upgrade catalogs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[ https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688436#comment-16688436 ] ASF GitHub Bot commented on AMBARI-24833: - asfgit commented on issue #25: AMBARI-24833. Extend cloud log rolling options URL: https://github.com/apache/ambari-logsearch/pull/25#issuecomment-439130819 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/49/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log Feeder: send logs to cloud storage (gcs/s3 etc.) > > > Key: AMBARI-24833 > URL: https://issues.apache.org/jira/browse/AMBARI-24833 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.7.0 >Reporter: Olivér Szabó >Assignee: Olivér Szabó >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[ https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688330#comment-16688330 ] ASF GitHub Bot commented on AMBARI-24833: - asfgit commented on issue #25: AMBARI-24833. Extend cloud log rolling options URL: https://github.com/apache/ambari-logsearch/pull/25#issuecomment-439106294 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/48/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log Feeder: send logs to cloud storage (gcs/s3 etc.) > > > Key: AMBARI-24833 > URL: https://issues.apache.org/jira/browse/AMBARI-24833 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.7.0 >Reporter: Olivér Szabó >Assignee: Olivér Szabó >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24833) Log Feeder: send logs to cloud storage (gcs/s3 etc.)
[ https://issues.apache.org/jira/browse/AMBARI-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688317#comment-16688317 ] ASF GitHub Bot commented on AMBARI-24833: - oleewere opened a new pull request #25: AMBARI-24833. Extend cloud log rolling options URL: https://github.com/apache/ambari-logsearch/pull/25 # What changes were proposed in this pull request? Extend rolling options: - add size format - add default rolling strategy ## How was this patch tested? Waiting for UTs This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Log Feeder: send logs to cloud storage (gcs/s3 etc.) > > > Key: AMBARI-24833 > URL: https://issues.apache.org/jira/browse/AMBARI-24833 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch >Affects Versions: 2.7.0 >Reporter: Olivér Szabó >Assignee: Olivér Szabó >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AMBARI-24907) Update service metainfo to declare LDAP integration support
Sandor Molnar created AMBARI-24907:
--
Summary: Update service metainfo to declare LDAP integration
support
Key: AMBARI-24907
URL: https://issues.apache.org/jira/browse/AMBARI-24907
Project: Ambari
Issue Type: Task
Components: ambari-sever
Affects Versions: 2.7.0
Reporter: Sandor Molnar
Assignee: Sandor Molnar
Fix For: 2.8.0
Update service metainfo to declare LDAP integration support. The following tag
may be optionally set in a service's metainfo.xml file:
{noformat}
true
{
"equals": [
"ranger-admin-site/ranger.authentication.method",
"LDAP"
]
}
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24905) Service display name on left navigation bar should be suffixed with "Client" if only client service component is present for a service
[ https://issues.apache.org/jira/browse/AMBARI-24905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688133#comment-16688133 ] Hudson commented on AMBARI-24905: - FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #10296 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10296/]) AMBARI-24905 Service display name on left navigation bar should be (1963907+atkach: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=1fae6cf19dfc4f1bfb428eb34480e7382c460db8]) * (edit) ambari-web/app/views/main/service/info/menu.js * (edit) ambari-web/app/models/service.js * (edit) ambari-web/app/templates/main/service/menu_item.hbs * (edit) ambari-web/app/views/main/menu.js * (edit) ambari-web/app/views/main/service/item.js > Service display name on left navigation bar should be suffixed with "Client" > if only client service component is present for a service > -- > > Key: AMBARI-24905 > URL: https://issues.apache.org/jira/browse/AMBARI-24905 > Project: Ambari > Issue Type: Task > Components: ambari-web >Affects Versions: 2.7.0 >Reporter: Andrii Tkach >Assignee: Andrii Tkach >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: Displayname HDFS Client.png, Dsplayname HDFS.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > When a service only contains client service component then check service's > displayname. If service's displayname does not and with "Client" then suffix > service's displayname with "Client" > Current behavior: !Dsplayname HDFS.png! > Expected behavior: !Displayname HDFS Client.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24905) Service display name on left navigation bar should be suffixed with "Client" if only client service component is present for a service
[ https://issues.apache.org/jira/browse/AMBARI-24905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688108#comment-16688108 ] Andrii Tkach commented on AMBARI-24905: --- committed to trunk > Service display name on left navigation bar should be suffixed with "Client" > if only client service component is present for a service > -- > > Key: AMBARI-24905 > URL: https://issues.apache.org/jira/browse/AMBARI-24905 > Project: Ambari > Issue Type: Task > Components: ambari-web >Affects Versions: 2.7.0 >Reporter: Andrii Tkach >Assignee: Andrii Tkach >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: Displayname HDFS Client.png, Dsplayname HDFS.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > When a service only contains client service component then check service's > displayname. If service's displayname does not and with "Client" then suffix > service's displayname with "Client" > Current behavior: !Dsplayname HDFS.png! > Expected behavior: !Displayname HDFS Client.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (AMBARI-24905) Service display name on left navigation bar should be suffixed with "Client" if only client service component is present for a service
[ https://issues.apache.org/jira/browse/AMBARI-24905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Tkach resolved AMBARI-24905. --- Resolution: Fixed > Service display name on left navigation bar should be suffixed with "Client" > if only client service component is present for a service > -- > > Key: AMBARI-24905 > URL: https://issues.apache.org/jira/browse/AMBARI-24905 > Project: Ambari > Issue Type: Task > Components: ambari-web >Affects Versions: 2.7.0 >Reporter: Andrii Tkach >Assignee: Andrii Tkach >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: Displayname HDFS Client.png, Dsplayname HDFS.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > When a service only contains client service component then check service's > displayname. If service's displayname does not and with "Client" then suffix > service's displayname with "Client" > Current behavior: !Dsplayname HDFS.png! > Expected behavior: !Displayname HDFS Client.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24904) JAR does not exist: /var/lib/ambari-agent/lib/fast-hdfs-resource.jar
[ https://issues.apache.org/jira/browse/AMBARI-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688017#comment-16688017 ] Hudson commented on AMBARI-24904: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10295 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10295/]) AMBARI-24904. JAR does not exist: (aonishuk: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=3d215524b279bf106a6950e36808f392cc2567b4]) * (edit) ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py > JAR does not exist: /var/lib/ambari-agent/lib/fast-hdfs-resource.jar > > > Key: AMBARI-24904 > URL: https://issues.apache.org/jira/browse/AMBARI-24904 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: AMBARI-24904.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AMBARI-24906) JSON document validation for "Add Service" request
Balázs Bence Sári created AMBARI-24906: -- Summary: JSON document validation for "Add Service" request Key: AMBARI-24906 URL: https://issues.apache.org/jira/browse/AMBARI-24906 Project: Ambari Issue Type: Task Components: ambari-server Reporter: Balázs Bence Sári Assignee: Balázs Bence Sári Fix For: trunk Validation logic needs to be implemented for JSON deserialization of the Configuration object embedded into an AddService request. The rest of the request is already validated by Jackson and the constructor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687987#comment-16687987
]
ASF GitHub Bot commented on AMBARI-24895:
-
kasakrisz commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233827919
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/Solr.java
##
@@ -41,7 +41,7 @@
import org.slf4j.LoggerFactory;
public class Solr {
- private static final Logger LOG = LoggerFactory.getLogger(Solr.class);
+ private static final Logger logger = LoggerFactory.getLogger(Solr.class);
Review comment:
I am going to replace it to make it consistent.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24905) Service display name on left navigation bar should be suffixed with "Client" if only client service component is present for a service
[ https://issues.apache.org/jira/browse/AMBARI-24905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Tkach updated AMBARI-24905: -- Description: When a service only contains client service component then check service's displayname. If service's displayname does not and with "Client" then suffix service's displayname with "Client" Current behavior: !Dsplayname HDFS.png! Expected behavior: !Displayname HDFS Client.png! was: When a service only contains client service component then check service's displayname. If service's displayname does not and with "Client" then suffix service's displayname with "Client" Current behavior: !Dsplayname HDFS.png|thumbnail! Expected behavior: !Displayname HDFS Client.png|thumbnail! > Service display name on left navigation bar should be suffixed with "Client" > if only client service component is present for a service > -- > > Key: AMBARI-24905 > URL: https://issues.apache.org/jira/browse/AMBARI-24905 > Project: Ambari > Issue Type: Task > Components: ambari-web >Affects Versions: 2.7.0 >Reporter: Andrii Tkach >Assignee: Andrii Tkach >Priority: Major > Fix For: 2.8.0 > > Attachments: Displayname HDFS Client.png, Dsplayname HDFS.png > > > When a service only contains client service component then check service's > displayname. If service's displayname does not and with "Client" then suffix > service's displayname with "Client" > Current behavior: !Dsplayname HDFS.png! > Expected behavior: !Displayname HDFS Client.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687949#comment-16687949
]
ASF GitHub Bot commented on AMBARI-24895:
-
oleewere commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233822759
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/Solr.java
##
@@ -41,7 +41,7 @@
import org.slf4j.LoggerFactory;
public class Solr {
- private static final Logger LOG = LoggerFactory.getLogger(Solr.class);
+ private static final Logger logger = LoggerFactory.getLogger(Solr.class);
Review comment:
we need the log4j2 thing in the end product (infra manager), on testing
side, it won't really matter, but on naming convention we want to do the same
(LOG -> logger)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687946#comment-16687946
]
ASF GitHub Bot commented on AMBARI-24895:
-
oleewere commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233821022
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
##
@@ -49,7 +49,7 @@
// TODO: use swagger
public class InfraClient implements AutoCloseable {
- private static final Logger LOG = LoggerFactory.getLogger(InfraClient.class);
+ private static final Logger logger =
LoggerFactory.getLogger(InfraClient.class);
Review comment:
@adoroszlai , it is not a constant (only a final reference) - it is a common
misconception, also its not a log, its logger, so the name logger with
lowercase is the proper one.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687939#comment-16687939
]
ASF GitHub Bot commented on AMBARI-24895:
-
oleewere commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233821022
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
##
@@ -49,7 +49,7 @@
// TODO: use swagger
public class InfraClient implements AutoCloseable {
- private static final Logger LOG = LoggerFactory.getLogger(InfraClient.class);
+ private static final Logger logger =
LoggerFactory.getLogger(InfraClient.class);
Review comment:
it is not a constant (only a final reference)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687935#comment-16687935
]
ASF GitHub Bot commented on AMBARI-24895:
-
oleewere commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233821022
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
##
@@ -49,7 +49,7 @@
// TODO: use swagger
public class InfraClient implements AutoCloseable {
- private static final Logger LOG = LoggerFactory.getLogger(InfraClient.class);
+ private static final Logger logger =
LoggerFactory.getLogger(InfraClient.class);
Review comment:
it is not a constant
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24905) Service display name on left navigation bar should be suffixed with "Client" if only client service component is present for a service
[ https://issues.apache.org/jira/browse/AMBARI-24905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated AMBARI-24905: Labels: pull-request-available (was: ) > Service display name on left navigation bar should be suffixed with "Client" > if only client service component is present for a service > -- > > Key: AMBARI-24905 > URL: https://issues.apache.org/jira/browse/AMBARI-24905 > Project: Ambari > Issue Type: Task > Components: ambari-web >Affects Versions: 2.7.0 >Reporter: Andrii Tkach >Assignee: Andrii Tkach >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: Displayname HDFS Client.png, Dsplayname HDFS.png > > > When a service only contains client service component then check service's > displayname. If service's displayname does not and with "Client" then suffix > service's displayname with "Client" > Current behavior: !Dsplayname HDFS.png! > Expected behavior: !Displayname HDFS Client.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24905) Service display name on left navigation bar should be suffixed with "Client" if only client service component is present for a service
[ https://issues.apache.org/jira/browse/AMBARI-24905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Tkach updated AMBARI-24905: -- Attachment: Displayname HDFS Client.png Dsplayname HDFS.png > Service display name on left navigation bar should be suffixed with "Client" > if only client service component is present for a service > -- > > Key: AMBARI-24905 > URL: https://issues.apache.org/jira/browse/AMBARI-24905 > Project: Ambari > Issue Type: Task > Components: ambari-web >Affects Versions: 2.7.0 >Reporter: Andrii Tkach >Assignee: Andrii Tkach >Priority: Major > Fix For: 2.8.0 > > Attachments: Displayname HDFS Client.png, Dsplayname HDFS.png > > > When a service only contains client service component then check service's > displayname. If service's displayname does not and with "Client" then suffix > service's displayname with "Client" > Current behavior: !Dsplayname HDFS.png|thumbnail! > Expected behavior: !Displayname HDFS Client.png|thumbnail! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AMBARI-24905) Service display name on left navigation bar should be suffixed with "Client" if only client service component is present for a service
Andrii Tkach created AMBARI-24905: - Summary: Service display name on left navigation bar should be suffixed with "Client" if only client service component is present for a service Key: AMBARI-24905 URL: https://issues.apache.org/jira/browse/AMBARI-24905 Project: Ambari Issue Type: Task Components: ambari-web Affects Versions: 2.7.0 Reporter: Andrii Tkach Assignee: Andrii Tkach Fix For: 2.8.0 When a service only contains client service component then check service's displayname. If service's displayname does not and with "Client" then suffix service's displayname with "Client" Current behavior: !Dsplayname HDFS.png|thumbnail! Expected behavior: !Displayname HDFS Client.png|thumbnail! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24904) JAR does not exist: /var/lib/ambari-agent/lib/fast-hdfs-resource.jar
[ https://issues.apache.org/jira/browse/AMBARI-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated AMBARI-24904: Labels: pull-request-available (was: ) > JAR does not exist: /var/lib/ambari-agent/lib/fast-hdfs-resource.jar > > > Key: AMBARI-24904 > URL: https://issues.apache.org/jira/browse/AMBARI-24904 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: AMBARI-24904.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AMBARI-24904) JAR does not exist: /var/lib/ambari-agent/lib/fast-hdfs-resource.jar
Andrew Onischuk created AMBARI-24904: Summary: JAR does not exist: /var/lib/ambari-agent/lib/fast-hdfs-resource.jar Key: AMBARI-24904 URL: https://issues.apache.org/jira/browse/AMBARI-24904 Project: Ambari Issue Type: Bug Reporter: Andrew Onischuk Assignee: Andrew Onischuk Fix For: 2.8.0 Attachments: AMBARI-24904.patch -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24904) JAR does not exist: /var/lib/ambari-agent/lib/fast-hdfs-resource.jar
[ https://issues.apache.org/jira/browse/AMBARI-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Onischuk updated AMBARI-24904: - Attachment: AMBARI-24904.patch > JAR does not exist: /var/lib/ambari-agent/lib/fast-hdfs-resource.jar > > > Key: AMBARI-24904 > URL: https://issues.apache.org/jira/browse/AMBARI-24904 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Fix For: 2.8.0 > > Attachments: AMBARI-24904.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24904) JAR does not exist: /var/lib/ambari-agent/lib/fast-hdfs-resource.jar
[ https://issues.apache.org/jira/browse/AMBARI-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Onischuk updated AMBARI-24904: - Status: Patch Available (was: Open) > JAR does not exist: /var/lib/ambari-agent/lib/fast-hdfs-resource.jar > > > Key: AMBARI-24904 > URL: https://issues.apache.org/jira/browse/AMBARI-24904 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Fix For: 2.8.0 > > Attachments: AMBARI-24904.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687872#comment-16687872
]
ASF GitHub Bot commented on AMBARI-24895:
-
kasakrisz commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233805645
##
File path:
ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/security/HadoopCredentialStore.java
##
@@ -18,16 +18,16 @@
*/
package org.apache.ambari.infra.conf.security;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import static org.apache.commons.lang.StringUtils.isBlank;
+import static org.apache.commons.lang3.ArrayUtils.isNotEmpty;
import java.util.Optional;
-import static org.apache.commons.lang.StringUtils.isBlank;
-import static org.apache.commons.lang3.ArrayUtils.isNotEmpty;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
public class HadoopCredentialStore implements PasswordStore {
- private static final Logger LOG =
LoggerFactory.getLogger(InfraManagerSecurityConfig.class);
+ private static final Logger logger =
LogManager.getLogger(InfraManagerSecurityConfig.class);
Review comment:
LogManager.getLogger - log4j2
LoggerFactory.getLogger - slf4j
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24903) hdfsResource should create resources in file:/// if core-site is not available.
[ https://issues.apache.org/jira/browse/AMBARI-24903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687863#comment-16687863 ] Hudson commented on AMBARI-24903: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10294 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10294/]) AMBARI-24903. hdfsResource should create resources in file:/// if (aonishuk: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=17c47cff1ae2b5b0c0901fbdeea6e914ecebc575]) * (edit) ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py * (edit) ambari-server/src/main/resources/stack-hooks/before-START/scripts/shared_initialization.py > hdfsResource should create resources in file:/// if core-site is not > available. > --- > > Key: AMBARI-24903 > URL: https://issues.apache.org/jira/browse/AMBARI-24903 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: AMBARI-24903.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687815#comment-16687815
]
ASF GitHub Bot commented on AMBARI-24895:
-
zeroflag commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233794856
##
File path:
ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/security/HadoopCredentialStore.java
##
@@ -18,16 +18,16 @@
*/
package org.apache.ambari.infra.conf.security;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import static org.apache.commons.lang.StringUtils.isBlank;
+import static org.apache.commons.lang3.ArrayUtils.isNotEmpty;
import java.util.Optional;
-import static org.apache.commons.lang.StringUtils.isBlank;
-import static org.apache.commons.lang3.ArrayUtils.isNotEmpty;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
public class HadoopCredentialStore implements PasswordStore {
- private static final Logger LOG =
LoggerFactory.getLogger(InfraManagerSecurityConfig.class);
+ private static final Logger logger =
LogManager.getLogger(InfraManagerSecurityConfig.class);
Review comment:
what's the difference between LogManager.getLogger and
LoggerFactory.getLogger (used at other places)?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24894) Sensitive service configuration values should be decrypted when processing the Ambari agent command script, if enabled
[
https://issues.apache.org/jira/browse/AMBARI-24894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated AMBARI-24894:
Labels: pull-request-available (was: )
> Sensitive service configuration values should be decrypted when processing
> the Ambari agent command script, if enabled
> --
>
> Key: AMBARI-24894
> URL: https://issues.apache.org/jira/browse/AMBARI-24894
> Project: Ambari
> Issue Type: Task
> Components: ambari-agent, ambari-server
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> Sensitive service configuration values should be decrypted when processing
> the Ambari agent command script, if enabled.
> During the processing of
> resource_management.libraries.script.script.Script#execute, the command data
> file is to be read in and the encrypted values in the JSON document are to be
> decrypted before executing the command.
> Each encrypted value will be in the form of
> ${enc=, value=}
> For example:
> ${enc=aes265_hex, value=5248...303d}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24551) [Log Search UI] get rid of redundant requests after undoing or redoing several history steps
[ https://issues.apache.org/jira/browse/AMBARI-24551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Tobias updated AMBARI-24551: --- Resolution: Fixed Status: Resolved (was: Patch Available) > [Log Search UI] get rid of redundant requests after undoing or redoing > several history steps > > > Key: AMBARI-24551 > URL: https://issues.apache.org/jira/browse/AMBARI-24551 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch, logsearch >Affects Versions: 2.7.1 >Reporter: Istvan Tobias >Assignee: Istvan Tobias >Priority: Minor > Labels: pull-request-available > Fix For: 2.8.0 > > Original Estimate: 4h > Time Spent: 3h 40m > Remaining Estimate: 20m > > After undoing or redoing more than one history items several redundant API > requests are sent. This occurs because changes for several filter controls > are applied step-by-step, and each control change generates new request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24839) Ambari is trying to create hbase.rootdir using s3 url
[ https://issues.apache.org/jira/browse/AMBARI-24839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687776#comment-16687776 ] Hudson commented on AMBARI-24839: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10293 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10293/]) AMBARI-24839. Ambari is trying to create hbase.rootdir using s3 url (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=f231e836afbd05d4ffd961226d1f6e5996b43816]) * (edit) contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java * (edit) ambari-server/src/main/resources/stack-hooks/before-START/scripts/params.py * (edit) ambari-server/src/main/resources/stack-hooks/before-START/scripts/shared_initialization.py * (edit) ambari-server/src/main/resources/stack-hooks/before-START/files/fast-hdfs-resource.jar * (edit) ambari-agent/src/test/python/ambari_agent/dummy_files/alert_definitions.json * (edit) ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py * (edit) ambari-server/src/test/python/stacks/stack-hooks/before-START/test_before_start.py > Ambari is trying to create hbase.rootdir using s3 url > - > > Key: AMBARI-24839 > URL: https://issues.apache.org/jira/browse/AMBARI-24839 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: AMBARI-24839.patch, AMBARI-24839.patch > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Please look at the related Jira for blueprint. > For shared services cluster, Hbase needs to use S3 Object store for rootdir. > Ambari is trying to create hbase.rootdir using s3 url, hence failing with > below error. > > > 2018-10-24 03:12:45,424 - get_user_call_output returned (0, > u'\n\n content="text/html;charset=utf-8"/>\nError 404 Not > Found\n\nHTTP ERROR 404\nProblem accessing > /webhdfs/v1s3a:/san-s3-ohio/hbase. Reason:\nNot > Found\n\n\n404', u'') > out: > > > Error 404 Not Found > > HTTP ERROR 404 > Problem accessing /webhdfs/v1s3a:/san-s3-ohio/hbase. Reason: > Not Found > > > 404 > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24551) [Log Search UI] get rid of redundant requests after undoing or redoing several history steps
[ https://issues.apache.org/jira/browse/AMBARI-24551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Tobias updated AMBARI-24551: --- Status: Patch Available (was: In Progress) > [Log Search UI] get rid of redundant requests after undoing or redoing > several history steps > > > Key: AMBARI-24551 > URL: https://issues.apache.org/jira/browse/AMBARI-24551 > Project: Ambari > Issue Type: Bug > Components: ambari-logsearch, logsearch >Affects Versions: 2.7.1 >Reporter: Istvan Tobias >Assignee: Istvan Tobias >Priority: Minor > Labels: pull-request-available > Fix For: 2.8.0 > > Original Estimate: 4h > Time Spent: 3h 40m > Remaining Estimate: 20m > > After undoing or redoing more than one history items several redundant API > requests are sent. This occurs because changes for several filter controls > are applied step-by-step, and each control change generates new request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687741#comment-16687741
]
ASF GitHub Bot commented on AMBARI-24895:
-
adoroszlai commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233765518
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
##
@@ -49,7 +49,7 @@
// TODO: use swagger
public class InfraClient implements AutoCloseable {
- private static final Logger LOG = LoggerFactory.getLogger(InfraClient.class);
+ private static final Logger logger =
LoggerFactory.getLogger(InfraClient.class);
Review comment:
Why lowercase? It is a constant.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AMBARI-24895) Infra Manager: code clean up
[
https://issues.apache.org/jira/browse/AMBARI-24895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687742#comment-16687742
]
ASF GitHub Bot commented on AMBARI-24895:
-
adoroszlai commented on a change in pull request #15: AMBARI-24895 - Infra
Manager: code clean up
URL: https://github.com/apache/ambari-infra/pull/15#discussion_r233765973
##
File path:
ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/Solr.java
##
@@ -41,7 +41,7 @@
import org.slf4j.LoggerFactory;
public class Solr {
- private static final Logger LOG = LoggerFactory.getLogger(Solr.class);
+ private static final Logger logger = LoggerFactory.getLogger(Solr.class);
Review comment:
Is there a reason for keeping `slf4j` in integration tests?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Infra Manager: code clean up
>
>
> Key: AMBARI-24895
> URL: https://issues.apache.org/jira/browse/AMBARI-24895
> Project: Ambari
> Issue Type: Task
> Components: ambari-infra
>Affects Versions: 2.8.0
>Reporter: Krisztian Kasa
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> * rename LOG -> logger
> * remove slf4j use log4j2
> * merge Job Properties and Job Parameter classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24903) hdfsResource should create resources in file:/// if core-site is not available.
[ https://issues.apache.org/jira/browse/AMBARI-24903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated AMBARI-24903: Labels: pull-request-available (was: ) > hdfsResource should create resources in file:/// if core-site is not > available. > --- > > Key: AMBARI-24903 > URL: https://issues.apache.org/jira/browse/AMBARI-24903 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: AMBARI-24903.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24903) hdfsResource should create resources in file:/// if core-site is not available.
[ https://issues.apache.org/jira/browse/AMBARI-24903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Onischuk updated AMBARI-24903: - Status: Patch Available (was: Open) > hdfsResource should create resources in file:/// if core-site is not > available. > --- > > Key: AMBARI-24903 > URL: https://issues.apache.org/jira/browse/AMBARI-24903 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Fix For: 2.8.0 > > Attachments: AMBARI-24903.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24903) hdfsResource should create resources in file:/// if core-site is not available.
[ https://issues.apache.org/jira/browse/AMBARI-24903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Onischuk updated AMBARI-24903: - Attachment: AMBARI-24903.patch > hdfsResource should create resources in file:/// if core-site is not > available. > --- > > Key: AMBARI-24903 > URL: https://issues.apache.org/jira/browse/AMBARI-24903 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Fix For: 2.8.0 > > Attachments: AMBARI-24903.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AMBARI-24903) hdfsResource should create resources in file:/// if core-site is not available.
Andrew Onischuk created AMBARI-24903: Summary: hdfsResource should create resources in file:/// if core-site is not available. Key: AMBARI-24903 URL: https://issues.apache.org/jira/browse/AMBARI-24903 Project: Ambari Issue Type: Bug Reporter: Andrew Onischuk Assignee: Andrew Onischuk Fix For: 2.8.0 Attachments: AMBARI-24903.patch -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-24902) ATS 1.5 does not start in DL cluster without HDFS
[ https://issues.apache.org/jira/browse/AMBARI-24902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687712#comment-16687712 ] Hudson commented on AMBARI-24902: - SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10291 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10291/]) AMBARI-24902. ATS 1.5 does not start in DL cluster without HDFS (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=2b7366441b37ddf0a2cb7acb41fa196553c27115]) * (edit) ambari-server/src/main/resources/stack-hooks/before-ANY/scripts/shared_initialization.py * (edit) ambari-server/src/main/resources/stack-hooks/before-ANY/scripts/hook.py > ATS 1.5 does not start in DL cluster without HDFS > - > > Key: AMBARI-24902 > URL: https://issues.apache.org/jira/browse/AMBARI-24902 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: AMBARI-24902.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AMBARI-24901) Handle complex "Add Service" request in ServiceResourceProvider
[
https://issues.apache.org/jira/browse/AMBARI-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doroszlai, Attila updated AMBARI-24901:
---
Affects Version/s: (was: 2.8.0)
Status: Patch Available (was: In Progress)
> Handle complex "Add Service" request in ServiceResourceProvider
> ---
>
> Key: AMBARI-24901
> URL: https://issues.apache.org/jira/browse/AMBARI-24901
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
>Reporter: Doroszlai, Attila
>Assignee: Doroszlai, Attila
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Related to AMBARI-24881, change {{ServiceResourceProvider}} to handle the
> complex "Add Service" request. So far only stub logic is needed, details of
> the service creation will be filled later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24901) Handle complex "Add Service" request in ServiceResourceProvider
[
https://issues.apache.org/jira/browse/AMBARI-24901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated AMBARI-24901:
Labels: pull-request-available (was: )
> Handle complex "Add Service" request in ServiceResourceProvider
> ---
>
> Key: AMBARI-24901
> URL: https://issues.apache.org/jira/browse/AMBARI-24901
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
>Affects Versions: 2.8.0
>Reporter: Doroszlai, Attila
>Assignee: Doroszlai, Attila
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> Related to AMBARI-24881, change {{ServiceResourceProvider}} to handle the
> complex "Add Service" request. So far only stub logic is needed, details of
> the service creation will be filled later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AMBARI-24902) ATS 1.5 does not start in DL cluster without HDFS
[ https://issues.apache.org/jira/browse/AMBARI-24902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated AMBARI-24902: Labels: pull-request-available (was: ) > ATS 1.5 does not start in DL cluster without HDFS > - > > Key: AMBARI-24902 > URL: https://issues.apache.org/jira/browse/AMBARI-24902 > Project: Ambari > Issue Type: Bug >Reporter: Andrew Onischuk >Assignee: Andrew Onischuk >Priority: Major > Labels: pull-request-available > Fix For: 2.8.0 > > Attachments: AMBARI-24902.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
