[jira] [Commented] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.
[ https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263290#comment-15263290 ] Keta Patel commented on AMBARI-15979: - https://github.com/apache/ambari/commit/9bef76ba08fe190ad40d128cf317dce0df36f7f4 > Provide UI validation for widget_name and description fields in Create/Edit > Widget pop-up. > -- > > Key: AMBARI-15979 > URL: https://issues.apache.org/jira/browse/AMBARI-15979 > Project: Ambari > Issue Type: Improvement > Components: ambari-web >Affects Versions: trunk >Reporter: Keta Patel >Assignee: Keta Patel > Fix For: 2.4.0 > > Attachments: AMBARI-15979-April-20.patch, > AMBARI-15979-April-25.patch, AMBARI-15979-April-26-updated.patch, > AMBARI-15979-April-26.patch, AMBARI-15979-inlineError.patch, > AMBARI-15979-topError.patch, AMBARI-15979.patch, > create_widget_button_location.tiff, create_widget_step1.tiff, > create_widget_step2.tiff, create_widget_step3.tiff, > fixed_ErrorOnTop_character_validation_for_description.tiff, > fixed_ErrorOnTop_character_validation_for_name.tiff, > fixed_ErrorOnTop_length_validation_for_description.tiff, > fixed_ErrorOnTop_length_validation_for_name.tiff, > fixed_InlineError_character_validation_for_description.tiff, > fixed_InlineError_character_validation_for_name.tiff, > fixed_InlineError_length_validation_for_description.tiff, > fixed_InlineError_length_validation_for_name.tiff, > fixed_characters_allowed_for_description.tiff, > fixed_characters_allowed_for_name.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_description.tiff, > original_length_validation_for_name.tiff > > > The UI validation at present checks only the length of the user input for > widget_name and description fields. All characters are allowed to be stored > in the database through them. A more strict UI validation that limits the > type of characters entered for these fields will provide a good first line of > defense. > Steps to reproduce: > 1. Make sure you have Ambari Metrics service installed on your cluster. > 2. On the Dashboard, select any service that makes use of Ambari Metrics, say > HDFS. > 3. In the "Metrics" section, click the "Actions" button in the top-right > corner, and select "Create a new widget" option from the drop-down. > (attachment: create_widget_button_location.tiff) > 4. Create widget pop-up is displayed. > 5. On Step-1, select any type for the widget and click "Next". (attachment: > create_widget_step1.tiff) > 6. On Step-2, select any valid metrics parameter and click "Next". > (attachment: create_widget_step2.tiff) > 7. On Step-3, for widget_name and description fields, you can enter any > character. No validation is present to check the contents. The only > validation present checks the length of the input text. > (attachments: > create_widget_step3.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_name.tiff, > original_length_validation_for_description.tiff ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.
[ https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261962#comment-15261962 ] Hudson commented on AMBARI-15979: - SUCCESS: Integrated in Ambari-trunk-Commit #4755 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4755/]) AMBARI-15979 Provide UI validation for widget_name and description (atkach: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=9bef76ba08fe190ad40d128cf317dce0df36f7f4]) * ambari-web/test/controllers/main/service/widgets/create/step3_controller_test.js * ambari-web/app/controllers/main/service/widgets/create/step3_controller.js * ambari-web/app/utils/validator.js * ambari-web/app/messages.js * ambari-web/app/templates/main/service/widgets/create/step3.hbs > Provide UI validation for widget_name and description fields in Create/Edit > Widget pop-up. > -- > > Key: AMBARI-15979 > URL: https://issues.apache.org/jira/browse/AMBARI-15979 > Project: Ambari > Issue Type: Improvement > Components: ambari-web >Affects Versions: trunk >Reporter: Keta Patel >Assignee: Keta Patel > Fix For: 2.4.0 > > Attachments: AMBARI-15979-April-20.patch, > AMBARI-15979-April-25.patch, AMBARI-15979-April-26-updated.patch, > AMBARI-15979-April-26.patch, AMBARI-15979-inlineError.patch, > AMBARI-15979-topError.patch, AMBARI-15979.patch, > create_widget_button_location.tiff, create_widget_step1.tiff, > create_widget_step2.tiff, create_widget_step3.tiff, > fixed_ErrorOnTop_character_validation_for_description.tiff, > fixed_ErrorOnTop_character_validation_for_name.tiff, > fixed_ErrorOnTop_length_validation_for_description.tiff, > fixed_ErrorOnTop_length_validation_for_name.tiff, > fixed_InlineError_character_validation_for_description.tiff, > fixed_InlineError_character_validation_for_name.tiff, > fixed_InlineError_length_validation_for_description.tiff, > fixed_InlineError_length_validation_for_name.tiff, > fixed_characters_allowed_for_description.tiff, > fixed_characters_allowed_for_name.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_description.tiff, > original_length_validation_for_name.tiff > > > The UI validation at present checks only the length of the user input for > widget_name and description fields. All characters are allowed to be stored > in the database through them. A more strict UI validation that limits the > type of characters entered for these fields will provide a good first line of > defense. > Steps to reproduce: > 1. Make sure you have Ambari Metrics service installed on your cluster. > 2. On the Dashboard, select any service that makes use of Ambari Metrics, say > HDFS. > 3. In the "Metrics" section, click the "Actions" button in the top-right > corner, and select "Create a new widget" option from the drop-down. > (attachment: create_widget_button_location.tiff) > 4. Create widget pop-up is displayed. > 5. On Step-1, select any type for the widget and click "Next". (attachment: > create_widget_step1.tiff) > 6. On Step-2, select any valid metrics parameter and click "Next". > (attachment: create_widget_step2.tiff) > 7. On Step-3, for widget_name and description fields, you can enter any > character. No validation is present to check the contents. The only > validation present checks the length of the input text. > (attachments: > create_widget_step3.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_name.tiff, > original_length_validation_for_description.tiff ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.
[ https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261788#comment-15261788 ] Andrii Tkach commented on AMBARI-15979: --- committed to trunk > Provide UI validation for widget_name and description fields in Create/Edit > Widget pop-up. > -- > > Key: AMBARI-15979 > URL: https://issues.apache.org/jira/browse/AMBARI-15979 > Project: Ambari > Issue Type: Improvement > Components: ambari-web >Affects Versions: trunk >Reporter: Keta Patel >Assignee: Keta Patel > Fix For: 2.4.0 > > Attachments: AMBARI-15979-April-20.patch, > AMBARI-15979-April-25.patch, AMBARI-15979-April-26-updated.patch, > AMBARI-15979-April-26.patch, AMBARI-15979-inlineError.patch, > AMBARI-15979-topError.patch, AMBARI-15979.patch, > create_widget_button_location.tiff, create_widget_step1.tiff, > create_widget_step2.tiff, create_widget_step3.tiff, > fixed_ErrorOnTop_character_validation_for_description.tiff, > fixed_ErrorOnTop_character_validation_for_name.tiff, > fixed_ErrorOnTop_length_validation_for_description.tiff, > fixed_ErrorOnTop_length_validation_for_name.tiff, > fixed_InlineError_character_validation_for_description.tiff, > fixed_InlineError_character_validation_for_name.tiff, > fixed_InlineError_length_validation_for_description.tiff, > fixed_InlineError_length_validation_for_name.tiff, > fixed_characters_allowed_for_description.tiff, > fixed_characters_allowed_for_name.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_description.tiff, > original_length_validation_for_name.tiff > > > The UI validation at present checks only the length of the user input for > widget_name and description fields. All characters are allowed to be stored > in the database through them. A more strict UI validation that limits the > type of characters entered for these fields will provide a good first line of > defense. > Steps to reproduce: > 1. Make sure you have Ambari Metrics service installed on your cluster. > 2. On the Dashboard, select any service that makes use of Ambari Metrics, say > HDFS. > 3. In the "Metrics" section, click the "Actions" button in the top-right > corner, and select "Create a new widget" option from the drop-down. > (attachment: create_widget_button_location.tiff) > 4. Create widget pop-up is displayed. > 5. On Step-1, select any type for the widget and click "Next". (attachment: > create_widget_step1.tiff) > 6. On Step-2, select any valid metrics parameter and click "Next". > (attachment: create_widget_step2.tiff) > 7. On Step-3, for widget_name and description fields, you can enter any > character. No validation is present to check the contents. The only > validation present checks the length of the input text. > (attachments: > create_widget_step3.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_name.tiff, > original_length_validation_for_description.tiff ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.
[
https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259586#comment-15259586
]
Hadoop QA commented on AMBARI-15979:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12800875/AMBARI-15979-April-26-updated.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-web.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/6675//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/6675//console
This message is automatically generated.
> Provide UI validation for widget_name and description fields in Create/Edit
> Widget pop-up.
> --
>
> Key: AMBARI-15979
> URL: https://issues.apache.org/jira/browse/AMBARI-15979
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-web
>Affects Versions: trunk
>Reporter: Keta Patel
>Assignee: Keta Patel
> Attachments: AMBARI-15979-April-20.patch,
> AMBARI-15979-April-25.patch, AMBARI-15979-April-26-updated.patch,
> AMBARI-15979-April-26.patch, AMBARI-15979-inlineError.patch,
> AMBARI-15979-topError.patch, AMBARI-15979.patch,
> create_widget_button_location.tiff, create_widget_step1.tiff,
> create_widget_step2.tiff, create_widget_step3.tiff,
> fixed_ErrorOnTop_character_validation_for_description.tiff,
> fixed_ErrorOnTop_character_validation_for_name.tiff,
> fixed_ErrorOnTop_length_validation_for_description.tiff,
> fixed_ErrorOnTop_length_validation_for_name.tiff,
> fixed_InlineError_character_validation_for_description.tiff,
> fixed_InlineError_character_validation_for_name.tiff,
> fixed_InlineError_length_validation_for_description.tiff,
> fixed_InlineError_length_validation_for_name.tiff,
> fixed_characters_allowed_for_description.tiff,
> fixed_characters_allowed_for_name.tiff,
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_description.tiff,
> original_length_validation_for_name.tiff
>
>
> The UI validation at present checks only the length of the user input for
> widget_name and description fields. All characters are allowed to be stored
> in the database through them. A more strict UI validation that limits the
> type of characters entered for these fields will provide a good first line of
> defense.
> Steps to reproduce:
> 1. Make sure you have Ambari Metrics service installed on your cluster.
> 2. On the Dashboard, select any service that makes use of Ambari Metrics, say
> HDFS.
> 3. In the "Metrics" section, click the "Actions" button in the top-right
> corner, and select "Create a new widget" option from the drop-down.
> (attachment: create_widget_button_location.tiff)
> 4. Create widget pop-up is displayed.
> 5. On Step-1, select any type for the widget and click "Next". (attachment:
> create_widget_step1.tiff)
> 6. On Step-2, select any valid metrics parameter and click "Next".
> (attachment: create_widget_step2.tiff)
> 7. On Step-3, for widget_name and description fields, you can enter any
> character. No validation is present to check the contents. The only
> validation present checks the length of the input text.
> (attachments:
> create_widget_step3.tiff,
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_name.tiff,
> original_length_validation_for_description.tiff )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.
[
https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256863#comment-15256863
]
Hadoop QA commented on AMBARI-15979:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12800556/AMBARI-15979-April-25.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-web.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/6639//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/6639//console
This message is automatically generated.
> Provide UI validation for widget_name and description fields in Create/Edit
> Widget pop-up.
> --
>
> Key: AMBARI-15979
> URL: https://issues.apache.org/jira/browse/AMBARI-15979
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-web
>Affects Versions: trunk
>Reporter: Keta Patel
>Assignee: Keta Patel
> Attachments: AMBARI-15979-April-20.patch,
> AMBARI-15979-April-25.patch, AMBARI-15979-inlineError.patch,
> AMBARI-15979-topError.patch, AMBARI-15979.patch,
> create_widget_button_location.tiff, create_widget_step1.tiff,
> create_widget_step2.tiff, create_widget_step3.tiff,
> fixed_ErrorOnTop_character_validation_for_description.tiff,
> fixed_ErrorOnTop_character_validation_for_name.tiff,
> fixed_ErrorOnTop_length_validation_for_description.tiff,
> fixed_ErrorOnTop_length_validation_for_name.tiff,
> fixed_InlineError_character_validation_for_description.tiff,
> fixed_InlineError_character_validation_for_name.tiff,
> fixed_InlineError_length_validation_for_description.tiff,
> fixed_InlineError_length_validation_for_name.tiff,
> fixed_characters_allowed_for_description.tiff,
> fixed_characters_allowed_for_name.tiff,
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_description.tiff,
> original_length_validation_for_name.tiff
>
>
> The UI validation at present checks only the length of the user input for
> widget_name and description fields. All characters are allowed to be stored
> in the database through them. A more strict UI validation that limits the
> type of characters entered for these fields will provide a good first line of
> defense.
> Steps to reproduce:
> 1. Make sure you have Ambari Metrics service installed on your cluster.
> 2. On the Dashboard, select any service that makes use of Ambari Metrics, say
> HDFS.
> 3. In the "Metrics" section, click the "Actions" button in the top-right
> corner, and select "Create a new widget" option from the drop-down.
> (attachment: create_widget_button_location.tiff)
> 4. Create widget pop-up is displayed.
> 5. On Step-1, select any type for the widget and click "Next". (attachment:
> create_widget_step1.tiff)
> 6. On Step-2, select any valid metrics parameter and click "Next".
> (attachment: create_widget_step2.tiff)
> 7. On Step-3, for widget_name and description fields, you can enter any
> character. No validation is present to check the contents. The only
> validation present checks the length of the input text.
> (attachments:
> create_widget_step3.tiff,
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_name.tiff,
> original_length_validation_for_description.tiff )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.
[
https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253488#comment-15253488
]
Hadoop QA commented on AMBARI-15979:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12800121/AMBARI-15979-inlineError.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-web.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/6597//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/6597//console
This message is automatically generated.
> Provide UI validation for widget_name and description fields in Create/Edit
> Widget pop-up.
> --
>
> Key: AMBARI-15979
> URL: https://issues.apache.org/jira/browse/AMBARI-15979
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-web
>Affects Versions: trunk
>Reporter: Keta Patel
>Assignee: Keta Patel
> Attachments: AMBARI-15979-April-20.patch,
> AMBARI-15979-inlineError.patch, AMBARI-15979-topError.patch,
> AMBARI-15979.patch, create_widget_button_location.tiff,
> create_widget_step1.tiff, create_widget_step2.tiff, create_widget_step3.tiff,
> fixed_ErrorOnTop_character_validation_for_description.tiff,
> fixed_ErrorOnTop_character_validation_for_name.tiff,
> fixed_ErrorOnTop_length_validation_for_description.tiff,
> fixed_ErrorOnTop_length_validation_for_name.tiff,
> fixed_InlineError_character_validation_for_description.tiff,
> fixed_InlineError_character_validation_for_name.tiff,
> fixed_InlineError_length_validation_for_description.tiff,
> fixed_InlineError_length_validation_for_name.tiff,
> fixed_characters_allowed_for_description.tiff,
> fixed_characters_allowed_for_name.tiff,
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_description.tiff,
> original_length_validation_for_name.tiff
>
>
> The UI validation at present checks only the length of the user input for
> widget_name and description fields. All characters are allowed to be stored
> in the database through them. A more strict UI validation that limits the
> type of characters entered for these fields will provide a good first line of
> defense.
> Steps to reproduce:
> 1. Make sure you have Ambari Metrics service installed on your cluster.
> 2. On the Dashboard, select any service that makes use of Ambari Metrics, say
> HDFS.
> 3. In the "Metrics" section, click the "Actions" button in the top-right
> corner, and select "Create a new widget" option from the drop-down.
> (attachment: create_widget_button_location.tiff)
> 4. Create widget pop-up is displayed.
> 5. On Step-1, select any type for the widget and click "Next". (attachment:
> create_widget_step1.tiff)
> 6. On Step-2, select any valid metrics parameter and click "Next".
> (attachment: create_widget_step2.tiff)
> 7. On Step-3, for widget_name and description fields, you can enter any
> character. No validation is present to check the contents. The only
> validation present checks the length of the input text.
> (attachments:
> create_widget_step3.tiff,
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_name.tiff,
> original_length_validation_for_description.tiff )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.
[
https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250990#comment-15250990
]
Hadoop QA commented on AMBARI-15979:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12799786/AMBARI-15979-April-20.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-web.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/6568//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/6568//console
This message is automatically generated.
> Provide UI validation for widget_name and description fields in Create/Edit
> Widget pop-up.
> --
>
> Key: AMBARI-15979
> URL: https://issues.apache.org/jira/browse/AMBARI-15979
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-web
>Affects Versions: trunk
>Reporter: Keta Patel
>Assignee: Keta Patel
> Attachments: AMBARI-15979-April-20.patch, AMBARI-15979.patch,
> create_widget_button_location.tiff, create_widget_step1.tiff,
> create_widget_step2.tiff, create_widget_step3.tiff,
> fixed_character_validation_for_description.tiff,
> fixed_character_validation_for_name.tiff,
> fixed_characters_allowed_for_description.tiff,
> fixed_characters_allowed_for_name.tiff,
> fixed_length_validation_for_description.tiff,
> fixed_length_validation_for_name.tiff,
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_description.tiff,
> original_length_validation_for_name.tiff
>
>
> The UI validation at present checks only the length of the user input for
> widget_name and description fields. All characters are allowed to be stored
> in the database through them. A more strict UI validation that limits the
> type of characters entered for these fields will provide a good first line of
> defense.
> Steps to reproduce:
> 1. Make sure you have Ambari Metrics service installed on your cluster.
> 2. On the Dashboard, select any service that makes use of Ambari Metrics, say
> HDFS.
> 3. In the "Metrics" section, click the "Actions" button in the top-right
> corner, and select "Create a new widget" option from the drop-down.
> (attachment: create_widget_button_location.tiff)
> 4. Create widget pop-up is displayed.
> 5. On Step-1, select any type for the widget and click "Next". (attachment:
> create_widget_step1.tiff)
> 6. On Step-2, select any valid metrics parameter and click "Next".
> (attachment: create_widget_step2.tiff)
> 7. On Step-3, for widget_name and description fields, you can enter any
> character. No validation is present to check the contents. The only
> validation present checks the length of the input text.
> (attachments:
> create_widget_step3.tiff,
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_name.tiff,
> original_length_validation_for_description.tiff )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.
[
https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249074#comment-15249074
]
Hadoop QA commented on AMBARI-15979:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12799612/AMBARI-15979.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/6550//console
This message is automatically generated.
> Provide UI validation for widget_name and description fields in Create/Edit
> Widget pop-up.
> --
>
> Key: AMBARI-15979
> URL: https://issues.apache.org/jira/browse/AMBARI-15979
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-web
>Affects Versions: trunk
>Reporter: Keta Patel
>Assignee: Keta Patel
> Attachments: AMBARI-15979.patch, create_widget_button_location.tiff,
> create_widget_step1.tiff, create_widget_step2.tiff, create_widget_step3.tiff,
> fixed_character_validation_for_description.tiff,
> fixed_character_validation_for_name.tiff,
> fixed_characters_allowed_for_description.tiff,
> fixed_characters_allowed_for_name_and_description.tiff,
> fixed_length_validation_for_description.tiff,
> fixed_length_validation_for_name.tiff,
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_description.tiff,
> original_length_validation_for_name.tiff
>
>
> The UI validation at present checks only the length of the user input for
> widget_name and description fields. All characters are allowed to be stored
> in the database through them. A more strict UI validation that limits the
> type of characters entered for these fields will provide a good first line of
> defense.
> Steps to reproduce:
> 1. Make sure you have Ambari Metrics service installed on your cluster.
> 2. On the Dashboard, select any service that makes use of Ambari Metrics, say
> HDFS.
> 3. In the "Metrics" section, click the "Actions" button in the top-right
> corner, and select "Create a new widget" option from the drop-down.
> (attachment: create_widget_button_location.tiff)
> 4. Create widget pop-up is displayed.
> 5. On Step-1, select any type for the widget and click "Next". (attachment:
> create_widget_step1.tiff)
> 6. On Step-2, select any valid metrics parameter and click "Next".
> (attachment: create_widget_step2.tiff)
> 7. On Step-3, for widget_name and description fields, you can enter any
> character. No validation is present to check the contents. The only
> validation present checks the length of the input text.
> (attachments:
> create_widget_step3.tiff,
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_name.tiff,
> original_length_validation_for_description.tiff )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.
[ https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248808#comment-15248808 ] Keta Patel commented on AMBARI-15979: - Ambari-Web tests with the patch: 25671 tests complete (33 seconds) 154 tests pending > Provide UI validation for widget_name and description fields in Create/Edit > Widget pop-up. > -- > > Key: AMBARI-15979 > URL: https://issues.apache.org/jira/browse/AMBARI-15979 > Project: Ambari > Issue Type: Improvement > Components: ambari-web >Affects Versions: trunk >Reporter: Keta Patel >Assignee: Keta Patel > Attachments: AMBARI-15979.patch, create_widget_button_location.tiff, > create_widget_step1.tiff, create_widget_step2.tiff, create_widget_step3.tiff, > fixed_character_validation_for_description.tiff, > fixed_character_validation_for_name.tiff, > fixed_characters_allowed_for_description.tiff, > fixed_characters_allowed_for_name_and_description.tiff, > fixed_length_validation_for_description.tiff, > fixed_length_validation_for_name.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_description.tiff, > original_length_validation_for_name.tiff > > > The UI validation at present checks only the length of the user input for > widget_name and description fields. All characters are allowed to be stored > in the database through them. A more strict UI validation that limits the > type of characters entered for these fields will provide a good first line of > defense. > Steps to reproduce: > 1. Make sure you have Ambari Metrics service installed on your cluster. > 2. On the Dashboard, select any service that makes use of Ambari Metrics, say > HDFS. > 3. In the "Metrics" section, click the "Actions" button in the top-right > corner, and select "Create a new widget" option from the drop-down. > (attachment: create_widget_button_location.tiff) > 4. Create widget pop-up is displayed. > 5. On Step-1, select any type for the widget and click "Next". (attachment: > create_widget_step1.tiff) > 6. On Step-2, select any valid metrics parameter and click "Next". > (attachment: create_widget_step2.tiff) > 7. On Step-3, for widget_name and description fields, you can enter any > character. No validation is present to check the contents. The only > validation present checks the length of the input text. > (attachments: > create_widget_step3.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_name.tiff, > original_length_validation_for_description.tiff ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-15979) Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.
[ https://issues.apache.org/jira/browse/AMBARI-15979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248446#comment-15248446 ] Keta Patel commented on AMBARI-15979: - The UI validation is enhanced by checking the content of the input for name and description. The patch attached allows only alphanumeric, underscore, hyphen, space and percentage symbol to be valid characters for both fields. The % symbol is added as part of the white-list as there are existing widgets that contain % symbols in their names. In order to keep the characters in the name consistent, this was decided. The description could probably have a little more flexibility in terms of characters allowed. Any suggestions to update this validation would be helpful. The warning message template is also updated to conform to the existing norms used in several Ambari pop-ups (e.g. Manage Config Groups, Manage Alert Groups). The images attached (starting with "fixed_") show how the fix appears with the patch. > Provide UI validation for widget_name and description fields in Create/Edit > Widget pop-up. > -- > > Key: AMBARI-15979 > URL: https://issues.apache.org/jira/browse/AMBARI-15979 > Project: Ambari > Issue Type: Improvement > Components: ambari-web >Affects Versions: trunk >Reporter: Keta Patel >Assignee: Keta Patel > Attachments: create_widget_button_location.tiff, > create_widget_step1.tiff, create_widget_step2.tiff, create_widget_step3.tiff, > fixed_character_validation_for_description.tiff, > fixed_character_validation_for_name.tiff, > fixed_characters_allowed_for_description.tiff, > fixed_characters_allowed_for_name_and_description.tiff, > fixed_length_validation_for_description.tiff, > fixed_length_validation_for_name.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_description.tiff, > original_length_validation_for_name.tiff > > > The UI validation at present checks only the length of the user input for > widget_name and description fields. All characters are allowed to be stored > in the database through them. A more strict UI validation that limits the > type of characters entered for these fields will provide a good first line of > defense. > Steps to reproduce: > 1. Make sure you have Ambari Metrics service installed on your cluster. > 2. On the Dashboard, select any service that makes use of Ambari Metrics, say > HDFS. > 3. In the "Metrics" section, click the "Actions" button in the top-right > corner, and select "Create a new widget" option from the drop-down. > (attachment: create_widget_button_location.tiff) > 4. Create widget pop-up is displayed. > 5. On Step-1, select any type for the widget and click "Next". (attachment: > create_widget_step1.tiff) > 6. On Step-2, select any valid metrics parameter and click "Next". > (attachment: create_widget_step2.tiff) > 7. On Step-3, for widget_name and description fields, you can enter any > character. No validation is present to check the contents. The only > validation present checks the length of the input text. > (attachments: > create_widget_step3.tiff, > original_characters_allowed_for_name_and_description.tiff, > original_length_validation_for_name.tiff, > original_length_validation_for_description.tiff ) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
